The prefix page looked up each origin AS's details only to show its handle and description. That lookup also reads every live route the AS originates, so a prefix of a large network paid for a read of that network's whole table on every view.
GetPrefixDetailsContext already selected the handle and description of each route's origin AS and dropped them. It now also returns them, keyed by AS number, and the page takes the names from there. GetPrefixDetails, the store interface, the test store and the other callers change with it; the JSON prefix answer ignores the names and is unchanged.
The new test serves the prefix page from a store whose AS details lookup always fails and checks that each origin's handle and description still appear.
Judgement call: the page's origin list was handed each description but never rendered it, so the definition of done ("the page shows each origin's handle and description") could not hold. The list now shows the description after the handle.
Model: opus-5-5
Fixes https://git.eeqj.de/sneak/routewatch/issues/67.
The prefix page looked up each origin AS's details only to show its handle and description. That lookup also reads every live route the AS originates, so a prefix of a large network paid for a read of that network's whole table on every view.
`GetPrefixDetailsContext` already selected the handle and description of each route's origin AS and dropped them. It now also returns them, keyed by AS number, and the page takes the names from there. `GetPrefixDetails`, the store interface, the test store and the other callers change with it; the JSON prefix answer ignores the names and is unchanged.
The new test serves the prefix page from a store whose AS details lookup always fails and checks that each origin's handle and description still appear.
Judgement call: the page's origin list was handed each description but never rendered it, so the definition of done ("the page shows each origin's handle and description") could not hold. The list now shows the description after the handle.
Model: opus-5-5
The prefix page looked up each origin AS's details only for its handle and
description, and that lookup also reads every live route the AS originates.
GetPrefixDetailsContext already selects the handle and description; it now
returns them keyed by AS number, and the page uses them instead.
The origin list was handed each description but never rendered it; it now
shows it after the handle.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #67.
The prefix page looked up each origin AS's details only to show its handle and description. That lookup also reads every live route the AS originates, so a prefix of a large network paid for a read of that network's whole table on every view.
GetPrefixDetailsContextalready selected the handle and description of each route's origin AS and dropped them. It now also returns them, keyed by AS number, and the page takes the names from there.GetPrefixDetails, the store interface, the test store and the other callers change with it; the JSON prefix answer ignores the names and is unchanged.The new test serves the prefix page from a store whose AS details lookup always fails and checks that each origin's handle and description still appear.
Judgement call: the page's origin list was handed each description but never rendered it, so the definition of done ("the page shows each origin's handle and description") could not hold. The list now shows the description after the handle.
Model: opus-5-5
Review passed.
Model: opus-5-5