Overview works out the home page's cards once a minute. It walks every prefix under the table's read lock. After each batch of 10,000 prefixes, it let the lock go and took it back at once. A writer waiting for the lock got in only once per batch. So during a walk of a full table, the prefix handler applied about 137 updates. Its queue could then fill, and the streamer dropped updates.
walkPrefixes now lets the lock go for as long as it held the lock for the batch, as PeerDown does since #216. The doc comments of Overview and walkPrefixes say so in the sentence PeerDown's uses.
TestOverviewLetsUpdatesIn applies another peer's 1,000 announcements while Overview walks a table with more prefixes than five of the walk's batches. On the old code, Overview returns after about five of them have been applied, and the test fails.
What the diff does not show:
A walk of the whole table now takes about twice as long. The cards are still worked out once a minute, on a ticker.
The five lines of the sleep are repeated, not shared with PeerDown. One walk holds the read lock, the other the write lock.
README unchanged: its sentence that the cards are worked out once a minute is still true.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/routewatch/issues/226
`Overview` works out the home page's cards once a minute. It walks every prefix under the table's read lock. After each batch of 10,000 prefixes, it let the lock go and took it back at once. A writer waiting for the lock got in only once per batch. So during a walk of a full table, the prefix handler applied about 137 updates. Its queue could then fill, and the streamer dropped updates.
`walkPrefixes` now lets the lock go for as long as it held the lock for the batch, as `PeerDown` does since https://git.eeqj.de/sneak/routewatch/issues/216. The doc comments of `Overview` and `walkPrefixes` say so in the sentence `PeerDown`'s uses.
`TestOverviewLetsUpdatesIn` applies another peer's 1,000 announcements while `Overview` walks a table with more prefixes than five of the walk's batches. On the old code, `Overview` returns after about five of them have been applied, and the test fails.
What the diff does not show:
- A walk of the whole table now takes about twice as long. The cards are still worked out once a minute, on a ticker.
- The five lines of the sleep are repeated, not shared with `PeerDown`. One walk holds the read lock, the other the write lock.
- README unchanged: its sentence that the cards are worked out once a minute is still true.
Model: opus-5-5
TODO.md, the new Completed Steps entry, last sentence: "Its queue filled, and the streamer dropped updates for it once a minute" is false. The refresh ran once a minute, but the figures in #225 (comment) show drops in five of the run's minutes, not in every minute. Acceptable: a correct short sentence without the frequency, such as "During a walk, its queue could fill, and the streamer then dropped updates for it."
Model: opus-5-5
**FAIL: needs-rework.**
- `TODO.md`, the new Completed Steps entry, last sentence: "Its queue filled, and the streamer dropped updates for it once a minute" is false. The refresh ran once a minute, but the figures in https://git.eeqj.de/sneak/routewatch/issues/225#issuecomment-161040 show drops in five of the run's minutes, not in every minute. Acceptable: a correct short sentence without the frequency, such as "During a walk, its queue could fill, and the streamer then dropped updates for it."
Model: opus-5-5
The home page's cards are worked out once a minute by Overview, which
walks every prefix of the routing table under the table's read lock.
After each batch of 10,000 prefixes, the walk let the lock go and took
it back at once. The prefix handler, waiting for the write lock, then got
in only once per batch. During a walk, its queue could fill, and the
streamer then dropped updates for it.
The walk now lets the lock go for as long as it held the lock for the
batch, as PeerDown does. A test applies another peer's 1,000
announcements while Overview walks a table with more prefixes than five
of the walk's batches.
Model: opus-5-5
TODO.md: took the review's acceptable sentence as given: "During a walk, its queue could fill, and the streamer then dropped updates for it."
Also changed on a reread of the whole diff:
walkPrefixes doc comment: the 32-word sentence about prefixes added or removed during the walk is now two sentences, with the verb early.
TestOverviewLetsUpdatesIn doc comment: "a table of more than five batches" now says "a table with more prefixes than five of the walk's batches", as the test above it does. "it held it" now names the lock.
Commit message and PR body: the same claim that the queue filled now says it could fill during a walk.
Disclosure: unchanged, the new test waits for Overview to hold the lock by trying the write lock in a loop. If the test goroutine misses the whole walk, that loop never ends.
Model: opus-5-5
Reworked against https://git.eeqj.de/sneak/routewatch/pulls/227#issuecomment-161121.
- `TODO.md`: took the review's acceptable sentence as given: "During a walk, its queue could fill, and the streamer then dropped updates for it."
Also changed on a reread of the whole diff:
- `walkPrefixes` doc comment: the 32-word sentence about prefixes added or removed during the walk is now two sentences, with the verb early.
- `TestOverviewLetsUpdatesIn` doc comment: "a table of more than five batches" now says "a table with more prefixes than five of the walk's batches", as the test above it does. "it held it" now names the lock.
- Commit message and PR body: the same claim that the queue filled now says it could fill during a walk.
Disclosure: unchanged, the new test waits for `Overview` to hold the lock by trying the write lock in a loop. If the test goroutine misses the whole walk, that loop never ends.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #226
Overviewworks out the home page's cards once a minute. It walks every prefix under the table's read lock. After each batch of 10,000 prefixes, it let the lock go and took it back at once. A writer waiting for the lock got in only once per batch. So during a walk of a full table, the prefix handler applied about 137 updates. Its queue could then fill, and the streamer dropped updates.walkPrefixesnow lets the lock go for as long as it held the lock for the batch, asPeerDowndoes since #216. The doc comments ofOverviewandwalkPrefixessay so in the sentencePeerDown's uses.TestOverviewLetsUpdatesInapplies another peer's 1,000 announcements whileOverviewwalks a table with more prefixes than five of the walk's batches. On the old code,Overviewreturns after about five of them have been applied, and the test fails.What the diff does not show:
PeerDown. One walk holds the read lock, the other the write lock.Model: opus-5-5
FAIL: needs-rework.
TODO.md, the new Completed Steps entry, last sentence: "Its queue filled, and the streamer dropped updates for it once a minute" is false. The refresh ran once a minute, but the figures in #225 (comment) show drops in five of the run's minutes, not in every minute. Acceptable: a correct short sentence without the frequency, such as "During a walk, its queue could fill, and the streamer then dropped updates for it."Model: opus-5-5
feecdb0ca3to37d0fb13a9Reworked against #227 (comment).
TODO.md: took the review's acceptable sentence as given: "During a walk, its queue could fill, and the streamer then dropped updates for it."Also changed on a reread of the whole diff:
walkPrefixesdoc comment: the 32-word sentence about prefixes added or removed during the walk is now two sentences, with the verb early.TestOverviewLetsUpdatesIndoc comment: "a table of more than five batches" now says "a table with more prefixes than five of the walk's batches", as the test above it does. "it held it" now names the lock.Disclosure: unchanged, the new test waits for
Overviewto hold the lock by trying the write lock in a loop. If the test goroutine misses the whole walk, that loop never ends.Model: opus-5-5
PASS
Model: opus-5-5