Resolve PTR names over DNS-over-HTTPS and cache them for the record TTL (closes #238)

`internal/ptr` asks Google, Cloudflare, AdGuard and Quad9 in turn, 2 seconds in all per address. It keeps answers in memory and writes them through to `cache.db`, opened by the new `internal/cachedb`. A reserved address is not sent to the resolvers.

Judgement calls:
- Each resolver gets an equal share of the time left, so a hung resolver does not use up the 2 seconds.
- The negative TTL is the smaller of the SOA minimum and the SOA's own TTL (RFC 2308).
- Names that are not host names are dropped, as `net.Resolver.LookupAddr` does.

Model: opus-5-5

Dockerfile

@@ -105,7 +105,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
 ARG CACHEBUST
 
 # Create non-root user
-RUN useradd -u 1000 -m routewatch
+RUN useradd -r -u 1000 -m routewatch
 
 RUN mkdir -p /var/lib/berlin.sneak.app.routewatch && chown routewatch:routewatch /var/lib/berlin.sneak.app.routewatch
 

README.md

@@ -63,8 +63,8 @@ docker run --memory=5g --memory-swap=5g -p 8080:8080 \
     -v routewatch:/var/lib/berlin.sneak.app.routewatch routewatch
 ```
 
-The memory limit is explained in Memory. The volume holds the database, the
-copies of the IP lists and the geolocation files.
+The memory limit is explained in Memory. The volume holds the database and the
+copies of the IP lists.
 
 To run the binary on the host instead, build it with `make build`. The build
 needs Go and a C compiler, because the SQLite library is written in C:
@@ -143,9 +143,9 @@ and origin AS can have two kept routes, one or none.
   AS path, a next hop and a time. The next hop is the router the peer sends the
   prefix's traffic to. RouteWatch records the peer itself as the next hop. The
   page also lists the prefix's origin changes, newest first. An origin change is
-  recorded when the first peer starts to carry the prefix with an origin AS, or
-  when the last peer stops. The page shows at most the newest 5,000. Each row
-  shows:
+  an AS starting to announce the prefix, when its first peer carries it, or
+  stopping, when its last peer no longer does. The page shows at most the newest
+  5,000. Each row shows:
     - the time
     - announced or withdrawn
     - the origin AS
@@ -197,9 +197,8 @@ also carries an `@meta` object:
 - `api_version`: `1`
 - `execution_time_ms`: the number of milliseconds the request took
 
-Every value with a unit is a number. The unit ends the field name, as in `_ms`,
-`_seconds`, `_bytes`, `_per_sec` and `_per_min`. `latitude` and `longitude` are
-in degrees, and their names do not say so.
+Every value with a unit is a number, and the unit ends the field name. Examples
+are `_ms`, `_seconds`, `_bytes`, `_per_sec` and `_per_min`.
 
 The paths:
 
@@ -286,16 +285,10 @@ address. Every entry has the same fields:
   lookups), or an empty list when it has none
 - `flags`: yes-or-no facts about the address:
     - `is_tor`: true when the address is on the `tor_exits` list
-    - `is_vpn`: true when the address is on any list of VPN servers (see IP
-      lists)
-    - `is_relay`: true when the address is on the `icloud_private_relay` list
     - `is_bogon`: true when the address is reserved, so that no network should
       announce it on the internet
-- `vpn_providers`: the names of the lists of VPN servers the address is on, or
-  an empty list when it is on none
 - `ip_lists`: the public IP lists the address is on (see IP lists), or an empty
   list when it is on none
-- `geo`: where the address is (see Geolocation), or null when no source answers
 
 Every other field is about the prefix in the routing table that holds the
 address. Each is null when no prefix in the routing table holds the address:
@@ -424,27 +417,6 @@ The lists:
   last 30 days. From
   [FireHOL](https://iplists.firehol.org/?ipset=firehol_level3), downloaded every
   3 hours.
-- `icloud_private_relay`: the networks where iCloud Private Relay traffic
-  leaves. From [Apple](https://mask-api.icloud.com/egress-ip-ranges.csv),
-  downloaded once a day.
-- `ivpn`: VPN servers run by IVPN. From
-  [IVPN](https://api.ivpn.net/v5/servers.json), downloaded once a day.
-- `mullvad`: VPN servers run by Mullvad. From
-  [Mullvad](https://api.mullvad.net/www/relays/all/), downloaded once a day.
-- `nordvpn`: VPN servers run by NordVPN. From
-  [NordVPN](https://api.nordvpn.com/v1/servers?limit=0&fields[servers.station]&fields[servers.ipv6_station]&fields[servers.hostname]),
-  downloaded once a day.
-- `pia`: VPN servers run by Private Internet Access. From
-  [Private Internet Access](https://serverlist.piaservers.net/vpninfo/servers/v6),
-  downloaded once a day.
-- `protonvpn`: the /24 networks that hold ProtonVPN servers. The whole /24 is
-  listed because the ProtonVPN-IPs README says traffic leaves from unpublished
-  addresses in it. From the public
-  [ProtonVPN-IPs](https://github.com/tn3w/ProtonVPN-IPs) mirror of Proton's
-  server list, downloaded once a day.
-- `protonvpn_entry`: the IPv4 and IPv6 addresses of ProtonVPN servers. From the
-  same [ProtonVPN-IPs](https://github.com/tn3w/ProtonVPN-IPs) mirror, downloaded
-  once a day.
 - `spamhaus_drop` and `spamhaus_dropv6`: IPv4 and IPv6 networks hijacked or
   leased by spammers or cyber criminals, according to Spamhaus. From
   [Spamhaus DROP](https://www.spamhaus.org/blocklists/do-not-route-or-peer/),
@@ -453,9 +425,6 @@ The lists:
   the Tor network leaves. From the Tor Project's
   [Onionoo](https://metrics.torproject.org/onionoo.html) service, downloaded
   every hour.
-- `x4bnet` and `x4bnet_v6`: IPv4 and IPv6 networks of VPN services, according to
-  a community list that names no service. From
-  [X4BNet](https://github.com/X4BNet/lists_vpn), downloaded once a day.
 
 No list is downloaded more often than its publisher updates it or allows. Each
 can be downloaded whole without an account or a key.
@@ -503,86 +472,15 @@ How RouteWatch keeps the answers:
   there.
 - It writes new answers every 5 seconds to `cache.db` in the state directory
   (see Configuration), and loads them from there at startup.
-- Each DNS record carries a TTL, the time for which it may be kept. An answer
-  expires after the shortest TTL of its records. RouteWatch keeps it for at
-  least 60 seconds and at most 24 hours.
-- When an address has no PTR names, the answer's SOA record says how long that
-  answer may be kept. The answer expires after the SOA record's minimum field,
-  or the record's own TTL when that is shorter. RouteWatch keeps it for at most
-  1 hour.
+- An answer expires after the TTL of its records, the shortest one when there
+  are several. RouteWatch keeps it for at least 60 seconds and at most 24 hours.
+- When an address has no PTR names, that answer expires after the SOA record's
+  minimum field, or the record's own TTL when that is shorter. RouteWatch keeps
+  it for at most 1 hour.
 - An answer with no PTR names and no SOA record is not kept. Neither is one
   whose SOA record has a TTL or minimum field of 0.
 - A failed lookup is not kept, so the next lookup of the address asks again.
 - Every 10 minutes it deletes expired answers from memory and from `cache.db`.
-- It keeps answers for at most 250,000 addresses, and keeps no answer for a new
-  address while it holds that many.
-
-## Geolocation
-
-An IP lookup finds where each address is, on a best-effort basis. It uses two
-sources:
-
-- [geojs](https://www.geojs.io/) is asked first. One request carries every
-  address of the lookup that the cache does not hold. geojs has 1 second to
-  answer.
-- [DB-IP City Lite](https://db-ip.com/db/download/ip-to-city-lite) answers when
-  geojs has no answer for the address. It is a database file that RouteWatch
-  reads itself.
-
-geojs has no answer when its request fails or runs out of time. An answer with
-no country, city or coordinates also counts as no answer, and RouteWatch does
-not cache it.
-
-The `geo` object of a result has these fields:
-
-- `country_code`: the two-letter country code
-- `country`: the country's name in English
-- `continent_code`: the two-letter continent code
-- `region`: the region or state
-- `city`: the city
-- `latitude` and `longitude`: the location in degrees
-- `accuracy_radius_km`: how far from that location the address may be, in km
-- `time_zone`: the time zone's name, such as `Europe/Berlin`
-- `source`: the source of the answer, `geojs` or `dbip`
-- `updated`: when the answer was fetched from geojs, or when the database copy
-  was downloaded
-
-A field the source does not know is null. DB-IP has no `accuracy_radius_km` and
-no `time_zone`, so both are null in its answers. `geo` itself is null when
-neither source answers. A reserved address, one whose `is_bogon` flag is true,
-goes to neither source, so its `geo` is null.
-
-What goes outside: geojs receives each address that the cache does not hold. For
-`/ip/` and the home page, that address is the visitor's own. A lookup answered
-from the cache sends nothing. DB-IP receives only the monthly request for its
-file.
-
-How RouteWatch keeps the answers of geojs:
-
-- It holds at most 250,000 addresses in memory, and drops the least recently
-  used first. That takes about 100 MB of the Go heap.
-- It writes new answers every 5 seconds to `cache.db` in the state directory.
-- It loads the newest 250,000 answers from `cache.db` at startup.
-- An address not in memory is read from `cache.db` before geojs is asked.
-- An answer expires 7 days after its fetch. Every 10 minutes RouteWatch deletes
-  expired answers from memory and from `cache.db`.
-
-Answers from the database are not cached, because reading the file is local.
-
-How RouteWatch keeps the database:
-
-- It keeps one copy in the state directory, named `dbip-city-lite.mmdb`.
-- It downloads the current month's file at the first start, and then once a
-  month. Until the first download finishes, only geojs answers.
-- A download fails when it takes over 10 minutes or unpacks to over 200 MiB.
-- A new file replaces the old copy only once it opens. After a failed download
-  RouteWatch keeps the old copy and tries again an hour later.
-- The file is about 130 MB. RouteWatch maps it into memory, outside the Go heap.
-  The kernel loads the parts that are read, and can drop them again when memory
-  is short.
-
-The home page's footer says "IP Geolocation by DB-IP" with a link to
-[db-ip.com](https://db-ip.com).
 
 ## Configuration
 
@@ -635,9 +533,7 @@ are not read.
 The state directory holds:
 
 - `db.sqlite`: the database
-- `cache.db`: the answers of PTR lookups and of geojs
-- `dbip-city-lite.mmdb`: the copy of DB-IP's City Lite database (see
-  Geolocation)
+- `cache.db`: the answers of PTR lookups
 - `iplists`: the IP list copies
 
 It is at:
@@ -662,9 +558,8 @@ a memory limit of 5 GiB and swap disabled:
 docker run --memory=5g --memory-swap=5g ...
 ```
 
-The 5 GiB leaves room above the ceilings for spikes, for the kernel's cache of
-the database file, and for the mapped copy of DB-IP's database (see
-Geolocation).
+The 5 GiB leaves room above the ceilings for spikes and for the kernel's cache
+of the database file.
 
 The ceilings add up to 3.7 GiB:
 
@@ -684,13 +579,6 @@ The ceilings add up to 3.7 GiB:
   limit caps the SQLite library.
 - About 0.2 GiB for everything else in the runtime.
 
-The `icloud_private_relay` list has about 285,000 networks. Neighbouring
-networks merge, which leaves about 6,900 address ranges. Loaded, the list adds
-about 0.3 MiB to the Go heap and under 6 MiB to the process's resident memory.
-Parsing the file allocates about 94 MiB in about 0.2 seconds. The next garbage
-collection frees all of it but the 0.3 MiB above. Parsing happens at startup and
-whenever a download brings a new version.
-
 The SQLite library gets its memory from glibc, the C library. glibc keeps freed
 memory in pools called arenas, and hands it back to the kernel slowly. It
 creates up to eight arenas per processor core. So on a host with many cores the
@@ -706,10 +594,8 @@ What happens at each limit:
   allocating more.
 - The SQLite hard heap limit: a database statement fails with an out-of-memory
   error, which the handler logs. The prefix handler writes the routing table's
-  changes and its origin changes again in a later write. Everything else in a
-  handler's failed write is dropped. The PTR cache and the geolocation part
-  write their answers to `cache.db` again in a later write. The process keeps
-  running.
+  changes again in a later write. Everything else in the failed write is
+  dropped. The process keeps running.
 - The handler queues: the handlers are the four parts that take the feed's
   messages (see Design). The prefix handler's queue holds at most 100,000
   messages, about 100 MiB. Each of the other three holds at most 20,000. When a
@@ -809,8 +695,6 @@ The parts:
   address.
 - The PTR cache looks up the PTR names of addresses and keeps the answers (see
   PTR lookups).
-- The geolocation part finds where addresses are, keeps the answers of geojs and
-  downloads DB-IP's database (see Geolocation).
 - The database maintainer checkpoints the database every 5 seconds: it folds the
   write-ahead log, where SQLite first writes changes, into the database file. It
   reclaims free space every 10 minutes. Every hour it refreshes the statistics
@@ -920,8 +804,7 @@ On `SIGTERM` or `SIGINT` the daemon stops its parts in this order:
 4. the database maintainer
 5. the IP list downloads
 6. the HTTP server
-7. the geolocation part, which writes the geojs answers it holds
-8. the PTR cache, which writes what it holds
+7. the PTR cache, which writes what it holds
 
 Last, the daemon checkpoints and closes the database. It gives all this 8
 seconds and then exits with status 0. A stop that is still running after 9
@@ -944,8 +827,6 @@ What a stop can lose:
   SQLite rolls back any write the exit cut off.
 - When the 8 seconds run out, the PTR answers not yet in `cache.db` are lost.
   RouteWatch asks the resolvers for them again the next time they are needed.
-- When the 8 seconds run out, the geojs answers not yet in `cache.db` are lost.
-  RouteWatch asks geojs for them again the next time they are needed.
 
 ### Code layout
 
@@ -962,7 +843,6 @@ routewatch/
 │   ├── cachedb/            # cache.db, the caches of outside answers
 │   ├── config/             # Settings from the environment
 │   ├── database/           # SQLite storage
-│   ├── geo/                # Geolocation: geojs, DB-IP City Lite, the cache
 │   ├── iplist/             # Public IP lists: downloads and lookups
 │   ├── logger/             # Structured logging
 │   ├── metrics/            # Feed and route update figures
@@ -1015,16 +895,11 @@ announcements(id PRIMARY KEY, prefix_id, peer_asn, origin_asn, path,
 
 The indexes are in `internal/database/schema.sql`.
 
-`cache.db` is a separate file, with two tables:
+`cache.db` is a separate file, with one table:
 
 ```sql
 -- The answers of PTR lookups. names is empty for an address with no PTR names.
 hostnames(address PRIMARY KEY, names, expires_at)
-
--- The answers of geojs. A part geojs does not know is NULL.
-geolocations(address PRIMARY KEY, country_code, country, continent_code,
-             region, city, latitude, longitude, accuracy_radius_km, time_zone,
-             fetched_at)
 ```
 
 ## Development
@@ -1076,8 +951,8 @@ calls one of them. The scripts:
 - `script/projectname`: print the project name, `routewatch`, which
   `script/docker` uses as the image tag.
 - `script/test`: build the `test` phase of the `Dockerfile` alone. It runs
-  `go test -short -count=1 -timeout 90s -race -cover ./...`. On failure it runs
-  the tests again with `-v` and without `-cover`.
+  `go test -short -count=1 -timeout 90s -race -cover ./...`, and reruns it with
+  `-v` on failure.
 - `script/lint`: build the `lint` phase of the `Dockerfile` alone. It runs
   `golangci-lint` v2.14.0 with `.golangci.yml`.
 - `script/fmt`: format the Go code with `go fmt` and the markdown with

TODO.md

@@ -22,76 +22,40 @@ formatting of the Go code and the markdown. Then it builds the image.
 The image sets memory ceilings for a 5 GiB container (README "Memory"). README
 "Running under upaas" says how to run it.
 
-Five runs of `next` on the live feed have ended since 2026-10-27, from three
-hours to five days long. The runs found the handlers dropping updates for five
-causes, and the WHOIS fetcher asking a registry that had refused it. Each is
-fixed on `next`, and its Completed Steps entry below names its issue. A 21-hour
-run of `742e759`, which has every fix but one, dropped no update except after
-the feed stalled. That cause, https://git.eeqj.de/sneak/routewatch/issues/229,
-is fixed on `next`.
+A five-day run of `1c65656` on the live feed, from 2026-10-27 to 2026-11-01,
+found three problems:
 
-A run of `e58c663` on the live feed began at 09:19 UTC on 2026-11-10
-(https://git.eeqj.de/sneak/routewatch/issues/232). It is to confirm that fix.
-Next Step lists what its outcome reports. The seven IP lookup additions of
-https://git.eeqj.de/sneak/routewatch/issues/203 landed after it began, so it
-does not exercise them.
+- The prefix handler dropped updates while a peer's session went down
+  (https://git.eeqj.de/sneak/routewatch/issues/216).
+- The AS handler dropped updates when the feed burst
+  (https://git.eeqj.de/sneak/routewatch/issues/217).
+- The WHOIS fetcher kept asking a registry that had refused it
+  (https://git.eeqj.de/sneak/routewatch/issues/218).
+
+All three are fixed on `next`. So is
+https://git.eeqj.de/sneak/routewatch/issues/222, which the third fix brought up.
+A run of `26d939a` on the live feed showed the prefix handler still dropping
+updates while the home page's cards were worked out.
+https://git.eeqj.de/sneak/routewatch/issues/226 fixed that on `next`.
+https://git.eeqj.de/sneak/routewatch/issues/225, also on `next`, takes the peers
+whose sessions go down together out of the table in one walk. A 24-hour run of
+`9bd0e91` on the live feed is checking whether any handler still drops updates.
 
 The order of the project's remaining work is kept on
 https://git.eeqj.de/sneak/routewatch/issues/86.
 
 # Next Step
 
-Post the outcome of the run of `e58c663` on
-https://git.eeqj.de/sneak/routewatch/issues/232. The run lasts at least 24
-hours. If the feed has not stalled or reconnected by then, the run goes on until
-it does, up to 72 hours in all. The outcome says:
-
-- whether the feed stalled or reconnected
-- whether any handler dropped an update, and the most messages the prefix
-  handler's queue held at once
-- the most messages the prefix handler held back at once
-- the size of the `origin_changes` table on disk
-- the process's peak memory against 5 GiB
-
-File an issue for each problem the run finds.
+Post the outcome of the 24-hour run of `9bd0e91` on
+https://git.eeqj.de/sneak/routewatch/issues/226: whether any handler still drops
+updates, and the process's peak memory against 5 GiB. File an issue for each
+problem the run finds.
 
 # Completed Steps
 
-- 2026-11-10: `github.com/mattn/go-sqlite3` is at v1.14.53, so building on the
-  host no longer prints its two C compiler warnings (closes
-  https://git.eeqj.de/sneak/routewatch/issues/245).
-- 2026-11-10: `README.md` and this file are read whole against the rules of
-  https://git.eeqj.de/sneak/routewatch/issues/157, and every statement except
-  measured figures and what outside services do is checked against the code on
-  `next`. Four README sentences failed the prose rules. Five disagreed with the
-  code. Each is rewritten. Status and Next Step describe the live-feed run in
-  progress (closes https://git.eeqj.de/sneak/routewatch/issues/251).
-- 2026-11-10: the image creates the `routewatch` user as a regular user with UID
-  1000, so the build no longer warns about the system UID range (closes
-  https://git.eeqj.de/sneak/routewatch/issues/248).
-- 2026-11-10: each result of the IP lookup has `geo`, where the address is. It
-  comes from geojs, with DB-IP's City Lite database as the fallback. The geojs
-  answers stay in memory and in `cache.db` for 7 days (closes
-  https://git.eeqj.de/sneak/routewatch/issues/239).
-- 2026-11-10: the IP lookup checks the `icloud_private_relay` list of Apple's
-  iCloud Private Relay networks, downloaded once a day. Each result has
-  `flags.is_relay` (closes https://git.eeqj.de/sneak/routewatch/issues/237).
-- 2026-11-10: the IP lookup checks two ProtonVPN lists from a public mirror of
-  Proton's server list. `protonvpn` holds the /24 networks of ProtonVPN's
-  servers, and `protonvpn_entry` holds the servers' IPv4 and IPv6 addresses
-  (closes https://git.eeqj.de/sneak/routewatch/issues/236).
 - 2026-11-10: the IP lookup finds PTR names over DNS-over-HTTPS and caches them
-  in memory and in `cache.db` for the record's TTL. A TTL is the time for which
-  a DNS record may be kept (closes
+  for the record's TTL, in memory and in `cache.db` (closes
   https://git.eeqj.de/sneak/routewatch/issues/238).
-- 2026-11-10: the tests no longer fail when a busy host stalls for several
-  seconds. Most waits for something that should happen are now 15 seconds. Tests
-  that depend on a short idle timeout or a request limit run on a fake clock
-  (closes https://git.eeqj.de/sneak/routewatch/issues/240)
-- 2026-11-10: the IP lookup checks the public VPN server lists of Mullvad,
-  NordVPN, Private Internet Access and IVPN, and X4BNet's community list. Each
-  result has `flags.is_vpn` and `vpn_providers` (closes
-  https://git.eeqj.de/sneak/routewatch/issues/235).
 - 2026-11-10: `tor_exits` comes from Onionoo, so it holds IPv6 exits and
   `is_tor` is true for them (closes
   https://git.eeqj.de/sneak/routewatch/issues/234).

cmd/asinfo-gen/main_test.go

@@ -12,7 +12,7 @@ import (
 
 // parseTimeLimit is how long a test waits for parseCSV to return before it
 // fails.
-const parseTimeLimit = 15 * time.Second
+const parseTimeLimit = 2 * time.Second
 
 // TestParseCSVReadsTodaysLayout parses an as.csv with the country code column
 // that the source added after the description. It expects each AS with its

go.mod

@@ -8,11 +8,8 @@ require (
 	github.com/go-chi/chi/v5 v5.2.2
 	github.com/google/btree v1.1.3
 	github.com/google/uuid v1.6.0
-	github.com/hashicorp/golang-lru/v2 v2.0.7
-	github.com/mattn/go-sqlite3 v1.14.53
-	github.com/maxmind/mmdbwriter v1.2.0
+	github.com/mattn/go-sqlite3 v1.14.29
 	github.com/miekg/dns v1.1.73
-	github.com/oschwald/maxminddb-golang/v2 v2.9.0
 	github.com/rcrowley/go-metrics v0.0.0-20250401214520-65e299d6c5c9
 	go.uber.org/fx v1.24.0
 	go4.org/netipx v0.0.0-20260823151212-3075585bcbeb
@@ -25,5 +22,5 @@ require (
 	go.uber.org/multierr v1.10.0 // indirect
 	go.uber.org/zap v1.26.0 // indirect
 	golang.org/x/net v0.57.0 // indirect
-	golang.org/x/sys v0.49.0 // indirect
+	golang.org/x/sys v0.47.0 // indirect
 )

go.sum

@@ -1,5 +1,7 @@
 github.com/bits-and-blooms/bitset v1.26.0 h1:WPvcPZbP1yuKofmjs2SYIFO1EjzIGhCP9ducElLsh5Q=
 github.com/bits-and-blooms/bitset v1.26.0/go.mod h1:7hO7Gc7Pp1vODcmWvKMRA9BNmbv6a/7QIWpPxHddWR8=
+github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
+github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/dustin/go-humanize v1.0.1 h1:GzkhY7T5VNhEkwH0PVJgjz+fX1rhBrR7pRT3mDkpeCY=
 github.com/dustin/go-humanize v1.0.1/go.mod h1:Mu1zIs6XwVuF/gI1OepvI0qD18qycQx+mFykh5fBlto=
 github.com/go-chi/chi/v5 v5.2.2 h1:CMwsvRVTbXVytCk1Wd72Zy1LAsAh9GxMmSNWLHCG618=
@@ -8,20 +10,16 @@ github.com/google/btree v1.1.3 h1:CVpQJjYgC4VbzxeGVHfvZrv1ctoYCAI8vbl07Fcxlyg=
 github.com/google/btree v1.1.3/go.mod h1:qOPhT0dTNdNzV6Z/lhRX0YXUafgPLFUh+gZMl761Gm4=
 github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
 github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
-github.com/hashicorp/golang-lru/v2 v2.0.7 h1:a+bsQ5rvGLjzHuww6tVxozPZFVghXaHOwFs4luLUK2k=
-github.com/hashicorp/golang-lru/v2 v2.0.7/go.mod h1:QeFd9opnmA6QUJc5vARoKUSoFhyfM2/ZepoAG6RGpeM=
-github.com/mattn/go-sqlite3 v1.14.53 h1:mnTM0owzUMrKuLo+0w51NUiB0ir2Fo7kFXlPt/l3BGs=
-github.com/mattn/go-sqlite3 v1.14.53/go.mod h1:6JTjA44L93a0QCyJef5YvlPoKXntQPjzWv5gtm9sB6w=
-github.com/maxmind/mmdbwriter v1.2.0 h1:hyvDopImmgvle3aR8AaddxXnT0iQH2KWJX3vNfkwzYM=
-github.com/maxmind/mmdbwriter v1.2.0/go.mod h1:EQmKHhk2y9DRVvyNxwCLKC5FrkXZLx4snc5OlLY5XLE=
+github.com/mattn/go-sqlite3 v1.14.29 h1:1O6nRLJKvsi1H2Sj0Hzdfojwt8GiGKm+LOfLaBFaouQ=
+github.com/mattn/go-sqlite3 v1.14.29/go.mod h1:Uh1q+B4BYcTPb+yiD3kU8Ct7aC0hY9fxUwlHK0RXw+Y=
 github.com/miekg/dns v1.1.73 h1:uhT8nJxmTrPJYClxVxTCX+CVn6qnzSiybRk72Z6DgrE=
 github.com/miekg/dns v1.1.73/go.mod h1:RW2Obtfd5NZHvOFe3zYG0W8koWOQtAzyHaLo8vASBuQ=
-github.com/oschwald/maxminddb-golang/v2 v2.9.0 h1:YpIl3WoA9oIuNvqNaO/aD1N/7Ci2wOqoKH5GWo53H5Y=
-github.com/oschwald/maxminddb-golang/v2 v2.9.0/go.mod h1:3TxexMBcR0ss3SbyYvnqfsDzDjN4o1KCg/nTsaMAivU=
+github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
+github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
 github.com/rcrowley/go-metrics v0.0.0-20250401214520-65e299d6c5c9 h1:bsUq1dX0N8AOIL7EB/X911+m4EHsnWEHeJ0c+3TTBrg=
 github.com/rcrowley/go-metrics v0.0.0-20250401214520-65e299d6c5c9/go.mod h1:bCqnVzQkZxMG4s8nGwiZ5l3QUCyqpo9Y+/ZMZ9VjZe4=
-github.com/stretchr/testify v1.12.1 h1:EuwCh5fleGS7H32xRwO3wRGT7DxrDhLAT6FF8MpWDWE=
-github.com/stretchr/testify v1.12.1/go.mod h1:MDEgiDPPsNp5cuIrHPPCyornHKgEVbtFUmoNlxoYthg=
+github.com/stretchr/testify v1.8.1 h1:w7B6lhMri9wdJUVmEZPGGhZzrYTPvgJArz7wNPgYKsk=
+github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
 go.uber.org/dig v1.19.0 h1:BACLhebsYdpQ7IROQ1AGPjrXcP5dF80U3gKoFzbaq/4=
 go.uber.org/dig v1.19.0/go.mod h1:Us0rSJiThwCv2GteUN0Q7OKvU7n5J4dxZ9JKUXozFdE=
 go.uber.org/fx v1.24.0 h1:wE8mruvpg2kiiL1Vqd0CC+tr0/24XIB10Iwp2lLWzkg=
@@ -32,16 +30,14 @@ go.uber.org/multierr v1.10.0 h1:S0h4aNzvfcFsC3dRF1jLoaov7oRaKqRGC/pUEJ2yvPQ=
 go.uber.org/multierr v1.10.0/go.mod h1:20+QtiLqy0Nd6FdQB9TLXag12DsQkrbs3htMFfDN80Y=
 go.uber.org/zap v1.26.0 h1:sI7k6L95XOKS281NhVKOFCUNIvv9e0w4BF8N3u+tCRo=
 go.uber.org/zap v1.26.0/go.mod h1:dtElttAiwGvoJ/vj4IwHBS/gXsEu/pZ50mUIRWuG0so=
-go.yaml.in/yaml/v3 v3.0.5 h1:N6y/pJk8buWs9NY5ERU2HSMfm+IuD/OtfdAnq6kESPw=
-go.yaml.in/yaml/v3 v3.0.5/go.mod h1:HVTZu1O7/Vkt2N+BFy8Zza+lnLsABggaTM2ZpNIGuKg=
 go4.org/netipx v0.0.0-20260823151212-3075585bcbeb h1:XBM4hvfwGAttkkiTIFfeigdfcL1xIfdKXqFdgiHGtDs=
 go4.org/netipx v0.0.0-20260823151212-3075585bcbeb/go.mod h1:PLyyIXexvUFg3Owu6p/WfdlivPbZJsZdgWZlrGope/Y=
 golang.org/x/net v0.57.0 h1:K5+3DljvIuDG9/Jv9rvyMywYNFCQ9RSUY6OOTTkT+tE=
 golang.org/x/net v0.57.0/go.mod h1:KpXc8iv+r3XplLAG/f7Jsf9RPszJzdR0f58q9vGOuEU=
 golang.org/x/sync v0.24.0 h1:iqiDrGoDgyuvAKrhLQthUEzU/R378N78gXbBjxed7oA=
 golang.org/x/sync v0.24.0/go.mod h1:sUUOizhqBxiL6pEWpqNLUiaJn1ShEbZ6BBqskPbjZm0=
-golang.org/x/sys v0.49.0 h1:XbzkgYJHdqh/8m2Uu0W/dQv8nktxx4BFHp1M0gROTXA=
-golang.org/x/sys v0.49.0/go.mod h1:hNLxWAXmnKAxqDtdwIYC4bM9oQPEecfsnNMuSxOs3og=
+golang.org/x/sys v0.47.0 h1:o7XGOvZQCADBQQ4Y7VNq2dRWQR7JmOUW8Kxx4ZsNgWs=
+golang.org/x/sys v0.47.0/go.mod h1:4GL1E5IUh+htKOUEOaiffhrAeqysfVGipDYzABqnCmw=
 golang.org/x/term v0.45.0 h1:NwWyBmoJCbfTHpxrWoZ9C6/VxOf7ic219I8xZZFdrf0=
 golang.org/x/term v0.45.0/go.mod h1:9aqxs0blBcrm/n0L9QW0aRVD+ktan8ssZromtqJC43w=
 golang.org/x/text v0.43.0 h1:1QivrlhwAsnMOcqgOdl9my7s9OyZl8O5/UGUTJVXoWc=

internal/bogon/bogon.go

@@ -1,5 +1,5 @@
-// Package bogon tells whether a prefix, an address or an AS number is reserved:
-// set aside for a special purpose, so that no network should announce it on the
+// Package bogon tells whether a prefix or an AS number is reserved: set aside
+// for a special purpose, so that no network should announce it on the
 // internet. A route is a bogon announcement when its prefix is reserved or its
 // origin AS is.
 //
@@ -42,15 +42,6 @@ func Prefix(prefix netip.Prefix) (string, bool) {
 	return holder.name + " (" + holder.prefix.String() + ")", true
 }
 
-// Addr returns why addr is reserved, and true, when it lies inside a reserved
-// block, as Prefix decides. An IPv4 address written in IPv6 form counts as the
-// IPv4 address it holds. It returns "" and false when addr is not reserved.
-func Addr(addr netip.Addr) (string, bool) {
-	addr = addr.Unmap()
-
-	return Prefix(netip.PrefixFrom(addr, addr.BitLen()))
-}
-
 // ASN returns why asn is reserved, and true, when it is. It returns "" and
 // false when asn is not reserved.
 func ASN(asn int) (string, bool) {

internal/bogon/bogon_test.go

@@ -8,9 +8,6 @@ import (
 	"git.eeqj.de/sneak/routewatch/internal/bogon"
 )
 
-// privateUseTen is why a prefix or an address inside 10.0.0.0/8 is reserved.
-const privateUseTen = "Private-Use (10.0.0.0/8)"
-
 func TestPrefix(t *testing.T) {
 	t.Parallel()
 
@@ -19,8 +16,8 @@ func TestPrefix(t *testing.T) {
 		// want is why the prefix is reserved, or "" when it is not.
 		want string
 	}{
-		{"10.1.2.0/24", privateUseTen},
-		{"10.0.0.0/8", privateUseTen},
+		{"10.1.2.0/24", "Private-Use (10.0.0.0/8)"},
+		{"10.0.0.0/8", "Private-Use (10.0.0.0/8)"},
 		{"192.0.2.0/24", "Documentation (TEST-NET-1) (192.0.2.0/24)"},
 		{"2001:db8:1::/48", "Documentation (2001:db8::/32)"},
 		{"fd00::/8", "Unique-Local (fc00::/7)"},
@@ -59,39 +56,6 @@ func TestPrefix(t *testing.T) {
 	}
 }
 
-func TestAddr(t *testing.T) {
-	t.Parallel()
-
-	tests := []struct {
-		addr string
-		// want is why the address is reserved, or "" when it is not.
-		want string
-	}{
-		{"10.0.0.1", privateUseTen},
-		{"fd00::1", "Unique-Local (fc00::/7)"},
-		// An IPv4 address written in IPv6 form counts as the IPv4 address.
-		{"::ffff:10.0.0.1", privateUseTen},
-		{"::ffff:8.8.8.8", ""},
-		// An address that may be announced, inside a reserved block.
-		{"192.0.0.9", ""},
-		// Addresses anyone may announce.
-		{"8.8.8.8", ""},
-		{"2001:4860:4860::8888", ""},
-	}
-
-	for _, tc := range tests {
-		t.Run(tc.addr, func(t *testing.T) {
-			t.Parallel()
-
-			reason, reserved := bogon.Addr(netip.MustParseAddr(tc.addr))
-			if reason != tc.want || reserved != (tc.want != "") {
-				t.Errorf("Addr(%s) = %q, %v; want %q", tc.addr, reason,
-					reserved, tc.want)
-			}
-		})
-	}
-}
-
 func TestASN(t *testing.T) {
 	t.Parallel()
 

internal/cachedb/schema.sql

@@ -6,19 +6,3 @@ CREATE TABLE IF NOT EXISTS hostnames (
     names TEXT NOT NULL,
     expires_at INTEGER NOT NULL
 );
-
--- geolocations holds the answers of geojs. A part geojs does not know is NULL.
--- fetched_at is in seconds since 1970.
-CREATE TABLE IF NOT EXISTS geolocations (
-    address TEXT PRIMARY KEY,
-    country_code TEXT,
-    country TEXT,
-    continent_code TEXT,
-    region TEXT,
-    city TEXT,
-    latitude REAL,
-    longitude REAL,
-    accuracy_radius_km INTEGER,
-    time_zone TEXT,
-    fetched_at INTEGER NOT NULL
-);

internal/database/database_internal_test.go

@@ -72,34 +72,17 @@ const (
 	// lockTestPrefix is the prefix the batch writes in the checkpoint tests
 	// store.
 	lockTestPrefix = "192.0.2.0/24"
-	// longBusyTimeoutMs is the busy timeout setLongBusyTimeout gives the
-	// writing connection. A checkpoint that waits for an open read takes this
-	// long.
-	longBusyTimeoutMs = 30000
 	// readerCheckpointLimit is how long a checkpoint, and a batch write
-	// waiting for it, may take while a reader is open: well under
-	// longBusyTimeoutMs, with room for a stall on a busy host.
-	readerCheckpointLimit = 15 * time.Second
+	// waiting for it, may take while a reader is open: well under the busy
+	// timeout, which a checkpoint that waits for the reader takes.
+	readerCheckpointLimit = time.Second
 	// truncateCheckpointLimit is how long a checkpoint of a WAL file over
 	// sqliteWALSizeLimitBytes may take to give up while a reader is open: its
-	// wait for the reader plus readerCheckpointLimit.
+	// wait for the reader plus a second, well under the busy timeout.
 	truncateCheckpointLimit = truncateBusyTimeoutMs*time.Millisecond +
-		readerCheckpointLimit
+		time.Second
 )
 
-// setLongBusyTimeout gives the writing connection of db longBusyTimeoutMs, so
-// that a checkpoint that waits for an open read takes far longer than a stall
-// on a busy host.
-func setLongBusyTimeout(ctx context.Context, t *testing.T, db *Database) {
-	t.Helper()
-
-	_, err := db.writer.ExecContext(ctx,
-		fmt.Sprintf("PRAGMA busy_timeout=%d", longBusyTimeoutMs))
-	if err != nil {
-		t.Fatalf("failed to set the busy timeout: %v", err)
-	}
-}
-
 // TestConnectionPoolPragmas holds several pooled connections open at once and
 // checks each one carries the per-connection settings from the DSN, plus the
 // process-wide heap limits, and sees the new file with auto_vacuum
@@ -596,8 +579,6 @@ func TestCheckpointDoesNotWaitForReader(t *testing.T) {
 	ctx := context.Background()
 	ts := time.Now().UTC()
 
-	setLongBusyTimeout(ctx, t, db)
-
 	err = db.UpdatePrefixesBatch(map[string]time.Time{"198.51.100.0/24": ts})
 	if err != nil {
 		t.Fatalf("failed to store the prefix the reader reads: %v", err)
@@ -709,7 +690,6 @@ func TestCheckpointEmptiesWALOnceNoReadIsOpen(t *testing.T) {
 	}
 
 	fillWALPastLimit(ctx, t, db)
-	setLongBusyTimeout(ctx, t, db)
 
 	started := time.Now()
 

internal/geo/cache.go

@@ -1,253 +0,0 @@
-package geo
-
-import (
-	"context"
-	"database/sql"
-	"errors"
-	"fmt"
-	"maps"
-	"time"
-)
-
-const (
-	// entryLifetime is how long a geojs answer is kept after its fetch.
-	entryLifetime = 7 * 24 * time.Hour
-
-	// flushInterval is how often new answers are written to cache.db.
-	flushInterval = 5 * time.Second
-
-	// sweepInterval is how often expired answers are deleted.
-	sweepInterval = 10 * time.Minute
-
-	// rowColumns are the columns of the geolocations table in the order
-	// scanRow reads them.
-	rowColumns = "address, country_code, country, continent_code, region, " +
-		"city, latitude, longitude, accuracy_radius_km, time_zone, fetched_at"
-)
-
-// rowScanner is the Scan method of *sql.Row and *sql.Rows.
-type rowScanner interface {
-	Scan(dest ...any) error
-}
-
-// cached returns the current answer held for address, from memory, then from
-// the answers waiting to be written, then from cache.db. It returns nil when
-// there is none.
-func (l *Locator) cached(ctx context.Context, address string) *Location {
-	found, ok := l.entries.Get(address)
-	if ok {
-		if !l.expired(found) {
-			return found
-		}
-
-		l.entries.Remove(address)
-	}
-
-	l.pendingMu.Lock()
-	waiting := l.pending[address]
-	l.pendingMu.Unlock()
-
-	if waiting != nil && !l.expired(waiting) {
-		l.entries.Add(address, waiting)
-
-		return waiting
-	}
-
-	stored, err := l.readRow(ctx, address)
-	if err != nil {
-		l.logger.Warn("Failed to read a geolocation cache row",
-			"address", address, "error", err)
-
-		return nil
-	}
-
-	if stored != nil {
-		l.entries.Add(address, stored)
-	}
-
-	return stored
-}
-
-// expired says whether the answer is at the end of its lifetime.
-func (l *Locator) expired(answer *Location) bool {
-	return !l.now().Before(answer.Updated.Add(entryLifetime))
-}
-
-// cutoff returns the fetch time at or before which an answer has expired.
-func (l *Locator) cutoff() int64 {
-	return l.now().Add(-entryLifetime).Unix()
-}
-
-// store keeps an answer in memory and queues it for cache.db. While cache.db
-// cannot be written, the queue stops growing at maxEntries answers.
-func (l *Locator) store(address string, answer *Location) {
-	l.entries.Add(address, answer)
-
-	l.pendingMu.Lock()
-	defer l.pendingMu.Unlock()
-
-	if len(l.pending) < l.maxEntries {
-		l.pending[address] = answer
-	}
-}
-
-// keepCache writes new answers and deletes expired ones until ctx ends.
-func (l *Locator) keepCache(ctx context.Context) {
-	flushes := time.NewTicker(flushInterval)
-	defer flushes.Stop()
-
-	sweeps := time.NewTicker(sweepInterval)
-	defer sweeps.Stop()
-
-	for {
-		select {
-		case <-ctx.Done():
-			l.flush(context.WithoutCancel(ctx))
-
-			return
-		case <-flushes.C:
-			l.flush(ctx)
-		case <-sweeps.C:
-			l.sweep(ctx)
-		}
-	}
-}
-
-// load reads the answers that have not expired into memory, at most maxEntries
-// of them, the newest last so that they are the last to be dropped.
-func (l *Locator) load(ctx context.Context) error {
-	rows, err := l.db.QueryContext(ctx,
-		"SELECT "+rowColumns+" FROM (SELECT "+rowColumns+" FROM geolocations "+
-			"WHERE fetched_at > ? ORDER BY fetched_at DESC LIMIT ?) "+
-			"ORDER BY fetched_at",
-		l.cutoff(), l.maxEntries)
-	if err != nil {
-		return fmt.Errorf("reading the geolocation cache: %w", err)
-	}
-
-	defer func() { _ = rows.Close() }()
-
-	for rows.Next() {
-		address, answer, err := scanRow(rows)
-		if err != nil {
-			return fmt.Errorf("reading a geolocation cache row: %w", err)
-		}
-
-		l.entries.Add(address, answer)
-	}
-
-	err = rows.Err()
-	if err != nil {
-		return fmt.Errorf("reading the geolocation cache: %w", err)
-	}
-
-	return nil
-}
-
-// readRow returns the current answer for address in cache.db, or nil when it
-// has none.
-func (l *Locator) readRow(
-	ctx context.Context, address string,
-) (*Location, error) {
-	row := l.db.QueryRowContext(ctx,
-		"SELECT "+rowColumns+" FROM geolocations "+
-			"WHERE address = ? AND fetched_at > ?",
-		address, l.cutoff())
-
-	_, answer, err := scanRow(row)
-	if errors.Is(err, sql.ErrNoRows) {
-		return nil, nil //nolint:nilnil // no row is not a failure
-	}
-
-	return answer, err
-}
-
-// scanRow reads one row of the geolocations table.
-func scanRow(row rowScanner) (string, *Location, error) {
-	var (
-		address string
-		fetched int64
-		answer  Location
-	)
-
-	err := row.Scan(&address, &answer.CountryCode, &answer.Country,
-		&answer.ContinentCode, &answer.Region, &answer.City, &answer.Latitude,
-		&answer.Longitude, &answer.AccuracyRadiusKm, &answer.TimeZone, &fetched)
-	if err != nil {
-		return "", nil, err
-	}
-
-	answer.Source = sourceGeoJS
-	answer.Updated = time.Unix(fetched, 0).UTC()
-
-	return address, &answer, nil
-}
-
-// flush writes the pending answers to cache.db. Those it cannot write stay
-// pending, unless a newer answer for the address has arrived meanwhile.
-func (l *Locator) flush(ctx context.Context) {
-	l.pendingMu.Lock()
-	batch := l.pending
-	l.pending = make(map[string]*Location)
-	l.pendingMu.Unlock()
-
-	if len(batch) == 0 {
-		return
-	}
-
-	err := l.writeRows(ctx, batch)
-	if err == nil {
-		return
-	}
-
-	l.logger.Error("Failed to write the geolocation cache", "error", err)
-
-	l.pendingMu.Lock()
-	defer l.pendingMu.Unlock()
-
-	maps.Insert(batch, maps.All(l.pending))
-	l.pending = batch
-}
-
-// writeRows writes batch to cache.db in one transaction.
-func (l *Locator) writeRows(
-	ctx context.Context, batch map[string]*Location,
-) error {
-	tx, err := l.db.BeginTx(ctx, nil)
-	if err != nil {
-		return err
-	}
-
-	defer func() { _ = tx.Rollback() }()
-
-	for address, answer := range batch {
-		_, err = tx.ExecContext(ctx,
-			"INSERT OR REPLACE INTO geolocations ("+rowColumns+") "+
-				"VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)",
-			address, answer.CountryCode, answer.Country, answer.ContinentCode,
-			answer.Region, answer.City, answer.Latitude, answer.Longitude,
-			answer.AccuracyRadiusKm, answer.TimeZone, answer.Updated.Unix())
-		if err != nil {
-			return err
-		}
-	}
-
-	return tx.Commit()
-}
-
-// sweep deletes the expired answers from memory and cache.db.
-func (l *Locator) sweep(ctx context.Context) {
-	for _, address := range l.entries.Keys() {
-		answer, ok := l.entries.Peek(address)
-		if ok && l.expired(answer) {
-			l.entries.Remove(address)
-		}
-	}
-
-	_, err := l.db.ExecContext(ctx,
-		"DELETE FROM geolocations WHERE fetched_at <= ?", l.cutoff())
-	if err != nil {
-		l.logger.Error("Failed to delete expired geolocation cache rows",
-			"error", err)
-	}
-}

internal/geo/database.go

@@ -1,349 +0,0 @@
-package geo
-
-import (
-	"compress/gzip"
-	"context"
-	"errors"
-	"fmt"
-	"io"
-	"io/fs"
-	"net/http"
-	"net/netip"
-	"os"
-	"path/filepath"
-	"time"
-
-	"github.com/oschwald/maxminddb-golang/v2"
-)
-
-const (
-	// DatabaseDownloadFormat is the URL of DB-IP's City Lite database, with %s
-	// for the year and month.
-	DatabaseDownloadFormat = "https://download.db-ip.com/free/" +
-		"dbip-city-lite-%s.mmdb.gz"
-
-	// databaseMonthFormat is the year and month in the URL.
-	databaseMonthFormat = "2006-01"
-
-	// databaseFileName is the copy of the database in the state directory.
-	databaseFileName = "dbip-city-lite.mmdb"
-
-	// databaseDownloadSuffix ends the name of the file a download is written
-	// to, until it has opened.
-	databaseDownloadSuffix = ".download"
-
-	// maxDatabaseSize is the largest database accepted once unpacked, in
-	// bytes.
-	maxDatabaseSize = 200 << 20
-
-	// databaseDownloadTimeout limits one download.
-	databaseDownloadTimeout = 10 * time.Minute
-
-	// databaseCheckInterval is how often RouteWatch checks whether a new
-	// month's database is due. A new month's file appears some time on the
-	// first of the month, so a failed download is tried again this much later.
-	databaseCheckInterval = time.Hour
-)
-
-var (
-	errDatabaseStatus  = errors.New("unexpected HTTP status from DB-IP")
-	errDatabaseTooLong = errors.New("database is over the size limit")
-)
-
-// dbipName is the part of a database record that holds an English name.
-type dbipName struct {
-	Names struct {
-		English string `maxminddb:"en"`
-	} `maxminddb:"names"`
-}
-
-// dbipRecord is the part of a database record RouteWatch reads.
-type dbipRecord struct {
-	City      dbipName `maxminddb:"city"`
-	Continent struct {
-		Code string `maxminddb:"code"`
-	} `maxminddb:"continent"`
-	Country struct {
-		dbipName
-
-		ISOCode string `maxminddb:"iso_code"`
-	} `maxminddb:"country"`
-	Location struct {
-		Latitude  *float64 `maxminddb:"latitude"`
-		Longitude *float64 `maxminddb:"longitude"`
-	} `maxminddb:"location"`
-	Subdivisions []dbipName `maxminddb:"subdivisions"`
-}
-
-// location returns the record as a Location fetched at the time given. The
-// first subdivision is the region. The database has no accuracy radius and no
-// time zone.
-func (r *dbipRecord) location(fetched time.Time) *Location {
-	found := &Location{
-		CountryCode:   nilIfEmpty(r.Country.ISOCode),
-		Country:       nilIfEmpty(r.Country.Names.English),
-		ContinentCode: nilIfEmpty(r.Continent.Code),
-		City:          nilIfEmpty(r.City.Names.English),
-		Latitude:      r.Location.Latitude,
-		Longitude:     r.Location.Longitude,
-		Source:        sourceDBIP,
-		Updated:       fetched,
-	}
-
-	if len(r.Subdivisions) > 0 {
-		found.Region = nilIfEmpty(r.Subdivisions[0].Names.English)
-	}
-
-	return found
-}
-
-// nilIfEmpty returns a pointer to text, or nil when text is empty.
-func nilIfEmpty(text string) *string {
-	if text == "" {
-		return nil
-	}
-
-	return &text
-}
-
-// fromDatabase returns where the copy of the database places addr. It returns
-// nil when there is no copy yet or the copy has no record for addr. It also
-// returns nil, and logs the error, when reading the copy fails.
-func (l *Locator) fromDatabase(addr netip.Addr) *Location {
-	l.databaseMu.RLock()
-	defer l.databaseMu.RUnlock()
-
-	if l.database == nil {
-		return nil
-	}
-
-	result := l.database.Lookup(addr)
-
-	err := result.Err()
-	if err != nil {
-		l.logger.Error("Failed to look up an address in the database",
-			"address", addr, "error", err)
-
-		return nil
-	}
-
-	if !result.Found() {
-		return nil
-	}
-
-	var record dbipRecord
-
-	err = result.Decode(&record)
-	if err != nil {
-		l.logger.Error("Failed to read a database record",
-			"address", addr, "error", err)
-
-		return nil
-	}
-
-	return record.location(l.databaseFetched)
-}
-
-// keepDatabaseCurrent downloads the database when it is due, at once and then
-// every databaseCheckInterval, until ctx ends.
-func (l *Locator) keepDatabaseCurrent(ctx context.Context) {
-	l.downloadDatabaseIfDue(ctx)
-
-	checks := time.NewTicker(databaseCheckInterval)
-	defer checks.Stop()
-
-	for {
-		select {
-		case <-ctx.Done():
-			return
-		case <-checks.C:
-			l.downloadDatabaseIfDue(ctx)
-		}
-	}
-}
-
-// downloadDatabaseIfDue downloads this month's database, unless the copy in
-// use was downloaded this month. A failure leaves the copy as it is.
-func (l *Locator) downloadDatabaseIfDue(ctx context.Context) {
-	now := l.now().UTC()
-
-	if !l.databaseDue(now) {
-		return
-	}
-
-	err := l.downloadDatabase(ctx, now)
-	if err != nil && ctx.Err() == nil {
-		l.logger.Error("Database download failed; keeping the previous copy",
-			"error", err)
-	}
-}
-
-// databaseDue says whether there is no open copy or it is from an earlier
-// month than now.
-func (l *Locator) databaseDue(now time.Time) bool {
-	l.databaseMu.RLock()
-	defer l.databaseMu.RUnlock()
-
-	return l.database == nil ||
-		l.databaseFetched.Format(databaseMonthFormat) !=
-			now.Format(databaseMonthFormat)
-}
-
-// downloadDatabase fetches the database of now's month. The file replaces the
-// copy, on disk and in use, only once it has opened.
-func (l *Locator) downloadDatabase(ctx context.Context, now time.Time) error {
-	ctx, cancel := context.WithTimeout(ctx, databaseDownloadTimeout)
-	defer cancel()
-
-	url := fmt.Sprintf(l.databaseURLFormat, now.Format(databaseMonthFormat))
-
-	request, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
-	if err != nil {
-		return err
-	}
-
-	request.Header.Set(userAgentHeader, userAgent)
-
-	response, err := l.client.Do(request)
-	if err != nil {
-		return err
-	}
-
-	defer func() { _ = response.Body.Close() }()
-
-	if response.StatusCode != http.StatusOK {
-		return fmt.Errorf("%w: %s", errDatabaseStatus, response.Status)
-	}
-
-	return l.replaceDatabase(response.Body, now)
-}
-
-// replaceDatabase unpacks the gzip stream body beside the copy, then makes the
-// result the copy once it has opened. Whatever fails, the file it wrote is
-// removed and the copy stays.
-func (l *Locator) replaceDatabase(body io.Reader, now time.Time) error {
-	root, err := os.OpenRoot(l.dir)
-	if err != nil {
-		return err
-	}
-
-	defer func() { _ = root.Close() }()
-
-	downloadName := databaseFileName + databaseDownloadSuffix
-
-	err = unpackDatabase(root, downloadName, body, l.maxDatabaseBytes)
-	if err != nil {
-		_ = root.Remove(downloadName)
-
-		return err
-	}
-
-	opened, err := maxminddb.Open(filepath.Join(l.dir, downloadName))
-	if err != nil {
-		_ = root.Remove(downloadName)
-
-		return fmt.Errorf("opening the downloaded database: %w", err)
-	}
-
-	err = root.Rename(downloadName, databaseFileName)
-	if err != nil {
-		_ = opened.Close()
-		_ = root.Remove(downloadName)
-
-		return err
-	}
-
-	l.useDatabase(opened, now.Truncate(time.Second))
-	l.logger.Info("Downloaded a new copy of the database")
-
-	return nil
-}
-
-// unpackDatabase writes the gzip stream body to the file name in root, up to
-// limit bytes once unpacked.
-func unpackDatabase(
-	root *os.Root, name string, body io.Reader, limit int64,
-) error {
-	unpacked, err := gzip.NewReader(body)
-	if err != nil {
-		return fmt.Errorf("unpacking the database: %w", err)
-	}
-
-	f, err := root.Create(name)
-	if err != nil {
-		return err
-	}
-
-	defer func() { _ = f.Close() }()
-
-	written, err := io.Copy(f, io.LimitReader(unpacked, limit+1))
-	if err != nil {
-		return fmt.Errorf("unpacking the database: %w", err)
-	}
-
-	if written > limit {
-		return errDatabaseTooLong
-	}
-
-	return nil
-}
-
-// openDatabaseCopy opens the copy left by an earlier run, if there is one. A
-// copy that does not open is treated as no copy, so it is downloaded again.
-func (l *Locator) openDatabaseCopy() {
-	path := filepath.Join(l.dir, databaseFileName)
-
-	info, err := os.Stat(path)
-	if errors.Is(err, fs.ErrNotExist) {
-		return
-	}
-
-	if err != nil {
-		l.logger.Error("Failed to read the database copy", "error", err)
-
-		return
-	}
-
-	opened, err := maxminddb.Open(path)
-	if err != nil {
-		l.logger.Error("Failed to open the database copy", "error", err)
-
-		return
-	}
-
-	l.useDatabase(opened, info.ModTime().UTC().Truncate(time.Second))
-}
-
-// useDatabase makes opened the copy in use and closes the one it replaces.
-func (l *Locator) useDatabase(opened *maxminddb.Reader, fetched time.Time) {
-	l.databaseMu.Lock()
-	defer l.databaseMu.Unlock()
-
-	if l.database != nil {
-		err := l.database.Close()
-		if err != nil {
-			l.logger.Error("Failed to close the old database copy", "error", err)
-		}
-	}
-
-	l.database = opened
-	l.databaseFetched = fetched
-}
-
-// closeDatabase closes the copy in use, after which no source can answer from
-// it.
-func (l *Locator) closeDatabase() {
-	l.databaseMu.Lock()
-	defer l.databaseMu.Unlock()
-
-	if l.database == nil {
-		return
-	}
-
-	err := l.database.Close()
-	if err != nil {
-		l.logger.Error("Failed to close the database copy", "error", err)
-	}
-
-	l.database = nil
-}

internal/geo/geojs.go

@@ -1,151 +0,0 @@
-package geo
-
-import (
-	"context"
-	"encoding/json"
-	"errors"
-	"fmt"
-	"io"
-	"math"
-	"net/http"
-	"net/netip"
-	"strconv"
-	"strings"
-	"time"
-)
-
-const (
-	// GeoJSEndpoint is the URL of the geojs geo endpoint.
-	GeoJSEndpoint = "https://get.geojs.io/v1/ip/geo.json"
-
-	// geojsTimeLimit limits one request to geojs.
-	geojsTimeLimit = time.Second
-
-	// geojsAddressSeparator separates the addresses of one request.
-	geojsAddressSeparator = ","
-
-	// geojsUnknown is what geojs sends for a value it does not know.
-	geojsUnknown = "nil"
-
-	// maxGeoJSAnswerBytes is far more than an answer for the most addresses
-	// an IP lookup can ask about.
-	maxGeoJSAnswerBytes = 1 << 20
-)
-
-var errGeoJSStatus = errors.New("unexpected HTTP status from geojs")
-
-// geojsAnswer is one address's entry in an answer from geojs.
-//
-//nolint:tagliatelle // the keys geojs sends
-type geojsAnswer struct {
-	IP            string `json:"ip"`
-	CountryCode   string `json:"country_code"`
-	Country       string `json:"country"`
-	ContinentCode string `json:"continent_code"`
-	Region        string `json:"region"`
-	City          string `json:"city"`
-	Latitude      string `json:"latitude"`
-	Longitude     string `json:"longitude"`
-	Accuracy      *int   `json:"accuracy"`
-	TimeZone      string `json:"timezone"`
-}
-
-// askGeoJS asks geojs about addresses in one request, and returns its answers
-// by address. An address geojs left out, or gave no country, city or
-// coordinates for, has no entry.
-func (l *Locator) askGeoJS(
-	ctx context.Context, addresses []string,
-) (map[string]*Location, error) {
-	ctx, cancel := context.WithTimeout(ctx, l.timeLimit)
-	defer cancel()
-
-	// A comma and a colon are legal in a query, and the escaped forms are
-	// not what geojs documents.
-	url := l.geojsURL + "?ip=" + strings.Join(addresses, geojsAddressSeparator)
-
-	request, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
-	if err != nil {
-		return nil, err
-	}
-
-	request.Header.Set(userAgentHeader, userAgent)
-
-	response, err := l.client.Do(request)
-	if err != nil {
-		return nil, err
-	}
-
-	defer func() { _ = response.Body.Close() }()
-
-	if response.StatusCode != http.StatusOK {
-		return nil, fmt.Errorf("%w: %d", errGeoJSStatus, response.StatusCode)
-	}
-
-	var parsed []geojsAnswer
-
-	err = json.NewDecoder(io.LimitReader(response.Body, maxGeoJSAnswerBytes)).
-		Decode(&parsed)
-	if err != nil {
-		return nil, fmt.Errorf("reading the geojs answer: %w", err)
-	}
-
-	fetched := l.now().UTC().Truncate(time.Second)
-	answers := make(map[string]*Location, len(parsed))
-
-	for _, answer := range parsed {
-		addr, err := netip.ParseAddr(answer.IP)
-		if err != nil {
-			continue
-		}
-
-		location := answer.location(fetched)
-		if hasLocation(location) {
-			answers[plainAddress(addr)] = location
-		}
-	}
-
-	return answers, nil
-}
-
-// hasLocation says whether found has a country, a city or a coordinate.
-func hasLocation(found *Location) bool {
-	return found.CountryCode != nil || found.Country != nil ||
-		found.City != nil || found.Latitude != nil || found.Longitude != nil
-}
-
-// location returns the answer as a Location fetched at the time given.
-func (a geojsAnswer) location(fetched time.Time) *Location {
-	return &Location{
-		CountryCode:      knownText(a.CountryCode),
-		Country:          knownText(a.Country),
-		ContinentCode:    knownText(a.ContinentCode),
-		Region:           knownText(a.Region),
-		City:             knownText(a.City),
-		Latitude:         knownNumber(a.Latitude),
-		Longitude:        knownNumber(a.Longitude),
-		AccuracyRadiusKm: a.Accuracy,
-		TimeZone:         knownText(a.TimeZone),
-		Source:           sourceGeoJS,
-		Updated:          fetched,
-	}
-}
-
-// knownText returns a pointer to text, or nil when geojs does not know it.
-func knownText(text string) *string {
-	if text == "" || text == geojsUnknown {
-		return nil
-	}
-
-	return &text
-}
-
-// knownNumber returns text as a number, or nil when geojs does not know it. NaN
-// and infinity parse, but JSON cannot carry them.
-func knownNumber(text string) *float64 {
-	number, err := strconv.ParseFloat(text, 64)
-	if err != nil || math.IsNaN(number) || math.IsInf(number, 0) {
-		return nil
-	}
-
-	return &number
-}

internal/geo/locator.go

@@ -1,232 +0,0 @@
-// Package geo finds where IP addresses are. It asks geojs.io, and keeps those
-// answers in memory and in cache.db. When geojs.io gives no location for an
-// address, it reads a copy of DB-IP's City Lite database, which it downloads
-// once a month.
-package geo
-
-import (
-	"context"
-	"database/sql"
-	"fmt"
-	"log/slog"
-	"net/http"
-	"net/netip"
-	"sync"
-	"time"
-
-	lru "github.com/hashicorp/golang-lru/v2"
-	"github.com/oschwald/maxminddb-golang/v2"
-)
-
-// The values of Location.Source.
-const (
-	sourceGeoJS = "geojs"
-	sourceDBIP  = "dbip"
-)
-
-const (
-	// maxEntries limits how many geojs answers are held in memory.
-	maxEntries = 250_000
-
-	// userAgentHeader and userAgent name routewatch to geojs and DB-IP.
-	userAgentHeader = "User-Agent"
-	userAgent       = "routewatch (+https://git.eeqj.de/sneak/routewatch)"
-)
-
-// Params is what New needs.
-type Params struct {
-	// DB is the open cache.db.
-	DB *sql.DB
-
-	// Dir is the directory that holds the copy of the database.
-	Dir string
-
-	// GeoJSURL is the URL of the geojs geo endpoint, GeoJSEndpoint in use.
-	GeoJSURL string
-
-	// DatabaseURLFormat is the URL of the database with %s for the year and
-	// month, DatabaseDownloadFormat in use.
-	DatabaseURLFormat string
-
-	Logger *slog.Logger
-}
-
-// Location is where an address is. A part the source does not know is nil.
-//
-//nolint:tagliatelle // snake_case keys, as the Go style guide asks
-type Location struct {
-	CountryCode      *string  `json:"country_code"`
-	Country          *string  `json:"country"`
-	ContinentCode    *string  `json:"continent_code"`
-	Region           *string  `json:"region"`
-	City             *string  `json:"city"`
-	Latitude         *float64 `json:"latitude"`
-	Longitude        *float64 `json:"longitude"`
-	AccuracyRadiusKm *int     `json:"accuracy_radius_km"`
-	TimeZone         *string  `json:"time_zone"`
-
-	// Source is geojs or dbip.
-	Source string `json:"source"`
-
-	// Updated is when the value was fetched: the geojs answer, or the copy of
-	// the database.
-	Updated time.Time `json:"updated"`
-}
-
-// Locator answers where addresses are. Start loads its cache and starts its
-// goroutines.
-type Locator struct {
-	db                *sql.DB
-	dir               string
-	geojsURL          string
-	databaseURLFormat string
-	timeLimit         time.Duration
-	maxEntries        int
-	maxDatabaseBytes  int64
-	logger            *slog.Logger
-	client            *http.Client
-	now               func() time.Time
-
-	// entries holds geojs answers by address, and drops the least recently
-	// used first.
-	entries *lru.Cache[string, *Location]
-
-	// pending holds the answers that cache.db does not have yet.
-	pendingMu sync.Mutex
-	pending   map[string]*Location
-
-	// database is the open copy, nil until one has opened, and databaseFetched
-	// is when that copy was downloaded. A lookup holds the read lock, so that
-	// a new copy never closes the old one under it.
-	databaseMu      sync.RWMutex
-	database        *maxminddb.Reader
-	databaseFetched time.Time
-
-	// stop ends the goroutines Start runs, and done is closed when they have
-	// returned.
-	stop context.CancelFunc
-	done chan struct{}
-}
-
-// New returns a Locator with an empty cache. Start loads it.
-func New(params Params) (*Locator, error) {
-	entries, err := lru.New[string, *Location](maxEntries)
-	if err != nil {
-		return nil, fmt.Errorf("creating the geolocation cache: %w", err)
-	}
-
-	return &Locator{
-		db:                params.DB,
-		dir:               params.Dir,
-		geojsURL:          params.GeoJSURL,
-		databaseURLFormat: params.DatabaseURLFormat,
-		timeLimit:         geojsTimeLimit,
-		maxEntries:        maxEntries,
-		maxDatabaseBytes:  maxDatabaseSize,
-		logger:            params.Logger.With("component", "geo"),
-		client:            &http.Client{},
-		now:               time.Now,
-		entries:           entries,
-		pending:           make(map[string]*Location),
-		done:              make(chan struct{}),
-	}, nil
-}
-
-// Lookup returns where each of addrs is, in the same order. The entry for an
-// address neither source answers for is nil. Addresses with no current cached
-// answer go to geojs in one request. The returned Locations are shared with
-// the cache and must not be changed.
-func (l *Locator) Lookup(ctx context.Context, addrs []netip.Addr) []*Location {
-	locations := make([]*Location, len(addrs))
-
-	var unanswered []string
-
-	for i, addr := range addrs {
-		address := plainAddress(addr)
-
-		locations[i] = l.cached(ctx, address)
-		if locations[i] == nil {
-			unanswered = append(unanswered, address)
-		}
-	}
-
-	if len(unanswered) == 0 {
-		return locations
-	}
-
-	answers, err := l.askGeoJS(ctx, unanswered)
-	if err != nil {
-		l.logger.Warn("geojs lookup failed; using the database", "error", err)
-	}
-
-	for i, addr := range addrs {
-		if locations[i] != nil {
-			continue
-		}
-
-		address := plainAddress(addr)
-
-		answer, ok := answers[address]
-		if ok {
-			l.store(address, answer)
-			locations[i] = answer
-
-			continue
-		}
-
-		locations[i] = l.fromDatabase(addr)
-	}
-
-	return locations
-}
-
-// plainAddress returns addr as the requests to geojs and the cache name it: an
-// IPv4 address mapped into IPv6 as plain IPv4, and with no zone. A client
-// chooses the zone, so it must not reach the request.
-func plainAddress(addr netip.Addr) string {
-	return addr.Unmap().WithZone("").String()
-}
-
-// Start loads the cached answers that have not expired and opens the copy of
-// the database, if there is one. It then starts the goroutines that write new
-// answers, delete expired ones and download the database. They run until Stop:
-// the end of ctx does not stop them.
-func (l *Locator) Start(ctx context.Context) error {
-	err := l.load(ctx)
-	if err != nil {
-		return err
-	}
-
-	l.logger.Info("Geolocation cache loaded", "entries", l.entries.Len())
-
-	l.openDatabaseCopy()
-
-	ctx, l.stop = context.WithCancel(context.WithoutCancel(ctx))
-
-	go func() {
-		defer close(l.done)
-		defer l.closeDatabase()
-
-		var workers sync.WaitGroup
-
-		workers.Go(func() { l.keepCache(ctx) })
-		workers.Go(func() { l.keepDatabaseCurrent(ctx) })
-		workers.Wait()
-	}()
-
-	return nil
-}
-
-// Stop cancels a download in progress, writes the answers cache.db does not
-// have yet, and waits until the goroutines have returned or ctx ends.
-func (l *Locator) Stop(ctx context.Context) {
-	l.stop()
-
-	select {
-	case <-l.done:
-		l.logger.Info("Geolocation stopped")
-	case <-ctx.Done():
-		l.logger.Warn("Stop deadline passed before the geolocation cache " +
-			"was written")
-	}
-}

internal/iplist/download.go

@@ -21,7 +21,7 @@ const (
 	downloadTimeout = time.Minute
 
 	// maxDownloadSize is the size of the largest list file accepted, in
-	// bytes. The largest list, iCloud Private Relay, is about 12 MiB.
+	// bytes. The largest list, FireHOL abusers, is about 2.5 MiB.
 	maxDownloadSize = 200 << 20
 )
 

internal/iplist/iplist.go

@@ -34,33 +34,6 @@ const (
 	// addresses in two fields: exit_addresses, which has IPv4 only, and
 	// or_addresses, which has IPv4 and IPv6, each with a port.
 	FormatOnionooJSON
-
-	// FormatMullvadJSON is Mullvad's JSON list of relays. A relay's addresses
-	// are in ipv4_addr_in, ipv6_addr_in and ipv4_v2ray.
-	FormatMullvadJSON
-
-	// FormatNordVPNJSON is NordVPN's JSON list of servers. A server's
-	// addresses are in station and ipv6_station.
-	FormatNordVPNJSON
-
-	// FormatPIAJSON is Private Internet Access's JSON server list, then a
-	// blank line and a signature. Each region's servers has lists of servers
-	// by protocol, and each server has its address in ip.
-	FormatPIAJSON
-
-	// FormatIVPNJSON is IVPN's JSON server list. The hosts of its wireguard
-	// and openvpn gateways have their addresses in host and v2ray.
-	FormatIVPNJSON
-
-	// FormatProtonVPN has one address or network per line, with comment lines
-	// that start with #. Unlike FormatLines, a file with no addresses or
-	// networks fails.
-	FormatProtonVPN
-
-	// FormatICloudPrivateRelayCSV is Apple's CSV file of iCloud Private Relay
-	// networks. Each line starts with a network, followed by its country,
-	// region and city.
-	FormatICloudPrivateRelayCSV
 )
 
 // List is one public IP list.
@@ -80,9 +53,6 @@ type List struct {
 
 	// Format is how the list's file is written.
 	Format Format
-
-	// VPN says that the list holds servers of VPN services.
-	VPN bool
 }
 
 // Listing says that a list contains an address.
@@ -93,10 +63,6 @@ type Listing struct {
 	// Updated is when routewatch last downloaded the list, or last heard from
 	// its publisher that its copy was still current.
 	Updated time.Time `json:"updated"`
-
-	// VPN says that the list holds servers of VPN services. A lookup answer
-	// reports it through is_vpn and vpn_providers.
-	VPN bool `json:"-"`
 }
 
 // listCopy is a list's last good copy in memory.
@@ -163,7 +129,6 @@ func (b *IPLists) Lookup(addr netip.Addr) []Listing {
 				Name:        list.Name,
 				Description: list.Description,
 				Updated:     c.updated,
-				VPN:         list.VPN,
 			})
 		}
 	}

internal/iplist/iplist_internal_test.go

@@ -43,61 +43,6 @@ const (
 	],"bridges":[]}`
 )
 
-// Small documents in the VPN services' formats. PIA's and IVPN's have no
-// public IPv6 addresses, and IVPN's holds addresses that are not its servers,
-// which must not be read.
-const (
-	mullvadBody = `[
-		{"hostname":"a-wg-001","ipv4_addr_in":"192.0.2.40","ipv6_addr_in":"2001:db8::40"},
-		{"hostname":"a-br-001","ipv4_addr_in":"192.0.2.41","ipv6_addr_in":null,
-		 "ipv4_v2ray":"192.0.2.42"}
-	]`
-	nordVPNBody = `[
-		{"hostname":"a1.example.com","station":"192.0.2.50","ipv6_station":""},
-		{"hostname":"a2.example.com","station":"192.0.2.51","ipv6_station":"2001:db8::51"}
-	]`
-	piaBody = `{"groups":{"wg":[{"name":"wireguard","ports":[1337]}]},"regions":[
-		{"id":"a","servers":{
-			"wg":[{"ip":"192.0.2.60","cn":"a1"}],
-			"ikev2":[{"ip":"192.0.2.61","cn":"a1"}]}},
-		{"id":"b","servers":{"meta":[{"ip":"192.0.2.62","cn":"b1","van":true}]}}
-	]}` + "\n\nc2lnbmF0dXJl\nbGluZSB0d28=\n"
-	ivpnBody = `{"wireguard":[{"gateway":"a.wg.example.com","hosts":[
-		{"hostname":"a1","host":"192.0.2.70","v2ray":"192.0.2.71",
-		 "ipv6":{"local_ip":"2001:db8::70/96"}}]}],
-	"openvpn":[{"gateway":"a.gw.example.com","hosts":[
-		{"hostname":"a1","host":"192.0.2.72"}]}],
-	"config":{"api":{"ips":["192.0.2.73"]}}}`
-)
-
-// protonVPNBody is a small file in the format of the ProtonVPN-IPs list.
-const protonVPNBody = "#\n# protonvpn_ip_ranges.txt\n" +
-	"# https://github.com/tn3w/ProtonVPN-IPs\n#\n" +
-	"# The /24 block of every advertised IPv4.\n#\n" +
-	"192.0.2.0/24\n198.51.100.0/24\n"
-
-// protonVPNEntryBody is a small file in the format of the ProtonVPN-IPs list
-// of server addresses.
-const protonVPNEntryBody = "#\n# protonvpn_entry_ips.txt\n" +
-	"# https://github.com/tn3w/ProtonVPN-IPs\n#\n" +
-	"# Entry IPs clients connect to, resolved from ProtonVPN hostnames.\n#\n" +
-	"192.0.2.80\n2001:db8::80\n"
-
-// iCloudPrivateRelayAddr is an address on iCloudPrivateRelayBody.
-const iCloudPrivateRelayAddr = "2001:db8:1::5"
-
-// iCloudPrivateRelayBody is a small file in the format of Apple's iCloud
-// Private Relay file.
-const iCloudPrivateRelayBody = "192.0.2.0/31,GB,GB-EN,London,\n" +
-	"198.51.100.32/27,US,US-CA,Los Angeles,\n" +
-	"2001:db8:1::/64,US,US-AK,Anchorage,\n"
-
-// emptyFileCase names the case of a wrong document that is an empty file.
-const emptyFileCase = "an empty file"
-
-// errorPage is a file that is no list, as a publisher's error page is.
-const errorPage = "<!DOCTYPE html>\n<html></html>\n"
-
 // testETag is the ETag a publisher sends with a version of the test list.
 const testETag = `"v1"`
 
@@ -213,7 +158,13 @@ func lookup(t *testing.T, b *IPLists, addr string) []Listing {
 func TestLookupFindsListedAddresses(t *testing.T) {
 	t.Parallel()
 
-	runLookupCases(t, []lookupCase{
+	tests := []struct {
+		name     string
+		format   Format
+		body     string
+		listed   []string
+		unlisted []string
+	}{
 		{
 			name:     "single addresses",
 			format:   FormatLines,
@@ -255,83 +206,9 @@ func TestLookupFindsListedAddresses(t *testing.T) {
 			},
 			unlisted: []string{"192.0.2.12", "2001:db8::2"},
 		},
-		{
-			name:   "iCloud Private Relay networks",
-			format: FormatICloudPrivateRelayCSV,
-			body:   iCloudPrivateRelayBody,
-			listed: []string{
-				"192.0.2.1", "198.51.100.63", iCloudPrivateRelayAddr,
-			},
-			unlisted: []string{"192.0.2.2", "198.51.100.64", "2001:db8:2::1"},
-		},
-	})
-}
+	}
 
-// TestLookupFindsVPNServers downloads a list in each VPN service's format and
-// looks up addresses on it and off it.
-func TestLookupFindsVPNServers(t *testing.T) {
-	t.Parallel()
-
-	runLookupCases(t, []lookupCase{
-		{
-			name:     "Mullvad relays",
-			format:   FormatMullvadJSON,
-			body:     mullvadBody,
-			listed:   []string{"192.0.2.40", "192.0.2.41", "192.0.2.42", "2001:db8::40"},
-			unlisted: []string{"192.0.2.43", "2001:db8::41"},
-		},
-		{
-			name:     "NordVPN servers",
-			format:   FormatNordVPNJSON,
-			body:     nordVPNBody,
-			listed:   []string{"192.0.2.50", "192.0.2.51", "2001:db8::51"},
-			unlisted: []string{"192.0.2.52", "2001:db8::50"},
-		},
-		{
-			name:     "PIA servers, with the signature after the JSON",
-			format:   FormatPIAJSON,
-			body:     piaBody,
-			listed:   []string{"192.0.2.60", "192.0.2.61", "192.0.2.62"},
-			unlisted: []string{"192.0.2.63", "2001:db8::60"},
-		},
-		{
-			name:     "IVPN hosts",
-			format:   FormatIVPNJSON,
-			body:     ivpnBody,
-			listed:   []string{"192.0.2.70", "192.0.2.71", "192.0.2.72"},
-			unlisted: []string{"192.0.2.73", "2001:db8::70"},
-		},
-		{
-			name:     "ProtonVPN networks",
-			format:   FormatProtonVPN,
-			body:     protonVPNBody,
-			listed:   []string{"192.0.2.0", "192.0.2.255", "198.51.100.7"},
-			unlisted: []string{"192.0.3.1", "2001:db8::90"},
-		},
-		{
-			name:     "ProtonVPN server addresses",
-			format:   FormatProtonVPN,
-			body:     protonVPNEntryBody,
-			listed:   []string{"192.0.2.80", "2001:db8::80"},
-			unlisted: []string{"192.0.2.81", "2001:db8::81"},
-		},
-	})
-}
-
-// lookupCase is a list file, the addresses it holds and some it does not.
-type lookupCase struct {
-	name     string
-	format   Format
-	body     string
-	listed   []string
-	unlisted []string
-}
-
-// runLookupCases downloads each case's list file and checks its addresses.
-func runLookupCases(t *testing.T, cases []lookupCase) {
-	t.Helper()
-
-	for _, tt := range cases {
+	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 
@@ -383,7 +260,7 @@ func TestFailedDownloadKeepsThePreviousCopy(t *testing.T) {
 		body   string
 	}{
 		{"server error", http.StatusInternalServerError, "unavailable"},
-		{"not a list", http.StatusOK, errorPage},
+		{"not a list", http.StatusOK, "<!DOCTYPE html>\n<html></html>\n"},
 	}
 
 	for _, tt := range tests {
@@ -429,7 +306,7 @@ func TestFileThatIsNotAnOnionooDocumentKeepsThePreviousCopy(t *testing.T) {
 		name string
 		body string
 	}{
-		{"not JSON", errorPage},
+		{"not JSON", "<!DOCTYPE html>\n<html></html>\n"},
 		{"other JSON", `{"status":"ok","data":{"relays_count":1}}`},
 		{"JSON array", `[{"or_addresses":["192.0.2.1:443"]}]`},
 		{"no relays", `{"relays":[],"bridges":[]}`},
@@ -471,168 +348,6 @@ func TestFileThatIsNotAnOnionooDocumentKeepsThePreviousCopy(t *testing.T) {
 	}
 }
 
-// TestWrongVPNDocumentFailsToParse parses documents that are not a VPN
-// service's list. Each fails, so none can replace a good copy.
-func TestWrongVPNDocumentFailsToParse(t *testing.T) {
-	t.Parallel()
-
-	formats := []struct {
-		name       string
-		format     Format
-		good       string
-		empty      string
-		badAddress string
-	}{
-		{
-			"Mullvad", FormatMullvadJSON, mullvadBody,
-			`[{"hostname":"a"}]`, `[{"ipv4_addr_in":"example"}]`,
-		},
-		{
-			"NordVPN", FormatNordVPNJSON, nordVPNBody,
-			`[{"hostname":"a","station":"","ipv6_station":""}]`,
-			`[{"station":"example"}]`,
-		},
-		{
-			"PIA", FormatPIAJSON, piaBody,
-			`{"regions":[{"id":"a","servers":{}}]}`,
-			`{"regions":[{"servers":{"wg":[{"ip":"example"}]}}]}`,
-		},
-		{
-			"IVPN", FormatIVPNJSON, ivpnBody,
-			`{"wireguard":[{"hosts":[]}],"openvpn":[]}`,
-			`{"wireguard":[{"hosts":[{"host":"example"}]}]}`,
-		},
-	}
-
-	for _, f := range formats {
-		bodies := map[string]string{
-			"not JSON":     errorPage,
-			"other JSON":   `{"status":"ok","data":{"count":1}}`,
-			"no addresses": f.empty,
-			"bad address":  f.badAddress,
-			"cut off":      f.good[:len(f.good)/2],
-			emptyFileCase:  "",
-		}
-
-		for name, body := range bodies {
-			t.Run(f.name+" "+name, func(t *testing.T) {
-				t.Parallel()
-
-				addresses, err := parse(strings.NewReader(body), f.format)
-				if err == nil {
-					t.Errorf("parse returned %v and no error", addresses.Ranges())
-				}
-			})
-		}
-	}
-}
-
-// TestWrongProtonVPNDocumentFailsToParse parses documents that are not a
-// ProtonVPN-IPs list. Each fails, so none can replace a good copy.
-func TestWrongProtonVPNDocumentFailsToParse(t *testing.T) {
-	t.Parallel()
-
-	bodies := map[string]string{
-		"error page":    errorPage,
-		"JSON":          `{"status":"ok"}`,
-		"comments only": "#\n# protonvpn_ip_ranges.txt\n#\n",
-		"bad network":   "192.0.2.0/24\nexample\n",
-		emptyFileCase:   "",
-	}
-
-	for name, body := range bodies {
-		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
-			addresses, err := parse(strings.NewReader(body), FormatProtonVPN)
-			if err == nil {
-				t.Errorf("parse returned %v and no error", addresses.Ranges())
-			}
-		})
-	}
-}
-
-// TestWrongICloudPrivateRelayDocumentFailsToParse parses documents that are
-// not Apple's iCloud Private Relay file. Each fails, so none can replace a
-// good copy.
-func TestWrongICloudPrivateRelayDocumentFailsToParse(t *testing.T) {
-	t.Parallel()
-
-	bodies := map[string]string{
-		"error page":     errorPage,
-		"JSON":           `{"status":"ok","count":1}`,
-		"no other field": "192.0.2.0/24\n",
-		"bad network":    "192.0.2.0/24,GB,GB-EN,London,\nexample,GB,GB-EN,London,\n",
-		"an address":     "192.0.2.1,GB,GB-EN,London,\n",
-		emptyFileCase:    "",
-	}
-
-	for name, body := range bodies {
-		t.Run(name, func(t *testing.T) {
-			t.Parallel()
-
-			addresses, err := parse(strings.NewReader(body),
-				FormatICloudPrivateRelayCSV)
-			if err == nil {
-				t.Errorf("parse returned %v and no error", addresses.Ranges())
-			}
-		})
-	}
-}
-
-// TestLookupMarksVPNLists looks up an address on a VPN list and on another
-// list. Only the VPN list's listing says it is one.
-func TestLookupMarksVPNLists(t *testing.T) {
-	t.Parallel()
-
-	_, url := newPublisher(t, goodListBody)
-	vpnList := testList(url, FormatLines)
-	vpnList.Name = "test_vpn_list"
-	vpnList.VPN = true
-	otherList := testList(url, FormatLines)
-
-	b := New(Params{
-		Dir:    t.TempDir(),
-		Lists:  []List{vpnList, otherList},
-		Logger: slog.New(slog.DiscardHandler),
-	})
-
-	for _, list := range b.lists {
-		err := b.download(t.Context(), list)
-		if err != nil {
-			t.Fatalf("download of %s: %v", list.Name, err)
-		}
-	}
-
-	listings := lookup(t, b, listedAddr)
-	if len(listings) != 2 || !listings[0].VPN || listings[1].VPN {
-		t.Errorf("listings %+v, want the first of two marked as a VPN list",
-			listings)
-	}
-}
-
-// TestPublicListsMarkTheVPNLists checks which public lists are VPN lists,
-// since their names are what vpn_providers reports.
-func TestPublicListsMarkTheVPNLists(t *testing.T) {
-	t.Parallel()
-
-	var got []string
-
-	for _, list := range Lists() {
-		if list.VPN {
-			got = append(got, list.Name)
-		}
-	}
-
-	want := []string{
-		"ivpn", "mullvad", "nordvpn", "pia", "protonvpn", "protonvpn_entry",
-		"x4bnet", "x4bnet_v6",
-	}
-	if !slices.Equal(got, want) {
-		t.Errorf("VPN lists %v, want %v", got, want)
-	}
-}
-
 // checkGoodCopyOnDisk checks that dir holds the good version of the test list
 // and no part of a failed download.
 func checkGoodCopyOnDisk(t *testing.T, dir string) {
@@ -750,13 +465,9 @@ func TestRestartLoadsCopiesFromDisk(t *testing.T) {
 	second.Start(t.Context())
 	second.Stop(t.Context())
 
-	// The download takes its time after writing the file, and the restart
-	// reads the file's time. A busy host can put seconds between the two.
-	const maxUpdatedDifference = 15 * time.Second
-
 	listings := lookup(t, second, listedAddr)
 	if len(listings) != 1 ||
-		listings[0].Updated.Sub(downloaded).Abs() > maxUpdatedDifference {
+		listings[0].Updated.Sub(downloaded).Abs() > time.Second {
 		t.Errorf("after the restart, listings %+v, want one updated at %s",
 			listings, downloaded)
 	}
@@ -934,33 +645,15 @@ func TestStopCancelsADownloadInProgress(t *testing.T) {
 func TestTorExitsListHoldsIPv6Exits(t *testing.T) {
 	t.Parallel()
 
-	checkPublicListHolds(t, TorExitsList, onionooBody, onionooIPv6ExitAddr)
-}
-
-// TestICloudPrivateRelayListHoldsItsNetworks downloads a file in Apple's
-// format as the public iCloud Private Relay list, which is what an address's
-// is_relay answer comes from.
-func TestICloudPrivateRelayListHoldsItsNetworks(t *testing.T) {
-	t.Parallel()
-
-	checkPublicListHolds(t, ICloudPrivateRelayList, iCloudPrivateRelayBody,
-		iCloudPrivateRelayAddr)
-}
-
-// checkPublicListHolds downloads body as the public list called name and
-// checks that addr has one listing, which names that list.
-func checkPublicListHolds(t *testing.T, name, body, addr string) {
-	t.Helper()
-
 	index := slices.IndexFunc(Lists(), func(list List) bool {
-		return list.Name == name
+		return list.Name == TorExitsList
 	})
 	if index < 0 {
-		t.Fatalf("no list named %s", name)
+		t.Fatalf("no list named %s", TorExitsList)
 	}
 
 	list := Lists()[index]
-	_, list.URL = newPublisher(t, body)
+	_, list.URL = newPublisher(t, onionooBody)
 	b := newTestIPLists(t.TempDir(), list)
 
 	err := b.download(t.Context(), list)
@@ -968,9 +661,9 @@ func checkPublicListHolds(t *testing.T, name, body, addr string) {
 		t.Fatalf("download: %v", err)
 	}
 
-	listings := lookup(t, b, addr)
-	if len(listings) != 1 || listings[0].Name != name {
-		t.Errorf("listings %+v, want one for %s", listings, name)
+	listings := lookup(t, b, onionooIPv6ExitAddr)
+	if len(listings) != 1 || listings[0].Name != TorExitsList {
+		t.Errorf("listings %+v, want one for %s", listings, TorExitsList)
 	}
 }
 

internal/iplist/lists.go

@@ -1,20 +1,10 @@
 package iplist
 
-import (
-	"slices"
-	"time"
-)
+import "time"
 
 // TorExitsList is the name of the list of Tor exit nodes.
 const TorExitsList = "tor_exits"
 
-// ICloudPrivateRelayList is the name of the list of iCloud Private Relay's
-// networks.
-const ICloudPrivateRelayList = "icloud_private_relay"
-
-// protonVPNIPsURL is where the ProtonVPN-IPs mirror publishes its files.
-const protonVPNIPsURL = "https://raw.githubusercontent.com/tn3w/ProtonVPN-IPs/master/"
-
 // How often each list is downloaded. No list is downloaded more often than
 // its publisher updates it or allows.
 const (
@@ -34,9 +24,6 @@ const (
 	fireHOLAbusersInterval = 5 * time.Hour
 	fireHOLLevel3Interval  = 3 * time.Hour
 
-	// Apple's iCloud Private Relay file is 12 MB, so once a day.
-	iCloudPrivateRelayInterval = 24 * time.Hour
-
 	// Spamhaus asks that DROP be downloaded at most once a day:
 	// https://www.spamhaus.org/blocklists/do-not-route-or-peer/
 	spamhausDROPInterval = 24 * time.Hour
@@ -45,20 +32,12 @@ const (
 	// Onionoo sets no download limit:
 	// https://metrics.torproject.org/onionoo.html
 	torExitsInterval = time.Hour
-
-	// A VPN service's servers change slowly, so once a day is enough.
-	vpnListInterval = 24 * time.Hour
 )
 
 // Lists returns the public IP lists routewatch downloads. Each can be
 // downloaded whole without an account or a key. Spamhaus merged its EDROP
 // list into DROP, so DROP covers both.
 func Lists() []List {
-	return slices.Concat(nonVPNLists(), vpnLists())
-}
-
-// nonVPNLists returns the public lists that are not lists of VPN servers.
-func nonVPNLists() []List {
 	return []List{
 		{
 			Name: "dshield",
@@ -91,13 +70,6 @@ func nonVPNLists() []List {
 			Interval: fireHOLLevel3Interval,
 			Format:   FormatLines,
 		},
-		{
-			Name:        ICloudPrivateRelayList,
-			Description: "In a network where iCloud Private Relay traffic leaves",
-			URL:         "https://mask-api.icloud.com/egress-ip-ranges.csv",
-			Interval:    iCloudPrivateRelayInterval,
-			Format:      FormatICloudPrivateRelayCSV,
-		},
 		{
 			Name: "spamhaus_drop",
 			Description: "In an IPv4 network that Spamhaus says spammers " +
@@ -124,86 +96,3 @@ func nonVPNLists() []List {
 		},
 	}
 }
-
-// vpnLists returns the public lists of VPN servers. Their names are what
-// vpn_providers reports.
-func vpnLists() []List {
-	return []List{
-		{
-			Name:        "ivpn",
-			Description: "A server of the IVPN service",
-			URL:         "https://api.ivpn.net/v5/servers.json",
-			Interval:    vpnListInterval,
-			Format:      FormatIVPNJSON,
-			VPN:         true,
-		},
-		{
-			Name:        "mullvad",
-			Description: "A server of the Mullvad VPN service",
-			URL:         "https://api.mullvad.net/www/relays/all/",
-			Interval:    vpnListInterval,
-			Format:      FormatMullvadJSON,
-			VPN:         true,
-		},
-		{
-			Name:        "nordvpn",
-			Description: "A server of the NordVPN service",
-			URL: "https://api.nordvpn.com/v1/servers?limit=0" +
-				"&fields[servers.station]&fields[servers.ipv6_station]" +
-				"&fields[servers.hostname]",
-			Interval: vpnListInterval,
-			Format:   FormatNordVPNJSON,
-			VPN:      true,
-		},
-		{
-			Name:        "pia",
-			Description: "A server of the Private Internet Access VPN service",
-			URL:         "https://serverlist.piaservers.net/vpninfo/servers/v6",
-			Interval:    vpnListInterval,
-			Format:      FormatPIAJSON,
-			VPN:         true,
-		},
-		{
-			// Proton's own server list needs a logged-in session, so this is
-			// the public ProtonVPN-IPs mirror of it. Proton publishes only
-			// the addresses clients connect to. The mirror's README says
-			// traffic leaves from others in the same /24, so this file of
-			// /24 networks is the one it says to use for detecting exits.
-			Name: "protonvpn",
-			Description: "In a /24 network that holds a server of the " +
-				"ProtonVPN service",
-			URL:      protonVPNIPsURL + "protonvpn_ip_ranges.txt",
-			Interval: vpnListInterval,
-			Format:   FormatProtonVPN,
-			VPN:      true,
-		},
-		{
-			Name:        "protonvpn_entry",
-			Description: "A server of the ProtonVPN service",
-			URL:         protonVPNIPsURL + "protonvpn_entry_ips.txt",
-			Interval:    vpnListInterval,
-			Format:      FormatProtonVPN,
-			VPN:         true,
-		},
-		{
-			Name: "x4bnet",
-			Description: "In an IPv4 network of a VPN service, according to " +
-				"X4BNet's community list",
-			URL: "https://raw.githubusercontent.com/X4BNet/lists_vpn/main/" +
-				"output/vpn/ipv4.txt",
-			Interval: vpnListInterval,
-			Format:   FormatLines,
-			VPN:      true,
-		},
-		{
-			Name: "x4bnet_v6",
-			Description: "In an IPv6 network of a VPN service, according to " +
-				"X4BNet's community list",
-			URL: "https://raw.githubusercontent.com/X4BNet/lists_vpn/main/" +
-				"output/vpn/ipv6.txt",
-			Interval: vpnListInterval,
-			Format:   FormatLines,
-			VPN:      true,
-		},
-	}
-}

internal/iplist/parse.go

@@ -8,7 +8,6 @@ import (
 	"io"
 	"net"
 	"net/netip"
-	"slices"
 	"strings"
 
 	"go4.org/netipx"
@@ -25,10 +24,6 @@ const (
 	// dshieldFieldSeparator separates the fields of a DShield line.
 	dshieldFieldSeparator = "\t"
 
-	// iCloudPrivateRelayFieldSeparator separates the fields of a line of
-	// Apple's iCloud Private Relay file.
-	iCloudPrivateRelayFieldSeparator = ","
-
 	// spamhausMetadataType is the type of the line that ends a Spamhaus
 	// file. That line holds the file's metadata and no network.
 	spamhausMetadataType = "metadata"
@@ -38,7 +33,7 @@ var (
 	errUnknownFormat = errors.New("unknown list format")
 	errNoNetwork     = errors.New("no network on the line")
 	errBadRange      = errors.New("first and last address make no range")
-	errNoAddresses   = errors.New("no addresses in the document")
+	errNoAddresses   = errors.New("no relay addresses in the document")
 )
 
 // parse reads a list file written in format and returns the addresses it
@@ -54,18 +49,6 @@ func parse(r io.Reader, format Format) (*netipx.IPSet, error) {
 		return parseLines(r, addDShieldNetwork)
 	case FormatOnionooJSON:
 		return parseOnionoo(r)
-	case FormatMullvadJSON:
-		return parseMullvad(r)
-	case FormatNordVPNJSON:
-		return parseNordVPN(r)
-	case FormatPIAJSON:
-		return parsePIA(r)
-	case FormatIVPNJSON:
-		return parseIVPN(r)
-	case FormatProtonVPN:
-		return parseLinesNotEmpty(r, addAddressOrNetwork)
-	case FormatICloudPrivateRelayCSV:
-		return parseLinesNotEmpty(r, addICloudPrivateRelayNetwork)
 	default:
 		return nil, errUnknownFormat
 	}
@@ -185,6 +168,11 @@ func addDShieldNetwork(builder *netipx.IPSetBuilder, line string) error {
 // fields of the relays in an Onionoo details document. A document with no
 // addresses fails, because the Tor network always has relays.
 func parseOnionoo(r io.Reader) (*netipx.IPSet, error) {
+	data, err := io.ReadAll(r)
+	if err != nil {
+		return nil, err
+	}
+
 	//nolint:tagliatelle // Onionoo's own field names
 	var details struct {
 		Relays []struct {
@@ -193,7 +181,7 @@ func parseOnionoo(r io.Reader) (*netipx.IPSet, error) {
 		} `json:"relays"`
 	}
 
-	err := readJSON(r, &details)
+	err = json.Unmarshal(data, &details)
 	if err != nil {
 		return nil, err
 	}
@@ -228,188 +216,6 @@ func parseOnionoo(r io.Reader) (*netipx.IPSet, error) {
 	return addresses, nil
 }
 
-// parseMullvad returns the addresses of the relays in a Mullvad document. A
-// relay with no IPv6 address has null for it, and only bridges have
-// ipv4_v2ray.
-func parseMullvad(r io.Reader) (*netipx.IPSet, error) {
-	//nolint:tagliatelle // Mullvad's own field names
-	var relays []struct {
-		IPv4      string `json:"ipv4_addr_in"`
-		IPv6      string `json:"ipv6_addr_in"`
-		IPv4V2Ray string `json:"ipv4_v2ray"`
-	}
-
-	err := readJSON(r, &relays)
-	if err != nil {
-		return nil, err
-	}
-
-	var texts []string
-
-	for _, relay := range relays {
-		texts = append(texts, relay.IPv4, relay.IPv6, relay.IPv4V2Ray)
-	}
-
-	return addressSet(texts)
-}
-
-// parseNordVPN returns the addresses of the servers in a NordVPN document. A
-// server with no IPv6 address has an empty ipv6_station.
-func parseNordVPN(r io.Reader) (*netipx.IPSet, error) {
-	//nolint:tagliatelle // NordVPN's own field names
-	var servers []struct {
-		Station     string `json:"station"`
-		IPv6Station string `json:"ipv6_station"`
-	}
-
-	err := readJSON(r, &servers)
-	if err != nil {
-		return nil, err
-	}
-
-	var texts []string
-
-	for _, server := range servers {
-		texts = append(texts, server.Station, server.IPv6Station)
-	}
-
-	return addressSet(texts)
-}
-
-// parsePIA returns the addresses of the servers in a Private Internet Access
-// document. json.Decoder stops at the end of the JSON, so the signature after
-// it is not read.
-func parsePIA(r io.Reader) (*netipx.IPSet, error) {
-	var list struct {
-		Regions []struct {
-			Servers map[string][]struct {
-				IP string `json:"ip"`
-			} `json:"servers"`
-		} `json:"regions"`
-	}
-
-	err := json.NewDecoder(r).Decode(&list)
-	if err != nil {
-		return nil, err
-	}
-
-	var texts []string
-
-	for _, region := range list.Regions {
-		for _, servers := range region.Servers {
-			for _, server := range servers {
-				texts = append(texts, server.IP)
-			}
-		}
-	}
-
-	return addressSet(texts)
-}
-
-// parseIVPN returns the addresses of the hosts in an IVPN document. A host's
-// ipv6 object holds only an address inside the VPN, so it is not read.
-func parseIVPN(r io.Reader) (*netipx.IPSet, error) {
-	type gateway struct {
-		Hosts []struct {
-			Host  string `json:"host"`
-			V2Ray string `json:"v2ray"`
-		} `json:"hosts"`
-	}
-
-	var list struct {
-		WireGuard []gateway `json:"wireguard"`
-		OpenVPN   []gateway `json:"openvpn"`
-	}
-
-	err := readJSON(r, &list)
-	if err != nil {
-		return nil, err
-	}
-
-	var texts []string
-
-	for _, gw := range slices.Concat(list.WireGuard, list.OpenVPN) {
-		for _, host := range gw.Hosts {
-			texts = append(texts, host.Host, host.V2Ray)
-		}
-	}
-
-	return addressSet(texts)
-}
-
-// parseLinesNotEmpty is parseLines for a list that always holds addresses, so
-// a file with none fails.
-func parseLinesNotEmpty(
-	r io.Reader, addLine func(*netipx.IPSetBuilder, string) error,
-) (*netipx.IPSet, error) {
-	addresses, err := parseLines(r, addLine)
-	if err != nil {
-		return nil, err
-	}
-
-	if len(addresses.Ranges()) == 0 {
-		return nil, errNoAddresses
-	}
-
-	return addresses, nil
-}
-
-// addICloudPrivateRelayNetwork adds the network at the start of a line of
-// Apple's iCloud Private Relay file to builder.
-func addICloudPrivateRelayNetwork(builder *netipx.IPSetBuilder, line string) error {
-	field, _, found := strings.Cut(line, iCloudPrivateRelayFieldSeparator)
-	if !found {
-		return errNoNetwork
-	}
-
-	network, err := netip.ParsePrefix(field)
-	if err != nil {
-		return err
-	}
-
-	builder.AddPrefix(network)
-
-	return nil
-}
-
-// readJSON reads r to its end and decodes it, as one JSON document, into v.
-func readJSON(r io.Reader, v any) error {
-	data, err := io.ReadAll(r)
-	if err != nil {
-		return err
-	}
-
-	return json.Unmarshal(data, v)
-}
-
-// addressSet returns the set of the addresses in texts, skipping empty ones.
-// A list with no addresses fails, because every VPN service has servers.
-func addressSet(texts []string) (*netipx.IPSet, error) {
-	var builder netipx.IPSetBuilder
-
-	for _, text := range texts {
-		if text == "" {
-			continue
-		}
-
-		err := addAddress(&builder, text)
-		if err != nil {
-			return nil, err
-		}
-	}
-
-	addresses, err := builder.IPSet()
-	if err != nil {
-		return nil, err
-	}
-
-	if len(addresses.Ranges()) == 0 {
-		return nil, errNoAddresses
-	}
-
-	return addresses, nil
-}
-
 // addAddress adds an address, such as 192.0.2.1, to builder.
 func addAddress(builder *netipx.IPSetBuilder, text string) error {
 	addr, err := netip.ParseAddr(text)

internal/ptr/cache.go

@@ -1,6 +1,6 @@
 // Package ptr looks up the PTR names of addresses over DNS-over-HTTPS. It
-// keeps answers in memory for as long as DNS allows, and in cache.db so that
-// the answers survive a restart.
+// keeps each answer in memory for as long as DNS allows, and in cache.db so
+// that the answers survive a restart.
 package ptr
 
 import (
@@ -29,10 +29,6 @@ const (
 
 	// nameSeparator separates the names in a row of the hostnames table.
 	nameSeparator = " "
-
-	// maxAddresses limits how many addresses the cache holds, so that a public
-	// lookup cannot grow memory and cache.db without bound.
-	maxAddresses = 250_000
 )
 
 // Params is what New needs.
@@ -56,16 +52,15 @@ type entry struct {
 // Cache answers PTR lookups from memory, and asks the resolvers for an address
 // it holds no current answer for. Start loads it from cache.db.
 type Cache struct {
-	db         *sql.DB
-	resolvers  []string
-	timeLimit  time.Duration
-	maxEntries int
-	logger     *slog.Logger
-	client     *http.Client
-	now        func() time.Time
+	db        *sql.DB
+	resolvers []string
+	timeLimit time.Duration
+	logger    *slog.Logger
+	client    *http.Client
+	now       func() time.Time
 
-	// entries holds the kept answers by address, at most maxEntries of them.
-	// pending holds those that cache.db does not have yet.
+	// entries holds every answer by address. pending holds those that
+	// cache.db does not have yet.
 	mu      sync.RWMutex
 	entries map[string]entry
 	pending map[string]entry
@@ -78,16 +73,15 @@ type Cache struct {
 // New returns an empty Cache. Start loads it.
 func New(params Params) *Cache {
 	return &Cache{
-		db:         params.DB,
-		resolvers:  params.Resolvers,
-		timeLimit:  LookupTimeout,
-		maxEntries: maxAddresses,
-		logger:     params.Logger.With("component", "ptr"),
-		client:     &http.Client{},
-		now:        time.Now,
-		entries:    make(map[string]entry),
-		pending:    make(map[string]entry),
-		done:       make(chan struct{}),
+		db:        params.DB,
+		resolvers: params.Resolvers,
+		timeLimit: LookupTimeout,
+		logger:    params.Logger.With("component", "ptr"),
+		client:    &http.Client{},
+		now:       time.Now,
+		entries:   make(map[string]entry),
+		pending:   make(map[string]entry),
+		done:      make(chan struct{}),
 	}
 }
 
@@ -101,12 +95,14 @@ func (c *Cache) LookupAddr(ctx context.Context, addr string) ([]string, error) {
 		return nil, fmt.Errorf("parsing the address: %w", err)
 	}
 
-	_, reserved := bogon.Addr(parsed)
+	parsed = parsed.Unmap()
+
+	_, reserved := bogon.Prefix(netip.PrefixFrom(parsed, parsed.BitLen()))
 	if reserved {
 		return []string{}, nil
 	}
 
-	address := parsed.Unmap().String()
+	address := parsed.String()
 
 	cached, ok := c.current(address)
 	if ok {
@@ -174,18 +170,11 @@ func (c *Cache) current(address string) (entry, bool) {
 	return found, true
 }
 
-// store keeps an answer in memory and queues it for cache.db. Once entries
-// holds maxEntries addresses it keeps no new address. It still replaces the
-// answer of an address already held.
+// store keeps an answer in memory and queues it for cache.db.
 func (c *Cache) store(address string, answer entry) {
 	c.mu.Lock()
 	defer c.mu.Unlock()
 
-	_, held := c.entries[address]
-	if !held && len(c.entries) >= c.maxEntries {
-		return
-	}
-
 	c.entries[address] = answer
 	c.pending[address] = answer
 }

internal/ptr/cache_internal_test.go

@@ -880,72 +880,3 @@ func TestFlushKeepsAnswersItCouldNotWrite(t *testing.T) {
 		t.Errorf("%d rows after the second write, want 1", got)
 	}
 }
-
-// TestNewAddressIsNotKeptAtTheLimit fills a cache that holds one address. A
-// lookup of a second address still returns its answer, and the cache keeps
-// nothing for it until the sweep has deleted the first address's expired
-// answer.
-func TestNewAddressIsNotKeptAtTheLimit(t *testing.T) {
-	t.Parallel()
-
-	db := openTestDB(t, t.TempDir())
-	resolver := newFakeResolver(t, ptrReply(300, testName))
-	cache, clock := newTestCache(t, db, resolver)
-	cache.maxEntries = 1
-
-	lookupOK(t, cache, testAddress)
-
-	names := lookupOK(t, cache, otherAddress)
-	if !slices.Equal(names, []string{testName}) {
-		t.Errorf("names %v at the limit, want %s", names, testName)
-	}
-
-	_, inEntries := cache.entries[otherAddress]
-	_, inPending := cache.pending[otherAddress]
-
-	if inEntries || inPending {
-		t.Errorf("a new address was kept at the limit: in entries %t, in pending %t",
-			inEntries, inPending)
-	}
-
-	cache.flush(t.Context())
-
-	if got := countRows(t, db); got != 1 {
-		t.Errorf("%d rows at the limit, want 1", got)
-	}
-
-	clock.advance(300 * time.Second)
-	cache.sweep(t.Context())
-	lookupOK(t, cache, otherAddress)
-
-	_, inEntries = cache.entries[otherAddress]
-	if !inEntries {
-		t.Error("a new address was not kept after the sweep made room")
-	}
-}
-
-// TestHeldAddressIsReplacedAtTheLimit lets the answer of the only address a
-// cache holds expire. The new answer replaces it in memory and is queued for
-// cache.db.
-func TestHeldAddressIsReplacedAtTheLimit(t *testing.T) {
-	t.Parallel()
-
-	resolver := newFakeResolver(t, ptrReply(300, testName))
-	cache, clock := newTestCache(t, openTestDB(t, t.TempDir()), resolver)
-	cache.maxEntries = 1
-
-	lookupOK(t, cache, testAddress)
-	clock.advance(300 * time.Second)
-	resolver.setReply(ptrReply(300, otherName))
-	lookupOK(t, cache, testAddress)
-
-	want := []string{otherName}
-
-	if got := cache.entries[testAddress].names; !slices.Equal(got, want) {
-		t.Errorf("entries holds %v, want %v", got, want)
-	}
-
-	if got := cache.pending[testAddress].names; !slices.Equal(got, want) {
-		t.Errorf("pending holds %v, want %v", got, want)
-	}
-}

internal/routewatch/app.go

@@ -19,7 +19,6 @@ import (
 	"git.eeqj.de/sneak/routewatch/internal/cachedb"
 	"git.eeqj.de/sneak/routewatch/internal/config"
 	"git.eeqj.de/sneak/routewatch/internal/database"
-	"git.eeqj.de/sneak/routewatch/internal/geo"
 	"git.eeqj.de/sneak/routewatch/internal/iplist"
 	"git.eeqj.de/sneak/routewatch/internal/logger"
 	"git.eeqj.de/sneak/routewatch/internal/metrics"
@@ -68,7 +67,6 @@ type RouteWatch struct {
 	ipLists        *iplist.IPLists
 	cacheDB        *sql.DB
 	ptrCache       *ptr.Cache
-	geoLocator     *geo.Locator
 }
 
 // ipListsDirName is the directory in the state directory that holds the IP
@@ -162,11 +160,6 @@ func (rw *RouteWatch) Run(ctx context.Context) error {
 		return err
 	}
 
-	err = rw.startGeoLocator(ctx)
-	if err != nil {
-		return err
-	}
-
 	// Start HTTP server
 	err = rw.server.Start(ctx)
 	if err != nil {
@@ -185,9 +178,8 @@ func (rw *RouteWatch) Run(ctx context.Context) error {
 
 // Shutdown stops all services in order: the streamer, the handlers, which
 // write what they hold, the WHOIS fetcher, the database maintainer, the
-// IP list downloads, the HTTP server, the geolocation cache and the PTR cache,
-// and last the database, which it checkpoints and closes. Each stage waits at
-// most until ctx ends, so
+// IP list downloads, the HTTP server and the PTR cache, and last the database,
+// which it checkpoints and closes. Each stage waits at most until ctx ends, so
 // Shutdown returns soon after: a handler logs what it could not write by
 // then, and the HTTP server closes the connections of requests still
 // running.
@@ -247,10 +239,6 @@ func (rw *RouteWatch) Shutdown(ctx context.Context) {
 			"error", err)
 	}
 
-	if rw.geoLocator != nil {
-		rw.geoLocator.Stop(ctx)
-	}
-
 	rw.stopPTRCache(ctx)
 
 	rw.closeDatabase(ctx)
@@ -295,32 +283,6 @@ func (rw *RouteWatch) startPTRCache(ctx context.Context) error {
 	return nil
 }
 
-// startGeoLocator loads the geolocation cache from cache.db, which
-// startPTRCache has opened, and gives the server the locator. The HTTP handlers
-// read it without a lock, so it is set before they run.
-func (rw *RouteWatch) startGeoLocator(ctx context.Context) error {
-	locator, err := geo.New(geo.Params{
-		DB:                rw.cacheDB,
-		Dir:               rw.config.StateDir,
-		GeoJSURL:          geo.GeoJSEndpoint,
-		DatabaseURLFormat: geo.DatabaseDownloadFormat,
-		Logger:            rw.logger.Logger,
-	})
-	if err != nil {
-		return err
-	}
-
-	err = locator.Start(ctx)
-	if err != nil {
-		return err
-	}
-
-	rw.geoLocator = locator
-	rw.server.SetGeoLocator(locator)
-
-	return nil
-}
-
 // stopPTRCache stops the PTR cache, which writes the answers cache.db does not
 // have yet, and closes cache.db, unless ctx has ended and a write may still be
 // running.

internal/routewatch/app_integration_internal_test.go

@@ -8,8 +8,6 @@ import (
 	"net/http"
 	"net/http/httptest"
 	"net/netip"
-	"os"
-	"path/filepath"
 	"slices"
 	"strconv"
 	"strings"
@@ -785,74 +783,3 @@ func TestShutdownCheckpointsAndClosesTheDatabaseLast(t *testing.T) {
 		t.Errorf("Shutdown made the calls %q, want %q", store.calls, want)
 	}
 }
-
-// TestPTRCacheAnswersTheIPLookup starts the PTR cache and the HTTP server as
-// Run does, and looks up a reserved address, which asks no resolver. Without
-// the PTR cache the server has no PTR resolver, and every IP lookup answers
-// 500.
-func TestPTRCacheAnswersTheIPLookup(t *testing.T) {
-	t.Parallel()
-
-	store := newMockStore()
-	log := logger.New()
-	port := freePort(t)
-	cfg := &config.Config{Port: port, StateDir: t.TempDir()}
-	s := streamer.New(log, metrics.New())
-
-	// A started server reads its routing table in the background, so it
-	// needs one.
-	rw := New(Dependencies{
-		DB:       store,
-		Streamer: s,
-		Server: server.New(store, routetable.New(routetable.Params{}), s, log,
-			cfg),
-		Logger: log,
-		Config: cfg,
-	})
-
-	err := rw.startPTRCache(t.Context())
-	if err != nil {
-		t.Fatalf("failed to start the PTR cache: %v", err)
-	}
-
-	defer rw.stopPTRCache(t.Context())
-
-	err = rw.server.Start(t.Context())
-	if err != nil {
-		t.Fatalf("failed to start the HTTP server: %v", err)
-	}
-
-	defer func() { _ = rw.server.Stop(t.Context()) }()
-
-	req, err := http.NewRequestWithContext(t.Context(), http.MethodGet,
-		"http://"+net.JoinHostPort("127.0.0.1", strconv.Itoa(port))+
-			"/api/v1/ip/10.0.0.1", nil)
-	if err != nil {
-		t.Fatalf("failed to build the request: %v", err)
-	}
-
-	resp, err := http.DefaultClient.Do(req)
-	if err != nil {
-		t.Fatalf("the IP lookup failed: %v", err)
-	}
-
-	defer func() { _ = resp.Body.Close() }()
-
-	body, err := io.ReadAll(resp.Body)
-	if err != nil {
-		t.Fatalf("failed to read the answer: %v", err)
-	}
-
-	if resp.StatusCode != http.StatusOK {
-		t.Fatalf("status %d, want %d; body %s", resp.StatusCode, http.StatusOK, body)
-	}
-
-	if !strings.Contains(string(body), `"ptr":[]`) {
-		t.Errorf("answer %s, want an empty ptr", body)
-	}
-
-	_, err = os.Stat(filepath.Join(cfg.StateDir, "cache.db"))
-	if err != nil {
-		t.Errorf("cache.db is not in the state directory: %v", err)
-	}
-}

internal/server/handlers.go

@@ -17,7 +17,6 @@ import (
 
 	"git.eeqj.de/sneak/routewatch/internal/bogon"
 	"git.eeqj.de/sneak/routewatch/internal/database"
-	"git.eeqj.de/sneak/routewatch/internal/geo"
 	"git.eeqj.de/sneak/routewatch/internal/iplist"
 	"git.eeqj.de/sneak/routewatch/internal/metrics"
 	"git.eeqj.de/sneak/routewatch/internal/ristypes"
@@ -765,9 +764,9 @@ type IPLookupResponse struct {
 }
 
 // IPLookupResult is the answer for one address: its PTR names, its flags, its
-// live route and that route's AS, the IP lists that contain it, and where it
-// is. Every result has every field. The fields of IPInfo are null when the
-// address has no live route.
+// live route and that route's AS, and the IP lists that contain it. Every
+// result has every field. The fields of IPInfo are null when the address has
+// no live route.
 //
 //nolint:tagliatelle // snake_case keys, as the Go style guide asks
 type IPLookupResult struct {
@@ -779,15 +778,8 @@ type IPLookupResult struct {
 
 	Flags IPLookupFlags `json:"flags"`
 
-	// VPNProviders names the VPN lists the address is on. It is empty, never
-	// nil, when there are none.
-	VPNProviders []string `json:"vpn_providers"`
-
 	// IPLists has one entry for each IP list the address is on.
 	IPLists []iplist.Listing `json:"ip_lists"`
-
-	// Geo is where the address is. It is nil when no source answers.
-	Geo *geo.Location `json:"geo"`
 }
 
 // IPLookupFlags are the yes-or-no facts about an address. Every result has
@@ -798,12 +790,6 @@ type IPLookupFlags struct {
 	// IsTor says that the address is on the Tor exit list.
 	IsTor bool `json:"is_tor"`
 
-	// IsVPN says that the address is on a list of VPN servers.
-	IsVPN bool `json:"is_vpn"`
-
-	// IsRelay says that the address is on the iCloud Private Relay list.
-	IsRelay bool `json:"is_relay"`
-
 	// IsBogon says that the address is reserved, as package bogon tells.
 	IsBogon bool `json:"is_bogon"`
 }
@@ -846,8 +832,6 @@ func (s *Server) handleIPInfo() http.HandlerFunc {
 			return
 		}
 
-		locations := s.geoLocations(ctx, ipsToLookup)
-
 		// Track ASNs that need WHOIS refresh
 		refreshASNs := make(map[int]bool)
 
@@ -883,9 +867,7 @@ func (s *Server) handleIPInfo() http.HandlerFunc {
 				return
 			}
 
-			result := s.ipLookupResult(ip, ptrs, ipInfo)
-			result.Geo = locations[ip]
-			response.Results = append(response.Results, result)
+			response.Results = append(response.Results, s.ipLookupResult(ip, ptrs, ipInfo))
 
 			if ipInfo.NeedsWHOISRefresh {
 				refreshASNs[*ipInfo.ASN] = true
@@ -992,30 +974,14 @@ func (s *Server) ipLookupResult(ip string, ptrs []string, info IPInfo) IPLookupR
 	listings := s.ipListListings(ip)
 
 	return IPLookupResult{
-		IP:           ip,
-		PTR:          ptrs,
-		IPInfo:       info,
-		Flags:        ipLookupFlags(ip, listings),
-		VPNProviders: vpnProviders(listings),
-		IPLists:      listings,
+		IP:      ip,
+		PTR:     ptrs,
+		IPInfo:  info,
+		Flags:   ipLookupFlags(ip, listings),
+		IPLists: listings,
 	}
 }
 
-// vpnProviders returns the names of the VPN lists among listings. It returns
-// an empty list, never nil, so that an answer's vpn_providers is [] rather
-// than null.
-func vpnProviders(listings []iplist.Listing) []string {
-	names := []string{}
-
-	for _, listing := range listings {
-		if listing.VPN {
-			names = append(names, listing.Name)
-		}
-	}
-
-	return names
-}
-
 // ipListListings returns the IP lists that contain ip. It returns an empty
 // list, never nil, so that an answer's ip_lists is [] rather than null.
 func (s *Server) ipListListings(ip string) []iplist.Listing {
@@ -1033,63 +999,20 @@ func ipLookupFlags(ip string, listings []iplist.Listing) IPLookupFlags {
 		IsTor: slices.ContainsFunc(listings, func(l iplist.Listing) bool {
 			return l.Name == iplist.TorExitsList
 		}),
-		IsVPN: slices.ContainsFunc(listings, func(l iplist.Listing) bool {
-			return l.VPN
-		}),
-		IsRelay: slices.ContainsFunc(listings, func(l iplist.Listing) bool {
-			return l.Name == iplist.ICloudPrivateRelayList
-		}),
 		IsBogon: isBogon(ip),
 	}
 }
 
-// geoLocations returns where ips are, by address. An address that does not
-// parse has no entry. Nor has a reserved one, which is sent to no outside
-// source and has no location.
-func (s *Server) geoLocations(
-	ctx context.Context, ips []string,
-) map[string]*geo.Location {
-	if s.geoLocator == nil {
-		return nil
-	}
-
-	var (
-		kept  []string
-		addrs []netip.Addr
-	)
-
-	for _, ip := range ips {
-		addr, err := netip.ParseAddr(ip)
-		if err != nil || isBogon(ip) {
-			continue
-		}
-
-		kept = append(kept, ip)
-		addrs = append(addrs, addr)
-	}
-
-	if len(addrs) == 0 {
-		return nil
-	}
-
-	answers := s.geoLocator.Lookup(ctx, addrs)
-	locations := make(map[string]*geo.Location, len(kept))
-
-	for i, ip := range kept {
-		locations[ip] = answers[i]
-	}
-
-	return locations
-}
-
-// isBogon says whether the address ip is reserved, as package bogon tells.
+// isBogon says whether the address ip is reserved. An IPv4 address written in
+// IPv6 form counts as the IPv4 address it holds.
 func isBogon(ip string) bool {
 	addr, err := netip.ParseAddr(ip)
 	if err != nil {
 		return false
 	}
 
-	_, reserved := bogon.Addr(addr)
+	addr = addr.Unmap()
+	_, reserved := bogon.Prefix(netip.PrefixFrom(addr, addr.BitLen()))
 
 	return reserved
 }

internal/server/handlers_internal_test.go

@@ -15,15 +15,12 @@ import (
 	"slices"
 	"strconv"
 	"strings"
-	"sync"
 	"sync/atomic"
 	"testing"
-	"testing/synctest"
 	"time"
 
 	"git.eeqj.de/sneak/routewatch/internal/config"
 	"git.eeqj.de/sneak/routewatch/internal/database"
-	"git.eeqj.de/sneak/routewatch/internal/geo"
 	"git.eeqj.de/sneak/routewatch/internal/iplist"
 	"git.eeqj.de/sneak/routewatch/internal/logger"
 	"git.eeqj.de/sneak/routewatch/internal/metrics"
@@ -177,9 +174,6 @@ type tableStats struct {
 // carried 203.0.113.0/24, the two with kept routes withdrew it, so its origin
 // keeps no route. The oldest and newest routes are those of the other two
 // prefixes.
-//
-// The requests run in a synctest bubble, whose clock is fake, so a stall on
-// the host does not use up the handlers' 4-second limit.
 func TestStatsHandlersAnswerFromMemory(t *testing.T) {
 	t.Parallel()
 
@@ -225,11 +219,7 @@ func TestStatsHandlersAnswerFromMemory(t *testing.T) {
 
 	for name, handler := range handlers {
 		rec := httptest.NewRecorder()
-
-		synctest.Test(t, func(t *testing.T) {
-			handler(rec,
-				httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/", nil))
-		})
+		handler(rec, httptest.NewRequestWithContext(t.Context(), http.MethodGet, "/", nil))
 
 		if rec.Code != http.StatusOK {
 			t.Errorf("%s: status %d, want %d; body %s",
@@ -264,20 +254,15 @@ func TestStatsHandlersAnswerFromMemory(t *testing.T) {
 // TestStatsAnswerCarriesChurnPerMinute checks that the stream object of the
 // /api/v1/stats answer holds route_churn_per_min as a whole number, and no
 // longer route_churn_per_sec, the moving average it replaces
-// (https://git.eeqj.de/sneak/routewatch/issues/160). The request runs in a
-// synctest bubble, whose clock is fake, so a stall on the host does not use up
-// the handler's 4-second limit.
+// (https://git.eeqj.de/sneak/routewatch/issues/160).
 func TestStatsAnswerCarriesChurnPerMinute(t *testing.T) {
 	t.Parallel()
 
 	s := newServerWithTestRoutes(t)
 
 	rec := httptest.NewRecorder()
-
-	synctest.Test(t, func(t *testing.T) {
-		s.handleStats()(rec,
-			httptest.NewRequestWithContext(t.Context(), http.MethodGet, statsPath, nil))
-	})
+	s.handleStats()(rec,
+		httptest.NewRequestWithContext(t.Context(), http.MethodGet, statsPath, nil))
 
 	if rec.Code != http.StatusOK {
 		t.Fatalf("status %d, want %d; body %s", rec.Code, http.StatusOK, rec.Body)
@@ -325,26 +310,18 @@ func (heldBackHandler) HeldBackCount() int                 { return heldBackMess
 
 // TestStatsAnswerGivesHowManyMessagesAHandlerHoldsBack registers a handler
 // that holds back messages. Its figures in /api/v1/stats, which the status
-// page shows, must give how many. The request runs in a synctest bubble, whose
-// clock is fake, so a stall on the host does not use up the handler's 4-second
-// limit.
+// page shows, must give how many.
 func TestStatsAnswerGivesHowManyMessagesAHandlerHoldsBack(t *testing.T) {
 	t.Parallel()
 
 	s := newServerWithTestRoutes(t)
 	s.streamer.RegisterHandler(heldBackHandler{})
 
-	var answer []byte
-
-	synctest.Test(t, func(t *testing.T) {
-		answer = get(t, s, statsPath).Body.Bytes()
-	})
-
 	var body struct {
 		Data StatsResponse `json:"data"`
 	}
 
-	err := json.Unmarshal(answer, &body)
+	err := json.Unmarshal(get(t, s, statsPath).Body.Bytes(), &body)
 	if err != nil {
 		t.Fatalf("decoding the answer: %v", err)
 	}
@@ -388,9 +365,7 @@ type unitStats struct {
 // names. They used to be strings with the unit in them, such as "1h18m34s" or
 // "1.1 GB" (https://git.eeqj.de/sneak/routewatch/issues/199). The stream has
 // never connected, so the uptime is 0. The memory use in /api/v1/stats is the
-// same number of bytes as its gc.heap_alloc_bytes. The requests run in a
-// synctest bubble, whose clock is fake, so a stall on the host does not use up
-// the handlers' 4-second limit.
+// same number of bytes as its gc.heap_alloc_bytes.
 func TestStatsAnswersGiveUnitsInFieldNames(t *testing.T) {
 	t.Parallel()
 
@@ -400,11 +375,7 @@ func TestStatsAnswersGiveUnitsInFieldNames(t *testing.T) {
 	s.SetASNFetcher(fixedIntervalASNFetcher{interval: fetchInterval})
 
 	for _, path := range []string{statusJSONPath, statsPath} {
-		var answer []byte
-
-		synctest.Test(t, func(t *testing.T) {
-			answer = get(t, s, path).Body.Bytes()
-		})
+		answer := get(t, s, path).Body.Bytes()
 
 		var body struct {
 			Data unitStats `json:"data"`
@@ -445,89 +416,82 @@ func TestStatsAnswersGiveUnitsInFieldNames(t *testing.T) {
 // connection_duration_seconds of /api/v1/stats is null while the stream is not
 // connected, and a whole number of seconds once it is. It used to be the
 // string "disconnected", or a Go duration such as "1h18m34s"
-// (https://git.eeqj.de/sneak/routewatch/issues/199). The test runs in a
-// synctest bubble, whose clock is fake, so a stall on the host does not use up
-// the handler's 4-second limit.
+// (https://git.eeqj.de/sneak/routewatch/issues/199).
 func TestStatsAnswerGivesConnectionDurationInSeconds(t *testing.T) {
 	t.Parallel()
 
 	s := newServerWithTestRoutes(t)
 
-	synctest.Test(t, func(t *testing.T) {
-		connectionDuration := func() json.RawMessage {
-			answer := get(t, s, statsPath).Body.Bytes()
+	connectionDuration := func() json.RawMessage {
+		answer := get(t, s, statsPath).Body.Bytes()
 
-			var body struct {
-				Data map[string]json.RawMessage `json:"data"`
-			}
-
-			err := json.Unmarshal(answer, &body)
-			if err != nil {
-				t.Fatalf("decoding the answer: %v; answer %s", err, answer)
-			}
-
-			duration, ok := body.Data["connection_duration_seconds"]
-			if !ok {
-				t.Fatalf("no connection_duration_seconds: %s", answer)
-			}
-
-			return duration
+		var body struct {
+			Data map[string]json.RawMessage `json:"data"`
 		}
 
-		disconnected := connectionDuration()
-		if string(disconnected) != "null" {
-			t.Errorf("disconnected: connection_duration_seconds = %s, want null",
-				disconnected)
+		err := json.Unmarshal(answer, &body)
+		if err != nil {
+			t.Fatalf("decoding the answer: %v; answer %s", err, answer)
 		}
 
-		s.streamer.GetMetricsTracker().SetConnected(true)
-
-		var seconds int64
-
-		connected := connectionDuration()
-
-		err := json.Unmarshal(connected, &seconds)
-		if err != nil || seconds != 0 {
-			t.Errorf("just connected: connection_duration_seconds = %s, want 0",
-				connected)
+		duration, ok := body.Data["connection_duration_seconds"]
+		if !ok {
+			t.Fatalf("no connection_duration_seconds: %s", answer)
 		}
-	})
+
+		return duration
+	}
+
+	disconnected := connectionDuration()
+	if string(disconnected) != "null" {
+		t.Errorf("disconnected: connection_duration_seconds = %s, want null",
+			disconnected)
+	}
+
+	s.streamer.GetMetricsTracker().SetConnected(true)
+
+	var seconds int64
+
+	connected := connectionDuration()
+
+	err := json.Unmarshal(connected, &seconds)
+	if err != nil || seconds != 0 {
+		t.Errorf("just connected: connection_duration_seconds = %s, want 0",
+			connected)
+	}
 }
 
 // TestStreamDurationsCountSeconds checks that the uptime and the connection
 // duration of a stream that connected 90 seconds ago are both 90. A stream
 // that has never connected has an uptime of 0, and one that is not connected
-// has no connection duration. The test runs in a synctest bubble, whose clock
-// is fake, so a stall on the host does not add to the 90 seconds.
+// has no connection duration.
 func TestStreamDurationsCountSeconds(t *testing.T) {
 	t.Parallel()
 
-	synctest.Test(t, func(t *testing.T) {
-		const connectedFor = 90 * time.Second
+	const connectedFor = 90 * time.Second
 
-		connectedSince := time.Now().Add(-connectedFor)
-		want := int64(connectedFor / time.Second)
+	connectedSince := time.Now().Add(-connectedFor)
+	want := int64(connectedFor / time.Second)
 
-		if got := uptimeSeconds(connectedSince); got != want {
-			t.Errorf("uptimeSeconds = %d, want %d", got, want)
-		}
+	if got := uptimeSeconds(connectedSince); got != want {
+		t.Errorf("uptimeSeconds = %d, want %d", got, want)
+	}
 
-		if got := uptimeSeconds(time.Time{}); got != 0 {
-			t.Errorf("uptimeSeconds before any connection = %d, want 0", got)
-		}
+	if got := uptimeSeconds(time.Time{}); got != 0 {
+		t.Errorf("uptimeSeconds before any connection = %d, want 0", got)
+	}
 
-		switch got := connectionDurationSeconds(true, connectedSince); {
-		case got == nil:
-			t.Errorf("connectionDurationSeconds = nil, want %d", want)
-		case *got != want:
-			t.Errorf("connectionDurationSeconds = %d, want %d", *got, want)
-		}
+	switch got := connectionDurationSeconds(true, connectedSince); {
+	case got == nil:
+		t.Errorf("connectionDurationSeconds = nil, want %d", want)
+	case *got != want:
+		t.Errorf("connectionDurationSeconds = %d, want %d", *got, want)
+	}
 
-		if got := connectionDurationSeconds(false, connectedSince); got != nil {
-			t.Errorf("connectionDurationSeconds while not connected = %d, want nil",
-				*got)
-		}
-	})
+	if got := connectionDurationSeconds(false, connectedSince); got != nil {
+		t.Errorf("connectionDurationSeconds while not connected = %d, want nil",
+			*got)
+	}
 }
 
 // newTestTable returns a routing table that holds a route for testPrefixV4,
@@ -1174,9 +1138,7 @@ func (failingDB) GetPrefixFirstSeen(
 // with the driver's error text. It also sends a prefix that does not parse.
 // No answer may carry the driver's or the prefix parser's text. Before the fix
 // the answers sent it to the client
-// (https://git.eeqj.de/sneak/routewatch/issues/108). The requests run in a
-// synctest bubble, whose clock is fake, so a stall on the host does not use up
-// the stats handlers' 4-second limit.
+// (https://git.eeqj.de/sneak/routewatch/issues/108).
 func TestJSONRoutesDoNotSendErrorDetails(t *testing.T) {
 	t.Parallel()
 
@@ -1197,11 +1159,8 @@ func TestJSONRoutesDoNotSendErrorDetails(t *testing.T) {
 
 	for _, tt := range tests {
 		rec := httptest.NewRecorder()
-
-		synctest.Test(t, func(t *testing.T) {
-			s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
-				t.Context(), http.MethodGet, tt.path, nil))
-		})
+		s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
+			t.Context(), http.MethodGet, tt.path, nil))
 
 		if rec.Code != tt.wantCode {
 			t.Errorf("%s: status %d, want %d; body %s",
@@ -1294,19 +1253,16 @@ func TestIPLookupAnswers500WhenDatabaseReadFails(t *testing.T) {
 	}
 }
 
-// errNoSuchHost is what fakeResolver answers a host name lookup it has no
-// addresses for with.
+// errNoSuchHost is what fakeResolver answers a lookup it has no answer for
+// with.
 var errNoSuchHost = errors.New("no such host")
 
 // fakeResolver answers a host name lookup with the addresses hosts lists for
-// the name. It answers a PTR lookup with the names ptrs lists for the address,
-// and with no names and no error, as the real one does, when ptrs lists none.
-// When ptrNeverAnswers is set, a PTR lookup fails after ptr.LookupTimeout, as
-// the real one does when no resolver answers. hostLookups counts the host name
-// lookups.
+// the name, and a PTR lookup with no names or, when ptrNeverAnswers is set,
+// with a failure after ptr.LookupTimeout, as the real one does when no
+// resolver answers. hostLookups counts the host name lookups.
 type fakeResolver struct {
 	hosts           map[string][]string
-	ptrs            map[string][]string
 	ptrNeverAnswers bool
 
 	hostLookups atomic.Int64
@@ -1323,7 +1279,7 @@ func (r *fakeResolver) LookupHost(_ context.Context, host string) ([]string, err
 	return addrs, nil
 }
 
-func (r *fakeResolver) LookupAddr(ctx context.Context, addr string) ([]string, error) {
+func (r *fakeResolver) LookupAddr(ctx context.Context, _ string) ([]string, error) {
 	if r.ptrNeverAnswers {
 		ctx, cancel := context.WithTimeout(ctx, ptr.LookupTimeout)
 		defer cancel()
@@ -1333,7 +1289,7 @@ func (r *fakeResolver) LookupAddr(ctx context.Context, addr string) ([]string, e
 		return nil, ctx.Err()
 	}
 
-	return r.ptrs[addr], nil
+	return nil, errNoSuchHost
 }
 
 // useFakeResolver makes r answer the server's host name and PTR lookups.
@@ -1445,21 +1401,17 @@ const addrInTestPrefixV4 = "192.0.2.1"
 
 // TestIPLookupKeepsRouteWhenPTRLookupDoesNotAnswer looks up a routed address
 // with a resolver that never answers its PTR lookup. Once the PTR lookup's own
-// limit passes, the lookup answers 200 with the route and an empty ptr. Before
-// the fix the PTR lookup ran until the request's time limit, and the lookup
-// answered 504 without the route
-// (https://git.eeqj.de/sneak/routewatch/issues/110).
+// limit passes, the lookup answers 200 with the route. Before the fix the PTR
+// lookup ran until the request's time limit, and the lookup answered 504
+// without the route (https://git.eeqj.de/sneak/routewatch/issues/110).
 func TestIPLookupKeepsRouteWhenPTRLookupDoesNotAnswer(t *testing.T) {
 	t.Parallel()
 
 	s := newServerWithTestRoutes(t)
 	useFakeResolver(s, &fakeResolver{ptrNeverAnswers: true})
 
-	// The request's time limit passes well after the PTR lookup's, so that a
-	// stall on a busy host does not use up the difference.
-	const requestTimeLimit = ptr.LookupTimeout + 15*time.Second
-
-	ctx, cancel := context.WithTimeout(t.Context(), requestTimeLimit)
+	// The request's time limit passes after the PTR lookup's.
+	ctx, cancel := context.WithTimeout(t.Context(), 2*ptr.LookupTimeout)
 	defer cancel()
 
 	rec := httptest.NewRecorder()
@@ -1483,10 +1435,6 @@ func TestIPLookupKeepsRouteWhenPTRLookupDoesNotAnswer(t *testing.T) {
 		*body.Data.Results[0].Netblock != testPrefixV4 {
 		t.Errorf("answer %s, want one result in %s", rec.Body, testPrefixV4)
 	}
-
-	if !strings.Contains(rec.Body.String(), `"ptr":[]`) {
-		t.Errorf("answer %s, want an empty ptr list", rec.Body)
-	}
 }
 
 // addrInTestPrefixV6 is an address in testPrefixV6, which
@@ -1506,24 +1454,8 @@ const listedUnroutedAddr = "203.0.113.1"
 // torExitAddr is the address that fakeIPLists lists on the Tor exit list.
 const torExitAddr = "203.0.113.2"
 
-// relayAddr is the address that fakeIPLists lists on the iCloud Private Relay
-// list.
-const relayAddr = "203.0.113.5"
-
-// The addresses that fakeIPLists lists on one and on two VPN lists, and the
-// names of those lists.
-const (
-	oneVPNListAddr  = "203.0.113.3"
-	twoVPNListsAddr = "203.0.113.4"
-	testVPNList     = "test_vpn"
-	otherTestVPN    = "other_test_vpn"
-)
-
-// fakeIPLists has five lists. The test list holds addrInTestPrefixV4,
-// listedUnroutedAddr and twoVPNListsAddr. The Tor exit list holds torExitAddr.
-// The iCloud Private Relay list holds relayAddr. The test VPN list holds
-// oneVPNListAddr and twoVPNListsAddr, and the other test VPN list holds
-// twoVPNListsAddr.
+// fakeIPLists has two lists. The test list holds addrInTestPrefixV4 and
+// listedUnroutedAddr, and the Tor exit list holds torExitAddr.
 type fakeIPLists struct{}
 
 func testListing() iplist.Listing {
@@ -1544,22 +1476,6 @@ func (fakeIPLists) Lookup(addr netip.Addr) []iplist.Listing {
 		return []iplist.Listing{{Name: iplist.TorExitsList}}
 	}
 
-	if addr == netip.MustParseAddr(relayAddr) {
-		return []iplist.Listing{{Name: iplist.ICloudPrivateRelayList}}
-	}
-
-	if addr == netip.MustParseAddr(oneVPNListAddr) {
-		return []iplist.Listing{{Name: testVPNList, VPN: true}}
-	}
-
-	if addr == netip.MustParseAddr(twoVPNListsAddr) {
-		return []iplist.Listing{
-			{Name: otherTestVPN, VPN: true},
-			testListing(),
-			{Name: testVPNList, VPN: true},
-		}
-	}
-
 	return []iplist.Listing{}
 }
 
@@ -1568,7 +1484,7 @@ func (fakeIPLists) ShortestInterval() time.Duration {
 }
 
 // TestIPLookupFlags looks up addresses with and without a route. Every result
-// has every flag, under the JSON keys the API documents.
+// has both flags, under the JSON keys the API documents.
 func TestIPLookupFlags(t *testing.T) {
 	t.Parallel()
 
@@ -1580,22 +1496,20 @@ func TestIPLookupFlags(t *testing.T) {
 		name  string
 		addr  string
 		tor   bool
-		relay bool
 		bogon bool
 	}{
-		{"on the Tor exit list", torExitAddr, true, false, true},
-		{"on the iCloud Private Relay list", relayAddr, false, true, true},
-		{"on another list", listedUnroutedAddr, false, false, true},
-		{"routed IPv4", addrInTestPrefixV4, false, false, true},
-		{"routed IPv6", addrInTestPrefixV6, false, false, true},
-		{"private IPv4", "10.0.0.1", false, false, true},
-		{"loopback IPv4", "127.0.0.1", false, false, true},
-		{"public IPv4", "1.1.1.1", false, false, false},
-		{"private IPv6", "fd00::1", false, false, true},
-		{"loopback IPv6", "::1", false, false, true},
-		{"public IPv6", "2606:4700:4700::1111", false, false, false},
-		{"public IPv4 in IPv6 form", "::ffff:1.1.1.1", false, false, false},
-		{"private IPv4 in IPv6 form", "::ffff:10.0.0.1", false, false, true},
+		{"on the Tor exit list", torExitAddr, true, true},
+		{"on another list", listedUnroutedAddr, false, true},
+		{"routed IPv4", addrInTestPrefixV4, false, true},
+		{"routed IPv6", addrInTestPrefixV6, false, true},
+		{"private IPv4", "10.0.0.1", false, true},
+		{"loopback IPv4", "127.0.0.1", false, true},
+		{"public IPv4", "1.1.1.1", false, false},
+		{"private IPv6", "fd00::1", false, true},
+		{"loopback IPv6", "::1", false, true},
+		{"public IPv6", "2606:4700:4700::1111", false, false},
+		{"public IPv4 in IPv6 form", "::ffff:1.1.1.1", false, false},
+		{"private IPv4 in IPv6 form", "::ffff:10.0.0.1", false, true},
 	}
 
 	for _, tt := range tests {
@@ -1616,10 +1530,7 @@ func TestIPLookupFlags(t *testing.T) {
 				t.Fatalf("%s: decoding flags %s: %v", path, results[0]["flags"], err)
 			}
 
-			want := map[string]bool{
-				"is_tor": tt.tor, "is_vpn": false, "is_relay": tt.relay,
-				"is_bogon": tt.bogon,
-			}
+			want := map[string]bool{"is_tor": tt.tor, "is_bogon": tt.bogon}
 			if !maps.Equal(got, want) {
 				t.Errorf("%s: flags %v, want %v", path, got, want)
 			}
@@ -1627,186 +1538,6 @@ func TestIPLookupFlags(t *testing.T) {
 	}
 }
 
-// fakeGeoLocator answers every address with location, and keeps the addresses
-// of each call. It is safe for the concurrent subtests that share it.
-type fakeGeoLocator struct {
-	location *geo.Location
-
-	mu    sync.Mutex
-	calls [][]netip.Addr
-}
-
-func (f *fakeGeoLocator) Lookup(
-	_ context.Context, addrs []netip.Addr,
-) []*geo.Location {
-	f.mu.Lock()
-	defer f.mu.Unlock()
-
-	f.calls = append(f.calls, addrs)
-
-	answers := make([]*geo.Location, len(addrs))
-	for i := range addrs {
-		answers[i] = f.location
-	}
-
-	return answers
-}
-
-// TestIPLookupGivesTheGeoObject looks up two public addresses. They go to the
-// locator in one call, and each result has the geo object under the keys the
-// API documents. These addresses are public, because a reserved one is not
-// looked up.
-func TestIPLookupGivesTheGeoObject(t *testing.T) {
-	t.Parallel()
-
-	s := newServerWithTestRoutes(t)
-	useFakeResolver(s, &fakeResolver{})
-
-	locator := &fakeGeoLocator{location: &geo.Location{
-		CountryCode: new("DE"),
-		City:        new("Berlin"),
-		Latitude:    new(52.5),
-		Source:      "geojs",
-		Updated:     testRouteTime(0),
-	}}
-	s.SetGeoLocator(locator)
-
-	path := "/api/v1/ip/1.1.1.1,8.8.8.8"
-
-	results := resultFields(t, get(t, s, path).Body.Bytes())
-	if len(results) != 2 {
-		t.Fatalf("%s: %d results, want 2", path, len(results))
-	}
-
-	if len(locator.calls) != 1 || len(locator.calls[0]) != 2 {
-		t.Errorf("locator calls %v, want one with both addresses", locator.calls)
-	}
-
-	var got map[string]json.RawMessage
-
-	err := json.Unmarshal(results[0]["geo"], &got)
-	if err != nil {
-		t.Fatalf("decoding geo %s: %v", results[0]["geo"], err)
-	}
-
-	wantKeys := []string{
-		"accuracy_radius_km", "city", "continent_code", "country",
-		"country_code", "latitude", "longitude", "region", "source",
-		"time_zone", "updated",
-	}
-	if keys := slices.Sorted(maps.Keys(got)); !slices.Equal(keys, wantKeys) {
-		t.Errorf("geo keys %v, want %v", keys, wantKeys)
-	}
-
-	if string(got["city"]) != `"Berlin"` || string(got["latitude"]) != "52.5" ||
-		string(got["region"]) != jsonNull {
-		t.Errorf("wrong geo %s", results[0]["geo"])
-	}
-}
-
-// TestIPLookupOfAReservedAddressHasNoGeo looks up a reserved address alone and
-// beside a public one. The reserved one never reaches the locator, and its geo
-// is null.
-func TestIPLookupOfAReservedAddressHasNoGeo(t *testing.T) {
-	t.Parallel()
-
-	s := newServerWithTestRoutes(t)
-	useFakeResolver(s, &fakeResolver{})
-
-	locator := &fakeGeoLocator{location: &geo.Location{Source: "geojs"}}
-	s.SetGeoLocator(locator)
-
-	results := resultFields(t, get(t, s, "/api/v1/ip/"+addrInTestPrefixV4).Body.Bytes())
-	if len(results) != 1 || string(results[0]["geo"]) != jsonNull {
-		t.Fatalf("results %v, want one with geo null", results)
-	}
-
-	if len(locator.calls) != 0 {
-		t.Errorf("locator calls %v, want none", locator.calls)
-	}
-
-	results = resultFields(t,
-		get(t, s, "/api/v1/ip/"+addrInTestPrefixV4+",1.1.1.1").Body.Bytes())
-	if len(results) != 2 || string(results[0]["geo"]) != jsonNull ||
-		string(results[1]["geo"]) == jsonNull {
-		t.Errorf("results %v, want geo only for the public address", results)
-	}
-
-	if len(locator.calls) != 1 || len(locator.calls[0]) != 1 {
-		t.Errorf("locator calls %v, want one with one address", locator.calls)
-	}
-}
-
-// TestIPLookupGeoIsNullWhenNoSourceAnswers checks an address the locator has
-// no answer for.
-func TestIPLookupGeoIsNullWhenNoSourceAnswers(t *testing.T) {
-	t.Parallel()
-
-	s := newServerWithTestRoutes(t)
-	useFakeResolver(s, &fakeResolver{})
-	s.SetGeoLocator(&fakeGeoLocator{})
-
-	results := resultFields(t, get(t, s, "/api/v1/ip/1.1.1.1").Body.Bytes())
-	if len(results) != 1 || string(results[0]["geo"]) != jsonNull {
-		t.Errorf("results %v, want one with geo null", results)
-	}
-}
-
-// TestIPLookupReportsVPNProviders looks up addresses on no list, on a list
-// that is not a VPN list, on one VPN list and on two. is_vpn says whether any
-// VPN list holds the address, and vpn_providers names only those lists. An
-// address on none has [], not null.
-func TestIPLookupReportsVPNProviders(t *testing.T) {
-	t.Parallel()
-
-	s := newServerWithTestRoutes(t)
-	s.resolver = &fakeResolver{}
-	s.SetIPLists(fakeIPLists{})
-
-	tests := []struct {
-		name      string
-		addr      string
-		isVPN     string
-		providers string
-	}{
-		{"on no list", "1.1.1.1", "false", `[]`},
-		{"on a list that is not a VPN list", listedUnroutedAddr, "false", `[]`},
-		{"on one VPN list", oneVPNListAddr, "true", `["` + testVPNList + `"]`},
-		{
-			"on two VPN lists", twoVPNListsAddr, "true",
-			`["` + otherTestVPN + `","` + testVPNList + `"]`,
-		},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			t.Parallel()
-
-			path := "/api/v1/ip/" + tt.addr
-
-			results := resultFields(t, get(t, s, path).Body.Bytes())
-			if len(results) != 1 {
-				t.Fatalf("%s: %d results, want 1", path, len(results))
-			}
-
-			var flags map[string]json.RawMessage
-
-			err := json.Unmarshal(results[0]["flags"], &flags)
-			if err != nil {
-				t.Fatalf("%s: decoding flags %s: %v", path, results[0]["flags"], err)
-			}
-
-			if got := string(flags["is_vpn"]); got != tt.isVPN {
-				t.Errorf("%s: is_vpn %s, want %s", path, got, tt.isVPN)
-			}
-
-			if got := string(results[0]["vpn_providers"]); got != tt.providers {
-				t.Errorf("%s: vpn_providers %s, want %s", path, got, tt.providers)
-			}
-		})
-	}
-}
-
 // TestIPLookupReportsIPLists looks up two routed addresses, one of them on an
 // IP list. The listed address's result names the list, says what it means and
 // when it was updated. The other's result has an empty list.
@@ -2026,32 +1757,6 @@ func TestIPLookupOfAnAddressWithoutPTRNamesOrStoredNetblock(t *testing.T) {
 	}
 }
 
-// TestIPLookupGivesPTRNamesWithoutTrailingDots looks up an address whose PTR
-// name the resolver gives fully qualified. The result's ptr holds the name
-// without its trailing dot.
-func TestIPLookupGivesPTRNamesWithoutTrailingDots(t *testing.T) {
-	t.Parallel()
-
-	s := newServerWithTestRoutes(t)
-	useFakeResolver(s, &fakeResolver{ptrs: map[string][]string{
-		addrInTestPrefixV4: {"host.example.com."},
-	}})
-
-	path := "/api/v1/ip/" + addrInTestPrefixV4
-
-	results := resultFields(t, get(t, s, path).Body.Bytes())
-	if len(results) != 1 {
-		t.Fatalf("%s: %d results, want 1", path, len(results))
-	}
-
-	got := string(results[0]["ptr"])
-
-	want := `["host.example.com"]`
-	if got != want {
-		t.Errorf("%s: ptr is %s, want %s", path, got, want)
-	}
-}
-
 // TestIPLookupAnswersMayBeCached checks the Cache-Control header of the IP
 // lookup answers. Caches may keep them for the IP lists' shortest interval,
 // and only the caller's own browser may keep the answer about the caller's
@@ -2595,13 +2300,9 @@ func settledGoroutineCount() int {
 	return prev
 }
 
-// waitForGoroutines waits up to 15 seconds for the goroutine count to drop to
-// target or below.
+// waitForGoroutines waits until the goroutine count drops to target or below.
 func waitForGoroutines(target int) bool {
-	const maxWait = 15 * time.Second
-
-	deadline := time.Now().Add(maxWait)
-	for time.Now().Before(deadline) {
+	for range 100 {
 		if runtime.NumGoroutine() <= target {
 			return true
 		}

internal/server/home_internal_test.go

@@ -76,9 +76,7 @@ func asLink(asn int) string {
 }
 
 // TestHomePageCardsShowTheTableFigures fills a routing table and the asns
-// table, works out the cards, and checks that each card shows its figure. The
-// cards are worked out in a synctest bubble, whose clock is fake, so a stall on
-// the host does not use up the 4-second limit on their database read.
+// table, works out the cards, and checks that each card shows its figure.
 func TestHomePageCardsShowTheTableFigures(t *testing.T) {
 	t.Parallel()
 
@@ -97,9 +95,7 @@ func TestHomePageCardsShowTheTableFigures(t *testing.T) {
 		t.Fatalf("GetOrCreateASNBatch: %v", err)
 	}
 
-	synctest.Test(t, func(t *testing.T) {
-		s.refreshHomeCards(t.Context())
-	})
+	s.refreshHomeCards(t.Context())
 
 	page := get(t, s, "/").Body.String()
 
@@ -283,7 +279,7 @@ func TestKeepHomeCardsFreshWorksThemOutEveryInterval(t *testing.T) {
 
 	const (
 		interval = 10 * time.Millisecond
-		maxWait  = 15 * time.Second
+		maxWait  = 5 * time.Second
 	)
 
 	table := emptyTable()
@@ -325,7 +321,7 @@ func TestKeepHomeCardsFreshWorksThemOutEveryInterval(t *testing.T) {
 func TestStartedServerWorksOutTheCards(t *testing.T) {
 	t.Parallel()
 
-	const maxWait = 15 * time.Second
+	const maxWait = 5 * time.Second
 
 	s := newServerWithTable(t, newCardsTable())
 

internal/server/middleware_internal_test.go

@@ -14,7 +14,6 @@ import (
 	"regexp"
 	"strings"
 	"testing"
-	"testing/synctest"
 	"time"
 
 	"git.eeqj.de/sneak/routewatch/internal/config"
@@ -164,10 +163,6 @@ func TestJSONAnswersPutNoUnitInAString(t *testing.T) {
 // router and the middleware write. Before the fix a panic in a handler, and a
 // method /status.json or the health check does not take, answered with an
 // empty body (https://git.eeqj.de/sneak/routewatch/issues/201).
-//
-// The requests run in a synctest bubble, whose clock is fake, so a stall on
-// the host does not use up the 2-second limit of the health check or the
-// 4-second limit of the stats handlers.
 func TestJSONAnswersCarryMeta(t *testing.T) {
 	t.Parallel()
 
@@ -186,10 +181,6 @@ func TestJSONAnswersCarryMeta(t *testing.T) {
 	s.router.Get(panicsPath, JSONValidationMiddleware(http.HandlerFunc(
 		func(http.ResponseWriter, *http.Request) { panic(errDiskIO) })).ServeHTTP)
 
-	failing := New(failingDB{}, newTestTable(),
-		streamer.New(logger.New(), metrics.New()), logger.New(), &config.Config{})
-	useFakeResolver(failing, &fakeResolver{})
-
 	tests := []struct {
 		method   string
 		path     string
@@ -225,40 +216,42 @@ func TestJSONAnswersCarryMeta(t *testing.T) {
 		{http.MethodGet, panicsPath, http.StatusInternalServerError},
 	}
 
-	synctest.Test(t, func(t *testing.T) {
-		for _, tt := range tests {
-			checkAnswerCarriesMeta(t, s, httptest.NewRequestWithContext(
-				t.Context(), tt.method, tt.path, nil), tt.wantCode)
-		}
+	for _, tt := range tests {
+		checkAnswerCarriesMeta(t, s, httptest.NewRequestWithContext(
+			t.Context(), tt.method, tt.path, nil), tt.wantCode)
+	}
 
-		// A request whose time limit has already passed answers 504. The
-		// handlers write the answers of the first five routes, and the JSON
-		// check on the route writes the last.
-		pastTimeLimit, cancel := context.WithDeadline(t.Context(), time.Now())
-		defer cancel()
+	// A request whose time limit has already passed answers 504. The handlers
+	// write the answers of the first five routes, and the JSON check on the
+	// route writes the last.
+	pastTimeLimit, cancel := context.WithDeadline(t.Context(), time.Now())
+	defer cancel()
 
-		for _, path := range []string{
-			statusJSONPath, statsPath, "/ip/" + addrInTestPrefixV4,
-			"/api/v1/ip/" + addrInTestPrefixV4, asJSONPath, writesNothingPath,
-		} {
-			checkAnswerCarriesMeta(t, s, httptest.NewRequestWithContext(
-				pastTimeLimit, http.MethodGet, path, nil), http.StatusGatewayTimeout)
-		}
+	for _, path := range []string{
+		statusJSONPath, statsPath, "/ip/" + addrInTestPrefixV4,
+		"/api/v1/ip/" + addrInTestPrefixV4, asJSONPath, writesNothingPath,
+	} {
+		checkAnswerCarriesMeta(t, s, httptest.NewRequestWithContext(
+			pastTimeLimit, http.MethodGet, path, nil), http.StatusGatewayTimeout)
+	}
 
-		// With a store whose reads fail, the health check answers 503, and
-		// the handlers of the other routes 500.
+	// With a store whose reads fail, the health check answers 503, and the
+	// handlers of the other routes 500.
+	failing := New(failingDB{}, newTestTable(),
+		streamer.New(logger.New(), metrics.New()), logger.New(), &config.Config{})
+	useFakeResolver(failing, &fakeResolver{})
+
+	checkAnswerCarriesMeta(t, failing, httptest.NewRequestWithContext(
+		t.Context(), http.MethodGet, healthCheckPath, nil),
+		http.StatusServiceUnavailable)
+
+	for _, path := range []string{
+		statusJSONPath, statsPath, asJSONPath,
+		"/api/v1/ip/" + addrInTestPrefixV4, "/ip/" + addrInTestPrefixV4,
+	} {
 		checkAnswerCarriesMeta(t, failing, httptest.NewRequestWithContext(
-			t.Context(), http.MethodGet, healthCheckPath, nil),
-			http.StatusServiceUnavailable)
-
-		for _, path := range []string{
-			statusJSONPath, statsPath, asJSONPath,
-			"/api/v1/ip/" + addrInTestPrefixV4, "/ip/" + addrInTestPrefixV4,
-		} {
-			checkAnswerCarriesMeta(t, failing, httptest.NewRequestWithContext(
-				t.Context(), http.MethodGet, path, nil), http.StatusInternalServerError)
-		}
-	})
+			t.Context(), http.MethodGet, path, nil), http.StatusInternalServerError)
+	}
 }
 
 // checkAnswerCarriesMeta serves req through the server's router, and checks

internal/server/routes_internal_test.go

@@ -5,7 +5,6 @@ import (
 	"net/http"
 	"net/http/httptest"
 	"testing"
-	"testing/synctest"
 )
 
 // TestRoutesAnswerHEAD sends HEAD for a page and JSON routes through the
@@ -13,23 +12,15 @@ import (
 // lookup of the caller's own address, are in the list because chi's GetHead
 // does not reach them. Before the fix every route answered HEAD with 405
 // (https://git.eeqj.de/sneak/routewatch/issues/111).
-//
-// The requests run in a synctest bubble, whose clock is fake, so a stall on
-// the host does not use up the stats handlers' 4-second limit. The resolver
-// is fake because no time limit would cut off a real DNS lookup in a bubble.
 func TestRoutesAnswerHEAD(t *testing.T) {
 	t.Parallel()
 
 	s := newServerWithTestRoutes(t)
-	s.resolver = &fakeResolver{}
 
 	for _, path := range []string{"/", statusJSONPath, statsPath, "/ip", "/ip/"} {
 		rec := httptest.NewRecorder()
-
-		synctest.Test(t, func(t *testing.T) {
-			s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
-				t.Context(), http.MethodHead, path, nil))
-		})
+		s.router.ServeHTTP(rec, httptest.NewRequestWithContext(
+			t.Context(), http.MethodHead, path, nil))
 
 		if rec.Code != http.StatusOK {
 			t.Errorf("HEAD %s: status %d, want %d; body %s",

internal/server/server.go

@@ -24,7 +24,6 @@ import (
 
 	"git.eeqj.de/sneak/routewatch/internal/config"
 	"git.eeqj.de/sneak/routewatch/internal/database"
-	"git.eeqj.de/sneak/routewatch/internal/geo"
 	"git.eeqj.de/sneak/routewatch/internal/iplist"
 	"git.eeqj.de/sneak/routewatch/internal/logger"
 	"git.eeqj.de/sneak/routewatch/internal/routetable"
@@ -59,17 +58,11 @@ type dnsResolver interface {
 	LookupHost(ctx context.Context, host string) ([]string, error)
 }
 
-// PTRResolver looks up the PTR names of addresses, as *ptr.Cache does.
-type PTRResolver interface {
+// ptrResolver looks up the PTR names of addresses, as *ptr.Cache does.
+type ptrResolver interface {
 	LookupAddr(ctx context.Context, addr string) ([]string, error)
 }
 
-// GeoLocator finds where addresses are, as *geo.Locator does. It returns one
-// entry for each address, nil when no source answers.
-type GeoLocator interface {
-	Lookup(ctx context.Context, addrs []netip.Addr) []*geo.Location
-}
-
 // Server provides HTTP endpoints for status monitoring
 type Server struct {
 	router     *chi.Mux
@@ -91,11 +84,7 @@ type Server struct {
 	resolver dnsResolver
 
 	// ptrResolver looks up the IP lookup's PTR names. SetPTRResolver sets it.
-	ptrResolver PTRResolver
-
-	// geoLocator finds where the IP lookup's addresses are. SetGeoLocator
-	// sets it.
-	geoLocator GeoLocator
+	ptrResolver ptrResolver
 
 	// cards is the copy of the home page's cards that the pages serve, nil
 	// until the server first works them out
@@ -216,16 +205,10 @@ func (s *Server) Stop(ctx context.Context) error {
 
 // SetPTRResolver sets what looks up the IP lookup's PTR names. Call it before
 // Start: the handlers read it without a lock.
-func (s *Server) SetPTRResolver(resolver PTRResolver) {
+func (s *Server) SetPTRResolver(resolver ptrResolver) {
 	s.ptrResolver = resolver
 }
 
-// SetGeoLocator sets what finds where the IP lookup's addresses are. Call it
-// before Start: the handlers read it without a lock.
-func (s *Server) SetGeoLocator(locator GeoLocator) {
-	s.geoLocator = locator
-}
-
 // SetASNFetcher sets the ASN WHOIS fetcher for on-demand lookups. Call it
 // before Start: the handlers read the fetcher without a lock.
 func (s *Server) SetASNFetcher(fetcher ASNFetcher) {

internal/server/server_internal_test.go

@@ -22,10 +22,10 @@ func TestStopClosesTheConnectionOfARequestStillRunning(t *testing.T) {
 		stopDeadline = 100 * time.Millisecond
 		// waitTimeout is how long the test waits for the request to reach
 		// the handler, and then for the client to see its connection closed.
-		waitTimeout = 15 * time.Second
+		waitTimeout = 2 * time.Second
 		// readHeaderTimeout bounds the test server's read of the request
 		// header, as every http.Server must.
-		readHeaderTimeout = waitTimeout
+		readHeaderTimeout = time.Second
 	)
 
 	release := make(chan struct{})

internal/streamer/streamer_internal_test.go

@@ -14,7 +14,6 @@ import (
 	"strings"
 	"sync/atomic"
 	"testing"
-	"testing/synctest"
 	"time"
 
 	"git.eeqj.de/sneak/routewatch/internal/logger"
@@ -399,7 +398,7 @@ func TestStopQueuesTheHeldStateMessages(t *testing.T) {
 	const (
 		held    = 2
 		lines   = held + 1
-		maxWait = 15 * time.Second
+		maxWait = 5 * time.Second
 	)
 
 	srv := httptest.NewServer(http.HandlerFunc(
@@ -479,15 +478,15 @@ func TestStopQueuesTheHeldStateMessages(t *testing.T) {
 // TestStopReturnsByItsDeadline stops a streamer whose handler has a full queue
 // and a STATE message held for it, and a worker that stays busy until the test
 // ends, as one does whose handler waits for a database write. Stop must return
-// within its deadline plus a margin instead of waiting for room on the queue
-// and for the worker, and log as not handed over the held message and every
-// message on the queue.
+// within its deadline plus a small margin instead of waiting for room on the
+// queue and for the worker, and log as not handed over the held message and
+// every message on the queue.
 func TestStopReturnsByItsDeadline(t *testing.T) {
 	t.Parallel()
 
 	const (
 		deadline = 100 * time.Millisecond
-		margin   = 15 * time.Second
+		margin   = 2 * time.Second
 	)
 
 	var logs bytes.Buffer
@@ -578,7 +577,7 @@ func TestStopBeforeMessageReachesQueues(t *testing.T) {
 func TestReconnectWhenStreamEnds(t *testing.T) {
 	t.Parallel()
 
-	endResponse := pipeTransport{write: func(context.Context, io.Writer) {}}
+	endResponse := func(http.ResponseWriter, *http.Request) {}
 	checkReconnect(t, endResponse, streamIdleTimeout)
 }
 
@@ -590,8 +589,9 @@ func TestReconnectWhenStreamGoesIdle(t *testing.T) {
 
 	const idleTimeout = 50 * time.Millisecond
 
-	holdResponse := pipeTransport{
-		write: func(ctx context.Context, _ io.Writer) { <-ctx.Done() },
+	holdResponse := func(w http.ResponseWriter, r *http.Request) {
+		flush(w)
+		<-r.Context().Done()
 	}
 	checkReconnect(t, holdResponse, idleTimeout)
 }
@@ -604,51 +604,16 @@ func TestReconnectWhenServerNeverAnswers(t *testing.T) {
 
 	const idleTimeout = 50 * time.Millisecond
 
-	neverAnswer := roundTripFunc(
-		func(req *http.Request) (*http.Response, error) {
-			<-req.Context().Done()
-
-			return nil, req.Context().Err()
-		},
-	)
+	neverAnswer := func(_ http.ResponseWriter, r *http.Request) {
+		<-r.Context().Done()
+	}
 	checkReconnect(t, neverAnswer, idleTimeout)
 }
 
-// pipeTransport answers every request with a response whose body write fills.
-// The body fails when the request's context ends, as a connection's does.
-// write gets that context, so that it can end when the request does.
-type pipeTransport struct {
-	write func(context.Context, io.Writer)
-}
-
-func (p pipeTransport) RoundTrip(req *http.Request) (*http.Response, error) {
-	body, w := io.Pipe()
-
-	context.AfterFunc(req.Context(), func() {
-		_ = w.CloseWithError(req.Context().Err())
-	})
-
-	go func(ctx context.Context) {
-		p.write(ctx, w)
-
-		_ = w.Close()
-	}(req.Context())
-
-	return &http.Response{StatusCode: http.StatusOK, Body: body}, nil
-}
-
-// roundTripFunc makes a function an http.RoundTripper.
-type roundTripFunc func(*http.Request) (*http.Response, error)
-
-func (f roundTripFunc) RoundTrip(req *http.Request) (*http.Response, error) {
-	return f(req)
-}
-
-// TestStreamNotDroppedWhileLinesArrive has a response send lines well within
-// the idle timeout for several times the timeout, then end. Each line must
-// start the idle timeout over, so the stream lasts until the response ends
-// instead of being dropped as idle. It runs in a synctest bubble, whose clock
-// is fake, so a stall on the host does not use up the timeout.
+// TestStreamNotDroppedWhileLinesArrive has the server send lines well within
+// the idle timeout for several times the timeout, then end the response. Each
+// line must start the idle timeout over, so the stream lasts until the server
+// ends it instead of being dropped as idle.
 func TestStreamNotDroppedWhileLinesArrive(t *testing.T) {
 	t.Parallel()
 
@@ -658,35 +623,26 @@ func TestStreamNotDroppedWhileLinesArrive(t *testing.T) {
 		sendFor      = 5 * idleTimeout
 	)
 
-	// The streamer is made outside the bubble. Its metrics start a goroutine
-	// that never returns, and a bubble waits for each of its goroutines to
-	// return.
-	s := New(logger.New(), metrics.New())
-	s.idleTimeout = idleTimeout
-	s.client = &http.Client{Transport: pipeTransport{
-		write: func(ctx context.Context, w io.Writer) {
+	srv := httptest.NewServer(http.HandlerFunc(
+		func(w http.ResponseWriter, _ *http.Request) {
 			deadline := time.Now().Add(sendFor)
 			for time.Now().Before(deadline) {
 				_, _ = io.WriteString(w, updateLine)
 
-				// The wait ends with the stream. A bubble's clock stops when
-				// the test function returns, and a goroutine then still
-				// asleep panics the test binary.
-				select {
-				case <-ctx.Done():
-					return
-				case <-time.After(lineInterval):
-				}
+				flush(w)
+				time.Sleep(lineInterval)
 			}
-		},
-	}}
+		}))
+	defer srv.Close()
 
-	synctest.Test(t, func(t *testing.T) {
-		err := s.stream(context.Background())
-		if !errors.Is(err, errStreamEnded) {
-			t.Fatalf("stream returned %v, want %v", err, errStreamEnded)
-		}
-	})
+	s := New(logger.New(), metrics.New())
+	s.url = srv.URL
+	s.idleTimeout = idleTimeout
+
+	err := s.stream(context.Background())
+	if !errors.Is(err, errStreamEnded) {
+		t.Fatalf("stream returned %v, want %v", err, errStreamEnded)
+	}
 }
 
 // TestStreamReadsLongLine has the server send one UPDATE line of about
@@ -750,7 +706,7 @@ func TestHandlerStatsReadWhileMessagesAreDropped(t *testing.T) {
 	const (
 		lines       = 5
 		wantDropped = lines - 2
-		maxWait     = 15 * time.Second
+		maxWait     = 5 * time.Second
 	)
 
 	srv := httptest.NewServer(http.HandlerFunc(
@@ -864,70 +820,61 @@ func streamLines(t *testing.T, s *Streamer, lines string) {
 // line and then stays open. The streamer must come back for a second
 // response, must not be marked connected when it does, and must handle the
 // UPDATE in it.
-//
-// It runs in a synctest bubble, whose clock is fake, so a stall on the host
-// does not use up the idle timeout. The fake server gets the requests in the
-// order the streamer makes them, because no real connection carries them.
 func checkReconnect(
-	t *testing.T, firstResponse http.RoundTripper, idleTimeout time.Duration,
+	t *testing.T, firstResponse http.HandlerFunc, idleTimeout time.Duration,
 ) {
 	t.Helper()
 
-	const maxWait = 15 * time.Second
+	const maxWait = 5 * time.Second
 
-	// The tracker is made outside the bubble. It starts a goroutine that never
-	// returns, and a bubble waits for each of its goroutines to return.
 	tracker := metrics.New()
+	connectedAtReconnect := make(chan bool, 1)
 
-	synctest.Test(t, func(t *testing.T) {
-		connectedAtReconnect := make(chan bool, 1)
-		laterResponse := pipeTransport{
-			write: func(ctx context.Context, w io.Writer) {
-				_, _ = io.WriteString(w, updateLine)
+	var requests atomic.Int32
 
-				<-ctx.Done()
-			},
-		}
+	srv := httptest.NewServer(http.HandlerFunc(
+		func(w http.ResponseWriter, r *http.Request) {
+			if requests.Add(1) == 1 {
+				firstResponse(w, r)
 
-		var requests atomic.Int32
+				return
+			}
 
-		s := New(logger.New(), tracker)
-		s.client = &http.Client{Transport: roundTripFunc(
-			func(req *http.Request) (*http.Response, error) {
-				if requests.Add(1) == 1 {
-					return firstResponse.RoundTrip(req)
-				}
+			select {
+			case connectedAtReconnect <- tracker.IsConnected():
+			default:
+			}
 
-				select {
-				case connectedAtReconnect <- tracker.IsConnected():
-				default:
-				}
+			_, _ = io.WriteString(w, updateLine)
 
-				return laterResponse.RoundTrip(req)
-			},
-		)}
-		s.idleTimeout = idleTimeout
-		s.minBackoff = time.Millisecond
-		handler := updateHandler{handled: make(chan struct{}, 1)}
-		s.RegisterHandler(handler)
+			flush(w)
+			<-r.Context().Done()
+		}))
+	defer srv.Close()
 
-		err := s.Start(t.Context())
-		if err != nil {
-			t.Fatalf("Start returned error: %v", err)
-		}
-		defer s.Stop(t.Context())
+	s := New(logger.New(), tracker)
+	s.url = srv.URL
+	s.idleTimeout = idleTimeout
+	s.minBackoff = time.Millisecond
+	handler := updateHandler{handled: make(chan struct{}, 1)}
+	s.RegisterHandler(handler)
 
-		select {
-		case <-handler.handled:
-		case <-time.After(maxWait):
-			t.Fatalf("no message from a second response handled within %s", maxWait)
-		}
+	err := s.Start(t.Context())
+	if err != nil {
+		t.Fatalf("Start returned error: %v", err)
+	}
+	defer s.Stop(t.Context())
 
-		if <-connectedAtReconnect {
-			t.Error("streamer was still marked connected when it came back " +
-				"for a second response")
-		}
-	})
+	select {
+	case <-handler.handled:
+	case <-time.After(maxWait):
+		t.Fatalf("no message from a second response handled within %s", maxWait)
+	}
+
+	if <-connectedAtReconnect {
+		t.Error("streamer was still marked connected when it came back " +
+			"for a second response")
+	}
 }
 
 // settledGoroutineCount lets transient goroutines finish, then reports the
@@ -949,13 +896,9 @@ func settledGoroutineCount() int {
 	return prev
 }
 
-// waitForGoroutines waits up to 15 seconds for the goroutine count to drop to
-// target or below.
+// waitForGoroutines waits until the goroutine count drops to target or below.
 func waitForGoroutines(target int) bool {
-	const maxWait = 15 * time.Second
-
-	deadline := time.Now().Add(maxWait)
-	for time.Now().Before(deadline) {
+	for range 100 {
 		if runtime.NumGoroutine() <= target {
 			return true
 		}

internal/templates/index.html

@@ -544,8 +544,6 @@
         <span>{{appLicense}}</span>
         <span class="separator">|</span>
         <span><a href="{{appGitCommitURL}}">{{appGitRevision}}</a></span>
-        <span class="separator">|</span>
-        <span>IP Geolocation by <a href="https://db-ip.com">DB-IP</a></span>
     </footer>
 
     <script nonce="{{.CSPNonce}}">

internal/templates/templates_test.go

@@ -67,23 +67,6 @@ func TestFooterLicense(t *testing.T) {
 	}
 }
 
-// TestHomePageCreditsDBIP expects the home page's footer to carry the credit
-// to DB-IP.
-func TestHomePageCreditsDBIP(t *testing.T) {
-	t.Parallel()
-
-	const attribution = `IP Geolocation by <a href="https://db-ip.com">DB-IP</a>`
-
-	_, footer, found := strings.Cut(renderPage(t, templates.IndexTemplate()), "<footer")
-	if !found {
-		t.Fatal("the page has no footer")
-	}
-
-	if !strings.Contains(footer, attribution) {
-		t.Errorf("footer does not credit DB-IP: %q", footer)
-	}
-}
-
 // TestFreshnessIndicator renders the home and status pages and expects each to
 // have, right after the status element, the element where the page's script
 // shows its spinner or "stale".