The IPv4 and IPv6 prefix lists on the AS page are each a <details> element. Its <summary> holds the list's heading and count, so a click on the heading folds or unfolds the list without a script. Both lists start open. The peer list is unchanged. The summary keeps the look of the other section headings. It hides the browser's own marker, which not every browser shows on a flex element, and draws a triangle before the heading that points down while the list is open. Model: opus-5-5
This commit was merged in pull request #182.
This commit is contained in:
@@ -6,6 +6,7 @@ import (
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"git.eeqj.de/sneak/routewatch/internal/database"
|
||||
"git.eeqj.de/sneak/routewatch/internal/templates"
|
||||
)
|
||||
|
||||
@@ -98,3 +99,82 @@ func TestFreshnessIndicator(t *testing.T) {
|
||||
})
|
||||
}
|
||||
}
|
||||
|
||||
// TestASDetailPrefixListsFold renders the AS page with one IPv4 and one IPv6
|
||||
// prefix. It expects each prefix list inside its own <details> element that
|
||||
// starts open and whose <summary> holds the list's heading, so that a click on
|
||||
// the heading folds the list.
|
||||
func TestASDetailPrefixListsFold(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
const (
|
||||
asn = 64500
|
||||
prefixV4 = "192.0.2.0/24"
|
||||
prefixV6 = "2001:db8::/32"
|
||||
)
|
||||
|
||||
ipv4 := []database.LiveRoute{{Prefix: prefixV4}}
|
||||
ipv6 := []database.LiveRoute{{Prefix: prefixV6}}
|
||||
|
||||
// The fields the AS page handler gives the template.
|
||||
data := struct {
|
||||
ASN *database.ASN
|
||||
IPv4Prefixes []database.LiveRoute
|
||||
IPv6Prefixes []database.LiveRoute
|
||||
TotalCount int
|
||||
IPv4Count int
|
||||
IPv6Count int
|
||||
Peers []database.ASPeer
|
||||
PeerCount int
|
||||
CSPNonce string
|
||||
}{
|
||||
ASN: &database.ASN{ASN: asn},
|
||||
IPv4Prefixes: ipv4,
|
||||
IPv6Prefixes: ipv6,
|
||||
TotalCount: len(ipv4) + len(ipv6),
|
||||
IPv4Count: len(ipv4),
|
||||
IPv6Count: len(ipv6),
|
||||
}
|
||||
|
||||
var rendered bytes.Buffer
|
||||
|
||||
err := templates.ASDetailTemplate().Execute(&rendered, data)
|
||||
if err != nil {
|
||||
t.Fatalf("rendering the page: %v", err)
|
||||
}
|
||||
|
||||
page := rendered.String()
|
||||
|
||||
lists := []struct{ heading, prefix string }{
|
||||
{"IPv4 Prefixes", prefixV4},
|
||||
{"IPv6 Prefixes", prefixV6},
|
||||
}
|
||||
|
||||
for _, list := range lists {
|
||||
before, _, found := strings.Cut(page, list.prefix)
|
||||
if !found {
|
||||
t.Fatalf("the page does not list %s", list.prefix)
|
||||
}
|
||||
|
||||
// The list's section starts at the last <details before its prefix.
|
||||
start := strings.LastIndex(before, "<details")
|
||||
if start < 0 || strings.Contains(before[start:], "</details>") {
|
||||
t.Errorf("%s: the list is not inside a <details> element", list.heading)
|
||||
|
||||
continue
|
||||
}
|
||||
|
||||
tag, section, _ := strings.Cut(before[start:], ">")
|
||||
if !strings.Contains(tag, " open") {
|
||||
t.Errorf("%s: the <details> element does not start open: %s>",
|
||||
list.heading, tag)
|
||||
}
|
||||
|
||||
_, summary, _ := strings.Cut(section, "<summary")
|
||||
summary, _, _ = strings.Cut(summary, "</summary>")
|
||||
|
||||
if !strings.Contains(summary, list.heading) {
|
||||
t.Errorf("%s: the <summary> does not hold the heading", list.heading)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user