sneak
5ba9fe8f66
.golangci.yml is the prompts-repo standard verbatim plus one approved
exception (paralleltest, sneak 2026-07-06). Roughly 1,500 findings
fixed:
- autofix sweep (wsl_v5/nlreturn/intrange/modernize formatting), with
the misspell autofix REVERTED where it rewrote authentic C game text
("missle vanishes" stays, with nolint and a comment)
- error handling: errcheck sites get real handling — saveFile now
closes explicitly and removes corrupt saves, scoreboard writes are
documented best-effort, err113 sentinel errors (ErrSaveOutOfDate,
ErrScreenTooSmall); panics allowed for unrecoverable states per
MEMORY.md policy
- gosec: real fixes (ParseInt for SEED, 0600 scorefile) and justified
per-line nolints for provably-bounded conversions (randomMonsterLetter
helper collapses eight rnd(26)+'A' sites)
- API tidying from linters: pointer receivers on flag types
(recvcheck), msg helpers renamed addmsgf/doaddf/Printwf/MvPrintwf
(goprintffuncname), myExit()/findFloor(monst)/mkGameInput(t) drop
always-constant params (unparam), gameEnd carries no status
- gocritic/staticcheck: if-else chains to switches, the pack.c
inventory filter untangled into matchesFilter, main.go split so
defers run before exit (exitAfterDefer, funlen)
- revive doc comments on all exported flag types/consts/methods
Remaining findings are confined to linters pending sneak's exception
decision (mnd, gochecknoglobals, cyclop, nestif, gocognit, exhaustive,
goconst, testpackage); TODO.md records the state. MEMORY.md added at
repo root as the project's agent working notes.
68 lines
2.3 KiB
Go
68 lines
2.3 KiB
Go
package game
|
|
|
|
// Creature is the _t arm of the C THING union: the player or a monster.
|
|
type Creature struct {
|
|
Pos Coord // position
|
|
Turn bool // if slowed, is it a turn to move
|
|
Type byte // what it is: 'A'..'Z' for monsters, '@' for the player
|
|
Disguise byte // what mimic looks like
|
|
OldCh byte // character that was where it was
|
|
Dest *Coord // where it is running to — aliases live coords (hero pos, room gold, another monster's pos)
|
|
Flags CreatureFlags
|
|
Stats Stats
|
|
Room *Room // current room for thing
|
|
Pack []*Object // what the thing is carrying
|
|
}
|
|
|
|
// Monster is a hostile creature on the level.
|
|
type Monster struct {
|
|
Creature
|
|
}
|
|
|
|
// Player embeds Creature and owns the player-only state that was global
|
|
// in the C sources (cur_armor, purse, food_left, ...).
|
|
type Player struct {
|
|
Creature
|
|
|
|
CurArmor *Object // what he is wearing
|
|
CurWeapon *Object // which weapon he is wielding
|
|
CurRing [2]*Object // which rings are being worn (Left/Right)
|
|
PackUsed [26]bool // is the character used in the pack?
|
|
Inpack int // number of things in pack
|
|
Purse int // how much gold he has
|
|
FoodLeft int // amount of food in hero's stomach
|
|
HungryState int // how hungry is he (0..3)
|
|
NoFood int // number of levels without food
|
|
MaxStats Stats // the maximum for the player
|
|
VfHit int // number of times the flytrap has hit
|
|
}
|
|
|
|
// On is the C on(thing, flag) macro.
|
|
func (c *Creature) On(f CreatureFlags) bool { return c.Flags.Has(f) }
|
|
|
|
// IsRing is the C ISRING(hand, ring) macro.
|
|
func (p *Player) IsRing(hand int, ring RingKind) bool {
|
|
return p.CurRing[hand] != nil && p.CurRing[hand].RingKind() == ring
|
|
}
|
|
|
|
// IsWearing is the C ISWEARING(ring) macro: is the ring on either hand.
|
|
func (p *Player) IsWearing(ring RingKind) bool {
|
|
return p.IsRing(Left, ring) || p.IsRing(Right, ring)
|
|
}
|
|
|
|
// attachMon pushes a monster onto the front of a list (list.c attach).
|
|
func attachMon(list *[]*Monster, item *Monster) {
|
|
*list = append([]*Monster{item}, *list...)
|
|
}
|
|
|
|
// detachMon removes a monster (by identity) from a list (list.c detach).
|
|
func detachMon(list *[]*Monster, item *Monster) {
|
|
for i, m := range *list {
|
|
if m == item {
|
|
*list = append((*list)[:i], (*list)[i+1:]...)
|
|
|
|
return
|
|
}
|
|
}
|
|
}
|