sneak
5ba9fe8f66
.golangci.yml is the prompts-repo standard verbatim plus one approved
exception (paralleltest, sneak 2026-07-06). Roughly 1,500 findings
fixed:
- autofix sweep (wsl_v5/nlreturn/intrange/modernize formatting), with
the misspell autofix REVERTED where it rewrote authentic C game text
("missle vanishes" stays, with nolint and a comment)
- error handling: errcheck sites get real handling — saveFile now
closes explicitly and removes corrupt saves, scoreboard writes are
documented best-effort, err113 sentinel errors (ErrSaveOutOfDate,
ErrScreenTooSmall); panics allowed for unrecoverable states per
MEMORY.md policy
- gosec: real fixes (ParseInt for SEED, 0600 scorefile) and justified
per-line nolints for provably-bounded conversions (randomMonsterLetter
helper collapses eight rnd(26)+'A' sites)
- API tidying from linters: pointer receivers on flag types
(recvcheck), msg helpers renamed addmsgf/doaddf/Printwf/MvPrintwf
(goprintffuncname), myExit()/findFloor(monst)/mkGameInput(t) drop
always-constant params (unparam), gameEnd carries no status
- gocritic/staticcheck: if-else chains to switches, the pack.c
inventory filter untangled into matchesFilter, main.go split so
defers run before exit (exitAfterDefer, funlen)
- revive doc comments on all exported flag types/consts/methods
Remaining findings are confined to linters pending sneak's exception
decision (mnd, gochecknoglobals, cyclop, nestif, gocognit, exhaustive,
goconst, testpackage); TODO.md records the state. MEMORY.md added at
repo root as the project's agent working notes.
67 lines
1.8 KiB
Go
67 lines
1.8 KiB
Go
package game
|
|
|
|
import "testing"
|
|
|
|
// The golden values below were produced by the original C generator
|
|
// (seed = seed*11109+13849; rnd(range) = abs(RN) % range) compiled and run
|
|
// on this machine. They lock in seed compatibility with the C game.
|
|
func TestRndMatchesCImplementation(t *testing.T) {
|
|
golden := map[int32][]int{
|
|
1: {0, 30, 79, 7, 87, 1, 23, 7, 57, 98},
|
|
12345: {92, 92, 45, 98, 24, 39, 92, 67, 3, 7},
|
|
2026: {43, 90, 6, 2, 43, 34, 20, 5, 67, 71},
|
|
1751808000: {61, 51, 56, 99, 68, 45, 88, 50, 46, 88},
|
|
}
|
|
for seed, want := range golden {
|
|
r := &Rng{Seed: seed}
|
|
for i, w := range want {
|
|
if got := r.Rnd(100); got != w {
|
|
t.Errorf("seed %d: rnd(100) call %d = %d, want %d", seed, i, got, w)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestRollMatchesCImplementation(t *testing.T) {
|
|
golden := map[int32][]int{
|
|
1: {6, 8, 10},
|
|
12345: {10, 10, 15},
|
|
2026: {10, 10, 13},
|
|
1751808000: {7, 9, 9},
|
|
}
|
|
for seed, want := range golden {
|
|
r := &Rng{Seed: seed}
|
|
for i, w := range want {
|
|
if got := r.Roll(3, 6); got != w {
|
|
t.Errorf("seed %d: roll(3,6) call %d = %d, want %d", seed, i, got, w)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// rnd(0) must return 0 without stepping the generator: the C macro
|
|
// short-circuits before evaluating RN, and BEFORE/AFTER depend on it.
|
|
func TestRndZeroDoesNotStep(t *testing.T) {
|
|
r := &Rng{Seed: 42}
|
|
if got := r.Rnd(0); got != 0 {
|
|
t.Fatalf("rnd(0) = %d, want 0", got)
|
|
}
|
|
|
|
if r.Seed != 42 {
|
|
t.Fatalf("rnd(0) stepped the generator: seed = %d, want 42", r.Seed)
|
|
}
|
|
}
|
|
|
|
// spread(1)==1 and spread(2)==2 deterministically; the C BEFORE/AFTER
|
|
// constants rely on this.
|
|
func TestSpreadSmallValues(t *testing.T) {
|
|
g := &RogueGame{Rng: &Rng{Seed: 7}}
|
|
if got := g.spread(1); got != 1 {
|
|
t.Errorf("spread(1) = %d, want 1", got)
|
|
}
|
|
|
|
if got := g.spread(2); got != 2 {
|
|
t.Errorf("spread(2) = %d, want 2", got)
|
|
}
|
|
}
|