next -> main #45

clawbot · 2026-08-10T15:39:22+02:00

clawbot commented

2026-08-10 15:39:22 +02:00

Release-cycle branch, opening a new cycle after #43 merged. One commit per work unit accumulates here.

Landed so far

`6f997b8` — trim the lint-gate comments to the traps (#44)

Comments and documentation only, per sneak's 2026-08-10 rule that comments keep what a reader needs to avoid a trap and drop reasoning, history and self-justification.

Cut from script/lint and Dockerfile.lint: why the image has two stages, why golangci-lint config verify was omitted, and what earlier drafts of the comments claimed. TODO.md loses its "Hardened" and "Corrected" paragraphs, which argued with earlier versions of themselves.

Kept, because each silently yields a green run over an unlinted or partly linted tree:

--target and --no-cache-filter must both stay, and $stage must match the stage name in Dockerfile.lint.
--target checks that the stage exists, not that it runs golangci-lint, and halts the build there — relocating the lint step or appending a stage after it is not caught.
.dockerignore decides what reaches the container and only what reaches it is linted; excluding a self-contained Go file drops it silently.

The TODO.md entry keeps the flags, the durable property (the lint stage executes every run and is never served from cache), the three unguarded seams, and the evidence that the gate was verified rather than assumed.

Evidence

No behaviour change. Changed lines that are not comments, in each touched file:

$ git diff script/lint    | grep -E '^[+-]' | grep -vE '^[+-]#|^[+-][+-]'   → (empty)
$ git diff .dockerignore  | grep -E '^[+-]' | grep -vE '^[+-]#|^[+-][+-]'   → (empty)
$ git diff Dockerfile.lint| grep -E '^[+-]' | grep -vE '^[+-]#|^[+-][+-]'   → (empty)

Stripping comments and blank lines from each file before and after the commit gives byte-identical content (diff reports no difference for all three). The docker build invocation still reads --target "$stage" --no-cache-filter="$stage" --output=type=cacheonly -f Dockerfile.lint ., and .dockerignore's only rule is still .git.

script/lint run, lint layer executing:

#11 [lint 2/2] RUN golangci-lint run --config .golangci.yml ./...
#11 11.83 0 issues.
#11 DONE 12.2s
EXIT_LINT=0

Not CACHED.

make check green in full, forced uncached through the make target (GOFLAGS=-count=1), re-run after the rebase onto current main:

#10 [lint 2/2] RUN golangci-lint run --config .golangci.yml ./...
#10 10.96 0 issues.
ok      git.eeqj.de/sneak/rgoue/cmd/rogue       1.027s  coverage: 29.7% of statements
ok      git.eeqj.de/sneak/rgoue/game            3.138s  coverage: 64.0% of statements
MAKE_CHECK_EXIT=0

Real durations, no (cached). git status empty around every evidence run; scratch kept outside the clone. No prune of any kind.

Release-cycle branch, opening a new cycle after https://git.eeqj.de/sneak/rgoue/pulls/43 merged. One commit per work unit accumulates here. ## Landed so far ### `6f997b8` — trim the lint-gate comments to the traps (https://git.eeqj.de/sneak/rgoue/issues/44) Comments and documentation only, per sneak's 2026-08-10 rule that comments keep what a reader needs to avoid a trap and drop reasoning, history and self-justification. Cut from `script/lint` and `Dockerfile.lint`: why the image has two stages, why `golangci-lint config verify` was omitted, and what earlier drafts of the comments claimed. `TODO.md` loses its "Hardened" and "Corrected" paragraphs, which argued with earlier versions of themselves. Kept, because each silently yields a green run over an unlinted or partly linted tree: 1. `--target` and `--no-cache-filter` must both stay, and `$stage` must match the stage name in `Dockerfile.lint`. 2. `--target` checks that the stage exists, not that it runs `golangci-lint`, and halts the build there — relocating the lint step or appending a stage after it is not caught. 3. `.dockerignore` decides what reaches the container and only what reaches it is linted; excluding a self-contained Go file drops it silently. The `TODO.md` entry keeps the flags, the durable property (the lint stage executes every run and is never served from cache), the three unguarded seams, and the evidence that the gate was verified rather than assumed. ## Evidence **No behaviour change.** Changed lines that are not comments, in each touched file: ``` $ git diff script/lint | grep -E '^[+-]' | grep -vE '^[+-]#|^[+-][+-]' → (empty) $ git diff .dockerignore | grep -E '^[+-]' | grep -vE '^[+-]#|^[+-][+-]' → (empty) $ git diff Dockerfile.lint| grep -E '^[+-]' | grep -vE '^[+-]#|^[+-][+-]' → (empty) ``` Stripping comments and blank lines from each file before and after the commit gives byte-identical content (`diff` reports no difference for all three). The `docker build` invocation still reads `--target "$stage" --no-cache-filter="$stage" --output=type=cacheonly -f Dockerfile.lint .`, and `.dockerignore`'s only rule is still `.git`. **`script/lint` run**, lint layer executing: ``` #11 [lint 2/2] RUN golangci-lint run --config .golangci.yml ./... #11 11.83 0 issues. #11 DONE 12.2s EXIT_LINT=0 ``` Not `CACHED`. **`make check` green in full**, forced uncached through the make target (`GOFLAGS=-count=1`), re-run after the rebase onto current `main`: ``` #10 [lint 2/2] RUN golangci-lint run --config .golangci.yml ./... #10 10.96 0 issues. ok git.eeqj.de/sneak/rgoue/cmd/rogue 1.027s coverage: 29.7% of statements ok git.eeqj.de/sneak/rgoue/game 3.138s coverage: 64.0% of statements MAKE_CHECK_EXIT=0 ``` Real durations, no `(cached)`. `git status` empty around every evidence run; scratch kept outside the clone. No prune of any kind.

clawbot added 1 commit 2026-08-10 15:39:23 +02:00

docs: trim the lint-gate comments to the traps (closes #44 ) 6f997b8d5c

Comments and documentation only; the docker build invocation and its three
flags are byte-identical and .dockerignore's effective rules are unchanged.

script/lint and Dockerfile.lint stated how the shape was derived — why two
stages, why `golangci-lint config verify` was omitted, what earlier drafts
of the comments claimed. That is in the history. What survives is the three
traps, each of which yields a green run over an unlinted or partly linted
tree: --target and --no-cache-filter must both stay with $stage matching the
stage name in Dockerfile.lint; --target checks that the stage exists, not
that it runs golangci-lint, and halts the build there; and .dockerignore
decides what reaches the container, so excluding a self-contained Go file
drops it from the lint silently.

The TODO.md entry loses its "Hardened" and "Corrected" paragraphs, which
argued with earlier versions of themselves, and keeps the flags, the durable
property, the three unguarded seams, and the evidence that the gate was
verified rather than assumed.

clawbot added the needs-review label 2026-08-10 15:39:27 +02:00

clawbot self-assigned this 2026-08-10 15:39:31 +02:00

clawbot referenced this pull request

2026-08-10 15:39:45 +02:00

Trim the lint-gate comments and TODO entry to the traps only #44

clawbot merged commit 8413c0c7ba into main

2026-08-10 15:41:16 +02:00

clawbot commented

2026-08-10 15:41:25 +02:00

Merged. Adversarial review skipped under the docs-only exception, which I verified rather than took from the PR body: stripping comments and blank lines from script/lint, Dockerfile.lint and .dockerignore gives byte-identical files before and after, and the invocation still carries --target "$stage" --no-cache-filter="$stage" --output=type=cacheonly. All three traps survive in the trimmed comments.

make check green, run twice — the first came back ok (cached) for both packages, which is not evidence the tests ran, so it was re-run forced: lint layer executed (0 issues., not CACHED), ok cmd/rogue 1.019s, ok game 2.998s.

Merged. Adversarial review skipped under the docs-only exception, which I verified rather than took from the PR body: stripping comments and blank lines from `script/lint`, `Dockerfile.lint` and `.dockerignore` gives byte-identical files before and after, and the invocation still carries `--target "$stage" --no-cache-filter="$stage" --output=type=cacheonly`. All three traps survive in the trimmed comments. `make check` green, run twice — the first came back `ok (cached)` for both packages, which is not evidence the tests ran, so it was re-run forced: lint layer executed (`0 issues.`, not `CACHED`), `ok cmd/rogue 1.019s`, `ok game 2.998s`.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: sneak/rgoue#45

next -> main #45

Landed so far

6f997b8 — trim the lint-gate comments to the traps (#44)

Evidence

`6f997b8` — trim the lint-gate comments to the traps (#44)