Drop the deprecated @types/libsodium-wrappers-sumo stub (closes #27) #81

Merged
clawbot merged 1 commits from issue-27-drop-sodium-types-stub into next2 2026-09-23 02:15:08 +02:00
Collaborator

Removes @types/libsodium-wrappers-sumo from devDependencies (#27). It is a deprecated stub with no .d.ts; the declarations the code uses (StateAddress, crypto_secretstream_*) come from libsodium-wrappers-sumo itself.

yarn.lock was regenerated by yarn remove, not edited by hand. The only other lockfile change is that libsodium-wrappers-sumo@* (the stub's dependency) no longer appears in the lockfile entry for that package.

Verification: make build (the TypeScript compile, which make check does not do) and make check are both green, with the stub absent from node_modules.

Deviation: the lockfile was regenerated with yarn remove run directly. make bootstrap installs with --frozen-lockfile, so no repo script can rewrite yarn.lock.

Model: opus-5-5

Removes `@types/libsodium-wrappers-sumo` from `devDependencies` (https://git.eeqj.de/sneak/quak/issues/27). It is a deprecated stub with no `.d.ts`; the declarations the code uses (`StateAddress`, `crypto_secretstream_*`) come from `libsodium-wrappers-sumo` itself. `yarn.lock` was regenerated by `yarn remove`, not edited by hand. The only other lockfile change is that `libsodium-wrappers-sumo@*` (the stub's dependency) no longer appears in the lockfile entry for that package. Verification: `make build` (the TypeScript compile, which `make check` does not do) and `make check` are both green, with the stub absent from `node_modules`. Deviation: the lockfile was regenerated with `yarn remove` run directly. `make bootstrap` installs with `--frozen-lockfile`, so no repo script can rewrite `yarn.lock`. Model: opus-5-5
clawbot added the needs-review label 2026-09-23 01:57:39 +02:00
clawbot self-assigned this 2026-09-23 01:57:39 +02:00
Author
Collaborator

FAIL (needs rebase) on 429243f against next2 3871d62.

  • TODO.md:21: the new Completed Steps entry conflicts with the issue 9 entry that next2 gained from #78 (both add a line at the top of the list). Acceptable: rebase onto the current next2 and keep both entries, with the newest first. The package.json and yarn.lock changes rebase cleanly, and I found nothing else wrong with them.

Judgement call: there is no test that fails without this change. That is expected, since removing a dependency changes no behaviour. make build does type-check against the declarations shipped by libsodium-wrappers-sumo.

Model: opus-5-5

FAIL (needs rebase) on `429243f` against `next2` `3871d62`. - `TODO.md:21`: the new Completed Steps entry conflicts with the issue 9 entry that `next2` gained from https://git.eeqj.de/sneak/quak/pulls/78 (both add a line at the top of the list). Acceptable: rebase onto the current `next2` and keep both entries, with the newest first. The `package.json` and `yarn.lock` changes rebase cleanly, and I found nothing else wrong with them. Judgement call: there is no test that fails without this change. That is expected, since removing a dependency changes no behaviour. `make build` does type-check against the declarations shipped by `libsodium-wrappers-sumo`. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-09-23 02:06:32 +02:00
clawbot added needs-rebase and removed needs-rework labels 2026-09-23 02:08:21 +02:00
clawbot added 1 commit 2026-09-23 02:09:16 +02:00
The package is an empty stub with no declarations; libsodium-wrappers-sumo
ships its own types. Removed with yarn remove, which regenerated yarn.lock.

Model: opus-5-5
clawbot force-pushed issue-27-drop-sodium-types-stub from 429243f716 to 58adaee47a 2026-09-23 02:09:16 +02:00 Compare
clawbot added needs-review and removed needs-rebase labels 2026-09-23 02:09:18 +02:00
clawbot merged commit d50b296d3a into next2 2026-09-23 02:15:08 +02:00
clawbot deleted branch issue-27-drop-sodium-types-stub 2026-09-23 02:15:08 +02:00
Sign in to join this conversation.