/files/upload-url signs the content MD5 into the presigned URL, so storage refused every thumbnail PUT that lacked a Content-MD5 header. ApiClient.putFile now takes a third argument, the base64 MD5 given to getUploadURL, and sends it as Content-MD5; fixMissingThumbnails passes it.
Tests: the fake storage in test/thumbnails/thumbnails.test.ts records the MD5 sent to /files/upload-url and answers 400 to a PUT whose Content-MD5 differs, so the fixMissingThumbnails tests fail without the header. test/api/upload.test.ts asserts the header.
Deviation: the issue names test/ente-server.ts for the refusing fake, but that fake serves no uploads; the upload fake lives in the thumbnail test, so the check went there.
Not checked against live storage; the fix follows the request the issue showed returning 200.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/quak/issues/238
`/files/upload-url` signs the content MD5 into the presigned URL, so storage refused every thumbnail PUT that lacked a `Content-MD5` header. `ApiClient.putFile` now takes a third argument, the base64 MD5 given to `getUploadURL`, and sends it as `Content-MD5`; `fixMissingThumbnails` passes it.
Tests: the fake storage in `test/thumbnails/thumbnails.test.ts` records the MD5 sent to `/files/upload-url` and answers 400 to a PUT whose `Content-MD5` differs, so the `fixMissingThumbnails` tests fail without the header. `test/api/upload.test.ts` asserts the header.
Deviation: the issue names `test/ente-server.ts` for the refusing fake, but that fake serves no uploads; the upload fake lives in the thumbnail test, so the check went there.
Not checked against live storage; the fix follows the request the issue showed returning 200.
Model: opus-5-5
`/files/upload-url` signs the content MD5 into the presigned URL, so
storage refused the PUT that `putFile` sent without it. `putFile` now
takes the MD5 given to `getUploadURL` and sends it. The thumbnail test's
fake storage refuses a PUT without the signed header.
Model: opus-5-5
The thumbnail upload now sends the MD5 that was signed into the upload URL, and the tests fail when that header is missing.
Judgement call: the fake storage that refuses the PUT is in test/thumbnails/thumbnails.test.ts, not test/ente-server.ts as the issue asked, because test/ente-server.ts serves no uploads.
Not verified: an upload to real storage. The issue shows the same request returning 200.
Model: opus-5-5
Verdict: PASS
Head: e185299860cb26c3304d6b87d47bd3fb6c871d41
The thumbnail upload now sends the MD5 that was signed into the upload URL, and the tests fail when that header is missing.
- Judgement call: the fake storage that refuses the PUT is in `test/thumbnails/thumbnails.test.ts`, not `test/ente-server.ts` as the issue asked, because `test/ente-server.ts` serves no uploads.
- Not verified: an upload to real storage. The issue shows the same request returning 200.
Model: opus-5-5
clawbot
merged commit 1bf18baf00 into next2026-11-11 22:59:10 +01:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #238
/files/upload-urlsigns the content MD5 into the presigned URL, so storage refused every thumbnail PUT that lacked aContent-MD5header.ApiClient.putFilenow takes a third argument, the base64 MD5 given togetUploadURL, and sends it asContent-MD5;fixMissingThumbnailspasses it.Tests: the fake storage in
test/thumbnails/thumbnails.test.tsrecords the MD5 sent to/files/upload-urland answers 400 to a PUT whoseContent-MD5differs, so thefixMissingThumbnailstests fail without the header.test/api/upload.test.tsasserts the header.Deviation: the issue names
test/ente-server.tsfor the refusing fake, but that fake serves no uploads; the upload fake lives in the thumbnail test, so the check went there.Not checked against live storage; the fix follows the request the issue showed returning 200.
Model: opus-5-5
Verdict: PASS
Head:
e185299860The thumbnail upload now sends the MD5 that was signed into the upload URL, and the tests fail when that header is missing.
test/thumbnails/thumbnails.test.ts, nottest/ente-server.tsas the issue asked, becausetest/ente-server.tsserves no uploads.Model: opus-5-5