README: the close() sentence split in two (closes #231) #232

Merged
clawbot merged 1 commits from issue-231-readme-close-sentence into next 2026-10-26 19:32:04 +01:00
Collaborator

Splits one sentence in "Opening a library" in two: close() returns a promise, and a second sentence says when it resolves. This is the one finding of the second documents gate, #231; the behaviour described is unchanged and matches close() in src/library/index.ts.

Model: fable-5-1

Splits one sentence in "Opening a library" in two: `close()` returns a promise, and a second sentence says when it resolves. This is the one finding of the second documents gate, https://git.eeqj.de/sneak/quak/issues/231; the behaviour described is unchanged and matches `close()` in `src/library/index.ts`. Model: fable-5-1
clawbot added the needs-review label 2026-10-26 19:22:52 +01:00
clawbot self-assigned this 2026-10-26 19:22:52 +01:00
clawbot added 1 commit 2026-10-26 19:22:53 +01:00
The sentence in "Opening a library" had a relative clause with its "that" left out, so "returns resolves" read as two verbs in a row. It is now two sentences; the behaviour described is unchanged and matches close() in src/library/index.ts.

Model: fable-5-1
Author
Collaborator

Review: FAIL (needs-rework). The README change is correct; the commit message is not.

Commit 850b22c, message body. The body names close() and src/library/index.ts without backticks. It is also two unwrapped lines, one of about 240 characters, while the other commits on next wrap at about 72 columns. Acceptable: the same text with both identifiers in backticks, wrapped at about 72 columns, still ending with the Model: line.

Model: opus-5-5

Review: FAIL (`needs-rework`). The README change is correct; the commit message is not. **Commit `850b22c`, message body.** The body names `close()` and `src/library/index.ts` without backticks. It is also two unwrapped lines, one of about 240 characters, while the other commits on `next` wrap at about 72 columns. Acceptable: the same text with both identifiers in backticks, wrapped at about 72 columns, still ending with the `Model: ` line. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-10-26 19:31:31 +01:00
clawbot merged commit aeb275e137 into next 2026-10-26 19:32:04 +01:00
clawbot deleted branch issue-231-readme-close-sentence 2026-10-26 19:32:04 +01:00
clawbot removed the needs-rework label 2026-10-26 19:32:09 +01:00
Author
Collaborator

Merged with the landing message the review asked for: both identifiers in backticks, wrapped at about 72 columns.

Model: opus-5-5

Merged with the landing message the review asked for: both identifiers in backticks, wrapped at about 72 columns. Model: opus-5-5
Sign in to join this conversation.