Test the live-photo hash check's error paths (closes #117)

Three downloadFile tests cover a live photo whose ZIP names an unknown
compression method, one whose ZIP has no image entry and one with no
video entry. Each checks that nothing is stored and the error names the
file ID; the unreadable ZIP is also checked not to be retried. Each test
fails when its check in livePhotoHasher is removed.

Model: opus-5-5

README.md

@@ -318,7 +318,6 @@ Endpoints used:
   encrypted token plus key attributes.
 - `POST /users/ott` and `POST /users/verify-email`: email OTP fallback path.
 - `POST /users/two-factor/verify`: TOTP second factor.
-- `POST /users/logout`: end the calling token's session (`quak logout`).
 - `GET /collections/v2?sinceTime=<usec>`: list collections changed since
   microsecond timestamp; pass 0 for a full enumeration.
 - `GET /collections/v2/diff?collectionID=<id>&sinceTime=<usec>`: list files in a
@@ -433,9 +432,7 @@ whatever else fits their use case. `Client.fromJSON(snapshot)` restores a
 working client from that snapshot without re-authenticating; it checks every
 field and each key's length first, and throws an error naming the bad field.
 `client.logout()` clears the token and zeroes the key buffers in place; every
-later call on that client throws. It does not contact the server, so the token
-stays valid there and in any saved snapshot; `await client.logoutOnServer()`
-first ends the session on the server (`POST /users/logout`).
+later call on that client throws.
 
 The CLI stores the snapshot at the platform-appropriate data directory via
 `env-paths`: `~/Library/Application Support/quak/session.json` on macOS,
@@ -445,21 +442,13 @@ you would treat the password itself. A missing file is reported as "not logged
 in"; a file that exists but is corrupt is reported as such, naming the bad
 field. Both exit with status 1.
 
-`quak logout` ends the session on the server, so the token in `session.json`
-stops working even in a copy of the file, and then deletes the file. If the
-server call fails (or the file is corrupt), the file is still deleted, the
-command says the server session could not be ended, and it exits with status 1.
-It does not delete the cache: it prints the account's cache directory and says
-it still holds decrypted data (file keys in `metadata.json`, cached originals
-and thumbnails), for the user to delete if they want it gone.
-
 ### CLI surface
 
 ```
 quak [--cache-dir <path>] <command>             global: local metadata/content cache location
 quak login                                      interactive or QUAK_EMAIL/QUAK_PASSWORD
 quak whoami                                     print logged-in account as JSON
-quak logout                                     end the session, delete it
+quak logout                                     delete saved session
 quak collections [--json]                       list all collections
 quak files --collection <id> [--json]           list files in a collection
 quak get <fileID> [--out path] [--collection]   download and decrypt a file
@@ -508,20 +497,6 @@ failure still exits non-zero.
         <name>.json             collection metadata + file list
 ```
 
-A collection's directory and JSON are named after the collection, and a symlink
-after the file's title, both with unsafe characters replaced. When two
-collections would get the same name, or two files in one collection the same
-title (ignoring case in both), each of them gets its ID added: two albums named
-`Trip` become `Trip (10)/` and `Trip (11)/`, and two files titled `IMG_0001.JPG`
-become `IMG_0001 (12345).JPG` and `IMG_0001 (12346).JPG`. IDs never change, so a
-name stays the same from run to run until such a clash appears or goes away.
-
-Each run removes the symlinks into `originals/` that no longer belong in their
-collection's directory, and the directories (and JSON) of collections that were
-deleted or renamed. Nothing else in `collections/` is touched: a file or a
-symlink you put there stays, and a directory that still holds one after its
-symlinks are removed stays too, with its JSON.
-
 Each file is downloaded exactly once regardless of how many collections it
 appears in. On subsequent runs, existing originals are skipped. If a download
 fails, the error is logged and the backup continues with the next file. The exit

TODO.md

@@ -22,22 +22,6 @@ Tag v1.0.0.
   download a live photo whose ZIP names an unknown compression method, one whose
   ZIP has no image entry and one with no video entry, and check that nothing is
   stored and the error names the file ID; the unreadable one is not retried.
-
-- 2026-09-23: `quak logout` ends the session on the server (issue 108). It calls
-  `POST /users/logout` through the new `Client.logoutOnServer()`, then deletes
-  `session.json` even when that call fails, says so and exits 1. It prints the
-  account's cache directory and says it still holds decrypted data. The default
-  cache path is now `defaultCacheDirectory()` in the library, shared with
-  `Library.open`.
-
-- 2026-09-23: Fixed the backup's per-collection folders (issue 103). Two files
-  in one collection with the same title, and two collections with the same name,
-  each get their ID added to the name (`IMG_0001 (12345).JPG`, `Trip (10)/`), so
-  none replaces another's symlink or JSON. Each run removes symlinks into
-  `originals/` for files no longer in the collection, and the folders of deleted
-  or renamed collections, leaving anything else in `collections/` alone. The
-  README backup layout states the naming rule.
-
 - 2026-09-23: Checked downloaded originals against their recorded content hash
   (issue 68). `downloadFile`, which `quak get`, the content cache and backup all
   use, hashes the decrypted bytes (unkeyed BLAKE2b-512, standard base64) and
@@ -46,14 +30,12 @@ Tag v1.0.0.
   hashed separately as `<imageHash>:<videoHash>`. `decryptFile` reads older
   clients' `imageHash` and `videoHash` fields for live photos. A file with no
   recorded hash is stored unchecked.
-
 - 2026-09-23: Kept one account's cache from mixing with another's (issue 104).
   When `metadata.json` in the cache directory was written for a different,
   non-zero user ID than the client's, `Library.open` deletes it and `mldata/`
   and starts empty, so the first refresh enumerates from 0. This only happens
   with `--cache-dir` or an explicit `cacheDirectory`; the default path already
   includes the user ID. A test opens one account's cache as another account.
-
 - 2026-09-23: `backup-metadata` no longer stops on one failed ML data request
   (issue 101). Each request of up to 200 files is tried on its own; a failed one
   is logged, its files are written with the reason in `mlDataError`, and the

bin/quak.ts

@@ -73,7 +73,7 @@ program
 
 program
     .command("logout")
-    .description("End the session on the server and delete the saved session")
+    .description("Delete the saved session")
     .action(() => run(logoutCommand(context())));
 
 program

src/backup.ts

@@ -17,9 +17,7 @@
 // temp-then-rename, so a file that exists is whole and is never re-fetched — an
 // interrupted run resumes by listing the directory. The derived views hold no
 // unique state, so they are rebuilt every run; that repairs stale sidecars and
-// missing or broken symlinks left by an earlier crash. A rebuild also removes
-// the symlinks into originals/ that no longer belong to an album, and the
-// directories of albums that no longer exist.
+// missing or broken symlinks left by an earlier crash.
 //
 // Resilience (issue #8): no per-file condition aborts the run. A failed
 // download or a failed symlink is caught, recorded in `failures.json` with a
@@ -36,14 +34,13 @@ import {
     readdirSync,
     readFileSync,
     readlinkSync,
-    rmdirSync,
     rmSync,
     statSync,
     symlinkSync,
     writeFileSync,
 } from "node:fs";
 import { copyFile, rename, rm } from "node:fs/promises";
-import { basename, dirname, extname, join, relative } from "node:path";
+import { basename, dirname, join, relative } from "node:path";
 
 import { fsyncPath } from "./download/index.js";
 import { safeExtension, sanitizeFileName } from "./filename.js";
@@ -230,93 +227,6 @@ const rebuildSymlink = (linkPath: string, target: string): void => {
     symlinkSync(target, linkPath);
 };
 
-// The on-disk names for the entries of one directory, keyed by ID. Each name
-// is used as is unless another entry would get the same name, ignoring case
-// (two names that differ only in case are one entry on a case-insensitive
-// file system); then every entry sharing it gets ` (<id>)`, before the
-// extension when `beforeExtension` is set. A name with an ID added can match
-// another entry's own name (`IMG (6).JPG`), so this repeats until no name is
-// shared. IDs are stable, so the names are too.
-const namesByID = (
-    entries: { id: number; name: string }[],
-    beforeExtension: boolean,
-): Map<number, string> => {
-    const withID = (id: number, name: string): string => {
-        const ext = beforeExtension ? extname(name) : "";
-        const stem = name.slice(0, name.length - ext.length);
-        return `${stem} (${id})${ext}`;
-    };
-    const names = new Map<number, string>();
-    for (const { id, name } of entries) names.set(id, name);
-    const suffixed = new Set<number>();
-    for (;;) {
-        const counts = new Map<string, number>();
-        for (const name of names.values()) {
-            const key = name.toLowerCase();
-            counts.set(key, (counts.get(key) ?? 0) + 1);
-        }
-        let changed = false;
-        for (const { id, name } of entries) {
-            if (suffixed.has(id)) continue;
-            if (counts.get(name.toLowerCase()) === 1) continue;
-            names.set(id, withID(id, name));
-            suffixed.add(id);
-            changed = true;
-        }
-        if (!changed) return names;
-    }
-};
-
-// Remove the symlinks in the album directory `dir` that point into
-// `originalsDir` and are not named in `keep`. Nothing else in the directory
-// is touched: anything else there was put there by the user.
-const removeStaleLinks = (
-    dir: string,
-    keep: Set<string>,
-    originalsDir: string,
-): void => {
-    const target = relative(dir, originalsDir);
-    for (const name of readdirSync(dir)) {
-        if (keep.has(name)) continue;
-        const path = join(dir, name);
-        if (
-            lstatSync(path).isSymbolicLink() &&
-            dirname(readlinkSync(path)) === target
-        ) {
-            rmSync(path);
-        }
-    }
-};
-
-// Remove the directories under `collectionsDir` that an earlier run wrote for
-// an album that is gone or renamed: a directory not named in `current` with a
-// `<name>.json` beside it holding an album ID, which is what a run writes. Its
-// symlinks into originals/ are removed; if that leaves it empty, it and its
-// JSON are deleted, otherwise both stay for what the user put there.
-const removeStaleAlbumDirs = (
-    collectionsDir: string,
-    current: Set<string>,
-    originalsDir: string,
-): void => {
-    for (const entry of readdirSync(collectionsDir, { withFileTypes: true })) {
-        if (!entry.isDirectory() || current.has(entry.name)) continue;
-        const jsonPath = join(collectionsDir, `${entry.name}.json`);
-        try {
-            const album = JSON.parse(readFileSync(jsonPath, "utf-8")) as {
-                id?: unknown;
-            };
-            if (typeof album.id !== "number") continue;
-        } catch {
-            continue;
-        }
-        const dir = join(collectionsDir, entry.name);
-        removeStaleLinks(dir, new Set(), originalsDir);
-        if (readdirSync(dir).length > 0) continue;
-        rmdirSync(dir);
-        rmSync(jsonPath);
-    }
-};
-
 const loadLedger = (path: string): Map<number, FailureEntry> => {
     const ledger = new Map<number, FailureEntry>();
     try {
@@ -393,10 +303,9 @@ export const runBackup = async (
 
     // Collections in scope, and the distinct files across them (a file shared
     // by two albums is one original).
-    const allCollections = lib.listCollections();
-    const collections = allCollections.filter((c) =>
-        only ? only.has(c.name) : true,
-    );
+    const collections = lib
+        .listCollections()
+        .filter((c) => (only ? only.has(c.name) : true));
     const collectionName = new Map<number, string>();
     for (const c of collections) collectionName.set(c.id, c.name);
 
@@ -497,55 +406,23 @@ export const runBackup = async (
         }
     }
 
-    // Then the per-collection symlink trees and JSON. Directory names are
-    // chosen across every album, not just those in scope, so a scoped run
-    // names an album the same as a full one and never takes the directory of
-    // an album it skipped. Stale entries are removed before anything is
-    // rebuilt, so on a case-insensitive file system removing an old name can
-    // never remove the new one.
-    const albumDirNames = namesByID(
-        allCollections.map((c) => ({
-            id: c.id,
-            name: sanitizeFileName(c.name, `collection-${c.id}`),
-        })),
-        false,
-    );
-    try {
-        removeStaleAlbumDirs(
-            collectionsDir,
-            new Set(albumDirNames.values()),
-            originalsDir,
-        );
-    } catch (err) {
-        log(`FAILED removing old album directories: ${errorMessage(err)}`);
-    }
-
+    // Then the per-collection symlink trees and JSON.
     for (const c of collections) {
-        const colDirName = albumDirNames.get(c.id)!;
+        const colDirName = sanitizeFileName(c.name, `collection-${c.id}`);
         const colDir = join(collectionsDir, colDirName);
         mkdirSync(colDir, { recursive: true });
 
         const files = filesByCollection.get(c.id) ?? [];
-        const linkNames = namesByID(
-            files.map((f) => ({
-                id: f.id,
-                name: sanitizeFileName(f.metadata.title, `file-${f.id}`),
-            })),
-            true,
-        );
-        try {
-            removeStaleLinks(colDir, new Set(linkNames.values()), originalsDir);
-        } catch (err) {
-            log(`FAILED removing old links in ${c.name}: ${errorMessage(err)}`);
-        }
-
         const metaFiles: { id: number; metadata: EnteFile["metadata"] }[] = [];
         for (const file of files) {
             metaFiles.push({ id: file.id, metadata: file.metadata });
             if (!includeOriginals) continue;
             const orig = join(originalsDir, originalName(file));
             if (!isPresent(orig)) continue;
-            const linkName = linkNames.get(file.id)!;
+            const linkName = sanitizeFileName(
+                file.metadata.title,
+                `file-${file.id}`,
+            );
             const linkPath = join(colDir, linkName);
             try {
                 rebuildSymlink(linkPath, relative(colDir, orig));

src/cli-commands.ts

@@ -17,11 +17,7 @@ import {
 import { join } from "node:path";
 import { Client, type ClientSnapshot } from "./client.js";
 import { init } from "./crypto/index.js";
-import {
-    defaultCacheDirectory,
-    Library,
-    type LibraryClient,
-} from "./library/index.js";
+import { Library, type LibraryClient } from "./library/index.js";
 import {
     fileListRow,
     fileListLine,
@@ -150,43 +146,14 @@ export const whoamiCommand = async (ctx: CliContext): Promise<number> => {
     return 0;
 };
 
-// Ends the session on the server, then deletes the session file even when that
-// failed, and exits 1 if it did. The cache is left in place; the user is told
-// where it is.
 export const logoutCommand = async (ctx: CliContext): Promise<number> => {
-    const path = sessionPath(ctx);
-    if (!existsSync(path)) {
-        ctx.stderr.write("No session found.\n");
-        return 0;
-    }
-    await init();
-    let cacheDir = ctx.cacheDir;
-    let failure: string | undefined;
-    try {
-        const client = ctx.loadSession(path);
-        if (client) {
-            cacheDir ??= defaultCacheDirectory(client.whoami().userID);
-            await client.logoutOnServer();
-            client.logout();
-        }
-    } catch (err) {
-        failure = err instanceof Error ? err.message : String(err);
-    }
-    unlinkSync(path);
-    if (failure === undefined) {
-        ctx.stderr.write("Session ended on the server.\n");
+    if (existsSync(sessionPath(ctx))) {
+        unlinkSync(sessionPath(ctx));
+        ctx.stderr.write("Session deleted.\n");
     } else {
-        ctx.stderr.write(
-            `Could not end the session on the server: ${failure}\n`,
-        );
+        ctx.stderr.write("No session found.\n");
     }
-    ctx.stderr.write("Session deleted.\n");
-    if (cacheDir !== undefined) {
-        ctx.stderr.write(
-            `Cache directory ${cacheDir} still holds decrypted data; delete it to remove that data.\n`,
-        );
-    }
-    return failure === undefined ? 0 : 1;
+    return 0;
 };
 
 export const collectionsCommand = async (

src/client.ts

@@ -217,14 +217,6 @@ export class Client {
         };
     }
 
-    // Ends this client's session on the server (`POST /users/logout`), so the
-    // token stops working everywhere, including in any saved copy of it. This
-    // client is left as it was; call `logout()` to clear it.
-    async logoutOnServer(): Promise<void> {
-        this.assertLoggedIn();
-        await this.api.postJSON("/users/logout", {});
-    }
-
     // Zeroes the key buffers in place, so any copy of the reference held
     // elsewhere is wiped too. Every method checks `assertLoggedIn` before
     // touching the keys, so nothing decrypts with the zeroed keys.

src/library/index.ts

@@ -98,11 +98,6 @@ export {
 
 export const DEFAULT_REFRESH_INTERVAL_SECONDS = 3;
 
-// The account's cache directory when `cacheDirectory` is not given: the
-// env-paths cache directory plus the user id, so each account has its own.
-export const defaultCacheDirectory = (userID: number): string =>
-    join(envPaths("quak", { suffix: "" }).cache, String(userID));
-
 // Project a metadata store into by-id records, filling each record's cache
 // paths from the content cache when one is given. Shared by the live read
 // projection and the precache's initial seeding at open().
@@ -349,7 +344,8 @@ export class Library {
     static async open(opts: LibraryOptions): Promise<Library> {
         const { userID } = opts.client.whoami();
         const cacheDirectory =
-            opts.cacheDirectory ?? defaultCacheDirectory(userID);
+            opts.cacheDirectory ??
+            join(envPaths("quak", { suffix: "" }).cache, String(userID));
         const metadataPath = join(cacheDirectory, "metadata.json");
         let store = await MetadataStore.load(metadataPath);
         // A cache directory given explicitly can hold another account's cache.

test/cli/backup.test.ts

@@ -40,7 +40,6 @@ import {
     readFileSync,
     readlinkSync,
     rmSync,
-    symlinkSync,
     writeFileSync,
 } from "node:fs";
 import { spawnSync } from "node:child_process";
@@ -48,7 +47,6 @@ import { join } from "node:path";
 import { tmpdir } from "node:os";
 import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
 
-import { runBackup, type BackupLibrary } from "../../src/backup.js";
 import { Library } from "../../src/library/index.js";
 import type { ContentSource } from "../../src/library/content.js";
 import type { CollectionsPage, FilesPage } from "../../src/client.js";
@@ -624,318 +622,3 @@ describe("lib.backup", () => {
         lib.close();
     });
 });
-
-// The album folders under collections/, driven through `runBackup` with a
-// stand-in library whose albums a test changes between runs.
-describe("backup album folders", () => {
-    interface Album {
-        collection: Collection;
-        files: EnteFile[];
-    }
-
-    const libraryOf = (albums: Album[]): BackupLibrary => ({
-        refresh: async () => {},
-        listCollections: () => albums.map((a) => a.collection),
-        listFiles: (id) =>
-            albums.find((a) => a.collection.id === id)?.files ?? [],
-        original: async (fileID) => {
-            const path = join(root, `source-${fileID}`);
-            writeFileSync(path, `original ${fileID}`);
-            return { path };
-        },
-        thumbnail: async () => {
-            throw new Error("no thumbnails in this stand-in");
-        },
-    });
-
-    // Every entry under collections/, one level of directories deep, with each
-    // symlink's target.
-    const tree = (outDir: string): string[] => {
-        const lines: string[] = [];
-        const list = (dir: string, prefix: string): void => {
-            for (const name of readdirSync(dir).sort()) {
-                const path = join(dir, name);
-                const st = lstatSync(path);
-                if (st.isSymbolicLink()) {
-                    lines.push(`${prefix}${name} -> ${readlinkSync(path)}`);
-                } else if (st.isDirectory() && prefix === "") {
-                    lines.push(`${name}/`);
-                    list(path, `${name}/`);
-                } else {
-                    lines.push(`${prefix}${name}`);
-                }
-            }
-        };
-        list(join(outDir, "collections"), "");
-        return lines;
-    };
-
-    const albumID = (outDir: string, jsonName: string): number =>
-        JSON.parse(readFileSync(join(outDir, "collections", jsonName), "utf-8"))
-            .id;
-
-    it("gives every file and every album its own name when names repeat", async () => {
-        const outDir = join(root, "backup");
-        const lib = libraryOf([
-            {
-                collection: collection(10, "Trip"),
-                files: [
-                    file(1, 10, "IMG_0001.JPG"),
-                    file(2, 10, "IMG_0001.JPG"),
-                    file(4, 10, "img_0001.jpg"),
-                    file(3, 10, "other.jpg"),
-                ],
-            },
-            {
-                collection: collection(11, "Trip"),
-                files: [file(3, 11, "other.jpg")],
-            },
-        ]);
-
-        const result = await runBackup(lib, { downloadDirectory: outDir });
-
-        expect(result.failed).toBe(0);
-        expect(tree(outDir)).toEqual([
-            "Trip (10)/",
-            "Trip (10)/IMG_0001 (1).JPG -> ../../originals/1.JPG",
-            "Trip (10)/IMG_0001 (2).JPG -> ../../originals/2.JPG",
-            "Trip (10)/img_0001 (4).jpg -> ../../originals/4.jpg",
-            "Trip (10)/other.jpg -> ../../originals/3.jpg",
-            "Trip (10).json",
-            "Trip (11)/",
-            "Trip (11)/other.jpg -> ../../originals/3.jpg",
-            "Trip (11).json",
-        ]);
-        expect(albumID(outDir, "Trip (10).json")).toBe(10);
-        expect(albumID(outDir, "Trip (11).json")).toBe(11);
-    });
-
-    it("keeps names unique when a name with an ID added is another entry's own name", async () => {
-        const outDir = join(root, "backup");
-        const lib = libraryOf([
-            {
-                collection: collection(10, "Trip"),
-                files: [
-                    file(5, 10, "IMG (6).JPG"),
-                    file(6, 10, "IMG.JPG"),
-                    file(7, 10, "IMG.JPG"),
-                ],
-            },
-            {
-                collection: collection(11, "Trip"),
-                files: [file(8, 11, "a.jpg")],
-            },
-            {
-                collection: collection(12, "Trip (11)"),
-                files: [file(9, 12, "b.jpg")],
-            },
-        ]);
-
-        const result = await runBackup(lib, { downloadDirectory: outDir });
-
-        expect(result.failed).toBe(0);
-        expect(tree(outDir)).toEqual([
-            "Trip (10)/",
-            "Trip (10)/IMG (6) (5).JPG -> ../../originals/5.JPG",
-            "Trip (10)/IMG (6).JPG -> ../../originals/6.JPG",
-            "Trip (10)/IMG (7).JPG -> ../../originals/7.JPG",
-            "Trip (10).json",
-            "Trip (11)/",
-            "Trip (11)/a.jpg -> ../../originals/8.jpg",
-            "Trip (11) (12)/",
-            "Trip (11) (12)/b.jpg -> ../../originals/9.jpg",
-            "Trip (11) (12).json",
-            "Trip (11).json",
-        ]);
-        expect(albumID(outDir, "Trip (10).json")).toBe(10);
-        expect(albumID(outDir, "Trip (11).json")).toBe(11);
-        expect(albumID(outDir, "Trip (11) (12).json")).toBe(12);
-    });
-
-    it("changes nothing on a second run over an unchanged account", async () => {
-        const outDir = join(root, "backup");
-        const lib = libraryOf([
-            {
-                collection: collection(10, "Trip"),
-                files: [
-                    file(1, 10, "IMG_0001.JPG"),
-                    file(2, 10, "IMG_0001.JPG"),
-                ],
-            },
-            {
-                collection: collection(11, "Trip"),
-                files: [file(3, 11, "other.jpg")],
-            },
-        ]);
-
-        await runBackup(lib, { downloadDirectory: outDir });
-        const before = tree(outDir);
-        const second = await runBackup(lib, { downloadDirectory: outDir });
-
-        expect(second.downloaded).toBe(0);
-        expect(second.failed).toBe(0);
-        expect(tree(outDir)).toEqual(before);
-    });
-
-    it("leaves the albums an onlyAlbumNames run skips as they were", async () => {
-        const outDir = join(root, "backup");
-        // "trip" is skipped by the scoped run but its name clashes with the
-        // in-scope "Trip", so "Trip" must keep its ID suffix.
-        const lib = libraryOf([
-            {
-                collection: collection(10, "Trip"),
-                files: [file(1, 10, "a.jpg")],
-            },
-            {
-                collection: collection(11, "trip"),
-                files: [file(2, 11, "b.jpg")],
-            },
-            {
-                collection: collection(12, "Work"),
-                files: [file(3, 12, "c.jpg")],
-            },
-        ]);
-        const json = (name: string): string =>
-            readFileSync(join(outDir, "collections", name), "utf-8");
-
-        await runBackup(lib, { downloadDirectory: outDir });
-        const before = tree(outDir);
-        const skippedJSON = [json("trip (11).json"), json("Work.json")];
-        const scoped = await runBackup(lib, {
-            downloadDirectory: outDir,
-            onlyAlbumNames: ["Trip"],
-        });
-
-        expect(scoped.failed).toBe(0);
-        expect(before).toEqual([
-            "Trip (10)/",
-            "Trip (10)/a.jpg -> ../../originals/1.jpg",
-            "Trip (10).json",
-            "Work/",
-            "Work/c.jpg -> ../../originals/3.jpg",
-            "Work.json",
-            "trip (11)/",
-            "trip (11)/b.jpg -> ../../originals/2.jpg",
-            "trip (11).json",
-        ]);
-        expect(tree(outDir)).toEqual(before);
-        expect([json("trip (11).json"), json("Work.json")]).toEqual(
-            skippedJSON,
-        );
-    });
-
-    it("removes links and album folders that are gone, and nothing the user added", async () => {
-        const outDir = join(root, "backup");
-        const albums: Album[] = [
-            {
-                collection: collection(10, "Trip"),
-                files: [
-                    file(1, 10, "IMG_0001.JPG"),
-                    file(2, 10, "IMG_0001.JPG"),
-                    file(3, 10, "other.jpg"),
-                ],
-            },
-            {
-                collection: collection(12, "Work"),
-                files: [file(5, 12, "a.jpg")],
-            },
-            {
-                collection: collection(13, "Old"),
-                files: [file(5, 13, "a.jpg")],
-            },
-        ];
-        const lib = libraryOf(albums);
-        await runBackup(lib, { downloadDirectory: outDir });
-
-        // What the user put in the tree: a note and a symlink of their own in
-        // an album, a note in an album about to be renamed, and a folder quak
-        // did not create.
-        const collectionsDir = join(outDir, "collections");
-        writeFileSync(join(collectionsDir, "Trip", "notes.txt"), "mine");
-        symlinkSync("../elsewhere", join(collectionsDir, "Trip", "mine"));
-        writeFileSync(join(collectionsDir, "Work", "keep.txt"), "mine");
-        mkdirSync(join(collectionsDir, "Mine"));
-        writeFileSync(join(collectionsDir, "Mine", "keep.txt"), "mine");
-
-        // File 2 leaves Trip, Work is renamed Office, Old is deleted.
-        albums[0]!.files.splice(1, 1);
-        albums[1]!.collection = collection(12, "Office");
-        albums.splice(2, 1);
-        const result = await runBackup(lib, { downloadDirectory: outDir });
-
-        expect(result.failed).toBe(0);
-        expect(tree(outDir)).toEqual([
-            "Mine/",
-            "Mine/keep.txt",
-            "Office/",
-            "Office/a.jpg -> ../../originals/5.jpg",
-            "Office.json",
-            "Trip/",
-            "Trip/IMG_0001.JPG -> ../../originals/1.JPG",
-            "Trip/mine -> ../elsewhere",
-            "Trip/notes.txt",
-            "Trip/other.jpg -> ../../originals/3.jpg",
-            "Trip.json",
-            "Work/",
-            "Work/keep.txt",
-            "Work.json",
-        ]);
-    });
-
-    // One album backed up, then a folder the user made beside it holding a
-    // symlink into originals/, with `json` (if given) as its sibling JSON.
-    const backupWithUserFolder = async (
-        json: string | undefined,
-    ): Promise<{ outDir: string; failed: number }> => {
-        const outDir = join(root, "backup");
-        const lib = libraryOf([
-            {
-                collection: collection(10, "Trip"),
-                files: [file(1, 10, "a.jpg")],
-            },
-        ]);
-        await runBackup(lib, { downloadDirectory: outDir });
-        const collectionsDir = join(outDir, "collections");
-        mkdirSync(join(collectionsDir, "Mine"));
-        symlinkSync(
-            "../../originals/1.jpg",
-            join(collectionsDir, "Mine", "a.jpg"),
-        );
-        if (json !== undefined) {
-            writeFileSync(join(collectionsDir, "Mine.json"), json);
-        }
-        const result = await runBackup(lib, { downloadDirectory: outDir });
-        return { outDir, failed: result.failed };
-    };
-
-    it("leaves a user folder with no JSON beside it as it was", async () => {
-        const { outDir, failed } = await backupWithUserFolder(undefined);
-
-        expect(failed).toBe(0);
-        expect(tree(outDir)).toEqual([
-            "Mine/",
-            "Mine/a.jpg -> ../../originals/1.jpg",
-            "Trip/",
-            "Trip/a.jpg -> ../../originals/1.jpg",
-            "Trip.json",
-        ]);
-    });
-
-    it("leaves a user folder whose JSON has no album ID as it was", async () => {
-        const json = '{"name":"Mine"}';
-        const { outDir, failed } = await backupWithUserFolder(json);
-
-        expect(failed).toBe(0);
-        expect(tree(outDir)).toEqual([
-            "Mine/",
-            "Mine/a.jpg -> ../../originals/1.jpg",
-            "Mine.json",
-            "Trip/",
-            "Trip/a.jpg -> ../../originals/1.jpg",
-            "Trip.json",
-        ]);
-        expect(
-            readFileSync(join(outDir, "collections", "Mine.json"), "utf-8"),
-        ).toBe(json);
-    });
-});

test/cli/commands.test.ts

@@ -38,8 +38,7 @@ import { loadSession } from "../../src/cli-session.js";
 import type { Client, ClientSnapshot } from "../../src/client.js";
 import type { ContentSource } from "../../src/library/content.js";
 import type { Collection, EnteFile } from "../../src/model/types.js";
-import { init, toBase64 } from "../../src/crypto/index.js";
-import { defaultCacheDirectory } from "../../src/library/index.js";
+import { init } from "../../src/crypto/index.js";
 
 const USER_ID = 42;
 
@@ -177,6 +176,19 @@ describe("session file", () => {
         expect(JSON.parse(readFileSync(path, "utf-8"))).toEqual(snapshot);
     });
 
+    it("is removed by logout", async () => {
+        const ctx = context();
+        saveSession(ctx.sessionDir, snapshot);
+        expect(await logoutCommand(ctx)).toBe(0);
+        expect(existsSync(join(ctx.sessionDir, "session.json"))).toBe(false);
+        expect(stderr.text).toBe("Session deleted.\n");
+    });
+
+    it("logout without a session says so and exits 0", async () => {
+        expect(await logoutCommand(context())).toBe(0);
+        expect(stderr.text).toBe("No session found.\n");
+    });
+
     it("a missing session exits 1 with 'Not logged in'", async () => {
         const ctx = { ...context(), loadSession };
         expect(await whoamiCommand(ctx)).toBe(1);
@@ -199,85 +211,6 @@ describe("session file", () => {
     });
 });
 
-// These use a real client read from the session file, over a fake API that
-// records each request and answers with `status`.
-describe("logout", () => {
-    const snapshot: ClientSnapshot = {
-        email: "cli@example.com",
-        userID: USER_ID,
-        token: "saved-token",
-        masterKey: toBase64(new Uint8Array(32)),
-        secretKey: toBase64(new Uint8Array(32)),
-        publicKey: toBase64(new Uint8Array(32)),
-    };
-
-    const requests: Request[] = [];
-
-    const logoutContext = (status: number): CliContext => ({
-        ...context(),
-        loadSession: (path) =>
-            loadSession(path, {
-                fetch: async (url, init) => {
-                    requests.push(new Request(url, init));
-                    return new Response(JSON.stringify({}), {
-                        status,
-                        headers: { "content-type": "application/json" },
-                    });
-                },
-            }),
-    });
-
-    beforeEach(() => {
-        requests.length = 0;
-    });
-
-    it("ends the session on the server, then deletes the file", async () => {
-        const ctx = logoutContext(200);
-        saveSession(ctx.sessionDir, snapshot);
-        expect(await logoutCommand(ctx)).toBe(0);
-
-        expect(requests).toHaveLength(1);
-        expect(requests[0]!.method).toBe("POST");
-        expect(new URL(requests[0]!.url).pathname).toBe("/users/logout");
-        expect(requests[0]!.headers.get("X-Auth-Token")).toBe("saved-token");
-        expect(existsSync(join(ctx.sessionDir, "session.json"))).toBe(false);
-        expect(stderr.text).toBe(
-            "Session ended on the server.\n" +
-                "Session deleted.\n" +
-                `Cache directory ${ctx.cacheDir} still holds decrypted data; delete it to remove that data.\n`,
-        );
-    });
-
-    it("still deletes the file when the server call fails, and says so", async () => {
-        const ctx = logoutContext(500);
-        saveSession(ctx.sessionDir, snapshot);
-        expect(await logoutCommand(ctx)).toBe(1);
-
-        expect(requests).toHaveLength(1);
-        expect(existsSync(join(ctx.sessionDir, "session.json"))).toBe(false);
-        expect(stderr.text).toBe(
-            "Could not end the session on the server: HTTP 500\n" +
-                "Session deleted.\n" +
-                `Cache directory ${ctx.cacheDir} still holds decrypted data; delete it to remove that data.\n`,
-        );
-    });
-
-    it("names the account's default cache directory without --cache-dir", async () => {
-        const ctx = { ...logoutContext(200), cacheDir: undefined };
-        saveSession(ctx.sessionDir, snapshot);
-        expect(await logoutCommand(ctx)).toBe(0);
-        expect(stderr.text).toContain(
-            `Cache directory ${defaultCacheDirectory(USER_ID)} still holds decrypted data`,
-        );
-    });
-
-    it("without a session says so, calls nothing and exits 0", async () => {
-        expect(await logoutCommand(logoutContext(200))).toBe(0);
-        expect(requests).toHaveLength(0);
-        expect(stderr.text).toBe("No session found.\n");
-    });
-});
-
 describe("whoami", () => {
     it("prints the account as one line of JSON", async () => {
         expect(await whoamiCommand(context())).toBe(0);