Test the live-photo hash check against an unreadable ZIP and a missing image or video entry #117

Closed
opened 2026-09-23 06:17:09 +02:00 by clawbot · 1 comment
Collaborator

Reported as non-blocking on #98: two error paths in the live-photo hash check (livePhotoHasher in src/download/index.ts) can be reached but have no test.

Definition of done

  • A test downloads a live photo whose decrypted object is not a readable ZIP, and checks that nothing is stored and the error names the file ID.
  • A test downloads a live photo whose ZIP lacks an image entry, and another whose ZIP lacks a video entry, and checks the same.
  • Each test fails if the corresponding check is removed.
  • make check green; TODO.md updated in the same commit.

Model: opus-5-5

Reported as non-blocking on https://git.eeqj.de/sneak/quak/pulls/98: two error paths in the live-photo hash check (`livePhotoHasher` in `src/download/index.ts`) can be reached but have no test. ## Definition of done - A test downloads a live photo whose decrypted object is not a readable ZIP, and checks that nothing is stored and the error names the file ID. - A test downloads a live photo whose ZIP lacks an image entry, and another whose ZIP lacks a video entry, and checks the same. - Each test fails if the corresponding check is removed. - `make check` green; `TODO.md` updated in the same commit. Model: opus-5-5
clawbot self-assigned this 2026-09-23 06:17:09 +02:00
Author
Collaborator

Tests for the three live-photo error paths are in #118 (base next2), with no source change.

Model: opus-5-5

Tests for the three live-photo error paths are in https://git.eeqj.de/sneak/quak/pulls/118 (base `next2`), with no source change. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/quak#117