clawbot
ed5ed236b1
All checks were successful
check / check (push) Successful in 27s
Option-2 answer to sneak's ruling of 2026-08-19 on sneak/homoicon#4: migrate to the successor, with settings. Closes #25. ## The change `golangci-lint` v2.12.0 deprecated `gomodguard`, and this config sets `linters.default: all`, so it is enabled everywhere and warns on every run. - `gomodguard` joins `wsl` in `linters.disable` under a shared "deprecated" comment. The warning is attached to the old name, so disabling it is what silences it. - `gomodguard_v2` is named in `linters.enable`, a no-op under `default: all` that gives the settings block a visible owner. - Blocked, each restating a decision already recorded in the Go package defaults: `rs/zerolog` → `log/slog`; the pre-fork `go-redis/redis` → `redis/go-redis/v9`; `sergi/go-diff` and `hexops/gotextdiff` → `go-udiff`. Every entry matches the module path exactly, so the pre-fork go-redis takes three: `go-redis/redis`, `/v7`, `/v8`. A prefix would also cover `go-redis/redismock`, the test double for the successor recommended here. Deliberately absent: recorded rejections that vendoring repos still require (`mattn/go-sqlite3`, `gorm.io/gorm`, `pmezard/go-difflib`), plus `urfave/cli` and unversioned `go-chi/chi`. Blocking those would redden repos mid-migration on their next re-vendor. ## After merge The file's sha256 moves from `d10f47ef5e0d8620efd62275b016a7de8fd5abedf333922eec86fe4abc06176e` to `a79b63a254602a5318db5d0e9a06bc71b84bf0c1d896305229d8bfed1d1b1776`, so every vendoring repo mismatches. #60 is the propagation brief; it and the record on #25 carry this value. ## Disclosures - Judgement call: `wsl` moved two lines down to share the "deprecated" comment. No behaviour change, but it widens the diff. - The `go.mod` survey and the settings-block probe are on #25. - Unverified: the linter was not run against each vendoring repo; the per-repo claim rests on reading their `go.mod` files. - `make check` exit 0. Model: opus-5 Co-authored-by: Jeffrey Paul <sneak@noreply.example.org> Reviewed-on: #55 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>
99 lines
3.9 KiB
YAML
99 lines
3.9 KiB
YAML
version: "2"
|
|
|
|
# Config schema uses the golangci-lint v2 layout (settings live under
|
|
# linters.settings, not top-level linters-settings) so that the
|
|
# thresholds below are actually applied by golangci-lint >= v2.
|
|
|
|
run:
|
|
timeout: 5m
|
|
modules-download-mode: readonly
|
|
|
|
linters:
|
|
default: all
|
|
enable:
|
|
# Successor to the deprecated gomodguard. Named explicitly, rather than
|
|
# left to `default: all`, because it carries the module policy below.
|
|
- gomodguard_v2
|
|
disable:
|
|
# Genuinely incompatible with project patterns
|
|
- exhaustruct # Requires all struct fields
|
|
- godot # Requires comments to end with periods
|
|
- wrapcheck # Too verbose for internal packages
|
|
- varnamelen # Short names like db, id are idiomatic Go
|
|
# Deprecated: the warning is attached to the old name, so it is
|
|
# silenced by disabling that name, not by enabling the successor.
|
|
- wsl # Deprecated, replaced by wsl_v5
|
|
- gomodguard # Deprecated, replaced by gomodguard_v2
|
|
settings:
|
|
lll:
|
|
line-length: 88
|
|
funlen:
|
|
lines: 80
|
|
statements: 50
|
|
cyclop:
|
|
max-complexity: 15
|
|
dupl:
|
|
threshold: 100
|
|
depguard:
|
|
# Test-support code must not be compiled into the shipped binary. A
|
|
# test-support package exists to hand a test privileges the program
|
|
# itself must never have, so a file that is not a test must not import
|
|
# one. Test files, and the files inside a package whose directory name
|
|
# ends in `test`, are where that code belongs, and are exempt.
|
|
#
|
|
# The deny list below is the one part of this file a repository is
|
|
# expected to extend, and the only part it may. depguard matches an
|
|
# import path against a list of prefixes, so it cannot be told "any path
|
|
# whose last segment ends in test"; a repository's own test-support
|
|
# packages have to be named here one at a time, by full import path,
|
|
# under a module path that differs from repository to repository. Add
|
|
# them; change nothing else.
|
|
rules:
|
|
test-support:
|
|
list-mode: lax
|
|
files:
|
|
- "$all"
|
|
- "!$test"
|
|
- "!**/*test/**"
|
|
deny:
|
|
- pkg: net/http/httptest
|
|
desc: >-
|
|
Test-support code belongs in test files and in packages whose
|
|
directory name ends in test, not in the shipped binary.
|
|
# Only decisions already recorded in the Go package defaults are
|
|
# listed here. Every entry matches the module path exactly.
|
|
gomodguard_v2:
|
|
blocked:
|
|
- module: github.com/rs/zerolog
|
|
recommendations:
|
|
- log/slog
|
|
reason: "Structured logging is stdlib log/slog."
|
|
# One entry per pre-fork module path, because the later releases
|
|
# are separate paths. A prefix match would be shorter but would
|
|
# also reach github.com/go-redis/redismock, the test double for
|
|
# the successor these entries recommend.
|
|
- module: github.com/go-redis/redis
|
|
recommendations:
|
|
- github.com/redis/go-redis/v9
|
|
reason: "Pre-fork module; use the maintained go-redis v9."
|
|
- module: github.com/go-redis/redis/v7
|
|
recommendations:
|
|
- github.com/redis/go-redis/v9
|
|
reason: "Pre-fork module; use the maintained go-redis v9."
|
|
- module: github.com/go-redis/redis/v8
|
|
recommendations:
|
|
- github.com/redis/go-redis/v9
|
|
reason: "Pre-fork module; use the maintained go-redis v9."
|
|
- module: github.com/sergi/go-diff
|
|
recommendations:
|
|
- github.com/aymanbagabas/go-udiff
|
|
reason: "No unified diff output; use go-udiff."
|
|
- module: github.com/hexops/gotextdiff
|
|
recommendations:
|
|
- github.com/aymanbagabas/go-udiff
|
|
reason: "Unmaintained fork; use go-udiff."
|
|
|
|
issues:
|
|
max-issues-per-linter: 0
|
|
max-same-issues: 0
|