Check builds use Docker's normal cache (closes #177) #178

Merged
clawbot merged 1 commits from issue-177-drop-cache-busting into next 2026-11-16 23:09:08 +01:00
Collaborator

Closes #177

Check builds now use Docker's normal cache. On an unchanged tree each step's stored result is reused, and Docker stores a result only for a step that succeeded.

  • script/lint, script/test, script/docker, script/cibuild: no --build-arg CACHEBUST, and their comments about it are gone.
  • Dockerfile: the three ARG CACHEBUST lines are gone.
  • prompts/REPO_POLICIES.md: the cache-busting rule is replaced by a short "Check builds use Docker's normal cache" rule. The rules on placing the ARG line and on re-vendoring scripts and ARG lines in one commit are gone. The rule that a new or changed check is proven by planting a defect it must catch stays, as do pinned tools, lockfile hashes and -count=1. The script/cibuild paragraph now says the image build reuses the gate phases the check just built.

Judgement call: README.md, prompts/CODE_STYLEGUIDE_GO.md, prompts/NEW_REPO_CHECKLIST.md and prompts/EXISTING_REPO_CHECKLIST.md restated the cache-busting rules, so they are updated too; leaving them would contradict the policy. The existing-repo checklist gets one item: no docker build in script/ passes --no-cache or a cache-busting build argument such as CACHEBUST, and no Dockerfile stage declares ARG CACHEBUST. It names them only to catch repos that still bust the cache.

Rolling this out to the repos that copy these files is #78.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/prompts/issues/177 Check builds now use Docker's normal cache. On an unchanged tree each step's stored result is reused, and Docker stores a result only for a step that succeeded. - `script/lint`, `script/test`, `script/docker`, `script/cibuild`: no `--build-arg CACHEBUST`, and their comments about it are gone. - `Dockerfile`: the three `ARG CACHEBUST` lines are gone. - `prompts/REPO_POLICIES.md`: the cache-busting rule is replaced by a short "Check builds use Docker's normal cache" rule. The rules on placing the `ARG` line and on re-vendoring scripts and `ARG` lines in one commit are gone. The rule that a new or changed check is proven by planting a defect it must catch stays, as do pinned tools, lockfile hashes and `-count=1`. The `script/cibuild` paragraph now says the image build reuses the gate phases the check just built. Judgement call: `README.md`, `prompts/CODE_STYLEGUIDE_GO.md`, `prompts/NEW_REPO_CHECKLIST.md` and `prompts/EXISTING_REPO_CHECKLIST.md` restated the cache-busting rules, so they are updated too; leaving them would contradict the policy. The existing-repo checklist gets one item: no `docker build` in `script/` passes `--no-cache` or a cache-busting build argument such as `CACHEBUST`, and no `Dockerfile` stage declares `ARG CACHEBUST`. It names them only to catch repos that still bust the cache. Rolling this out to the repos that copy these files is https://git.eeqj.de/sneak/prompts/issues/78. Model: opus-5-5
clawbot added the needs-review label 2026-11-16 22:18:00 +01:00
clawbot self-assigned this 2026-11-16 22:18:00 +01:00
Author
Collaborator

Verdict: FAIL
Head: ca36d0372c

needs-rework

  1. prompts/REPO_POLICIES.md, the "Check builds use Docker's normal cache" rule (lines 301 to 309): the PR deletes the rule that a new or changed check is proven by planting a defect it must catch, watching the build fail on it, and reverting the defect. Only half of that rule was about cache busting. Its other half, that a passing build does not show a check "covers what it should", does not depend on the cache; it is where the August fleet findings issue (#62) put its finding about a check that covers less than it claims. sneak's words on #177 cover only using the cache on unchanged trees. Acceptable: keep one sentence, for example "When a check is added or changed, plant a defect it must catch, watch the build fail on it, then revert the defect."
  2. prompts/REPO_POLICIES.md line 308: "Never prune the build cache (docker builder prune and the like): it is shared with every other build on the host." no longer says what to do instead; the cache-busting argument it stood beside is gone. Acceptable: add the alternative or say the capability is given up, for example "Nothing needs to run again on an unchanged tree."
  3. prompts/EXISTING_REPO_CHECKLIST.md lines 52 to 54: the new item catches only a build argument, so a repo that copied docker build --no-cache from main passes it, though the PR body says this item catches repos that still bust the cache. "a build argument whose only job is to make steps run again" also paraphrases the common name. Acceptable: "No docker build in script/ passes --no-cache or a cache-busting build argument such as CACHEBUST, and no Dockerfile stage declares ARG CACHEBUST." Update the PR body's sentence to match.

Judgement call: finding 1 departs from the issue's work list, which asked to drop that rule; sneak's quoted words do not cover it.

Model: opus-5-5

Verdict: FAIL Head: ca36d0372cf681fe94b4fe09eed41b9d3c8fa8a3 `needs-rework` 1. `prompts/REPO_POLICIES.md`, the "Check builds use Docker's normal cache" rule (lines 301 to 309): the PR deletes the rule that a new or changed check is proven by planting a defect it must catch, watching the build fail on it, and reverting the defect. Only half of that rule was about cache busting. Its other half, that a passing build does not show a check "covers what it should", does not depend on the cache; it is where the August fleet findings issue (https://git.eeqj.de/sneak/prompts/issues/62) put its finding about a check that covers less than it claims. sneak's words on https://git.eeqj.de/sneak/prompts/issues/177 cover only using the cache on unchanged trees. Acceptable: keep one sentence, for example "When a check is added or changed, plant a defect it must catch, watch the build fail on it, then revert the defect." 2. `prompts/REPO_POLICIES.md` line 308: "Never prune the build cache (`docker builder prune` and the like): it is shared with every other build on the host." no longer says what to do instead; the cache-busting argument it stood beside is gone. Acceptable: add the alternative or say the capability is given up, for example "Nothing needs to run again on an unchanged tree." 3. `prompts/EXISTING_REPO_CHECKLIST.md` lines 52 to 54: the new item catches only a build argument, so a repo that copied `docker build --no-cache` from `main` passes it, though the PR body says this item catches repos that still bust the cache. "a build argument whose only job is to make steps run again" also paraphrases the common name. Acceptable: "No `docker build` in `script/` passes `--no-cache` or a cache-busting build argument such as `CACHEBUST`, and no `Dockerfile` stage declares `ARG CACHEBUST`." Update the PR body's sentence to match. Judgement call: finding 1 departs from the issue's work list, which asked to drop that rule; sneak's quoted words do not cover it. Model: opus-5-5
Author
Collaborator

For the reworker: the review is right, and the error was in the issue text I wrote. Restore the rule that a new or changed check is proven by planting a defect it must catch and watching the build fail. It stands on its own and is not cache-busting machinery. Remove only what exists for CACHEBUST: the build argument, the ARG CACHEBUST lines, and the rule that scripts and ARG lines land in one commit. Change nothing else.

Model: opus-5-5

For the reworker: the review is right, and the error was in the issue text I wrote. Restore the rule that a new or changed check is proven by planting a defect it must catch and watching the build fail. It stands on its own and is not cache-busting machinery. Remove only what exists for `CACHEBUST`: the build argument, the `ARG CACHEBUST` lines, and the rule that scripts and `ARG` lines land in one commit. Change nothing else. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-11-16 22:39:04 +01:00
clawbot added 1 commit 2026-11-16 22:49:09 +01:00
Drop the CACHEBUST build argument from script/lint, script/test,
script/docker, script/cibuild and every Dockerfile stage. REPO_POLICIES
now says check builds use Docker's normal cache: an unchanged tree reuses
each step's stored result, which Docker keeps only for steps that
succeeded. The rules on placing ARG CACHEBUST and re-vendoring it in one
commit are gone; the rule that a planted defect proves a new or changed
check stays. The README, the Go style guide and both checklists restated
the cache-busting rules and are updated to match. The existing-repo
checklist asks that no script pass --no-cache or CACHEBUST.

Model: opus-5-5
clawbot force-pushed issue-177-drop-cache-busting from ca36d0372c to 15aab336ad 2026-11-16 22:49:09 +01:00 Compare
Author
Collaborator

Reworked at 15aab33 for #178 (comment) and #178 (comment):

  1. Planted-defect rule restored word for word, at the end of the "Check builds use Docker's normal cache" rule.
  2. "Nothing needs to run again on an unchanged tree." now comes before the ban on pruning.
  3. Checklist item now uses the review's wording; the PR body sentence matches.
  4. Change nothing else: two reasons the PR had reworded are back to the next text, "so that check builds keep them" (system packages above script/bootstrap, and the Python test phase install).

Judgement call: sentences that named CACHEBUST keep the PR's rewording without it; sentences that did not are as on next.

Model: opus-5-5

Reworked at `15aab33` for https://git.eeqj.de/sneak/prompts/pulls/178#issuecomment-182113 and https://git.eeqj.de/sneak/prompts/pulls/178#issuecomment-182099: 1. Planted-defect rule restored word for word, at the end of the "Check builds use Docker's normal cache" rule. 2. "Nothing needs to run again on an unchanged tree." now comes before the ban on pruning. 3. Checklist item now uses the review's wording; the PR body sentence matches. 4. Change nothing else: two reasons the PR had reworded are back to the `next` text, "so that check builds keep them" (system packages above `script/bootstrap`, and the Python `test` phase install). Judgement call: sentences that named `CACHEBUST` keep the PR's rewording without it; sentences that did not are as on `next`. Model: opus-5-5
clawbot added needs-review and removed needs-rework labels 2026-11-16 22:49:35 +01:00
Author
Collaborator

Verdict: PASS
Head: 15aab336ad

The change removes cache busting from the policy, the four canonical scripts and the Dockerfile as the cache-busting issue (#177) asks, and fixes the three findings of the earlier review.

Judgement call: prompts/EXISTING_REPO_CHECKLIST.md still names CACHEBUST and --no-cache, only to forbid them; I read that as meeting the definition of done.

Model: opus-5-5

Verdict: PASS Head: 15aab336ad33d43f74bbe42570ea55905563af9a The change removes cache busting from the policy, the four canonical scripts and the `Dockerfile` as the cache-busting issue (https://git.eeqj.de/sneak/prompts/issues/177) asks, and fixes the three findings of the earlier review. Judgement call: `prompts/EXISTING_REPO_CHECKLIST.md` still names `CACHEBUST` and `--no-cache`, only to forbid them; I read that as meeting the definition of done. Model: opus-5-5
clawbot merged commit 964d973e3c into next 2026-11-16 23:09:08 +01:00
clawbot deleted branch issue-177-drop-cache-busting 2026-11-16 23:09:08 +01:00
Sign in to join this conversation.