Set a time limit on the canonical check job (closes #120) #121

Merged
clawbot merged 1 commits from issue-120-check-job-time-limit into next 2026-10-07 11:31:35 +02:00
Collaborator

The canonical check.yml gave its check job no time limit, so a hung script/cibuild held the shared runner until the runner's own default limit. The job now sets timeout-minutes: 20. Closes #120.

Why 20: script/cibuild runs three Docker builds (the test phase, the lint phase, then the image, which runs both again), each held to the 5-minute Docker build limit in REPO_POLICIES.md, plus the bootstrap. If #113 changes that limit, this value follows it.

REPO_POLICIES.md (the workflow paragraph, right after its description of what script/cibuild runs) and both checklists name the limit among what the workflow sets; last_modified is bumped in all three. Part of the REPO_POLICIES.md diff is prettier rewrapping the end of that paragraph after the two added sentences. README.md does not describe what the workflow sets and is unchanged. Repositories pick this up on their next re-vendor.

Unverified: the runner's honouring of timeout-minutes was not tried on the shared runner.

Model: opus-5-5

The canonical `check.yml` gave its `check` job no time limit, so a hung `script/cibuild` held the shared runner until the runner's own default limit. The job now sets `timeout-minutes: 20`. Closes https://git.eeqj.de/sneak/prompts/issues/120. Why 20: `script/cibuild` runs three Docker builds (the test phase, the lint phase, then the image, which runs both again), each held to the 5-minute Docker build limit in `REPO_POLICIES.md`, plus the bootstrap. If https://git.eeqj.de/sneak/prompts/issues/113 changes that limit, this value follows it. `REPO_POLICIES.md` (the workflow paragraph, right after its description of what `script/cibuild` runs) and both checklists name the limit among what the workflow sets; `last_modified` is bumped in all three. Part of the `REPO_POLICIES.md` diff is prettier rewrapping the end of that paragraph after the two added sentences. `README.md` does not describe what the workflow sets and is unchanged. Repositories pick this up on their next re-vendor. Unverified: the runner's honouring of `timeout-minutes` was not tried on the shared runner. Model: opus-5-5
clawbot added the needs-review label 2026-10-07 10:37:52 +02:00
clawbot self-assigned this 2026-10-07 10:37:52 +02:00
Author
Collaborator

FAIL: needs rework.

  1. prompts/REPO_POLICIES.md, the workflow paragraph (around line 304), and the same wording in the commit message and PR body: the three builds are listed as "the lint phase, the test phase, then the image", but script/check builds the test phase first and the lint phase second. Acceptable: list them in the order script/cibuild runs them (the test phase, the lint phase, then the image).

  2. prompts/REPO_POLICIES.md, same paragraph: the two new sentences come before the existing sentences that describe what script/cibuild runs, and their parenthetical says what the paragraph says again two sentences later ("The image build is uncached and so runs the gate phases a second time"). Acceptable: move the time-limit sentences after the existing description of script/cibuild (after "from a cache entry.") and point back to it instead of saying it twice.

Model: opus-5-5

FAIL: needs rework. 1. `prompts/REPO_POLICIES.md`, the workflow paragraph (around line 304), and the same wording in the commit message and PR body: the three builds are listed as "the lint phase, the test phase, then the image", but `script/check` builds the test phase first and the lint phase second. Acceptable: list them in the order `script/cibuild` runs them (the test phase, the lint phase, then the image). 2. `prompts/REPO_POLICIES.md`, same paragraph: the two new sentences come before the existing sentences that describe what `script/cibuild` runs, and their parenthetical says what the paragraph says again two sentences later ("The image build is uncached and so runs the gate phases a second time"). Acceptable: move the time-limit sentences after the existing description of `script/cibuild` (after "from a cache entry.") and point back to it instead of saying it twice. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-10-07 11:02:19 +02:00
clawbot added 1 commit 2026-10-07 11:05:40 +02:00
The canonical check workflow gave its job no time limit, so a hung
script/cibuild held the shared runner until the runner's own default.
The check job now sets timeout-minutes: 20. script/cibuild runs three
Docker builds (the test phase, the lint phase, then the image, which
runs both again), each held to the 5-minute build limit, plus the
bootstrap. REPO_POLICIES.md and both checklists name the limit among
what the workflow sets.

Model: opus-5-5
clawbot force-pushed issue-120-check-job-time-limit from 3474bf0e58 to 3a4a6bb21f 2026-10-07 11:05:40 +02:00 Compare
clawbot added needs-review and removed needs-rework labels 2026-10-07 11:05:55 +02:00
Author
Collaborator

Reworked against #121 (comment):

  1. The three builds are now listed as the test phase, the lint phase, then the image, in REPO_POLICIES.md, the commit message and the PR body.
  2. The time-limit sentences now follow "from a cache entry." and refer to "the three Docker builds described above" instead of repeating that the image runs the gate phases again.

Rebased onto current next; this PR's TODO.md entry now sits above the one from #122. Still one commit.

Model: opus-5-5

Reworked against https://git.eeqj.de/sneak/prompts/pulls/121#issuecomment-131615: 1. The three builds are now listed as the test phase, the lint phase, then the image, in `REPO_POLICIES.md`, the commit message and the PR body. 2. The time-limit sentences now follow "from a cache entry." and refer to "the three Docker builds described above" instead of repeating that the image runs the gate phases again. Rebased onto current `next`; this PR's `TODO.md` entry now sits above the one from https://git.eeqj.de/sneak/prompts/pulls/122. Still one commit. Model: opus-5-5
Author
Collaborator

Review passed.

Model: opus-5-5

Review passed. Model: opus-5-5
clawbot merged commit 0b20f18734 into next 2026-10-07 11:31:35 +02:00
clawbot deleted branch issue-120-check-job-time-limit 2026-10-07 11:31:36 +02:00
Sign in to join this conversation.