Assign the image tag on its own line in script/ (closes #101) #102

Merged
clawbot merged 1 commits from issue-101-own-line-tag into next 2026-10-06 02:52:24 +02:00
Collaborator

script/cibuild, script/docker, script/lint and script/test now assign the image tag from script/projectname to tag on its own line before docker build, then pass -t "$tag", "$tag-lint" or "$tag-test". Passed inline, a failing script/projectname did not trip set -e, and the script went on to docker build with an empty or -lint tag. The comment above the line in script/cibuild and script/docker now covers both the version and the tag. Both snippets in prompts/REPO_POLICIES.md show the same form.

Checked with the reproduction from #101 (a script/projectname that only does exit 1) in a scratch copy, with a stand-in docker that only reports being called:

  • script/cibuild stops with exit 1 before docker build.
  • script/docker stops with exit 1 before docker build.
  • script/lint stops with exit 1 before docker build.
  • script/test stops with exit 1 before docker build.
  • With the real script/projectname, the tags are prompts, prompts, prompts-lint and prompts-test.

Disclosures:

  • Judgement call: script/lint and script/test had no such comment; each now has a shorter one above the tag line.
  • Judgement call: REPO_POLICIES.md gains one sentence stating the own-line rule after "Every docker build in script/ is tagged"; its lint/test snippet shows one tag= line for both builds, though each script assigns its own.
  • For script/cibuild, the scratch copy also replaced script/bootstrap and script/check with exit 0; otherwise script/check stops first, inside script/test.

Model: opus-5-5

`script/cibuild`, `script/docker`, `script/lint` and `script/test` now assign the image tag from `script/projectname` to `tag` on its own line before `docker build`, then pass `-t "$tag"`, `"$tag-lint"` or `"$tag-test"`. Passed inline, a failing `script/projectname` did not trip `set -e`, and the script went on to `docker build` with an empty or `-lint` tag. The comment above the line in `script/cibuild` and `script/docker` now covers both the version and the tag. Both snippets in `prompts/REPO_POLICIES.md` show the same form. Checked with the reproduction from https://git.eeqj.de/sneak/prompts/issues/101 (a `script/projectname` that only does `exit 1`) in a scratch copy, with a stand-in `docker` that only reports being called: - `script/cibuild` stops with exit 1 before `docker build`. - `script/docker` stops with exit 1 before `docker build`. - `script/lint` stops with exit 1 before `docker build`. - `script/test` stops with exit 1 before `docker build`. - With the real `script/projectname`, the tags are `prompts`, `prompts`, `prompts-lint` and `prompts-test`. Disclosures: - Judgement call: `script/lint` and `script/test` had no such comment; each now has a shorter one above the tag line. - Judgement call: `REPO_POLICIES.md` gains one sentence stating the own-line rule after "Every `docker build` in `script/` is tagged"; its lint/test snippet shows one `tag=` line for both builds, though each script assigns its own. - For `script/cibuild`, the scratch copy also replaced `script/bootstrap` and `script/check` with `exit 0`; otherwise `script/check` stops first, inside `script/test`. Model: opus-5-5
clawbot added the needs-review label 2026-10-06 01:37:28 +02:00
clawbot self-assigned this 2026-10-06 01:37:28 +02:00
clawbot added 1 commit 2026-10-06 01:37:28 +02:00
script/cibuild, script/docker, script/lint and script/test passed the
tag from script/projectname inline to docker build, where a failing
command substitution does not trip set -e. Each now assigns it to `tag`
on its own line first, so the script stops where script/projectname
fails. The comment above it says why; the REPO_POLICIES.md snippets show
the same form.

Model: opus-5-5
Author
Collaborator

PASS: this meets #101 and its plan.

Judgement call: the script/docker and script/cibuild snippet in prompts/REPO_POLICIES.md still differs from those scripts in its comment wording and in calling script/projectname rather than "$SCRIPT_DIR/projectname", as it did before this change; I did not count it, because the policy says the scripts are identical across repositories, not that the snippet is a copy of them.

Model: opus-5-5

PASS: this meets https://git.eeqj.de/sneak/prompts/issues/101 and its plan. Judgement call: the `script/docker` and `script/cibuild` snippet in `prompts/REPO_POLICIES.md` still differs from those scripts in its comment wording and in calling `script/projectname` rather than `"$SCRIPT_DIR/projectname"`, as it did before this change; I did not count it, because the policy says the scripts are identical across repositories, not that the snippet is a copy of them. Model: opus-5-5
clawbot merged commit b09fff488b into next 2026-10-06 02:52:24 +02:00
clawbot deleted branch issue-101-own-line-tag 2026-10-06 02:52:24 +02:00
Sign in to join this conversation.