1 Commits

Author SHA1 Message Date
31082fc77d REPO_POLICIES: canonical golangci-lint is v2.13.2
All checks were successful
check / check (push) Successful in 43s
v2.12.2 is built with Go 1.26 and cannot check a module whose go
directive is 1.27, so repos on the current Go release cannot use the
canonical version. Asked for by
sneak/template-app-go#1 (item 7).

Model: fable-5-1
2026-09-05 04:44:53 +00:00
2 changed files with 7 additions and 22 deletions

View File

@@ -21,10 +21,6 @@ fmt-check, and commit.
# Completed Steps
- 2026-09-03: Added `-count=1` to both `go test` invocations in the canonical Go
`make test` example in `REPO_POLICIES.md`, so the target cannot report a
cached pass it did not earn, and documented that Go's test-result cache is a
second, independent cache stacked below the Docker layer cache.
- 2026-08-07: Set the canonical `.golangci.yml` to the org-standard v2-schema
config already deployed byte-identical across the org's Go repos (settings
under `linters.settings` so thresholds like lll/funlen/cyclop/dupl actually

View File

@@ -1,6 +1,6 @@
---
title: Repository Policies
last_modified: 2026-09-03
last_modified: 2026-09-05
---
This document covers repository structure, tooling, and workflow standards. Code
@@ -214,24 +214,11 @@ style conventions are in separate documents:
```makefile
test:
@go test -count=1 -timeout 90s -race -cover ./... || \
@go test -timeout 90s -race -cover ./... || \
{ echo "--- Rerunning with -v for details ---"; \
go test -count=1 -timeout 90s -race -v ./...; exit 1; }
go test -timeout 90s -race -v ./...; exit 1; }
```
`-count=1` is required on both invocations: it defeats Go's test _result_
cache, so the target cannot report a pass it did not earn, and the rerun
reproduces a failure instead of replaying it. It leaves the build cache
alone, so it costs the runtime of the suite and no recompilation.
Note that this is a second, independent cache, stacked below the Docker
layer cache that [issue #26](https://git.eeqj.de/sneak/prompts/issues/26)
addresses. `CHECK_EPOCH` guarantees the `RUN make test` _step_ re-executes;
it does not guarantee `go test` inside that step does any work, because the
`GOCACHE` baked into earlier image layers survives into the re-executed
step. They are two separate defects requiring two separate fixes, and a fix
for one must not be recorded as covering the other.
Python example:
```makefile
@@ -283,8 +270,10 @@ style conventions are in separate documents:
configuration changes are made to the canonical copy in the `prompts` repo and
reach consuming repos by re-vendoring; an agent may open a PR against
canonical, which only the user merges. The canonical golangci-lint version is
v2.12.2 (released 2026-05-06), installed commit-pinned via
`go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@c0d3ddc9cf3faa61a4e378e879ece580256d76e5`.
v2.13.2 (released 2026-08-27, built with Go 1.27; a linter built with an older
Go cannot check a module whose `go` directive is newer), installed
commit-pinned via
`go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@27774aaf853a4fd21f1dd5e69439459dc1b26e68`.
- When pinning images or packages by hash, add a comment above the reference
with the version and date (YYYY-MM-DD).