Compare commits
1
Commits
25de12a9e2
..
next
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
d673785d33 |
No files matched your search
@@ -261,8 +261,8 @@ with your task.
|
|||||||
|
|
||||||
- [ ] Platform-standard formatter is configured (`black`, `prettier`, and for Go
|
- [ ] Platform-standard formatter is configured (`black`, `prettier`, and for Go
|
||||||
`gofmt` then `golines -m 77`)
|
`gofmt` then `golines -m 77`)
|
||||||
- [ ] Default formatter config, except four-space indents (not Go) and the Go
|
- [ ] Default formatter config, except four-space indents (not Go),
|
||||||
77-column limit
|
`proseWrap: always` for Markdown, and the Go 77-column limit
|
||||||
- [ ] Go: `script/bootstrap` installs `golines` with `go install` pinned to a
|
- [ ] Go: `script/bootstrap` installs `golines` with `go install` pinned to a
|
||||||
commit hash; `script/fmt-check` fails when `gofmt` or `golines -m 77`
|
commit hash; `script/fmt-check` fails when `gofmt` or `golines -m 77`
|
||||||
would change a file
|
would change a file
|
||||||
|
|||||||
@@ -692,6 +692,11 @@ style conventions are in separate documents:
|
|||||||
go install github.com/segmentio/golines@8f32f0f7e89c30f572c7f2cd3b2a48016b9d8bbf
|
go install github.com/segmentio/golines@8f32f0f7e89c30f572c7f2cd3b2a48016b9d8bbf
|
||||||
```
|
```
|
||||||
|
|
||||||
|
`script/bootstrap` reads the installed version from the `mod` line of
|
||||||
|
`go version -m "$(command -v golines)"`, which reports `v0.13.0`. It does
|
||||||
|
not use `golines --version`, which prints `golines vdev` for a binary that
|
||||||
|
`go install` built.
|
||||||
|
|
||||||
`golines` cannot shorten every line: long string literals and comments stay
|
`golines` cannot shorten every line: long string literals and comments stay
|
||||||
as they are. golangci-lint's `lll` limit therefore stays at 88 columns, so
|
as they are. golangci-lint's `lll` limit therefore stays at 88 columns, so
|
||||||
it fails only lines far past the formatter's limit.
|
it fails only lines far past the formatter's limit.
|
||||||
|
|||||||
Reference in new issue
Block a user