prompts/REPO_POLICIES.md: the formatter list names gofmt then golines -m 77; script/fmt runs both, script/fmt-check fails when either would change a file, and script/bootstrap installs github.com/segmentio/golines v0.13.0 with go install pinned to its commit hash. Bootstrap reads the installed version from the mod line of go version -m, since golines --version prints golines vdev for a binary that go install built.
prompts/CODE_STYLEGUIDE_GO.md and both checklists say the same.
Judgement call: lll in .golangci.yml stays at 88. golines does not split long string literals or comments, so 77 would fail lines no formatter can fix. Leaving the file untouched also spares every repo a re-vendor.
Not in this PR: both Go templates still need the script/fmt, script/fmt-check and script/bootstrap change, each in its own repository:
Go code is formatted with `gofmt`, then `golines -m 77`, per sneak on https://git.eeqj.de/sneak/smallwebwaf/issues/215#issuecomment-170263. Implements https://git.eeqj.de/sneak/prompts/issues/160.
- `prompts/REPO_POLICIES.md`: the formatter list names `gofmt` then `golines -m 77`; `script/fmt` runs both, `script/fmt-check` fails when either would change a file, and `script/bootstrap` installs `github.com/segmentio/golines` v0.13.0 with `go install` pinned to its commit hash. Bootstrap reads the installed version from the `mod` line of `go version -m`, since `golines --version` prints `golines vdev` for a binary that `go install` built.
- `prompts/CODE_STYLEGUIDE_GO.md` and both checklists say the same.
Judgement call: `lll` in `.golangci.yml` stays at 88. `golines` does not split long string literals or comments, so 77 would fail lines no formatter can fix. Leaving the file untouched also spares every repo a re-vendor.
Not in this PR: both Go templates still need the `script/fmt`, `script/fmt-check` and `script/bootstrap` change, each in its own repository:
- `clawbot/go-template-repo`: https://git.eeqj.de/clawbot/go-template-repo/issues/2
- `sneak/template-app-go`: https://git.eeqj.de/sneak/template-app-go/issues/22
Model: opus-5-5
clawbot
self-assigned this 2026-11-07 04:09:03 +01:00
prompts/REPO_POLICIES.md, the new golines paragraph under the formatter list: it says script/bootstrap installs golines with go install pinned to a commit hash, but not how bootstrap reads the installed version. The same file's rule that bootstrap installs a pinned tool by comparing versions treats unrecognised --version output as a mismatch. A golines built by go install prints golines vdev for --version, so a template that follows both rules reinstalls golines on every bootstrap run. Acceptable: one sentence saying bootstrap reads the installed version from the mod line of go version -m "$(command -v golines)", which reports v0.13.0, not from golines --version.
PR body, the "Not in this PR" paragraph: it names only clawbot/go-template-repo. This repository's README, under "Template Repos", names sneak/template-app-go as the Go template to update when policies change, and its script/fmt also runs plain gofmt. The body also never links the issue it implements. Acceptable: the body names both template repositories as still needing the script/fmt, script/fmt-check and script/bootstrap change, and links #160.
Open point, reading taken: the template part of the issue's definition of done cannot land in this repository, so I read it as follow-up work in those two repositories, not a defect here. The commit's (closes #160) closes the issue with that part undone unless it is tracked elsewhere.
Model: opus-5-5
**FAIL** (`needs-rework`)
1. `prompts/REPO_POLICIES.md`, the new `golines` paragraph under the formatter list: it says `script/bootstrap` installs `golines` with `go install` pinned to a commit hash, but not how bootstrap reads the installed version. The same file's rule that bootstrap installs a pinned tool by comparing versions treats unrecognised `--version` output as a mismatch. A `golines` built by `go install` prints `golines vdev` for `--version`, so a template that follows both rules reinstalls `golines` on every bootstrap run. Acceptable: one sentence saying bootstrap reads the installed version from the `mod` line of `go version -m "$(command -v golines)"`, which reports `v0.13.0`, not from `golines --version`.
2. PR body, the "Not in this PR" paragraph: it names only `clawbot/go-template-repo`. This repository's README, under "Template Repos", names `sneak/template-app-go` as the Go template to update when policies change, and its `script/fmt` also runs plain `gofmt`. The body also never links the issue it implements. Acceptable: the body names both template repositories as still needing the `script/fmt`, `script/fmt-check` and `script/bootstrap` change, and links https://git.eeqj.de/sneak/prompts/issues/160.
Open point, reading taken: the template part of the issue's definition of done cannot land in this repository, so I read it as follow-up work in those two repositories, not a defect here. The commit's `(closes #160)` closes the issue with that part undone unless it is tracked elsewhere.
Model: opus-5-5
For the reworker: fix both findings of the review above (#161 (comment)) as it says. The template work is now tracked on each template repository, clawbot/go-template-repo#2 and sneak/template-app-go#22, so the PR body links both, and #160. Keep one commit, run make check, and push with --force-with-lease.
Model: opus-5-5
**For the reworker:** fix both findings of the review above (https://git.eeqj.de/sneak/prompts/pulls/161#issuecomment-170299) as it says. The template work is now tracked on each template repository, https://git.eeqj.de/clawbot/go-template-repo/issues/2 and https://git.eeqj.de/sneak/template-app-go/issues/22, so the PR body links both, and https://git.eeqj.de/sneak/prompts/issues/160. Keep one commit, run `make check`, and push with `--force-with-lease`.
Model: opus-5-5
Fixed: prompts/REPO_POLICIES.md now says script/bootstrap reads the version from the mod line of go version -m "$(command -v golines)", not from golines --version. The pinned hash is the v0.13.0 tag, so the mod line reports v0.13.0.
Rework of https://git.eeqj.de/sneak/prompts/pulls/161#issuecomment-170299, now commit `f005c2d`:
1. Fixed: `prompts/REPO_POLICIES.md` now says `script/bootstrap` reads the version from the `mod` line of `go version -m "$(command -v golines)"`, not from `golines --version`. The pinned hash is the `v0.13.0` tag, so the `mod` line reports `v0.13.0`.
2. Fixed: the PR body names both templates with their issues, https://git.eeqj.de/clawbot/go-template-repo/issues/2 and https://git.eeqj.de/sneak/template-app-go/issues/22, and links https://git.eeqj.de/sneak/prompts/issues/160.
Model: opus-5-5
prompts/EXISTING_REPO_CHECKLIST.md, line 264, the "Default formatter config" item this PR rewrote: it reads as the complete list of exceptions to default formatter config, but omits proseWrap: always for Markdown. prompts/REPO_POLICIES.md now lists three exceptions: four-space indents, proseWrap: always and the Go 77-column limit. Someone working through the checklist would count proseWrap: always as a deviation to remove. Acceptable: the item names all three exceptions, matching prompts/REPO_POLICIES.md, for example "Default formatter config, except four-space indents (not Go), proseWrap: always for Markdown, and the Go 77-column limit". Keep one commit and run make fmt.
Model: opus-5-5
**FAIL** (`needs-rework`)
1. `prompts/EXISTING_REPO_CHECKLIST.md`, line 264, the "Default formatter config" item this PR rewrote: it reads as the complete list of exceptions to default formatter config, but omits `proseWrap: always` for Markdown. `prompts/REPO_POLICIES.md` now lists three exceptions: four-space indents, `proseWrap: always` and the Go 77-column limit. Someone working through the checklist would count `proseWrap: always` as a deviation to remove. Acceptable: the item names all three exceptions, matching `prompts/REPO_POLICIES.md`, for example "Default formatter config, except four-space indents (not Go), `proseWrap: always` for Markdown, and the Go 77-column limit". Keep one commit and run `make fmt`.
Model: opus-5-5
For the reworker: make exactly the one change the review above asks (#161 (comment)). The "Default formatter config" item at prompts/EXISTING_REPO_CHECKLIST.md:264 names all three exceptions, as REPO_POLICIES.md does: four-space indents (not Go), proseWrap: always for Markdown, and the Go 77-column limit. Change nothing else. Keep one commit, run make fmt and make check, and push with --force-with-lease. The top-level manager then checks this one point and merges.
Model: opus-5-5
**For the reworker:** make exactly the one change the review above asks (https://git.eeqj.de/sneak/prompts/pulls/161#issuecomment-170335). The "Default formatter config" item at `prompts/EXISTING_REPO_CHECKLIST.md:264` names all three exceptions, as `REPO_POLICIES.md` does: four-space indents (not Go), `proseWrap: always` for Markdown, and the Go 77-column limit. Change nothing else. Keep one commit, run `make fmt` and `make check`, and push with `--force-with-lease`. The top-level manager then checks this one point and merges.
Model: opus-5-5
REPO_POLICIES names gofmt then golines -m 77 as the Go formatter, says
what script/fmt, script/fmt-check and script/bootstrap do, and pins
golines v0.13.0 by commit hash. The Go style guide and both checklists
agree. lll stays at 88: golines leaves long strings and comments alone.
Model: opus-5-5
Fixed: the "Default formatter config" item in prompts/EXISTING_REPO_CHECKLIST.md names all three exceptions: four-space indents (not Go), proseWrap: always for Markdown, and the Go 77-column limit.
Model: opus-5-5
Rework of https://git.eeqj.de/sneak/prompts/pulls/161#issuecomment-170335, now commit `1d5923a`:
1. Fixed: the "Default formatter config" item in `prompts/EXISTING_REPO_CHECKLIST.md` names all three exceptions: four-space indents (not Go), `proseWrap: always` for Markdown, and the Go 77-column limit.
Model: opus-5-5
clawbot
merged commit d673785d33 into next2026-11-07 05:21:33 +01:00
Checked by the top-level manager against the review's one point (#161 (comment)): the checklist item names all three exceptions. Squash-merged into next.
Model: opus-5-5
Checked by the top-level manager against the review's one point (https://git.eeqj.de/sneak/prompts/pulls/161#issuecomment-170335): the checklist item names all three exceptions. Squash-merged into `next`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Go code is formatted with
gofmt, thengolines -m 77, per sneak on sneak/smallwebwaf#215 (comment). Implements #160.prompts/REPO_POLICIES.md: the formatter list namesgofmtthengolines -m 77;script/fmtruns both,script/fmt-checkfails when either would change a file, andscript/bootstrapinstallsgithub.com/segmentio/golinesv0.13.0 withgo installpinned to its commit hash. Bootstrap reads the installed version from themodline ofgo version -m, sincegolines --versionprintsgolines vdevfor a binary thatgo installbuilt.prompts/CODE_STYLEGUIDE_GO.mdand both checklists say the same.Judgement call:
lllin.golangci.ymlstays at 88.golinesdoes not split long string literals or comments, so 77 would fail lines no formatter can fix. Leaving the file untouched also spares every repo a re-vendor.Not in this PR: both Go templates still need the
script/fmt,script/fmt-checkandscript/bootstrapchange, each in its own repository:clawbot/go-template-repo: clawbot/go-template-repo#2sneak/template-app-go: sneak/template-app-go#22Model: opus-5-5
FAIL (
needs-rework)prompts/REPO_POLICIES.md, the newgolinesparagraph under the formatter list: it saysscript/bootstrapinstallsgolineswithgo installpinned to a commit hash, but not how bootstrap reads the installed version. The same file's rule that bootstrap installs a pinned tool by comparing versions treats unrecognised--versionoutput as a mismatch. Agolinesbuilt bygo installprintsgolines vdevfor--version, so a template that follows both rules reinstallsgolineson every bootstrap run. Acceptable: one sentence saying bootstrap reads the installed version from themodline ofgo version -m "$(command -v golines)", which reportsv0.13.0, not fromgolines --version.clawbot/go-template-repo. This repository's README, under "Template Repos", namessneak/template-app-goas the Go template to update when policies change, and itsscript/fmtalso runs plaingofmt. The body also never links the issue it implements. Acceptable: the body names both template repositories as still needing thescript/fmt,script/fmt-checkandscript/bootstrapchange, and links #160.Open point, reading taken: the template part of the issue's definition of done cannot land in this repository, so I read it as follow-up work in those two repositories, not a defect here. The commit's
(closes #160)closes the issue with that part undone unless it is tracked elsewhere.Model: opus-5-5
For the reworker: fix both findings of the review above (#161 (comment)) as it says. The template work is now tracked on each template repository, clawbot/go-template-repo#2 and sneak/template-app-go#22, so the PR body links both, and #160. Keep one commit, run
make check, and push with--force-with-lease.Model: opus-5-5
25de12a9e2tof005c2de88Rework of #161 (comment), now commit
f005c2d:prompts/REPO_POLICIES.mdnow saysscript/bootstrapreads the version from themodline ofgo version -m "$(command -v golines)", not fromgolines --version. The pinned hash is thev0.13.0tag, so themodline reportsv0.13.0.Model: opus-5-5
FAIL (
needs-rework)prompts/EXISTING_REPO_CHECKLIST.md, line 264, the "Default formatter config" item this PR rewrote: it reads as the complete list of exceptions to default formatter config, but omitsproseWrap: alwaysfor Markdown.prompts/REPO_POLICIES.mdnow lists three exceptions: four-space indents,proseWrap: alwaysand the Go 77-column limit. Someone working through the checklist would countproseWrap: alwaysas a deviation to remove. Acceptable: the item names all three exceptions, matchingprompts/REPO_POLICIES.md, for example "Default formatter config, except four-space indents (not Go),proseWrap: alwaysfor Markdown, and the Go 77-column limit". Keep one commit and runmake fmt.Model: opus-5-5
For the reworker: make exactly the one change the review above asks (#161 (comment)). The "Default formatter config" item at
prompts/EXISTING_REPO_CHECKLIST.md:264names all three exceptions, asREPO_POLICIES.mddoes: four-space indents (not Go),proseWrap: alwaysfor Markdown, and the Go 77-column limit. Change nothing else. Keep one commit, runmake fmtandmake check, and push with--force-with-lease. The top-level manager then checks this one point and merges.Model: opus-5-5
f005c2de88to1d5923ac4fRework of #161 (comment), now commit
1d5923a:prompts/EXISTING_REPO_CHECKLIST.mdnames all three exceptions: four-space indents (not Go),proseWrap: alwaysfor Markdown, and the Go 77-column limit.Model: opus-5-5
Checked by the top-level manager against the review's one point (#161 (comment)): the checklist item names all three exceptions. Squash-merged into
next.Model: opus-5-5