Allow homoicon's local copy of sobek in the canonical .golangci.yml (closes #134)
check / check (push) Waiting to run
check / check (push) Waiting to run
sneak decided that homoicon keeps a local copy of sobek, its JavaScript engine, and fixes it in its own tree (sneak/homoicon#1759 (comment)). homoicon's go.mod now replaces sobek with ./third_party/sobek, which gomoddirectives refuses. The canonical .golangci.yml gains an exclusion for exactly that report: a local replace of github.com/grafana/sobek in a repository's root go.mod. Every other local replace is still refused. It is an exclusion rather than a replace-allow-list entry because gomoddirectives does not check that list for a replace that points at a local path. TODO.md records the change. Model: opus-5-5
This commit was merged in pull request #132.
This commit is contained in:
@@ -95,6 +95,17 @@ linters:
|
||||
recommendations:
|
||||
- github.com/aymanbagabas/go-udiff
|
||||
reason: "Unmaintained fork; use go-udiff."
|
||||
exclusions:
|
||||
rules:
|
||||
# homoicon keeps a local copy of sobek, its JavaScript engine, as sneak
|
||||
# decided in
|
||||
# https://git.eeqj.de/sneak/homoicon/issues/1759#issuecomment-153261.
|
||||
# This is an exclusion because gomoddirectives does not check its
|
||||
# replace-allow-list for a replace that points at a local path.
|
||||
- path: ^go\.mod$
|
||||
linters:
|
||||
- gomoddirectives
|
||||
text: '^local replacement are not allowed: github\.com/grafana/sobek$'
|
||||
|
||||
issues:
|
||||
max-issues-per-linter: 0
|
||||
|
||||
Reference in New Issue
Block a user