Correct the phase-build comments in script/lint and script/test (closes #141)
check / check (push) Successful in 24s
check / check (push) Successful in 24s
The comments said a phase that is not the last stage is built only when --target names it. The canonical Dockerfile's last stage copies from both phases, so a plain build builds them too. The comments now say what --target does in every repository: it builds that phase and the stages it depends on, nothing else. The headers no longer say each script builds its phase alone, which is false wherever the phase depends on another stage. Model: opus-5-5
This commit is contained in:
1 parent
11245b85ca
commit
0f70ae6817
2 files changed
+6
-6
No files matched your search
+3
-3
@@ -1,11 +1,11 @@
|
||||
#!/bin/sh
|
||||
# script/lint: run the linter. Linting is a phase of the Dockerfile and
|
||||
# this builds that phase alone; the linter is never installed or run on
|
||||
# this builds that phase; the linter is never installed or run on
|
||||
# a developer host, where a shared result cache and a host-global lock
|
||||
# make its answer untrustworthy.
|
||||
#
|
||||
# The phase is not the last stage in the file, so it is built only when
|
||||
# --target names it. A new CACHEBUST value reruns every RUN step after
|
||||
# --target builds the lint phase and the stages it depends on, nothing
|
||||
# else. A new CACHEBUST value reruns every RUN step after
|
||||
# the ARG CACHEBUST line, since a cached lint layer is a lint that did
|
||||
# not run; unlike --no-cache, it keeps the layers above that line and
|
||||
# the cache mounts. This relies on every stage of the Dockerfile
|
||||
|
||||
Reference in new issue
Block a user