clawbot
fc511cd2d7
check / check (push) Failing after 1s
The old backend/.golangci.yml declared version "2" but used v1 schema keys, so under v2 it never validated and its thresholds were inert: the linter ran at defaults. Replace it verbatim with the org-standard file, repin the Dockerfile.backend lint stage to golangci-lint v2.12.2, and assert the config's sha256 as the first step of the backend lint target so it cannot silently drift again -- a local hash check, no network. Fix every finding the standard config surfaces in the Go source: wrap over-long lines, drop a dead //nolint:wsl, hoist the repeated test IP literals in middleware_test.go to named constants (goconst), and switch its request to NewRequestWithContext (noctx). TODO.md updated. Model: opus-4-8
151 lines
2.8 KiB
Go
151 lines
2.8 KiB
Go
// Package server provides the HTTP server lifecycle,
|
|
// including startup, routing, signal handling, and graceful
|
|
// shutdown.
|
|
package server
|
|
|
|
import (
|
|
"context"
|
|
"log/slog"
|
|
"net/http"
|
|
"os"
|
|
"os/signal"
|
|
"syscall"
|
|
"time"
|
|
|
|
"sneak.berlin/go/netwatch/internal/config"
|
|
"sneak.berlin/go/netwatch/internal/globals"
|
|
"sneak.berlin/go/netwatch/internal/handlers"
|
|
"sneak.berlin/go/netwatch/internal/logger"
|
|
"sneak.berlin/go/netwatch/internal/middleware"
|
|
|
|
"github.com/go-chi/chi/v5"
|
|
"go.uber.org/fx"
|
|
)
|
|
|
|
// Params defines the dependencies for Server.
|
|
type Params struct {
|
|
fx.In
|
|
|
|
Config *config.Config
|
|
Globals *globals.Globals
|
|
Handlers *handlers.Handlers
|
|
Logger *logger.Logger
|
|
Middleware *middleware.Middleware
|
|
}
|
|
|
|
// Server is the top-level HTTP server orchestrator.
|
|
type Server struct {
|
|
cancelFunc context.CancelFunc
|
|
exitCode int
|
|
h *handlers.Handlers
|
|
httpServer *http.Server
|
|
log *slog.Logger
|
|
mw *middleware.Middleware
|
|
params Params
|
|
router *chi.Mux
|
|
startupTime time.Time
|
|
}
|
|
|
|
// New creates a Server and registers lifecycle hooks for
|
|
// starting and stopping it.
|
|
func New(
|
|
lc fx.Lifecycle,
|
|
params Params,
|
|
) (*Server, error) {
|
|
s := new(Server)
|
|
s.params = params
|
|
s.mw = params.Middleware
|
|
s.h = params.Handlers
|
|
s.log = params.Logger.Get()
|
|
|
|
lc.Append(fx.Hook{
|
|
OnStart: func(_ context.Context) error {
|
|
s.startupTime = time.Now().UTC()
|
|
|
|
// The fx OnStart context is scoped to startup and is
|
|
// cancelled once the hook returns; run() derives its
|
|
// own context instead of inheriting this one.
|
|
go func() { //nolint:contextcheck // see comment above
|
|
s.run()
|
|
}()
|
|
|
|
return nil
|
|
},
|
|
OnStop: func(_ context.Context) error {
|
|
if s.cancelFunc != nil {
|
|
s.cancelFunc()
|
|
}
|
|
|
|
return nil
|
|
},
|
|
})
|
|
|
|
return s, nil
|
|
}
|
|
|
|
// ServeHTTP delegates to the chi router.
|
|
func (s *Server) ServeHTTP(
|
|
w http.ResponseWriter,
|
|
r *http.Request,
|
|
) {
|
|
s.router.ServeHTTP(w, r)
|
|
}
|
|
|
|
func (s *Server) run() {
|
|
exitCode := s.serve()
|
|
os.Exit(exitCode)
|
|
}
|
|
|
|
func (s *Server) serve() int {
|
|
var ctx context.Context
|
|
|
|
ctx, s.cancelFunc = context.WithCancel(
|
|
context.Background(),
|
|
)
|
|
|
|
go func() {
|
|
c := make(chan os.Signal, 1)
|
|
|
|
signal.Ignore(syscall.SIGPIPE)
|
|
signal.Notify(c, os.Interrupt, syscall.SIGTERM)
|
|
|
|
sig := <-c
|
|
s.log.Info("signal received", "signal", sig)
|
|
|
|
if s.cancelFunc != nil {
|
|
s.cancelFunc()
|
|
}
|
|
}()
|
|
|
|
go func() {
|
|
s.serveUntilShutdown()
|
|
}()
|
|
|
|
<-ctx.Done()
|
|
s.cleanShutdown()
|
|
|
|
return s.exitCode
|
|
}
|
|
|
|
const shutdownTimeout = 5 * time.Second
|
|
|
|
func (s *Server) cleanShutdown() {
|
|
s.exitCode = 0
|
|
|
|
ctxShutdown, shutdownCancel := context.WithTimeout(
|
|
context.Background(),
|
|
shutdownTimeout,
|
|
)
|
|
defer shutdownCancel()
|
|
|
|
err := s.httpServer.Shutdown(ctxShutdown)
|
|
if err != nil {
|
|
s.log.Error(
|
|
"server clean shutdown failed",
|
|
"error", err,
|
|
)
|
|
}
|
|
|
|
s.log.Info("server stopped")
|
|
}
|