Footer says what a latency figure is (closes #208) #214

Merged
clawbot merged 1 commits from issue-208-footer-latency into next 2026-11-11 23:10:34 +01:00
Collaborator

The footer's first line now reads "Latency: the time until a target's response headers arrive", the decided wording on #208. The old line said every check is a GET and that CORS may affect figures; the S3 targets are checked with HEAD, and a no-cors check counts any answer.

No test added: the change is fixed copy, and a test would only repeat the string.

closes #208

Model: opus-5-5

The footer's first line now reads "Latency: the time until a target's response headers arrive", the decided wording on https://git.eeqj.de/sneak/netwatch/issues/208. The old line said every check is a `GET` and that CORS may affect figures; the S3 targets are checked with `HEAD`, and a `no-cors` check counts any answer. No test added: the change is fixed copy, and a test would only repeat the string. closes https://git.eeqj.de/sneak/netwatch/issues/208 Model: opus-5-5
clawbot added the needs-review label 2026-11-11 21:26:27 +01:00
clawbot self-assigned this 2026-11-11 21:26:27 +01:00
Author
Collaborator

Verdict: FAIL
Head: 8c4c823bb5

needs-rework. The code change is correct. Both findings are in the PR description: edit it, no new commit needed.

  1. PR description, first paragraph: the HTTP methods are bare ("every check is a GET", "checked with HEAD"), while no-cors beside them is in backticks. Verbatim tokens go in backticks in markdown. Write GET and HEAD, as README.md and the issue do.
  2. PR description, the closing-keyword line: it names the issue by bare number. Write closes https://git.eeqj.de/sneak/netwatch/issues/208 instead, as the sibling PRs do.

Model: opus-5-5

Verdict: FAIL Head: 8c4c823bb5f776300a070786c6c8b5223257bc7e `needs-rework`. The code change is correct. Both findings are in the PR description: edit it, no new commit needed. 1. PR description, first paragraph: the HTTP methods are bare ("every check is a GET", "checked with HEAD"), while `no-cors` beside them is in backticks. Verbatim tokens go in backticks in markdown. Write `GET` and `HEAD`, as `README.md` and the issue do. 2. PR description, the closing-keyword line: it names the issue by bare number. Write `closes https://git.eeqj.de/sneak/netwatch/issues/208` instead, as the sibling PRs do. Model: opus-5-5
clawbot added 1 commit 2026-11-11 22:27:44 +01:00
The old line said every check is a GET and that CORS may affect
figures; the S3 targets use HEAD and a no-cors check counts any answer.

Model: opus-5-5
clawbot force-pushed issue-208-footer-latency from 8c4c823bb5 to 02dbb41aa7 2026-11-11 22:27:44 +01:00 Compare
Author
Collaborator
  1. Done: the description writes GET and HEAD.
  2. Done: the closing line names the issue by its full link.

Rebased onto next, head 02dbb41; the diff is unchanged.

Model: opus-5-5

1. Done: the description writes `GET` and `HEAD`. 2. Done: the closing line names the issue by its full link. Rebased onto `next`, head `02dbb41`; the diff is unchanged. Model: opus-5-5
Author
Collaborator

Verdict: PASS
Head: 02dbb41aa7

The footer's first line in buildUI now reads exactly the wording the issue decided, and nothing else changes.

Judgement call: no test added, accepted; the repo's tests do not assert fixed page text.

Model: opus-5-5

Verdict: PASS Head: 02dbb41aa7560f6bbee1365bc1c0be3b3290e047 The footer's first line in `buildUI` now reads exactly the wording the issue decided, and nothing else changes. Judgement call: no test added, accepted; the repo's tests do not assert fixed page text. Model: opus-5-5
clawbot merged commit dd119a0e46 into next 2026-11-11 23:10:34 +01:00
clawbot deleted branch issue-208-footer-latency 2026-11-11 23:10:34 +01:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/netwatch#214