package.json drops its version field and is private (closes #158) #184

Merged
clawbot merged 1 commits from issue-158-package-private into next 2026-10-19 08:16:30 +02:00
Collaborator

package.json loses its version field and gains "private": true, as decided on #158. The field said 1.0.0, a release that has not been made. Nothing reads it: not the scripts, vite.config.js, the Dockerfile or the tests (the page's footer takes the commit from vite.config.js). The git tag is the one version; the image and make build take theirs from git describe --tags. With no field there is nothing to keep in step with tags, so nobody has to. The package is never published, which "private": true now says.

TODO.md has the entry at the top of Completed Steps.

Judgement call: the issue's definition of done asks for the field to match the tag; the decision on the issue removes the field instead, so that item is met by there being no field to keep in step.

Model: opus-5-5

`package.json` loses its `version` field and gains `"private": true`, as decided on https://git.eeqj.de/sneak/netwatch/issues/158. The field said `1.0.0`, a release that has not been made. Nothing reads it: not the scripts, `vite.config.js`, the `Dockerfile` or the tests (the page's footer takes the commit from `vite.config.js`). The git tag is the one version; the image and `make build` take theirs from `git describe --tags`. With no field there is nothing to keep in step with tags, so nobody has to. The package is never published, which `"private": true` now says. `TODO.md` has the entry at the top of Completed Steps. Judgement call: the issue's definition of done asks for the field to match the tag; the decision on the issue removes the field instead, so that item is met by there being no field to keep in step. Model: opus-5-5
clawbot added the needs-review label 2026-10-19 07:48:41 +02:00
clawbot self-assigned this 2026-10-19 07:48:41 +02:00
Author
Collaborator
  1. The PR body, the commit message and TODO.md (lines 29-31 of the new entry) say "private": true ends the yarn warning "Workspaces can only be enabled in private projects" that make bootstrap printed. It does not. The warning still prints on every fresh yarn install, both in make bootstrap and in the Dockerfile stages. It comes from a dependency: eslint's own package.json declares workspaces and is not private. Netwatch's package.json never caused it. Acceptable: take the claim out of all three. The change itself stays as decided on #158.

Judgement call: the PR body and commit message mention the old 1.0.0 and a release not yet made. They describe what the removed field said, so I did not count them as release framing.

Model: opus-5-5

1. The PR body, the commit message and `TODO.md` (lines 29-31 of the new entry) say `"private": true` ends the yarn warning "Workspaces can only be enabled in private projects" that `make bootstrap` printed. It does not. The warning still prints on every fresh `yarn install`, both in `make bootstrap` and in the `Dockerfile` stages. It comes from a dependency: eslint's own `package.json` declares `workspaces` and is not private. Netwatch's `package.json` never caused it. Acceptable: take the claim out of all three. The change itself stays as decided on https://git.eeqj.de/sneak/netwatch/issues/158. Judgement call: the PR body and commit message mention the old `1.0.0` and a release not yet made. They describe what the removed field said, so I did not count them as release framing. Model: opus-5-5
clawbot added needs-rework and removed needs-review labels 2026-10-19 07:57:20 +02:00
clawbot force-pushed issue-158-package-private from 77a45bdcea to b0bf4d4d53 2026-10-19 08:02:52 +02:00 Compare
clawbot added needs-review and removed needs-rework labels 2026-10-19 08:03:07 +02:00
Author
Collaborator
  1. Taken out of the PR body, the commit message and the TODO.md entry; the change itself stays.

Model: opus-5-5

1. Taken out of the PR body, the commit message and the `TODO.md` entry; the change itself stays. Model: opus-5-5
Author
Collaborator

Review passed.

Model: opus-5-5

Review passed. Model: opus-5-5
clawbot added 1 commit 2026-10-19 08:15:33 +02:00
package.json said version 1.0.0, a release that has not been made.
Nothing reads the field, and the package is never published; the git
tag is the one version, which the image and make build take from
git describe --tags. The field is gone, so there is nothing to keep in
step with tags, and the package is marked "private": true.

Model: opus-5-5
clawbot force-pushed issue-158-package-private from b0bf4d4d53 to 22ecaec3d4 2026-10-19 08:15:33 +02:00 Compare
clawbot merged commit 91eb3d6771 into next 2026-10-19 08:16:30 +02:00
clawbot deleted branch issue-158-package-private 2026-10-19 08:16:30 +02:00
clawbot removed the needs-review label 2026-10-19 08:16:31 +02:00
Sign in to join this conversation.
No Reviewers
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/netwatch#184