The three unit tests of a check whose result is discarded (its round given up, the user paused, or the first round) checked only that the host's row showed nothing. The guard in tick also keeps the result out of the host's history and status and keeps logCheck from writing to the console, so a change that recorded the result and skipped only the row kept all three passing. Each test now also checks that the answering host's history is still empty, its status still pending, and that nothing went to console.error or console.info. Moving the guard to just before the row update, as #151 describes, makes all three fail; web/src/main.js is unchanged.
Things the diff does not make obvious:
Judgement call: the three test names now say "is not recorded and does not show in its row", and the comment above them says the same, since the tests now check more than the row.
Judgement call: the consoleLines helper moved up to the other helpers at the top of the file, as these tests now use it before its old place.
status is compared with pending and history with an empty list, as each test's host is new and that is how it starts.
Model: opus-5-5
The three unit tests of a check whose result is discarded (its round given up, the user paused, or the first round) checked only that the host's row showed nothing. The guard in `tick` also keeps the result out of the host's history and status and keeps `logCheck` from writing to the console, so a change that recorded the result and skipped only the row kept all three passing. Each test now also checks that the answering host's `history` is still empty, its `status` still `pending`, and that nothing went to `console.error` or `console.info`. Moving the guard to just before the row update, as https://git.eeqj.de/sneak/netwatch/issues/151 describes, makes all three fail; `web/src/main.js` is unchanged.
Things the diff does not make obvious:
- Judgement call: the three test names now say "is not recorded and does not show in its row", and the comment above them says the same, since the tests now check more than the row.
- Judgement call: the `consoleLines` helper moved up to the other helpers at the top of the file, as these tests now use it before its old place.
- `status` is compared with `pending` and `history` with an empty list, as each test's host is new and that is how it starts.
Model: opus-5-5
The three unit tests of a check whose result is discarded (its round
given up, the user paused, or the first round) checked only that the
row showed nothing. Each now also checks that the host's history is
still empty, its status still pending, and nothing was written to the
console, so a change that recorded the result and skipped only the row
fails them. The console helper moves above its first use.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The three unit tests of a check whose result is discarded (its round given up, the user paused, or the first round) checked only that the host's row showed nothing. The guard in
tickalso keeps the result out of the host's history and status and keepslogCheckfrom writing to the console, so a change that recorded the result and skipped only the row kept all three passing. Each test now also checks that the answering host'shistoryis still empty, itsstatusstillpending, and that nothing went toconsole.errororconsole.info. Moving the guard to just before the row update, as #151 describes, makes all three fail;web/src/main.jsis unchanged.Things the diff does not make obvious:
consoleLineshelper moved up to the other helpers at the top of the file, as these tests now use it before its old place.statusis compared withpendingandhistorywith an empty list, as each test's host is new and that is how it starts.Model: opus-5-5
Review passed.
Model: opus-5-5