reportbuf numbers report files with atomic.Uint64; the Go style guide asks for int types #161

Closed
opened 2026-10-14 16:08:49 +02:00 by clawbot · 2 comments
Collaborator

internal/reportbuf/reportbuf.go line 88, at v1.0.0-rc1: the report file sequence number is seq atomic.Uint64, read at line 324 with b.seq.Add(1).

How to see it: read the file.

What is right: prompts/CODE_STYLEGUIDE_GO.md item 3 (line 12 to 15): "Even if you are planning to deal with only positive integers, use int/int64 types instead of uint/uint64 types. This is for consistency and compatibility with the standard library." atomic.Int64 has the same Add method.

Severity: low. Style only; the names it produces are unchanged.

Definition of done

  • The sequence counter is atomic.Int64; file names are unchanged (TestTwoFlushesInOneMillisecond and TestReportFileHoldsTheLinesAppended in internal/reportbuf/reportbuf_test.go still pass).
  • TODO.md updated in the same commit; commit title ends (closes #N) with this issue's number.

Model: fable-5-1

`internal/reportbuf/reportbuf.go` line 88, at `v1.0.0-rc1`: the report file sequence number is `seq atomic.Uint64`, read at line 324 with `b.seq.Add(1)`. **How to see it**: read the file. **What is right**: `prompts/CODE_STYLEGUIDE_GO.md` item 3 (line 12 to 15): "Even if you are planning to deal with only positive integers, use `int`/`int64` types instead of `uint`/`uint64` types. This is for consistency and compatibility with the standard library." `atomic.Int64` has the same `Add` method. **Severity**: low. Style only; the names it produces are unchanged. ## Definition of done - [ ] The sequence counter is `atomic.Int64`; file names are unchanged (`TestTwoFlushesInOneMillisecond` and `TestReportFileHoldsTheLinesAppended` in `internal/reportbuf/reportbuf_test.go` still pass). - [ ] `TODO.md` updated in the same commit; commit title ends ` (closes #N)` with this issue's number. Model: fable-5-1
clawbot self-assigned this 2026-10-14 16:08:49 +02:00
Author
Collaborator

Done in #169, which covers #148 and #161 in one commit.

Model: opus-5-5

Done in https://git.eeqj.de/sneak/netwatch/pulls/169, which covers https://git.eeqj.de/sneak/netwatch/issues/148 and https://git.eeqj.de/sneak/netwatch/issues/161 in one commit. Model: opus-5-5
Author
Collaborator

Fixed in #169.

Model: opus-5-5

Fixed in https://git.eeqj.de/sneak/netwatch/pulls/169. Model: opus-5-5
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/netwatch#161