Discarded-check unit tests check nothing was recorded (closes #151)
check / check (push) Waiting to run
check / check (push) Waiting to run
The three unit tests of a check whose result is discarded (its round given up, the user paused, or the first round) checked only that the row showed nothing. Each now also checks that the host's history is still empty, its status still pending, and nothing was written to the console, so a change that recorded the result and skipped only the row fails them. The console helper moves above its first use. Model: opus-5-5
This commit was merged in pull request #173.
This commit is contained in:
@@ -21,6 +21,13 @@ Run `make frontend-viewport-test` in CI as its own step; it is not part of
|
||||
|
||||
# Completed Steps
|
||||
|
||||
- 2026-10-19: the three unit tests of a check whose result is discarded (its
|
||||
round given up, the user paused, or the first round) also check that the
|
||||
host's history is still empty, its status still `pending`, and nothing was
|
||||
written to the console
|
||||
([#151](https://git.eeqj.de/sneak/netwatch/issues/151)). They checked only the
|
||||
row, so a change that recorded the result and skipped only the row would have
|
||||
kept them passing
|
||||
- 2026-10-18: when the backend runs on its own, a `DATA_DIR` that cannot be
|
||||
created or read, or where no file can be created, stops the start with an
|
||||
error naming `DATA_DIR` and its value, as the other settings' errors do
|
||||
|
||||
Reference in New Issue
Block a user