Fix the data races that fail make test (closes #104)

Conversation 7 Commits 3 Files Changed 3

+49 -19

3 Commits

Author	SHA1	Message	Date
sneak	526cda9ebb	Raise the go test timeout so internal/handlers fits check / check (push) Successful in 3m11s Details With the two races fixed, internal/handlers still hit the 30s -timeout in the Docker build. Its time is real work, not clock waits: each test starts its own server and in-memory database, and each new session writes its welcome lines to the database one row at a time, which the race detector slows down. The only clock waits are the one-second long poll and a 200ms pause. Measured in docker build --no-cache .: internal/handlers took 21-30s under -race, and over 30s in the review builds that timed out. Both go test runs in the test target now use -timeout 120s. The retry stays (#101). Model: opus-5-5	2026-10-01 23:52:17 +00:00
clawbot	6a200ea639	Read the IRC client's nick under its lock in the relay check / check (push) Successful in 3m4s Details After registration each IRC connection runs a second goroutine that sends queued messages to the client, and it read c.nick without holding c.mu. The goroutine that reads client commands changes c.nick under c.mu when the client sends NICK, so the race detector failed TestIntegrationTwoClients. Every read of c.nick in relay.go now takes c.mu. No other field that goroutine reads changes after it starts. Model: opus-5-5	2026-09-29 10:48:48 +00:00
clawbot	6a514b565c	Build the HTTP router before the server starts (closes #104 ) check / check (push) Successful in 2m22s Details The fx OnStart hook started a goroutine that built the router and then began serving, so OnStart returned before the router existed. Code that served requests through the started Server, as the internal/handlers tests do, raced with that goroutine or hit a nil router. OnStart now configures the server, enables Sentry and builds the router itself, and only then starts serving in the background. Sentry is set up first because the routes depend on whether it is enabled. Run, whose only caller was that hook, is folded into it. Model: opus-5-5	2026-09-29 10:40:36 +00:00

Author

SHA1

Message

Date

sneak

526cda9ebb

Raise the go test timeout so internal/handlers fits

check / check (push) Successful in 3m11s

Details

With the two races fixed, internal/handlers still hit the 30s
-timeout in the Docker build. Its time is real work, not clock
waits: each test starts its own server and in-memory database, and
each new session writes its welcome lines to the database one row at
a time, which the race detector slows down. The only clock waits are
the one-second long poll and a 200ms pause.

Measured in docker build --no-cache .: internal/handlers took 21-30s
under -race, and over 30s in the review builds that timed out.

Both go test runs in the test target now use -timeout 120s. The
retry stays (#101).

Model: opus-5-5

2026-10-01 23:52:17 +00:00

clawbot

6a200ea639

Read the IRC client's nick under its lock in the relay

check / check (push) Successful in 3m4s

Details

After registration each IRC connection runs a second goroutine that sends
queued messages to the client, and it read c.nick without holding c.mu.
The goroutine that reads client commands changes c.nick under c.mu when
the client sends NICK, so the race detector failed
TestIntegrationTwoClients. Every read of c.nick in relay.go now takes
c.mu. No other field that goroutine reads changes after it starts.

Model: opus-5-5

2026-09-29 10:48:48 +00:00

clawbot

6a514b565c

Build the HTTP router before the server starts (closes #104 )

check / check (push) Successful in 2m22s

Details

The fx OnStart hook started a goroutine that built the router and then
began serving, so OnStart returned before the router existed. Code that
served requests through the started Server, as the internal/handlers
tests do, raced with that goroutine or hit a nil router.

OnStart now configures the server, enables Sentry and builds the router
itself, and only then starts serving in the background. Sentry is set up
first because the routes depend on whether it is enabled. Run, whose
only caller was that hook, is folded into it.

Model: opus-5-5

2026-09-29 10:40:36 +00:00

Fix the data races that fail make test (closes #104) #105