In neoirc-cli, Alt and a digit switches to that window (initKeyCapture in internal/cli/ui.go calls ui.SwitchBuffer), but the app's send target stays what it was. Only /window, /w, /join and /query set it (internal/cli/app.go). So after Alt and a digit, the text the user types goes to the channel or user of the window they left, while the screen shows another. Found by the review of #215; read from the code on 83a1585.
Fix: switching windows with Alt and a digit sets the send target the same way /window does, including window 0, the status window, which has no target. Change nothing else.
Definition of done
After Alt and a digit, text without a / goes to the channel or user of the window now shown.
After Alt and 0, text without a / is not sent to the previous window's target.
Tests in internal/cli for both.
If README.md describes window switching in neoirc-cli, it says what the code now does.
One reviewed PR against next.
Model: opus-5-5
In `neoirc-cli`, Alt and a digit switches to that window (`initKeyCapture` in `internal/cli/ui.go` calls `ui.SwitchBuffer`), but the app's send target stays what it was. Only `/window`, `/w`, `/join` and `/query` set it (`internal/cli/app.go`). So after Alt and a digit, the text the user types goes to the channel or user of the window they left, while the screen shows another. Found by the review of https://git.eeqj.de/sneak/neoirc/pulls/215; read from the code on `83a1585`.
Fix: switching windows with Alt and a digit sets the send target the same way `/window` does, including window `0`, the status window, which has no target. Change nothing else.
## Definition of done
1. After Alt and a digit, text without a `/` goes to the channel or user of the window now shown.
2. After Alt and `0`, text without a `/` is not sent to the previous window's target.
3. Tests in `internal/cli` for both.
4. If `README.md` describes window switching in `neoirc-cli`, it says what the code now does.
5. One reviewed PR against `next`.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
In
neoirc-cli, Alt and a digit switches to that window (initKeyCaptureininternal/cli/ui.gocallsui.SwitchBuffer), but the app's send target stays what it was. Only/window,/w,/joinand/queryset it (internal/cli/app.go). So after Alt and a digit, the text the user types goes to the channel or user of the window they left, while the screen shows another. Found by the review of #215; read from the code on83a1585.Fix: switching windows with Alt and a digit sets the send target the same way
/windowdoes, including window0, the status window, which has no target. Change nothing else.Definition of done
/goes to the channel or user of the window now shown.0, text without a/is not sent to the previous window's target.internal/clifor both.README.mddescribes window switching inneoirc-cli, it says what the code now does.next.Model: opus-5-5