sneak
3bfbb3fbe2
All checks were successful
check / check (push) Successful in 35s
- Add canonical .golangci.yml (v2 schema, default: all, project thresholds for lll/funlen/cyclop/dupl) - Bump golangci-lint pins from v2.0.2 to v2.12.2 in Makefile (go install, new /v2 module path) and Dockerfile (tagged+digest Debian image pin) - Fix all lint findings surfaced by the new linter set across cmd/mfer, internal/bork, internal/cli, internal/log, and mfer: static sentinel errors (err113), context-aware HTTP and exec (noctx), guarded integer conversions and stricter permissions (gosec), named constants (mnd, goconst), function decomposition (funlen, cyclop, gocognit, nestif), declaration ordering (funcorder), t.Parallel/t.TempDir/t.Setenv adoption in tests (paralleltest, usetesting), protobuf getters (protogetter), plus formatting and style cleanups (wsl_v5, nlreturn, lll, revive, testifylint, and others) - Serialize CLI runs in tests behind a mutex so parallel tests do not cross-wire the process-global logger's captured output The decompositions are behavior-preserving. In particular: - REPO_POLICIES.md is untouched and stays byte-identical to the authoritative copy in the prompts repo - the mfer.manifest type stays unexported; whether to export it is an open owner design question (README question 13) - directories created by fetch keep mode 0755, because fetched trees are content meant to be readable by other uids - an absent MFFilePath.Mtime is handled explicitly and identically in freshen, list, and export rather than being read as the Unix epoch, which would classify every entry as changed and rewrite the manifest on every freshen - every user-visible error message renders byte-identically to what it did before, with the err113 sentinels wrapped mid-sentence where needed; the rendered strings are now pinned by tests Also fixes an argument-injection defect the lint pass surfaced: key IDs reach gpg as bare positional arguments, so a key ID beginning with "-" was parsed by gpg as an option. All positional arguments now follow an explicit "--" end-of-options marker. The symlink-escape gap in fetch's path handling, which sanitizePath does not and cannot address, is filed separately as #86.
73 lines
2.0 KiB
Go
73 lines
2.0 KiB
Go
package cli
|
|
|
|
import (
|
|
"io"
|
|
"os"
|
|
|
|
"github.com/spf13/afero"
|
|
)
|
|
|
|
// NoColor disables colored output when set. Automatically true if the
|
|
// NO_COLOR environment variable is present (per https://no-color.org/).
|
|
//
|
|
//nolint:gochecknoglobals // process-wide setting derived from the environment
|
|
var NoColor = noColorEnvSet()
|
|
|
|
// noColorEnvSet reports whether the NO_COLOR environment variable is
|
|
// present.
|
|
func noColorEnvSet() bool {
|
|
_, exists := os.LookupEnv("NO_COLOR")
|
|
|
|
return exists
|
|
}
|
|
|
|
// RunOptions contains all configuration for running the CLI application.
|
|
// Use DefaultRunOptions for standard CLI execution, or construct manually for testing.
|
|
type RunOptions struct {
|
|
Appname string // Application name displayed in help and version output
|
|
Version string // Version string (typically set at build time)
|
|
Gitrev string // Git revision hash (typically set at build time)
|
|
Args []string // Command-line arguments (typically os.Args)
|
|
Stdin io.Reader // Standard input stream
|
|
Stdout io.Writer // Standard output stream
|
|
Stderr io.Writer // Standard error stream
|
|
Fs afero.Fs // Filesystem abstraction for file operations
|
|
}
|
|
|
|
// DefaultRunOptions returns RunOptions configured for normal CLI execution.
|
|
func DefaultRunOptions(appname, version, gitrev string) *RunOptions {
|
|
return &RunOptions{
|
|
Appname: appname,
|
|
Version: version,
|
|
Gitrev: gitrev,
|
|
Args: os.Args,
|
|
Stdin: os.Stdin,
|
|
Stdout: os.Stdout,
|
|
Stderr: os.Stderr,
|
|
Fs: afero.NewOsFs(),
|
|
}
|
|
}
|
|
|
|
// Run creates and runs the CLI application with default options.
|
|
func Run(appname, version, gitrev string) int {
|
|
return RunWithOptions(DefaultRunOptions(appname, version, gitrev))
|
|
}
|
|
|
|
// RunWithOptions creates and runs the CLI application with the given options.
|
|
func RunWithOptions(opts *RunOptions) int {
|
|
m := &CLIApp{
|
|
appname: opts.Appname,
|
|
version: opts.Version,
|
|
gitrev: opts.Gitrev,
|
|
exitCode: 0,
|
|
Stdin: opts.Stdin,
|
|
Stdout: opts.Stdout,
|
|
Stderr: opts.Stderr,
|
|
Fs: opts.Fs,
|
|
}
|
|
|
|
m.run(opts.Args)
|
|
|
|
return m.exitCode
|
|
}
|