sneak
3bfbb3fbe2
All checks were successful
check / check (push) Successful in 35s
- Add canonical .golangci.yml (v2 schema, default: all, project thresholds for lll/funlen/cyclop/dupl) - Bump golangci-lint pins from v2.0.2 to v2.12.2 in Makefile (go install, new /v2 module path) and Dockerfile (tagged+digest Debian image pin) - Fix all lint findings surfaced by the new linter set across cmd/mfer, internal/bork, internal/cli, internal/log, and mfer: static sentinel errors (err113), context-aware HTTP and exec (noctx), guarded integer conversions and stricter permissions (gosec), named constants (mnd, goconst), function decomposition (funlen, cyclop, gocognit, nestif), declaration ordering (funcorder), t.Parallel/t.TempDir/t.Setenv adoption in tests (paralleltest, usetesting), protobuf getters (protogetter), plus formatting and style cleanups (wsl_v5, nlreturn, lll, revive, testifylint, and others) - Serialize CLI runs in tests behind a mutex so parallel tests do not cross-wire the process-global logger's captured output The decompositions are behavior-preserving. In particular: - REPO_POLICIES.md is untouched and stays byte-identical to the authoritative copy in the prompts repo - the mfer.manifest type stays unexported; whether to export it is an open owner design question (README question 13) - directories created by fetch keep mode 0755, because fetched trees are content meant to be readable by other uids - an absent MFFilePath.Mtime is handled explicitly and identically in freshen, list, and export rather than being read as the Unix epoch, which would classify every entry as changed and rewrite the manifest on every freshen - every user-visible error message renders byte-identically to what it did before, with the err113 sentinels wrapped mid-sentence where needed; the rendered strings are now pinned by tests Also fixes an argument-injection defect the lint pass surfaced: key IDs reach gpg as bare positional arguments, so a key ID beginning with "-" was parsed by gpg as an option. All positional arguments now follow an explicit "--" end-of-options marker. The symlink-escape gap in fetch's path handling, which sanitizePath does not and cannot address, is filed separately as #86.
94 lines
2.1 KiB
Makefile
94 lines
2.1 KiB
Makefile
export DOCKER_BUILDKIT := 1
|
|
export PROGRESS_NO_TRUNC := 1
|
|
GOPATH := $(shell go env GOPATH)
|
|
export PATH := $(PATH):$(GOPATH)/bin
|
|
PROTOC_GEN_GO := $(GOPATH)/bin/protoc-gen-go
|
|
SOURCEFILES := mfer/*.go mfer/*.proto internal/*/*.go cmd/*/*.go go.mod go.sum
|
|
ARCH := $(shell uname -m)
|
|
GITREV_BUILD := $(shell bash $(PWD)/bin/gitrev.sh 2>/dev/null || echo unknown)
|
|
APPNAME := mfer
|
|
VERSION := 0.1.0
|
|
export DOCKER_IMAGE_CACHE_DIR := $(HOME)/Library/Caches/Docker/$(APPNAME)-$(ARCH)
|
|
GOLDFLAGS += -X main.Version=$(VERSION)
|
|
GOLDFLAGS += -X main.Gitrev=$(GITREV_BUILD)
|
|
GOFLAGS := -ldflags "$(GOLDFLAGS)"
|
|
|
|
.PHONY: bootstrap setup docker default run ci test check lint fmt fmt-check hooks fixme
|
|
|
|
default: fmt test
|
|
|
|
bootstrap:
|
|
@script/bootstrap
|
|
|
|
setup:
|
|
@script/setup
|
|
|
|
run: ./bin/mfer
|
|
./$<
|
|
./$< gen
|
|
|
|
ci: test
|
|
|
|
test:
|
|
@script/test
|
|
|
|
$(PROTOC_GEN_GO):
|
|
test -e $(PROTOC_GEN_GO) || go install -v google.golang.org/protobuf/cmd/protoc-gen-go@v1.28.1
|
|
|
|
fixme:
|
|
@grep -nir fixme . | grep -v Makefile
|
|
|
|
check:
|
|
@script/check
|
|
|
|
fmt-check:
|
|
@script/fmt-check
|
|
|
|
hooks:
|
|
@script/install-precommit
|
|
|
|
devprereqs:
|
|
which golangci-lint || go install -v github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.12.2
|
|
|
|
mfer/mf.pb.go: mfer/mf.proto
|
|
cd mfer && go generate .
|
|
|
|
bin/mfer: $(SOURCEFILES) mfer/mf.pb.go
|
|
protoc --version
|
|
cd cmd/mfer && go build -tags urfave_cli_no_docs -o ../../bin/mfer $(GOFLAGS) .
|
|
|
|
clean:
|
|
rm -rfv mfer/*.pb.go bin/mfer cmd/mfer/mfer *.dockerimage
|
|
|
|
fmt:
|
|
@script/fmt
|
|
|
|
lint:
|
|
@script/lint
|
|
|
|
docker:
|
|
@script/docker
|
|
|
|
sneak-mfer.$(ARCH).tzst.dockerimage: $(SOURCEFILES) vendor.tzst modcache.tzst
|
|
docker build --progress plain --build-arg GITREV=$(GITREV_BUILD) -t sneak/mfer .
|
|
docker save sneak/mfer | pv | zstdmt -19 > $@
|
|
du -sh $@
|
|
|
|
godoc:
|
|
open http://127.0.0.1:6060
|
|
godoc -http=:6060
|
|
|
|
vendor.tzst: go.mod go.sum
|
|
go mod tidy
|
|
go mod vendor
|
|
cd vendor && tar -c . | pv | zstdmt -19 > $(PWD)/$@.tmp
|
|
rm -rf vendor
|
|
mv $@.tmp $@
|
|
|
|
modcache.tzst: go.mod go.sum
|
|
go mod tidy
|
|
cd $(HOME)/go/pkg && chmod -R u+rw . && rm -rf mod sumdb
|
|
go mod download -x
|
|
cd $(shell go env GOMODCACHE) && tar -c . | pv | zstdmt -19 > $(PWD)/$@.tmp
|
|
mv $@.tmp $@
|