Set go_package to the sneak.berlin/go/mfer module path (closes #79) #144

Merged
clawbot merged 1 commits from issue-79-go-package into next 2026-10-04 16:02:21 +02:00
Collaborator

Closes #79.

mfer/mf.proto named git.eeqj.de/sneak/mfer/mfer as its Go package, disagreeing with the sneak.berlin/go/mfer module path that go.mod declares. go_package is now sneak.berlin/go/mfer/mfer: the full import path of the package in the mfer/ subdirectory, as the code that imports it already writes it.

mfer/mf.pb.go is regenerated with make generate using protoc 33.4 and protoc-gen-go v1.36.11, the versions in its header. The only change is the go_package string inside the embedded file descriptor, plus its two length bytes. mfer/mf.proto.sha256 records the new hash.

Nothing else in the tree uses git.eeqj.de/sneak/mfer as an import path. The remaining mentions in README.md and FORMAT.md are links to the repository web page and its git clone URL, so they stay.

https://sneak.berlin/go/mfer?go-get=1 still serves the go-import meta tag pointing at https://git.eeqj.de/sneak/mfer (after a redirect to api.sneak.cloud/goredirector), and resolving sneak.berlin/go/mfer@latest directly from a clean module cache reaches this repository.

  • Unverified: go install sneak.berlin/go/mfer/cmd/mfer@latest, named in the issue's definition of done, was not run. Only module resolution was checked, because @latest builds main, not this branch.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/mfer/issues/79. `mfer/mf.proto` named `git.eeqj.de/sneak/mfer/mfer` as its Go package, disagreeing with the `sneak.berlin/go/mfer` module path that `go.mod` declares. `go_package` is now `sneak.berlin/go/mfer/mfer`: the full import path of the package in the `mfer/` subdirectory, as the code that imports it already writes it. `mfer/mf.pb.go` is regenerated with `make generate` using `protoc` 33.4 and `protoc-gen-go` v1.36.11, the versions in its header. The only change is the `go_package` string inside the embedded file descriptor, plus its two length bytes. `mfer/mf.proto.sha256` records the new hash. Nothing else in the tree uses `git.eeqj.de/sneak/mfer` as an import path. The remaining mentions in `README.md` and `FORMAT.md` are links to the repository web page and its `git clone` URL, so they stay. `https://sneak.berlin/go/mfer?go-get=1` still serves the `go-import` meta tag pointing at `https://git.eeqj.de/sneak/mfer` (after a redirect to `api.sneak.cloud/goredirector`), and resolving `sneak.berlin/go/mfer@latest` directly from a clean module cache reaches this repository. - Unverified: `go install sneak.berlin/go/mfer/cmd/mfer@latest`, named in the issue's definition of done, was not run. Only module resolution was checked, because `@latest` builds `main`, not this branch. Model: opus-5-5
clawbot added the needs-review label 2026-10-04 15:39:13 +02:00
clawbot self-assigned this 2026-10-04 15:39:14 +02:00
clawbot added 1 commit 2026-10-04 15:39:14 +02:00
mf.proto named git.eeqj.de/sneak/mfer/mfer as its Go package, which
disagrees with the sneak.berlin/go/mfer module path go.mod declares.
go_package is now sneak.berlin/go/mfer/mfer, the import path of the
mfer/ package. mf.pb.go is regenerated with make generate, which
changes only the go_package bytes in its embedded descriptor, and
mf.proto.sha256 records the new mf.proto hash.

Model: opus-5-5
Author
Collaborator

Review passed.
Gated on next at 82b9434.

  • Not verified: go install sneak.berlin/go/mfer/cmd/mfer@latest, which builds main rather than this branch; only resolution of the sneak.berlin/go/mfer module path was checked.

Model: opus-5-5

Review passed. Gated on `next` at `82b9434`. - Not verified: `go install sneak.berlin/go/mfer/cmd/mfer@latest`, which builds `main` rather than this branch; only resolution of the `sneak.berlin/go/mfer` module path was checked. Model: opus-5-5
clawbot merged commit 5c7ef94799 into next 2026-10-04 16:02:21 +02:00
clawbot deleted branch issue-79-go-package 2026-10-04 16:02:21 +02:00
Sign in to join this conversation.