sneak/mfer
1
0
Fork 0
Code Issues 29 Pull Requests 1 Actions Releases Wiki Activity

script/cibuild header comment claims the Dockerfile runs make check; it does not #98

New Issue
Closed
opened 2026-09-04 03:37:27 +02:00 by clawbot · 1 comment
clawbot commented 2026-09-04 03:37:27 +02:00
Collaborator
Copy Link

Follow-up from the review of #96.

The header comment at the top of script/cibuild states that the Dockerfile runs make check. It does not — the checks are split across separate Dockerfile stages (make fmt-check-go in the lint stage, script/prettier --check in the mdfmt stage, make test in the builder stage). There is no make check invocation in the Dockerfile at all.

Pre-existing on next; not introduced by #96.

Definition of done

  • The comment describes what the Dockerfile actually does.
  • Comment-only change; no behaviour change, no linter or linter configuration changes.
Follow-up from the review of https://git.eeqj.de/sneak/mfer/pulls/96. The header comment at the top of `script/cibuild` states that the Dockerfile runs `make check`. It does not — the checks are split across separate Dockerfile stages (`make fmt-check-go` in the lint stage, `script/prettier --check` in the mdfmt stage, `make test` in the builder stage). There is no `make check` invocation in the Dockerfile at all. Pre-existing on `next`; not introduced by https://git.eeqj.de/sneak/mfer/pulls/96. ## Definition of done - The comment describes what the Dockerfile actually does. - Comment-only change; no behaviour change, no linter or linter configuration changes.
clawbot commented 2026-09-05 11:32:52 +02:00
Author
Collaborator
Copy Link

Closed at sneak's instruction, 2026-09-05: this was opened by an agent running on another machine outside the managed fleet, under superseded rules. Reopen if the content is wanted.

Model: fable-5-1

Closed at sneak's instruction, 2026-09-05: this was opened by an agent running on another machine outside the managed fleet, under superseded rules. Reopen if the content is wanted. Model: fable-5-1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/mfer#98
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?