sneak/mfer
1
0
Fork 0
Code Issues 29 Pull Requests 1 Actions Releases Wiki Activity

script/docker and make docker still bare-build, so they can serve cached checks #97

New Issue
Closed
opened 2026-09-04 03:37:26 +02:00 by clawbot · 1 comment
clawbot commented 2026-09-04 03:37:26 +02:00
Collaborator
Copy Link

Follow-up from the review of #96 (which fixes #89 for script/cibuild only).

script/cibuild now passes CHECK_EPOCH so the three check-running Dockerfile stages (lint, mdfmt, builder) re-execute on every run. script/docker and the docker target in Makefile:81 still invoke a plain docker build with no CHECK_EPOCH, so a developer running make docker can still be handed a green that came out of the BuildKit cache rather than a fresh make check.

This was deliberately out of scope for #96 — the text of #89 names script/cibuild specifically in its title, every DoD bullet and every implementation bullet. Filing separately rather than widening that PR.

Definition of done

  • script/docker and Makefile:81 either pass a fresh CHECK_EPOCH the same way script/cibuild does, or there is a documented reason they should not.
  • Demonstrated with a negative control: break formatting, run make docker on an otherwise unchanged tree, and show it fails.
  • No linter or linter configuration changes.
Follow-up from the review of https://git.eeqj.de/sneak/mfer/pulls/96 (which fixes https://git.eeqj.de/sneak/mfer/issues/89 for `script/cibuild` only). `script/cibuild` now passes `CHECK_EPOCH` so the three check-running Dockerfile stages (lint, mdfmt, builder) re-execute on every run. `script/docker` and the `docker` target in `Makefile:81` still invoke a plain `docker build` with no `CHECK_EPOCH`, so a developer running `make docker` can still be handed a green that came out of the BuildKit cache rather than a fresh `make check`. This was deliberately out of scope for https://git.eeqj.de/sneak/mfer/pulls/96 — the text of https://git.eeqj.de/sneak/mfer/issues/89 names `script/cibuild` specifically in its title, every DoD bullet and every implementation bullet. Filing separately rather than widening that PR. ## Definition of done - `script/docker` and `Makefile:81` either pass a fresh `CHECK_EPOCH` the same way `script/cibuild` does, or there is a documented reason they should not. - Demonstrated with a negative control: break formatting, run `make docker` on an otherwise unchanged tree, and show it fails. - No linter or linter configuration changes.
clawbot commented 2026-09-05 11:32:52 +02:00
Author
Collaborator
Copy Link

Closed at sneak's instruction, 2026-09-05: this was opened by an agent running on another machine outside the managed fleet, under superseded rules. Reopen if the content is wanted.

Model: fable-5-1

Closed at sneak's instruction, 2026-09-05: this was opened by an agent running on another machine outside the managed fleet, under superseded rules. Reopen if the content is wanted. Model: fable-5-1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/mfer#97
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?