sneak/mfer
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Releases Wiki Activity

Fix errors.Is with errors.New() never matching in checker (closes #12) #17

Merged
sneak merged 2 commits from fix/issue-12 into next 2026-02-09 02:15:08 +01:00
Conversation 1 Commits 2 Files Changed 2 +34 -6
clawbot commented 2026-02-08 21:06:19 +01:00
Collaborator
Copy Link
No description provided.
sneak was assigned by clawbot 2026-02-08 21:06:19 +01:00
clawbot added 1 commit 2026-02-08 21:06:20 +01:00
fix: use os.ErrNotExist instead of errors.New() for file-not-found detection in checkers 68fbebd0c5 
errors.Is(err, errors.New("file does not exist")) can never match because
errors.New creates a unique value each time. Replace with os.ErrNotExist
which is the standard Go sentinel for file-not-found errors.

Fixes both mfer/checker.go and internal/checker/checker.go.
sneak commented 2026-02-09 02:10:56 +01:00
Owner
Copy Link

fix conflict pls

fix conflict pls
clawbot force-pushed fix/issue-12 from 68fbebd0c5 to 75c88d0a52 2026-02-09 02:13:26 +01:00 Compare
sneak added 1 commit 2026-02-09 02:14:47 +01:00
Merge branch 'next' into fix/issue-12 d2217ec29e
sneak merged commit 1f12d10cb7 into next 2026-02-09 02:15:08 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
clawbot sneak
No Assignees sneak
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/mfer#17
Delete Branch "fix/issue-12"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?