7 Commits

Include renames

Author	SHA1	Message	Date
clawbot	fa97c4519c	Never write fetch's temp file into an existing file (closes #115) ... downloadFile opened the temp file with os.Create, which opens and empties a file already at that name. If that file was a hard link to a file outside the destination directory, fetch overwrote the outside file. It now removes whatever is at the temp name, which removes only that name, and creates the temp file with O_EXCL, so the create fails if anything is still or again there. A leftover temp file from an interrupted run is still replaced. The new test puts a hard link at the temp name and checks that fetch succeeds and the outside file is unchanged. The command name is now the constant cmdFetch, like the other command names, because lint requires it once a third test uses it. Model: opus-5-5	2026-10-03 16:58:35 +02:00
clawbot	7e601929c8	Refuse fetch writes through a symlink in the destination (closes #86) ... sanitizePath checks manifest paths only as text, so a symlink already inside the destination directory could send fetch's writes outside it. checkNoSymlinks now looks at each existing part of a path with os.Lstat and refuses the path if any part is a symlink, wherever it points. fetch runs it immediately before each write: creating the parent directories, creating the temp file, and renaming it into place. The new test puts such a symlink at each of those three places, and once inside a plain directory, and checks that the fetch fails and nothing outside changes. The G304 comment now states what holds. A symlink swapped in between a check and its write is not caught; os.Root closes that once the Go version is raised. Model: opus-5-5	2026-10-03 16:08:09 +02:00
clawbot	de476708e9	Update golangci-lint to v2.12.2 with canonical config (closes #60) ... Adopts golangci-lint v2.12.2 and the canonical .golangci.yml (default: all), and fixes all resulting findings across the tree. Two intended behavior changes: absent MFFilePath.Mtime is handled explicitly in freshen, list and export rather than dereferenced (main panicked); gpg positional key IDs now follow an explicit -- end-of-options marker. All twelve reworded user-visible error messages restored to byte-identical parity with main and pinned by tests.	2026-08-10 16:06:12 +02:00
3 people	7f25970dd3	Fix URL encoding for file paths in fetch command (closes #13) (#18) ... Co-authored-by: clawbot <clawbot@openclaw> Co-authored-by: Jeffrey Paul <sneak@noreply.example.org> Reviewed-on: #18 Co-authored-by: clawbot <clawbot@noreply.example.org> Co-committed-by: clawbot <clawbot@noreply.example.org>	2026-02-09 02:14:20 +01:00
sneak	a5b0343b28	Use Go 1.13+ octal literal syntax throughout codebase ... Update file permission literals from legacy octal format (0755, 0644) to explicit Go 1.13+ format (0o755, 0o644) for improved readability.	2025-12-18 01:29:40 -08:00
sneak	92bd13efde	Fix all linter errors ... - Add explicit error ignoring with _ = for Close/Remove calls - Rename WriteTo to Write to avoid io.WriterTo interface conflict - Fix errcheck warnings in fetch, freshen, gen, mfer, checker, deserialize, serialize, and output files	2025-12-17 14:37:52 -08:00
sneak	c5ca3e2ced	Change FileProgress callback to channel-based progress ... Replace callback-based progress reporting in Builder.AddFile with channel-based FileHashProgress for consistency with EnumerateStatus and ScanStatus patterns. Update scanner.go to use the new channel API.	2025-12-17 14:30:10 -08:00