Remove generateInner, now handled by Builder

- Remove generateInner() from serialize.go
- Update generate() to error if pbInner not set
- Remove legacy tests that depended on old code path
- Update TODO item to reflect removal

mfer/serialize.go

@@ -23,10 +23,7 @@ func newTimestampFromTime(t time.Time) *Timestamp {
 
 func (m *manifest) generate() error {
 	if m.pbInner == nil {
-		e := m.generateInner()
-		if e != nil {
-			return e
-		}
+		return errors.New("internal error: pbInner not set")
 	}
 	if m.pbOuter == nil {
 		e := m.generateOuter()
@@ -80,19 +77,3 @@ func (m *manifest) generateOuter() error {
 	m.pbOuter = o
 	return nil
 }
-
-func (m *manifest) generateInner() error {
-	m.pbInner = &MFFile{
-		Version:   MFFile_VERSION_ONE,
-		CreatedAt: newTimestampFromTime(time.Now()),
-		Files:     []*MFFilePath{},
-	}
-	for _, f := range m.files {
-		nf := &MFFilePath{
-			Path: f.path,
-			// FIXME add more stuff
-		}
-		m.pbInner.Files = append(m.pbInner.Files, nf)
-	}
-	return nil
-}