Update README: mark FIXMEs as resolved

This commit is contained in:
Jeffrey Paul 2025-12-17 17:08:37 -08:00
parent 16e3538ea6
commit efa4bb929a
4 changed files with 6 additions and 34 deletions

BIN
.index.mf Normal file

Binary file not shown.

View File

@ -1,5 +1,10 @@
# Important Rules # Important Rules
* when fixing a bug, write a failing test FIRST. only after the test fails, write
the code to fix the bug. then ensure the test passes. leave the test in
place and commit it with the bugfix. don't run shell commands to test
bugfixes or reproduce bugs. write tests!
* never, ever mention claude or anthropic in commit messages. do not use attribution * never, ever mention claude or anthropic in commit messages. do not use attribution
* after each change, run "make fmt". * after each change, run "make fmt".

View File

@ -365,7 +365,7 @@ The manifest file would do several important things:
- [x] **Add unit tests for `internal/checker`** - 88.5% coverage. - [x] **Add unit tests for `internal/checker`** - 88.5% coverage.
- [x] **Add unit tests for `internal/scanner`** - 80.1% coverage. - [x] **Add unit tests for `internal/scanner`** - 80.1% coverage.
- [ ] **Clean up FIXMEs in manifest.go** - Validate input paths exist, validate filesystem. - [x] **Clean up FIXMEs in manifest.go** - Validated input paths, validated filesystem, added context cancellation.
- [x] **Validate input paths before scanning** - Fails fast with clear error if paths don't exist. - [x] **Validate input paths before scanning** - Fails fast with clear error if paths don't exist.
# Open Questions # Open Questions

33
TODO.md
View File

@ -1,33 +0,0 @@
# TODO for 1.0 Release
## High Priority
- [ ] **Fix panic in log.go** - `internal/log/log.go:141` has a `panic("unable to get logger")` that should return an error or handle gracefully instead.
- [ ] **Clean up FIXMEs in manifest.go** - Multiple FIXMEs need attention:
- Line 67: Validate input paths exist before processing
- Line 77: Add validation for filesystem input
- Line 163: Avoid redundant stat calls
- Line 182: Add context support for cancellation
- [ ] **Fix WriteToFile overwrite behavior** - `mfer/output.go:9` has FIXME to refuse overwriting without `-f` flag.
- [ ] **Consolidate legacy manifest code** - `mfer/manifest.go` has old scanning code (`Scan()`, `addFile()`) that duplicates the new `internal/scanner` + `mfer/builder.go` pattern. Remove duplication.
## Medium Priority
- [ ] **Add unit tests for `internal/checker`** - Currently has no test files; only tested indirectly via CLI tests.
- [ ] **Add unit tests for `internal/scanner`** - Currently has no test files.
- [ ] **Add context cancellation to legacy code** - The old `manifest.Scan()` doesn't support context cancellation; the new scanner does.
- [ ] **Validate input paths before scanning** - Should fail fast with a clear error if paths don't exist.
- [ ] **Add resume support for fetch** - Allow resuming partial downloads using HTTP Range requests and existing temp files.
## Lower Priority
- [ ] **Add manifest signature support** - Implement signing and verification using signify or similar.
- [ ] **Improve error messages** - Ensure all error messages are clear and actionable.