Stanislav N. aka pztrn
e39cceace6
Added eventsMutex and wrap all events calls with it.
...
Due to some "golangish" code this library have possibility to
run into data race when application is working with callbacks.
This commit adds eventsMutex (which is a sync.Mutex), removed
all "golangish" ifs-map reads, and wrap events map read with
sync.Mutex to avoid data races.
2017-10-03 02:03:43 +05:00
Thomas Jager
1b0acb5f2f
Fix double close of irc.end channel.
2016-12-08 09:29:58 +01:00
Thomas Jager
cfd5535e09
Merge pull request #91 from ugjka/master
...
make other threads exit if there's an error in one
2016-11-26 18:48:35 +01:00
ugjka
f4980d9fc2
make other threads exit if there's an error in one
2016-11-26 13:51:12 +02:00
Thomas Jager
9fa6da3c5c
Merge pull request #87 from tetheredge/fix-example
...
fix import statement in the example to the correct repo name
2016-11-08 13:59:05 +01:00
Taylor Etheredge
0d77e6970c
fix import statement to correct repo name
2016-11-07 20:19:02 -06:00
Thomas Jager
01d32de186
Link to example in README
2016-11-05 19:17:13 +01:00
Thomas Jager
e7aa1b5e94
Add example
2016-11-05 19:10:18 +01:00
Thomas Jager
491578616f
Merge pull request #82 from thoj/testing
...
Changed the way Quit/Disconnect works to avoid possible DATA races.
2016-11-05 18:55:39 +01:00
Thomas Jager
229753e4cc
Do ping/Lag test
2016-11-05 18:53:53 +01:00
Thomas Jager
9e77c40650
Fix lag printing
2016-11-05 18:53:35 +01:00
Thomas Jager
fdbbdf33e3
Fix data races
2016-11-05 18:53:11 +01:00
Thomas Jager
3078a030ef
Merge pull request #84 from davidscholberg/master
...
README: fixed test file path, converted it to github-flavored file link
2016-10-17 16:17:55 +02:00
David Scholberg
1a78dc3a39
README: fixed test file path, converted it to github-flavored file link
2016-10-07 22:49:57 -04:00
Thomas Jager
30fbca01f1
Merge pull request #83 from tetheredge/testing
...
Testing
2016-08-03 10:57:04 +02:00
Taylor Etheredge
7c392f5a61
add helper function to degub tests
2016-08-02 21:00:42 -05:00
Taylor Etheredge
62964f02b0
update comment on handling error events
2016-08-02 20:58:54 -05:00
Thomas Jager
582bf80992
Changed the way Quit/Disconnect works to avoid possible DATA races.
...
Rewrote tests to be less spammy. Created REconnection test.
2016-07-27 22:55:55 +02:00
Thomas Jager
a6b1561a01
Redo and Clean up some tests
2016-07-25 13:27:37 +02:00
Thomas Jager
6c780b5b70
Merge branch 'master' of github.com:thoj/go-ircevent
2016-07-25 01:30:25 +02:00
Thomas Jager
39b48423fd
Wrong format type in printf (%s -> %d)
2016-07-25 01:29:47 +02:00
Thomas Jager
4d2d36fc65
Remove unreacable code
2016-07-25 01:29:06 +02:00
Thomas Jager
a08c332184
Merge pull request #77 from 42wim/sasl
...
Add SASL (PLAIN) support
2016-07-23 01:52:49 +02:00
Wim
8401b5855f
Add SASL (PLAIN) support
2016-07-22 22:38:18 +02:00
Thomas Jager
98c1902dd2
Merge pull request #74 from d1str0/master
...
Correct typo in README example and ellaborate on a comment.
2016-07-20 14:27:14 +02:00
Brady Sullivan
221c89fece
Correct type in README example and ellaborate on a comment.
2016-05-29 23:03:20 -07:00
Thomas Jager
da78ed515c
BREAKING CHANGES: Run callbacks in main thread and int callback id.
...
Execute callbacks in main thread. This will break callbacks that
use a long time to execute. Create your own thread in AddCallback
using gorutines on long running callbacks.
Use deterministic IDs for AddCallback. Changes the id from SHA-hash
to int.
2016-02-06 21:38:53 +01:00
Thomas Jager
ab737c68eb
Remove unnecessary return
2016-02-06 21:20:35 +01:00
Thomas Jager
a767654908
Merge pull request #69 from peted27/master
...
fix reconnection logic
2015-12-05 11:32:46 +01:00
peted
5a16c2581e
revert some changes but also update err chan for new connection so further errors are received in Loop
2015-11-14 23:51:15 +10:00
peted
937f84605b
fix reconnection logic
2015-11-14 23:10:39 +10:00
Thomas Jager
db3338ebd4
Merge pull request #68 from lukevers/quit-message
...
Add support for specifying a quit message.
2015-10-28 14:31:23 +01:00
Luke Evers
f0c83dc012
Add support for specifying a quit message.
2015-10-28 08:58:41 -04:00
Thomas Jager
988aaaacd9
Merge pull request #66 from dainis/master
...
Fix - #65 ,
2015-08-28 20:28:27 +02:00
Dainis Tillers
3b5fa9fe31
Fix - #65 , when disconnect is called it will try to reconnect again in the Loop function, but Disconnect has already closed the channel
2015-08-28 21:01:23 +03:00
Thomas Jager
172717c0c5
Remove fuzzing testcases
2015-07-31 21:34:27 +02:00
Thomas Jager
3f51dd25c7
Move fuzzing code to seperate file
2015-07-31 21:33:36 +02:00
Thomas Jager
f204a14e00
Only trim newline/linefeed
2015-07-31 13:03:48 +02:00
Thomas Jager
e2be9c53c1
Test empty Action
2015-07-31 13:03:31 +02:00
Thomas Jager
6ce1e34c21
Don't crash on empty ACTION
2015-07-31 13:03:09 +02:00
Thomas Jager
c47f9d8e3d
Fuzz testing callbacks
2015-07-31 08:30:21 +02:00
Thomas Jager
8b3e6a50ac
Fix ident
2015-07-31 08:29:20 +02:00
Thomas Jager
414fe0a201
Fix testcase. Id can come in diffrent orders.
2015-07-31 08:28:54 +02:00
Thomas Jager
6c849e1147
Merge branch 'master' of github.com:thoj/go-ircevent into fuzz
2015-07-31 07:35:48 +02:00
Thomas Jager
4b30e65f83
Fix indentation
2015-07-31 07:35:34 +02:00
Thomas Jager
4f50f209c4
Fix parser. Tested with go-fuzz
2015-07-31 07:34:19 +02:00
Thomas Jager
35f8ae857e
Merge pull request #62 from alaska/master
...
Add kick/multi kick. Properly randomize. Catch invalid CTCP messages and log
2015-07-31 07:05:02 +02:00
Andy Walker
b0ed3d4bd5
should return in case of CTCP error
2015-07-30 13:03:55 -04:00
Andy Walker
03b22b08f4
Report on unterminated CTCP messages
...
A bug was discovered where, under certain circumstances that are still
being researched, the library would panic on a message that started with
\0x01, but did not end with it. This would cause the re-slice to panic,
because the library assumes a terminating index >0, effectively
introducing the possibility of msg = msg[1:0]. Since this violates the
CTCP spec, it is an error, and should be logged, along with the
complete, escaped message.
2015-07-30 12:58:23 -04:00
Andy Walker
6112236593
fix multi-kick
...
Spec defines multiple users as joined by spaces not commas
2015-07-30 12:57:48 -04:00
