Commit Graph

189 Commits

Author SHA1 Message Date
Andy Walker
03b22b08f4 Report on unterminated CTCP messages
A bug was discovered where, under certain circumstances that are still
being researched, the library would panic on a message that started with
\0x01, but did not end with it. This would cause the re-slice to panic,
because the library assumes a terminating index >0, effectively
introducing the possibility of msg = msg[1:0]. Since this violates the
CTCP spec, it is an error, and should be logged, along with the
complete, escaped message.
2015-07-30 12:58:23 -04:00
Andy Walker
6112236593 fix multi-kick
Spec defines multiple users as joined by spaces not commas
2015-07-30 12:57:48 -04:00
Andy Walker
ad73608a87 add Kick and MultiKick commands 2015-07-21 18:41:16 -04:00
Andy Walker
b49099e075 use rand.Seed() in init() to properly randomize 2015-07-20 16:13:15 -04:00
Thomas Jager
f169aaad6f Merge pull request #58 from julidau/master
fixing small bugs
2015-06-25 10:38:50 +02:00
Julian Daube
f9d88d1af1 initialized .nickcurrent with .nick
fixes empty return of Nick() directly after initialising
2015-06-20 22:24:25 +02:00
Julian Daube
4f7b3d1c84 fixed a small bug which marks the connection alive to early 2015-06-20 22:21:27 +02:00
Thomas Jager
087ae892d0 CTCP Messages must be more then 2 characters long.
Avoid panic on malformed CTCP messages.
2015-03-31 15:14:13 +02:00
Thomas Jager
47e552f62d Merge pull request #56 from 9uuso/master
Fix commands to correspond parameter name
2015-03-22 08:39:03 +01:00
Juuso Haavisto
f467f72ebb fix command parameters 2015-03-21 21:13:32 +02:00
Thomas Jager
5e6704d895 Merge pull request #49 from Caerostris/master
minor adjustments for multiple connections
2014-11-03 17:37:15 +01:00
Keno Schwalb
4e1ebe0162 minor adjustments for multiple connections 2014-11-03 15:21:48 +00:00
Thomas Jager
9c4d007b9f Merge pull request #48 from veonik/master
Added Connected method
2014-11-02 20:53:40 +01:00
Tyler Sommer
533177a490 Added Connected method 2014-10-23 18:17:58 -07:00
Thomas Jager
18b9dfbf29 Merge pull request #47 from GawainLynch/master
Add a formatted ACTION
2014-10-07 22:40:37 +02:00
Gawain Lynch
fc7dfec2b9 Add a formatted ACTION 2014-10-07 21:29:22 +01:00
Thomas Jager
03e596dff4 Merge pull request #45 from antzucaro/master
Add verbose logging for ReadLoop().
2014-10-05 23:54:51 +02:00
Ant Zucaro
80f67f76b5 Add ReadLoop() debugging via Connection.Debug. 2014-10-05 08:56:52 -04:00
Ant Zucaro
f997fc841a Add a 'VerboseReadLoop' option.
Troubleshooting responses from the IRC server becomes easier when
you can actually see the raw responses. This change adds a
'VerboseReadLoop' member to the Connection struct. When set to
true, the raw messages sent from the server will be placed into
the standard log for review. This message is printed before
evaluating any callbacks.
2014-10-04 08:20:58 -04:00
Ant Zucaro
066134263e Change duplicate error message for missing irc.nick. 2014-10-04 08:10:14 -04:00
Thomas Jager
baefdc5d0b Merge pull request #44 from julianec/master
Set irc.currentnick to irc.nick if irc.currentnick is empty.
2014-08-27 21:38:15 +02:00
Juliane Clausen
bdde4f62f9 Set irc.currentnick to irc.nick if irc.currentnick is empty.
Handle nicks longer than 8 characters for IRC event 437 too.

Fixes issue 43 (IRC client gets stuck on nick collision)
2014-08-27 20:51:31 +02:00
Thomas Jager
90dc7f966b Merge pull request #41 from whd/master
Use tls.DialWithDialer instead of tls.Client and remove irc.netsock
2014-08-14 15:11:46 +02:00
Wesley Dawson
30608bd31c Use tls.DialWithDialer instead of tls.Client and remove irc.netsock 2014-08-13 18:35:37 -07:00
Thomas Jager
40cfe292a9 Merge pull request #40 from oniichaNj/master
no longer breaks on invalid (too short) ctcp requests
2014-08-06 09:09:35 +02:00
Dumb Thing
d088b73396 no longer breaks on invalid ctcp requests 2014-08-06 00:27:45 +02:00
Thomas Jager
33fb824b4f Merge pull request #38 from ecnahc515/custom_handling_disconnect
Custom handling disconnect
2014-07-29 10:03:48 +02:00
Thomas Jager
47f9578f45 Merge pull request #39 from adnils/master
Fix command letter casing.
2014-07-29 10:03:31 +02:00
Adrian Nilsson
0ffb74364d Fix command letter casing.
SendRaw and SendRawf have title casing.
2014-07-24 09:13:59 +02:00
Chance Zibolski
06fee2df7d disconnect: Clear callbacks before closing channels 2014-07-14 17:05:27 -07:00
Chance Zibolski
846881130f Remove pread 2014-07-14 17:05:06 -07:00
Chance Zibolski
30980fcbad Retrieve error chan from method.
This allows using the error chan in an interface.

Also moved the disconnect error into a named variable for checking specific
errors.
2014-07-14 16:02:09 -07:00
Thomas Jager
a4ab35198c Merge pull request #33 from lucron/master
Fix for reconnect and connection errors
2014-06-24 10:08:50 +02:00
soda
9328e32771 removed irc.Disconnect() comment 2014-06-21 17:21:15 +02:00
soda
2a60a33ae9 removed debug-printfs 2014-06-21 16:53:24 +02:00
soda
32cee7464f fix reconnect, make irc.end 2014-06-21 16:46:47 +02:00
soda
809b9be4e4 fixing reconnect 2014-06-21 16:30:15 +02:00
Thomas Jager
b73cc42bde Remove Disconnect() from Quit(). Use ERROR feedback from server instead. 2014-06-18 15:59:07 +02:00
Thomas Jager
14db1acfd0 Add default callback for ERROR 2014-06-18 15:58:18 +02:00
Thomas Jager
9909b5a3d3 Modified test 1 2014-06-18 15:56:42 +02:00
Thomas Jager
da2e16496d Merge pull request #31 from scrapbird/master
Fixed a bug in irc_callback.go on line 163 where a Message is treated as...
2014-05-12 07:26:43 +02:00
Brenton Morris
96de31cab4 Fixed a bug in irc_callback.go on line 163 where a Message is treated as an expression istead of a function 2014-05-12 15:27:02 +12:00
Thomas Jager
2e87f54e96 Merge pull request #29 from alsm/master
Close channel to signal goroutines to quit and waitgroup to confirm that...
2014-05-03 00:32:17 +02:00
alsm
f27b0b53e2 Close channel to signal goroutines to quit and waitgroup to confirm that they have 2014-05-02 23:20:51 +01:00
Thomas Jager
50d8ba24ee Merge pull request #28 from hobbeswalsh/master
Adding support for CTCP ACTION
2014-04-25 08:19:03 +02:00
Robin Walsh
31b6883175 Adding support for CTCP ACTION 2014-04-24 21:56:30 -07:00
Thomas Jager
accfd72b17 Merge pull request #27 from tpltnt/master
sanity checks IRC() and Connect()
2014-02-16 14:23:08 +01:00
tpltnt
f073b9b25c style fixes 2014-02-16 14:20:13 +01:00
tpltnt
6e0280dae6 port range checking added 2014-02-16 11:41:38 +01:00
tpltnt
48983c2abf refactoring: hasConnectionValues() integrated into Connection() + more detailed errors 2014-02-16 02:01:53 +01:00