clawbot
62dec447e3
check / check (push) Successful in 1m37s
Rebasing this branch onto next surfaced two failures that the branch
did not have in isolation. Both come from the change this PR makes:
the watcher package now queries live DNS, and it is the second package
to do so.
Burst fan-out in the watcher package. All 13 watcher tests are
parallel and each runs a full iterative resolution, so they hit the
same root servers in the same instant and get rate-limited. This is
exactly the pathology internal/resolver/livedns_test.go was written to
prevent (9cb2c2b); that gate is package-scoped and cannot reach into
this package's test binary, so liveWatcherGate is its counterpart
here, acquired in newTestWatcher and released when the test ends.
Cross-package oversubscription. Go runs package binaries in parallel,
so with both live-DNS packages in flight their gates sum rather than
hold. The excess is rate-limited and the resolver's 8s per-attempt
deadlines expire, failing ResolveIPAddresses tests this branch never
touched. script/test now passes -p 1 so each gate is authoritative
while its package runs. Serialising is also net faster here, because
the retries it removes cost more than the lost parallelism: resolver
16-22s (was 30-36s under contention), watcher 12-13s (was 27-37s),
whole suite 39-46s against the 60s cap and the 90s -timeout backstop.
TestQueryNameserverIP_UnreachableServer is dropped rather than fixed.
It asserted that a query to an RFC 5737 documentation address comes
back non-OK with no records, which does not hold in the build
environment: that network transparently intercepts all UDP/53 traffic
regardless of destination and answers it locally, so the query returns
StatusOK with 9 real records for example.com. Verified directly with
dig @192.0.2.1 inside the build network. The mock DNSClient that used
to force this classification is what this PR removes, and a live
substitute would only be testing the sandbox's network behaviour, so
the coverage gap is recorded in a comment where the test was.
Verified: three consecutive `docker build .` runs green, after three
consecutive failures without these changes.
47 lines
1.9 KiB
Bash
Executable File
47 lines
1.9 KiB
Bash
Executable File
#!/bin/sh
|
|
# script/test: run the test suite.
|
|
#
|
|
# -count=1 disables Go's test cache, and is load-bearing here. This
|
|
# suite queries live DNS on every run by policy (TESTING.md); a cached
|
|
# result is a replay of an earlier run's output with no query made at
|
|
# all. On an unchanged tree the whole suite would return success in
|
|
# under a second having resolved nothing, which makes the repeated-run
|
|
# green that is used as evidence for flakiness fixes worthless. Do not
|
|
# remove it.
|
|
#
|
|
# Conditional verbose rerun per REPO_POLICIES.md: run quiet first so
|
|
# CI and docker build logs stay readable, and rerun with -v only on
|
|
# failure. The rerun also carries -count=1 (a cached replay of the
|
|
# failure would show nothing new), and the exit status is forced to 1
|
|
# no matter how the rerun ends: the first failure already proved the
|
|
# suite broken, so a flaky test that passes the second time must not
|
|
# turn the build green.
|
|
#
|
|
# -timeout 90s is a deliberate backstop above the 60s hard cap on
|
|
# suite duration. Do not lower it.
|
|
#
|
|
# -p 1 runs one test package at a time, and is load-bearing. Live DNS
|
|
# is a resource outside the process: the concurrency gates that keep
|
|
# this suite from bursting at the root servers
|
|
# (internal/resolver/livedns_test.go, internal/watcher/watcher_test.go)
|
|
# are package-scoped, so each one only bounds its own test binary. Go
|
|
# runs package binaries in parallel by default, so with both live-DNS
|
|
# packages in flight at once their gates sum instead of holding, the
|
|
# root and TLD servers rate-limit the excess, and the resolver
|
|
# package's per-attempt deadlines expire. Serialising packages is what
|
|
# makes each gate authoritative while its package runs.
|
|
set -eu
|
|
|
|
ROOT="$(cd "$(dirname "$0")/.." && pwd -P)"
|
|
|
|
main() {
|
|
cd "$ROOT"
|
|
go test -count=1 -p 1 -race -timeout 90s -cover ./... || {
|
|
echo "--- Rerunning with -v for details ---" >&2
|
|
go test -count=1 -p 1 -race -timeout 90s -v ./... || true
|
|
exit 1
|
|
}
|
|
}
|
|
|
|
main "$@"
|