sneak/dnswatcher
1
0
Fork 0
Code Issues 29 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

config: fail fast when DNSWATCHER_TARGETS is empty #77

Closed
clawbot wants to merge 1 commits from fix/empty-targets-validation into main
pull from: fix/empty-targets-validation
merge into: :main
Conversation 1 Commits 1 Files Changed 2
+123 -20
clawbot commented 2026-03-02 01:22:40 +01:00
Collaborator
Copy Link
Copy Source

When DNSWATCHER_TARGETS is empty or unset (the default), dnswatcher now exits with a clear error message instead of silently starting with nothing to monitor.

Changes

  • Added ErrNoTargets sentinel error in internal/config/config.go
  • buildConfig now validates that at least one domain or hostname is configured after target classification
  • When no targets are configured, config.New returns ErrNoTargets, causing the fx application to fail to start with a clear error message
  • Extracted classifyAndValidateTargets() and parseDurationOrDefault() helpers to keep buildConfig within the funlen limit
  • Added tests: TestNewReturnsErrNoTargetsWhenEmpty and TestNewSucceedsWithTargets

Closes #69

When `DNSWATCHER_TARGETS` is empty or unset (the default), dnswatcher now exits with a clear error message instead of silently starting with nothing to monitor. ## Changes - Added `ErrNoTargets` sentinel error in `internal/config/config.go` - `buildConfig` now validates that at least one domain or hostname is configured after target classification - When no targets are configured, `config.New` returns `ErrNoTargets`, causing the fx application to fail to start with a clear error message - Extracted `classifyAndValidateTargets()` and `parseDurationOrDefault()` helpers to keep `buildConfig` within the funlen limit - Added tests: `TestNewReturnsErrNoTargetsWhenEmpty` and `TestNewSucceedsWithTargets` Closes #69
clawbot added 1 commit 2026-03-02 01:22:40 +01:00
config: fail fast when DNSWATCHER_TARGETS is empty
check / check (push) Successful in 45s
Details
713a2b7332 
When DNSWATCHER_TARGETS is empty or unset (the default), dnswatcher now
exits with a clear error message instead of silently starting with
nothing to monitor.

Added ErrNoTargets sentinel error returned from config.New when both
domains and hostnames lists are empty after target classification. This
causes the fx application to fail to start, preventing silent
misconfiguration.

Also extracted classifyAndValidateTargets and parseDurationOrDefault
helper functions to keep buildConfig within the funlen limit.

Closes #69
clawbot commented 2026-03-02 01:22:49 +01:00
Author
Collaborator
Copy Link
Copy Source

Closing as duplicate — PR #75 already addresses issue #69 and is merge-ready.

Closing as duplicate — PR #75 already addresses issue #69 and is merge-ready.
clawbot closed this pull request 2026-03-02 01:22:50 +01:00
clawbot added the needs-review label 2026-03-02 01:22:52 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No labels needs-review
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
clawbot sneak (Jeffrey Paul)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/dnswatcher#77