healthcheck: answer 503 when no root server gave a usable reply in the last round of DNS checks (closes #302)

Conversation 5 Commits 3 Files Changed 14

+534 -45

3 Commits

Author	SHA1	Message	Date
clawbot	4e39890c0a	watcher: names say "usable reply", as their comments do (rework for #302 ) check / check (push) Waiting to run Details The function that decides the round could not reach the DNS, and its test, are renamed to say no root server gave a usable reply, since a root server's address that replied unusably counts the same. Model: opus-5-5	2026-10-18 14:45:15 +00:00
sneak	cc27d8d957	docs: health check wording follows the code (rework for #302 ) check / check (push) Canceled after 0s Details The README, the comments and TODO.md say the health check gives error only when every lookup in a round failed because no root server gave a usable reply, and the README drops the claim that the other failures are reported as notifications. Model: opus-5-5	2026-10-18 14:04:04 +00:00
clawbot	a70b173a48	healthcheck: answer 503 when the last round of DNS checks reached no root server (closes #302 ) check / check (push) Canceled after 0s Details The health check answered ok while every DNS lookup failed, as on a network that intercepts DNS queries. A lookup whose root servers give no usable reply now fails with ErrNoRootServerAnswered. At the end of each round of DNS checks the watcher records whether every lookup failed with it or with ErrIntercepted; the health check then gives status error, and /.well-known/healthcheck and /health answer 503. Until the first round finishes it stays ok. The health check now depends on the watcher, so fx builds the watcher first: its first round starts before the HTTP server listens, and the server tests' fx graph includes it. NewWithRootServers lets tests start a resolver's walks at real servers that are not root servers. Model: opus-5-5	2026-10-18 13:30:45 +00:00

Author

SHA1

Message

Date

clawbot

4e39890c0a

watcher: names say "usable reply", as their comments do (rework for #302 )

check / check (push) Waiting to run

Details

The function that decides the round could not reach the DNS, and its
test, are renamed to say no root server gave a usable reply, since a
root server's address that replied unusably counts the same.

Model: opus-5-5

2026-10-18 14:45:15 +00:00

sneak

cc27d8d957

docs: health check wording follows the code (rework for #302 )

check / check (push) Canceled after 0s

Details

The README, the comments and TODO.md say the health check gives error
only when every lookup in a round failed because no root server gave a
usable reply, and the README drops the claim that the other failures
are reported as notifications.

Model: opus-5-5

2026-10-18 14:04:04 +00:00

clawbot

a70b173a48

healthcheck: answer 503 when the last round of DNS checks reached no root server (closes #302 )

check / check (push) Canceled after 0s

Details

The health check answered ok while every DNS lookup failed, as on a
network that intercepts DNS queries. A lookup whose root servers give no
usable reply now fails with ErrNoRootServerAnswered. At the end of each
round of DNS checks the watcher records whether every lookup failed with
it or with ErrIntercepted; the health check then gives status error, and
/.well-known/healthcheck and /health answer 503. Until the first round
finishes it stays ok.

The health check now depends on the watcher, so fx builds the watcher
first: its first round starts before the HTTP server listens, and the
server tests' fx graph includes it. NewWithRootServers lets tests start
a resolver's walks at real servers that are not root servers.

Model: opus-5-5

2026-10-18 13:30:45 +00:00

healthcheck: answer 503 when no root server gave a usable reply in the last round of DNS checks (closes #302) #304