The resolver declared timeoutMultiplier and passed each try's number to exchangeWithTimeout, which threw it away with a comment saying the client config grew the timeout. Nothing grew it. Both clients get the fixed 2-second queryTimeoutDuration when the resolver is built, so every try waits the same time.
This change removes the constant. It also folds exchangeWithTimeout into tryExchange, its only caller: with the unused argument gone, the function was one call and a return. tryExchange gets a two-line comment saying it sends over UDP up to maxRetries times and that every try waits the same queryTimeoutDuration. The retry loop works as before, so behaviour does not change.
No test called exchangeWithTimeout, so no test changes. No other comment or document in the repo says the resolver's timeout grows. TESTING.md already describes the fixed 2-second timeout and the second try.
Judgement call: I folded the function into its caller rather than keeping it without the argument, which the issue allowed as either.
Model: opus-5-5
Closes https://git.eeqj.de/sneak/dnswatcher/issues/296.
The resolver declared `timeoutMultiplier` and passed each try's number to `exchangeWithTimeout`, which threw it away with a comment saying the client config grew the timeout. Nothing grew it. Both clients get the fixed 2-second `queryTimeoutDuration` when the resolver is built, so every try waits the same time.
This change removes the constant. It also folds `exchangeWithTimeout` into `tryExchange`, its only caller: with the unused argument gone, the function was one call and a return. `tryExchange` gets a two-line comment saying it sends over UDP up to `maxRetries` times and that every try waits the same `queryTimeoutDuration`. The retry loop works as before, so behaviour does not change.
No test called `exchangeWithTimeout`, so no test changes. No other comment or document in the repo says the resolver's timeout grows. `TESTING.md` already describes the fixed 2-second timeout and the second try.
Judgement call: I folded the function into its caller rather than keeping it without the argument, which the issue allowed as either.
Model: opus-5-5
The resolver declared timeoutMultiplier and passed each try's number to
exchangeWithTimeout, which threw it away with a comment saying the
client config grew the timeout. Nothing did: every try waits the same
2-second queryTimeoutDuration. The constant goes, and exchangeWithTimeout
is folded into its one caller, tryExchange, whose comment now says the
timeout is fixed. Behaviour is unchanged.
Model: opus-5-5
clawbot
self-assigned this 2026-10-15 18:08:00 +02:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Closes #296.
The resolver declared
timeoutMultiplierand passed each try's number toexchangeWithTimeout, which threw it away with a comment saying the client config grew the timeout. Nothing grew it. Both clients get the fixed 2-secondqueryTimeoutDurationwhen the resolver is built, so every try waits the same time.This change removes the constant. It also folds
exchangeWithTimeoutintotryExchange, its only caller: with the unused argument gone, the function was one call and a return.tryExchangegets a two-line comment saying it sends over UDP up tomaxRetriestimes and that every try waits the samequeryTimeoutDuration. The retry loop works as before, so behaviour does not change.No test called
exchangeWithTimeout, so no test changes. No other comment or document in the repo says the resolver's timeout grows.TESTING.mdalready describes the fixed 2-second timeout and the second try.Judgement call: I folded the function into its caller rather than keeping it without the argument, which the issue allowed as either.
Model: opus-5-5
This passes review.
Model: opus-5-5