watcher: change messages name only the record types that differ (closes #219) #238

Merged
clawbot merged 1 commits from issue-219-change-messages-name-the-type into next 2026-10-02 08:46:57 +02:00
Collaborator

Closes #219

A Record Change notification now names the hostname and the nameserver, then, for each record type whose values changed, the type, its old values and its new values. An Inconsistency notification names the hostname and, for each record type on which the two nameservers differ, what each returned, after that nameserver's name. Record types with the same values on both sides are left out. The dashboard's Recent alerts shows the same text.

From a run watching github.com:

Hostname: github.com
Nameserver: dns4.p08.nsone.net.
Type: A
Old: 140.82.121.4
New: 140.82.121.3
Hostname: github.com
Type: A
dns3.p08.nsone.net.: 140.82.121.4
ns-520.awsdns-01.net.: 140.82.121.3

Not visible in the diff:

  • A record type present on only one side is written as none on the other.
  • Values of one type appear in the order saved, which the resolver sorts.

Judgement call: values are separated by , , as in the NS Address Change message, so a TXT value that itself contains a comma is not set apart from the values next to it.

Model: opus-5-5

Closes https://git.eeqj.de/sneak/dnswatcher/issues/219 A Record Change notification now names the hostname and the nameserver, then, for each record type whose values changed, the type, its old values and its new values. An Inconsistency notification names the hostname and, for each record type on which the two nameservers differ, what each returned, after that nameserver's name. Record types with the same values on both sides are left out. The dashboard's Recent alerts shows the same text. From a run watching `github.com`: ``` Hostname: github.com Nameserver: dns4.p08.nsone.net. Type: A Old: 140.82.121.4 New: 140.82.121.3 ``` ``` Hostname: github.com Type: A dns3.p08.nsone.net.: 140.82.121.4 ns-520.awsdns-01.net.: 140.82.121.3 ``` Not visible in the diff: - A record type present on only one side is written as `none` on the other. - Values of one type appear in the order saved, which the resolver sorts. Judgement call: values are separated by `, `, as in the NS Address Change message, so a TXT value that itself contains a comma is not set apart from the values next to it. Model: opus-5-5
clawbot added the needs-review label 2026-10-02 08:11:55 +02:00
clawbot self-assigned this 2026-10-02 08:11:55 +02:00
Author
Collaborator

Review passed on b57dec7.

Model: opus-5-5

Review passed on b57dec7. Model: opus-5-5
clawbot added 1 commit 2026-10-02 08:46:34 +02:00
A Record Change notification printed the nameserver's whole old and new
record sets in Go map syntax, and an Inconsistency notification the two
nameservers' whole sets, so a one-address change had to be found by eye
among kilobytes of unchanged TXT, CAA, MX and NS values. Both now list,
in sorted order of type, only the record types whose values differ: a
line naming the type, then each side's values separated by commas, or
none when that side has no records of that type. The dashboard's Recent
alerts shows the same text.

Model: opus-5-5
clawbot force-pushed issue-219-change-messages-name-the-type from b57dec7662 to ac5248067d 2026-10-02 08:46:34 +02:00 Compare
clawbot merged commit f99de191c0 into next 2026-10-02 08:46:57 +02:00
clawbot deleted branch issue-219-change-messages-name-the-type 2026-10-02 08:46:57 +02:00
clawbot removed the needs-review label 2026-10-02 08:46:57 +02:00
Sign in to join this conversation.