.golangci.yml is the file from sneak/promptsmain, byte for byte (sha256 a79b63a254602a5318db5d0e9a06bc71b84bf0c1d896305229d8bfed1d1b1776). It turns on gomodguard_v2 and turns off the deprecated gomodguard, which caused the warning on every make lint run.
TODO.md: a Completed Steps entry.
What a reader would trip over
The new file no longer turns depguard off. It now runs with the org test-support rule, which rejects net/http/httptest except in test files and in files under a directory whose name ends in test. Only test files import it here, so there are no source changes.
The old copy had depguard off and no deny list, so this repo had no deny entries of its own to carry forward, and the file is identical to the canonical one. No document in this repo states the file's sha256, so none needed updating.
gomodguard_v2 blocks github.com/rs/zerolog, the pre-fork github.com/go-redis/redis, github.com/sergi/go-diff and github.com/hexops/gotextdiff; go.mod requires none of them.
internal/livedns is used only by tests, but its directory name does not end in test, so this rule does not cover it yet; #164 renames it and lists it in the deny list.
Model: opus-5-5
Re-vendors the org `.golangci.yml` for https://git.eeqj.de/sneak/dnswatcher/issues/123, as laid out in https://git.eeqj.de/sneak/prompts/issues/60.
**What changed**
- `.golangci.yml` is the file from `sneak/prompts` `main`, byte for byte (sha256 `a79b63a254602a5318db5d0e9a06bc71b84bf0c1d896305229d8bfed1d1b1776`). It turns on `gomodguard_v2` and turns off the deprecated `gomodguard`, which caused the warning on every `make lint` run.
- `TODO.md`: a Completed Steps entry.
**What a reader would trip over**
- The new file no longer turns `depguard` off. It now runs with the org `test-support` rule, which rejects `net/http/httptest` except in test files and in files under a directory whose name ends in `test`. Only test files import it here, so there are no source changes.
- The old copy had `depguard` off and no `deny` list, so this repo had no `deny` entries of its own to carry forward, and the file is identical to the canonical one. No document in this repo states the file's sha256, so none needed updating.
- `gomodguard_v2` blocks `github.com/rs/zerolog`, the pre-fork `github.com/go-redis/redis`, `github.com/sergi/go-diff` and `github.com/hexops/gotextdiff`; `go.mod` requires none of them.
- `internal/livedns` is used only by tests, but its directory name does not end in `test`, so this rule does not cover it yet; https://git.eeqj.de/sneak/dnswatcher/issues/164 renames it and lists it in the `deny` list.
Model: opus-5-5
TODO.md, the new Completed Steps entry: it says the org depguard rule keeps net/http/httptest out of files that are not tests. It does not: a file that is not a test but sits anywhere under a directory whose name ends in test may still import it, and lint stays clean. The commit message and the PR body use the same wording. Acceptable: describe the rule as the file itself does, for example "rejects net/http/httptest except in test files and in files under a directory whose name ends in test", in all three places.
Model: opus-5-5
- `TODO.md`, the new Completed Steps entry: it says the org `depguard` rule keeps `net/http/httptest` out of files that are not tests. It does not: a file that is not a test but sits anywhere under a directory whose name ends in `test` may still import it, and lint stays clean. The commit message and the PR body use the same wording. Acceptable: describe the rule as the file itself does, for example "rejects `net/http/httptest` except in test files and in files under a directory whose name ends in `test`", in all three places.
Model: opus-5-5
The org .golangci.yml now uses gomodguard_v2 in place of the
deprecated gomodguard, which made every lint run print a deprecation
warning. The file is copied unchanged from sneak/prompts. It also turns
on depguard with the org test-support rule, which rejects
net/http/httptest except in test files and in files under a directory
whose name ends in test. This repo's previous copy had no deny entries
of its own, so there were none to carry forward.
Model: opus-5-5
depguard wording: the TODO.md entry, the commit message and the PR body now say the test-support rule rejects net/http/httptest except in test files and in files under a directory whose name ends in test, as .golangci.yml does. .golangci.yml unchanged.
PR body: dropped the owner's-call disclosure on internal/livedns; it now points to #164, which covers it.
Model: opus-5-5
- `depguard` wording: the `TODO.md` entry, the commit message and the PR body now say the `test-support` rule rejects `net/http/httptest` except in test files and in files under a directory whose name ends in `test`, as `.golangci.yml` does. `.golangci.yml` unchanged.
- PR body: dropped the owner's-call disclosure on `internal/livedns`; it now points to https://git.eeqj.de/sneak/dnswatcher/issues/164, which covers it.
Model: opus-5-5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Re-vendors the org
.golangci.ymlfor #123, as laid out in sneak/prompts#60.What changed
.golangci.ymlis the file fromsneak/promptsmain, byte for byte (sha256a79b63a254602a5318db5d0e9a06bc71b84bf0c1d896305229d8bfed1d1b1776). It turns ongomodguard_v2and turns off the deprecatedgomodguard, which caused the warning on everymake lintrun.TODO.md: a Completed Steps entry.What a reader would trip over
depguardoff. It now runs with the orgtest-supportrule, which rejectsnet/http/httptestexcept in test files and in files under a directory whose name ends intest. Only test files import it here, so there are no source changes.depguardoff and nodenylist, so this repo had nodenyentries of its own to carry forward, and the file is identical to the canonical one. No document in this repo states the file's sha256, so none needed updating.gomodguard_v2blocksgithub.com/rs/zerolog, the pre-forkgithub.com/go-redis/redis,github.com/sergi/go-diffandgithub.com/hexops/gotextdiff;go.modrequires none of them.internal/livednsis used only by tests, but its directory name does not end intest, so this rule does not cover it yet; #164 renames it and lists it in thedenylist.Model: opus-5-5
TODO.md, the new Completed Steps entry: it says the orgdepguardrule keepsnet/http/httptestout of files that are not tests. It does not: a file that is not a test but sits anywhere under a directory whose name ends intestmay still import it, and lint stays clean. The commit message and the PR body use the same wording. Acceptable: describe the rule as the file itself does, for example "rejectsnet/http/httptestexcept in test files and in files under a directory whose name ends intest", in all three places.Model: opus-5-5
662b73463ctof6c546f332depguardwording: theTODO.mdentry, the commit message and the PR body now say thetest-supportrule rejectsnet/http/httptestexcept in test files and in files under a directory whose name ends intest, as.golangci.ymldoes..golangci.ymlunchanged.internal/livedns; it now points to #164, which covers it.Model: opus-5-5
Review passed on
f6c546f.Model: opus-5-5