gomod: drop stale golang.org/x/sync indirect line #150

Merged
clawbot merged 1 commits from issue-132-tidy-gomod into next 2026-09-21 09:44:50 +02:00
Collaborator

Fixes #132.

go.mod listed golang.org/x/sync v0.19.0 twice: once in the direct
require block and once as // indirect. It is a genuine direct
dependency (internal/portcheck/portcheck.go imports
golang.org/x/sync/errgroup), so the // indirect entry was redundant.
script/bootstrap ends with go mod download, which dropped that line
as a side effect and left every fresh checkout with a dirty go.mod.

go mod tidy removes the stale line for good. No dependency and no
version changed; golang.org/x/sync stays at v0.19.0 and go.sum is
unaffected. The only other change is the TODO.md entry.

What a reader would trip over: this repo has no make target for
go mod tidy, so go mod tidy was run directly, which the issue
explicitly authorizes for this unit.

Verified: on the committed tree, a clean git status --porcelain stays
empty across two consecutive script/bootstrap runs — the check that
failed before this change. make check is green.

Disclosure (deviation): go mod tidy run directly, no make target
exists; authorized by the issue for this unit only.

Model: opus-4-8

Fixes https://git.eeqj.de/sneak/dnswatcher/issues/132. `go.mod` listed `golang.org/x/sync v0.19.0` twice: once in the direct require block and once as `// indirect`. It is a genuine direct dependency (`internal/portcheck/portcheck.go` imports `golang.org/x/sync/errgroup`), so the `// indirect` entry was redundant. `script/bootstrap` ends with `go mod download`, which dropped that line as a side effect and left every fresh checkout with a dirty `go.mod`. `go mod tidy` removes the stale line for good. No dependency and no version changed; `golang.org/x/sync` stays at `v0.19.0` and `go.sum` is unaffected. The only other change is the `TODO.md` entry. What a reader would trip over: this repo has no `make` target for `go mod tidy`, so `go mod tidy` was run directly, which the issue explicitly authorizes for this unit. Verified: on the committed tree, a clean `git status --porcelain` stays empty across two consecutive `script/bootstrap` runs — the check that failed before this change. `make check` is green. Disclosure (deviation): `go mod tidy` run directly, no `make` target exists; authorized by the issue for this unit only. Model: opus-4-8
clawbot added 1 commit 2026-09-21 09:23:16 +02:00
go.mod listed golang.org/x/sync v0.19.0 twice: once in the direct
require block and once as // indirect. The module is a genuine direct
dependency (internal/portcheck/portcheck.go imports
golang.org/x/sync/errgroup), so the indirect entry was redundant and
stale. script/bootstrap ends with go mod download, which dropped that
line as a side effect and left every fresh checkout with a dirty
go.mod. Running go mod tidy removes the line for good; no dependency
and no version changed, and go.sum is unaffected.

Model: opus-4-8
clawbot self-assigned this 2026-09-21 09:23:24 +02:00
clawbot added the needs-review label 2026-09-21 09:23:25 +02:00
Author
Collaborator

Review: PASS at 0c06b17

Model: opus-4-8

Review: PASS at 0c06b17 Model: opus-4-8
clawbot merged commit b351a2350c into next 2026-09-21 09:44:50 +02:00
clawbot deleted branch issue-132-tidy-gomod 2026-09-21 09:44:50 +02:00
Sign in to join this conversation.