build: re-vendor canonical files from prompts dd4027b (closes #257)

The canonical files are fetched whole from sneak/prompts at dd4027b;
.golangci.yml keeps the livednstest deny entry and .dockerignore adds
/bin. Lint and test are phases of the Dockerfile (golangci-lint
v2.14.0; tests on the Debian Go 1.25.7 image with the same flags), and
the build stage depends on both and stamps the version the canonical
way. Dockerfile.lint is gone; the prettier stages of Dockerfile.fmt
moved into the Dockerfile, so Markdown formatting still runs in Docker.
Every scripted docker build passes --no-cache; script/cibuild
bootstraps, runs script/check, then builds the image. script/fmt-check
absorbs fmt-check-go and fmt-check-markdown. The canonical .gitignore
has no bin/ entry. The new linter raised no findings.

Model: opus-5-5

.editorconfig

@@ -10,6 +10,3 @@ insert_final_newline = true
 
 [Makefile]
 indent_style = tab
-
-[*.go]
-indent_style = tab

.gitea/workflows/check.yml

@@ -1,17 +1,9 @@
 name: check
 on: [push]
-# A new push to a branch cancels that branch's older run, queued or running;
-# runs on other branches, `next` and `main` among them, are left alone.
-concurrency:
-    group: ${{ github.workflow }}-${{ github.ref }}
-    cancel-in-progress: true
 jobs:
     check:
         runs-on: ubuntu-latest
         steps:
             # actions/checkout v4.2.2, 2026-02-22
             - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
-              # script/cibuild needs no token, so none is left in .git/config.
-              with:
-                  persist-credentials: false
             - run: script/cibuild

.gitignore

@@ -45,13 +45,3 @@ node_modules/
 [iI][dD]_[eE][cC][dD][sS][aA]_[sS][kK]
 [iI][dD]_[eE][dD]25519
 [iI][dD]_[eE][dD]25519_[sS][kK]
-
-# This repository's own entries, kept after the canonical content above.
-*.log
-*.out
-*.test
-bin/
-vendor/
-data/
-*.exe
-/dnswatcher

Dockerfile

@@ -18,10 +18,6 @@ RUN golangci-lint run --config .golangci.yml ./...
 # it ends, because the first run already failed.
 # golang 1.25.7-trixie, 2026-10-06
 FROM golang@sha256:2b174ffcf56c7ad0c47d30d2630693265639ddf2a5141149c2da34db921791b4 AS test
-# The file permission tests skip themselves as root, so the tests run as
-# an ordinary user, whose home directory holds Go's build cache.
-RUN useradd --create-home tester
-USER tester
 WORKDIR /src
 COPY go.mod go.sum ./
 RUN go mod download

README.md

@@ -99,11 +99,10 @@ notification endpoint set, changes show only on the dashboard; see
   records, stored per nameserver. Their changes are notified as a hostname's
   are, as a record change, NS query failure, NS recovery, inconsistency or CNAME
   address change, in a message that starts `Domain:` where a hostname's starts
-  `Hostname:`. A domain listed in `DNSWATCHER_SKIP_RECORD_NOTIFICATIONS` gets no
-  record change or inconsistency notification. A domain with no delegation of
-  its own has these records asked at the servers of the zone it is in, as a
-  hostname has. A domain that does not exist has none: they are not asked for,
-  and those saved by an earlier check are removed without a notification.
+  `Hostname:`. A domain with no delegation of its own has these records asked at
+  the servers of the zone it is in, as a hostname has. A domain that does not
+  exist has none: they are not asked for, and those saved by an earlier check
+  are removed without a notification.
 
 ### DNS Hostname Monitoring (Subdomains)
 
@@ -137,14 +136,10 @@ notification endpoint set, changes show only on the dashboard; see
   lower case, because names are case-insensitive and nameservers may answer in
   any letter case. TXT and CAA values keep their letter case; they are not
   lower-cased.
-- Any observable change in any nameserver's response triggers a notification,
-  except a record change or an inconsistency for a domain or hostname listed in
-  `DNSWATCHER_SKIP_RECORD_NOTIFICATIONS`. This includes:
+- Any observable change in any nameserver's response triggers a notification.
+  This includes:
     - **Record change**: A nameserver returns different records than it did on
-      the previous check (additions, removals, value changes). For a domain or
-      hostname listed in `DNSWATCHER_SKIP_RECORD_NOTIFICATIONS`, neither a
-      record change nor an inconsistency is notified; its records are still
-      checked and saved, and its other notifications are sent.
+      the previous check (additions, removals, value changes).
     - **NS query failure**: A nameserver that previously responded becomes
       unreachable (timeout, SERVFAIL, REFUSED, network error). This is distinct
       from "responded with no records": a nameserver that answers NXDOMAIN or
@@ -165,8 +160,7 @@ notification endpoint set, changes show only on the dashboard; see
       failed on it, and answers differently is reported on the check where it
       answers. So is a pair that differs in a record type whose query to either
       nameserver failed on the previous check. If a pair agrees again and later
-      disagrees, the alert is sent again. For a domain or hostname listed in
-      `DNSWATCHER_SKIP_RECORD_NOTIFICATIONS`, no inconsistency is notified.
+      disagrees, the alert is sent again.
     - **CNAME address change**: The addresses at the end of a name's CNAME chain
       differ from those of the previous check. They are found when its
       nameservers answer with a CNAME and no address; a name that answers with
@@ -192,13 +186,9 @@ notification endpoint set, changes show only on the dashboard; see
 - Any change in port availability triggers a notification:
     - Port transitioned from open to closed (or vice versa).
     - New IP appeared (from DNS change): its port state is recorded without a
-      port notification; the DNS change notification shows the new address. A
-      domain or hostname listed in `DNSWATCHER_SKIP_RECORD_NOTIFICATIONS` gets
-      no notification for an address added to its own A or AAAA records.
+      port notification; the DNS change notification shows the new address.
     - IP disappeared (from DNS change) — noted in the DNS change notification;
-      port state for that IP is removed. A domain or hostname listed in
-      `DNSWATCHER_SKIP_RECORD_NOTIFICATIONS` gets no notification for an address
-      removed from its own A or AAAA records. When none of a name's nameservers
+      port state for that IP is removed. When none of a name's nameservers
       answered, its addresses are not known, so the port state saved for them is
       kept.
 
@@ -220,9 +210,7 @@ notification endpoint set, changes show only on the dashboard; see
 
 **Every observable state change produces a notification.** dnswatcher is
 designed as a real-time change feed — degradations, failures, recoveries, and
-routine changes are all reported equally. A domain or hostname listed in
-`DNSWATCHER_SKIP_RECORD_NOTIFICATIONS` gets no record change or inconsistency
-notification.
+routine changes are all reported equally.
 
 Supported notification backends:
 
@@ -421,24 +409,23 @@ following precedence (highest to lowest):
 
 ### Environment Variables
 
-| Variable                               | Description                                                                                                                           | Default               |
-| -------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------- | --------------------- |
-| `PORT`                                 | HTTP listen port                                                                                                                      | `8080`                |
-| `DNSWATCHER_DEBUG`                     | Enable debug logging                                                                                                                  | `false`               |
-| `DNSWATCHER_DATA_DIR`                  | Directory for state file                                                                                                              | `/var/lib/dnswatcher` |
-| `DNSWATCHER_TARGETS`                   | Comma-separated DNS names (auto-classified via PSL)                                                                                   | `""`                  |
-| `DNSWATCHER_SKIP_RECORD_NOTIFICATIONS` | Comma-separated names from `DNSWATCHER_TARGETS` for which no record change or inconsistency is notified; any other name stops startup | `""`                  |
-| `DNSWATCHER_SLACK_WEBHOOK`             | Slack incoming webhook URL                                                                                                            | `""`                  |
-| `DNSWATCHER_MATTERMOST_WEBHOOK`        | Mattermost incoming webhook URL                                                                                                       | `""`                  |
-| `DNSWATCHER_NTFY_TOPIC`                | ntfy topic URL                                                                                                                        | `""`                  |
-| `DNSWATCHER_DNS_INTERVAL`              | DNS check interval, a positive duration such as `30m`; empty means the default, anything else stops startup                           | `1h`                  |
-| `DNSWATCHER_TLS_INTERVAL`              | TLS check interval, a positive duration such as `6h`; empty means the default, anything else stops startup                            | `12h`                 |
-| `DNSWATCHER_TLS_EXPIRY_WARNING`        | Days before expiry to warn                                                                                                            | `7`                   |
-| `DNSWATCHER_SENTRY_DSN`                | Sentry DSN for error reporting                                                                                                        | `""`                  |
-| `DNSWATCHER_MAINTENANCE_MODE`          | Only sets `maintenanceMode` in the health check response; changes nothing else                                                        | `false`               |
-| `DNSWATCHER_METRICS_USERNAME`          | Basic auth username for /metrics, which is served only when this is set                                                               | `""`                  |
-| `DNSWATCHER_METRICS_PASSWORD`          | Basic auth password for /metrics                                                                                                      | `""`                  |
-| `DNSWATCHER_SEND_TEST_NOTIFICATION`    | Send a test notification after first scan completes                                                                                   | `false`               |
+| Variable                            | Description                                                                                                 | Default               |
+| ----------------------------------- | ----------------------------------------------------------------------------------------------------------- | --------------------- |
+| `PORT`                              | HTTP listen port                                                                                            | `8080`                |
+| `DNSWATCHER_DEBUG`                  | Enable debug logging                                                                                        | `false`               |
+| `DNSWATCHER_DATA_DIR`               | Directory for state file                                                                                    | `/var/lib/dnswatcher` |
+| `DNSWATCHER_TARGETS`                | Comma-separated DNS names (auto-classified via PSL)                                                         | `""`                  |
+| `DNSWATCHER_SLACK_WEBHOOK`          | Slack incoming webhook URL                                                                                  | `""`                  |
+| `DNSWATCHER_MATTERMOST_WEBHOOK`     | Mattermost incoming webhook URL                                                                             | `""`                  |
+| `DNSWATCHER_NTFY_TOPIC`             | ntfy topic URL                                                                                              | `""`                  |
+| `DNSWATCHER_DNS_INTERVAL`           | DNS check interval, a positive duration such as `30m`; empty means the default, anything else stops startup | `1h`                  |
+| `DNSWATCHER_TLS_INTERVAL`           | TLS check interval, a positive duration such as `6h`; empty means the default, anything else stops startup  | `12h`                 |
+| `DNSWATCHER_TLS_EXPIRY_WARNING`     | Days before expiry to warn                                                                                  | `7`                   |
+| `DNSWATCHER_SENTRY_DSN`             | Sentry DSN for error reporting                                                                              | `""`                  |
+| `DNSWATCHER_MAINTENANCE_MODE`       | Only sets `maintenanceMode` in the health check response; changes nothing else                              | `false`               |
+| `DNSWATCHER_METRICS_USERNAME`       | Basic auth username for /metrics, which is served only when this is set                                     | `""`                  |
+| `DNSWATCHER_METRICS_PASSWORD`       | Basic auth password for /metrics                                                                            | `""`                  |
+| `DNSWATCHER_SEND_TEST_NOTIFICATION` | Send a test notification after first scan completes                                                         | `false`               |
 
 **`DNSWATCHER_TARGETS` is required.** dnswatcher will refuse to start if no
 monitoring targets are configured. A monitoring daemon with nothing to monitor
@@ -792,9 +779,7 @@ docker run -d \
       nameservers answered, the addresses an earlier check found at the end of
       the chain are used.
 4. **On change detection**: Send notifications to all configured endpoints,
-   update in-memory state, persist to disk. A record change or inconsistency for
-   a domain or hostname listed in `DNSWATCHER_SKIP_RECORD_NOTIFICATIONS` sends
-   no notification, but the state is still updated and saved.
+   update in-memory state, persist to disk.
 5. **Shutdown**: The watcher stops checking and saves the final state to disk,
    and shutdown waits for that save before it goes on. Then it waits for
    in-flight notification deliveries to complete. Both waits share the fx

TODO.md

@@ -22,9 +22,6 @@ trial run of the finished image: https://git.eeqj.de/sneak/dnswatcher/issues/149
 - 2026-10-06: canonical files re-fetched from `sneak/prompts` at `dd4027b`; lint
   and test are phases of the `Dockerfile`, every scripted build uncached (closes
   #257).
-- 2026-10-05: a name listed in `DNSWATCHER_SKIP_RECORD_NOTIFICATIONS` gets no
-  Record Change or Inconsistency notification; a name listed there that is not
-  in `DNSWATCHER_TARGETS` stops startup (closes #255).
 - 2026-10-02: a nameserver whose query for one record type failed while the
   others answered with no records is `ok`, not `nodata` (closes #253).
 - 2026-10-02: a domain that does not exist is shown so, with no nameservers; no

internal/config/config.go

@@ -5,7 +5,6 @@ import (
 	"errors"
 	"fmt"
 	"log/slog"
-	"slices"
 	"strings"
 	"time"
 
@@ -36,10 +35,6 @@ var ErrInvalidInterval = errors.New(
 	"interval must be a positive duration such as 30m or 1h",
 )
 
-// ErrNotInTargets is returned when DNSWATCHER_SKIP_RECORD_NOTIFICATIONS
-// lists a name that is not in DNSWATCHER_TARGETS.
-var ErrNotInTargets = errors.New("name is not in DNSWATCHER_TARGETS")
-
 // Params contains dependencies for Config.
 type Params struct {
 	fx.In
@@ -50,25 +45,24 @@ type Params struct {
 
 // Config holds application configuration.
 type Config struct {
-	Port                    int
-	Debug                   bool
-	DataDir                 string
-	Domains                 []string
-	Hostnames               []string
-	SkipRecordNotifications []string
-	SlackWebhook            string
-	MattermostWebhook       string
-	NtfyTopic               string
-	DNSInterval             time.Duration
-	TLSInterval             time.Duration
-	TLSExpiryWarning        int
-	SentryDSN               string
-	MaintenanceMode         bool
-	MetricsUsername         string
-	MetricsPassword         string
-	SendTestNotification    bool
-	params                  *Params
-	log                     *slog.Logger
+	Port                 int
+	Debug                bool
+	DataDir              string
+	Domains              []string
+	Hostnames            []string
+	SlackWebhook         string
+	MattermostWebhook    string
+	NtfyTopic            string
+	DNSInterval          time.Duration
+	TLSInterval          time.Duration
+	TLSExpiryWarning     int
+	SentryDSN            string
+	MaintenanceMode      bool
+	MetricsUsername      string
+	MetricsPassword      string
+	SendTestNotification bool
+	params               *Params
+	log                  *slog.Logger
 }
 
 // New creates a new Config instance from environment and config files.
@@ -109,7 +103,6 @@ func setupViper(name string) {
 	viper.SetDefault("DEBUG", false)
 	viper.SetDefault("DATA_DIR", "/var/lib/"+name)
 	viper.SetDefault("TARGETS", "")
-	viper.SetDefault("SKIP_RECORD_NOTIFICATIONS", "")
 	viper.SetDefault("SLACK_WEBHOOK", "")
 	viper.SetDefault("MATTERMOST_WEBHOOK", "")
 	viper.SetDefault("NTFY_TOPIC", "")
@@ -154,33 +147,25 @@ func buildConfig(
 		return nil, err
 	}
 
-	skipRecordNotifications, err := parseSkipRecordNotifications(
-		domains, hostnames,
-	)
-	if err != nil {
-		return nil, err
-	}
-
 	cfg := &Config{
-		Port:                    viper.GetInt("PORT"),
-		Debug:                   viper.GetBool("DEBUG"),
-		DataDir:                 viper.GetString("DATA_DIR"),
-		Domains:                 domains,
-		Hostnames:               hostnames,
-		SkipRecordNotifications: skipRecordNotifications,
-		SlackWebhook:            viper.GetString("SLACK_WEBHOOK"),
-		MattermostWebhook:       viper.GetString("MATTERMOST_WEBHOOK"),
-		NtfyTopic:               viper.GetString("NTFY_TOPIC"),
-		DNSInterval:             dnsInterval,
-		TLSInterval:             tlsInterval,
-		TLSExpiryWarning:        viper.GetInt("TLS_EXPIRY_WARNING"),
-		SentryDSN:               viper.GetString("SENTRY_DSN"),
-		MaintenanceMode:         viper.GetBool("MAINTENANCE_MODE"),
-		MetricsUsername:         viper.GetString("METRICS_USERNAME"),
-		MetricsPassword:         viper.GetString("METRICS_PASSWORD"),
-		SendTestNotification:    viper.GetBool("SEND_TEST_NOTIFICATION"),
-		params:                  params,
-		log:                     log,
+		Port:                 viper.GetInt("PORT"),
+		Debug:                viper.GetBool("DEBUG"),
+		DataDir:              viper.GetString("DATA_DIR"),
+		Domains:              domains,
+		Hostnames:            hostnames,
+		SlackWebhook:         viper.GetString("SLACK_WEBHOOK"),
+		MattermostWebhook:    viper.GetString("MATTERMOST_WEBHOOK"),
+		NtfyTopic:            viper.GetString("NTFY_TOPIC"),
+		DNSInterval:          dnsInterval,
+		TLSInterval:          tlsInterval,
+		TLSExpiryWarning:     viper.GetInt("TLS_EXPIRY_WARNING"),
+		SentryDSN:            viper.GetString("SENTRY_DSN"),
+		MaintenanceMode:      viper.GetBool("MAINTENANCE_MODE"),
+		MetricsUsername:      viper.GetString("METRICS_USERNAME"),
+		MetricsPassword:      viper.GetString("METRICS_PASSWORD"),
+		SendTestNotification: viper.GetBool("SEND_TEST_NOTIFICATION"),
+		params:               params,
+		log:                  log,
 	}
 
 	return cfg, nil
@@ -219,36 +204,6 @@ func parseAndValidateTargets() ([]string, []string, error) {
 	return domains, hostnames, nil
 }
 
-// parseSkipRecordNotifications reads DNSWATCHER_SKIP_RECORD_NOTIFICATIONS,
-// a comma-separated list of names from the targets. Each name is written
-// as ClassifyTargets writes a target, in lower case without a trailing
-// dot, and a name listed more than once is kept once. A name that is
-// not one of domains or hostnames is an error naming it.
-func parseSkipRecordNotifications(
-	domains, hostnames []string,
-) ([]string, error) {
-	value := viper.GetString("SKIP_RECORD_NOTIFICATIONS")
-
-	var names []string
-
-	for _, listed := range parseCSV(value) {
-		name := strings.ToLower(strings.TrimSuffix(listed, "."))
-
-		if !slices.Contains(domains, name) && !slices.Contains(hostnames, name) {
-			return nil, fmt.Errorf(
-				"invalid DNSWATCHER_SKIP_RECORD_NOTIFICATIONS %q: %w",
-				listed, ErrNotInTargets,
-			)
-		}
-
-		if !slices.Contains(names, name) {
-			names = append(names, name)
-		}
-	}
-
-	return names, nil
-}
-
 func parseCSV(input string) []string {
 	if input == "" {
 		return nil

internal/config/config_test.go

@@ -57,7 +57,6 @@ func TestNew_DefaultValues(t *testing.T) {
 	assert.Empty(t, cfg.MetricsUsername)
 	assert.Empty(t, cfg.MetricsPassword)
 	assert.False(t, cfg.SendTestNotification)
-	assert.Empty(t, cfg.SkipRecordNotifications)
 }
 
 func TestNew_EnvironmentOverrides(t *testing.T) {
@@ -236,33 +235,6 @@ func TestNew_TargetsWithTrailingComma(t *testing.T) {
 		"trailing comma should be ignored")
 }
 
-func TestNew_SkipRecordNotifications(t *testing.T) {
-	viper.Reset()
-	t.Setenv("DNSWATCHER_TARGETS", "example.net,www.example.net,example.org")
-	t.Setenv("DNSWATCHER_SKIP_RECORD_NOTIFICATIONS",
-		" WWW.Example.net. , example.net,www.example.net")
-
-	cfg, err := config.New(nil, newTestParams(t))
-	require.NoError(t, err)
-	assert.Equal(t,
-		[]string{"www.example.net", "example.net"},
-		cfg.SkipRecordNotifications,
-		"names are written as targets are, each once",
-	)
-}
-
-func TestNew_SkipRecordNotificationsNotInTargetsStopsStartup(t *testing.T) {
-	viper.Reset()
-	t.Setenv("DNSWATCHER_TARGETS", "example.net")
-	t.Setenv("DNSWATCHER_SKIP_RECORD_NOTIFICATIONS",
-		"example.net,www.example.net")
-
-	_, err := config.New(nil, newTestParams(t))
-	require.ErrorIs(t, err, config.ErrNotInTargets)
-	require.ErrorContains(t, err, "DNSWATCHER_SKIP_RECORD_NOTIFICATIONS")
-	require.ErrorContains(t, err, `"www.example.net"`)
-}
-
 func TestNew_CustomDNSIntervalDuration(t *testing.T) {
 	viper.Reset()
 	t.Setenv("DNSWATCHER_TARGETS", "example.com")

internal/watcher/skiprecordnotifications_test.go

@@ -1,107 +0,0 @@
-package watcher_test
-
-import (
-	"slices"
-	"testing"
-
-	"sneak.berlin/go/dnswatcher/internal/config"
-	"sneak.berlin/go/dnswatcher/internal/state"
-	"sneak.berlin/go/dnswatcher/internal/watcher"
-)
-
-// TestSkipRecordNotificationsAlerts runs the hostname change detection
-// for two names on the same check: nsA's address changes, so that nsA
-// now differs from nsB, and nsC stops answering. The name in
-// SkipRecordNotifications gets only the NS Failure; the other name also
-// gets the Record Change and the Inconsistency.
-func TestSkipRecordNotificationsAlerts(t *testing.T) {
-	t.Parallel()
-
-	const skipped = "skipped.example.net"
-
-	prev := saved(map[string]*state.NameserverRecordState{
-		nsA: answered(map[string][]string{"A": {ip1}}),
-		nsB: answered(map[string][]string{"A": {ip1}}),
-		nsC: answered(map[string][]string{"A": {ip1}}),
-	})
-	current := saved(map[string]*state.NameserverRecordState{
-		nsA: answered(map[string][]string{"A": {ip2}}),
-		nsB: answered(map[string][]string{"A": {ip1}}),
-		nsC: failed(),
-	})
-
-	cfg := &config.Config{
-		Hostnames:               []string{host, skipped},
-		SkipRecordNotifications: []string{skipped},
-	}
-
-	// The hostname change detection uses only the configuration and the
-	// notifier.
-	notifier := &mockNotifier{}
-	w := watcher.NewForTest(cfg, nil, nil, nil, nil, notifier)
-
-	w.DetectHostnameChanges(t.Context(), host, prev, current)
-	w.DetectHostnameChanges(t.Context(), skipped, prev, current)
-
-	sent := notifier.getNotifications()
-	titles := make([]string, 0, len(sent))
-
-	for _, n := range sent {
-		titles = append(titles, n.Title)
-	}
-
-	slices.Sort(titles)
-
-	want := []string{
-		"Inconsistency: " + host,
-		"NS Failure: " + skipped,
-		"NS Failure: " + host,
-		"Record Change: " + host,
-	}
-
-	if !slices.Equal(titles, want) {
-		t.Errorf("sent %v, want %v", titles, want)
-	}
-}
-
-// TestSkipRecordNotificationsCheck checks testHost, which is in
-// SkipRecordNotifications, from a saved state in which every nameserver
-// live DNS lists answered with an address live DNS never returns. No
-// Record Change and no Inconsistency is sent, and the check still saves
-// what the nameservers answer.
-func TestSkipRecordNotificationsCheck(t *testing.T) {
-	t.Parallel()
-
-	cfg := defaultTestConfig(t)
-	cfg.Hostnames = []string{testHost}
-	cfg.SkipRecordNotifications = []string{testHost}
-
-	nameservers := lookupNameservers(t, testHost)
-
-	_, deps := runChecks(t, cfg, func(deps *testDeps) {
-		byNameserver := make(map[string]*state.NameserverRecordState)
-		for _, ns := range nameservers {
-			byNameserver[ns] = answered(map[string][]string{"A": {oldIP}})
-		}
-
-		deps.state.SetHostnameState(testHost, saved(byNameserver))
-	})
-
-	for _, title := range []string{
-		"Record Change: " + testHost,
-		"Inconsistency: " + testHost,
-	} {
-		if n := countNotifications(deps, title); n != 0 {
-			t.Errorf("sent %d %q, want 0", n, title)
-		}
-	}
-
-	// A nameserver whose query for A failed keeps oldIP, so the check
-	// is that some address live DNS gave was saved.
-	hs, _ := deps.state.GetHostnameState(testHost)
-	fromLiveDNS := func(ip string) bool { return ip != oldIP }
-
-	if !slices.ContainsFunc(addresses(hs), fromLiveDNS) {
-		t.Errorf("saved addresses %v, want those live DNS gave", addresses(hs))
-	}
-}

internal/watcher/watcher.go

@@ -730,16 +730,12 @@ func (w *Watcher) detectCNAMEAddressChanges(
 // failed on either check has no records to compare. The records kept
 // for a record type whose query failed are compared too, but not those
 // of a type in UnknownTypes on either check, which the message leaves
-// out as well. Nothing is sent for a name in SkipRecordNotifications.
+// out as well.
 func (w *Watcher) detectRecordChanges(
 	ctx context.Context,
 	hostname string,
 	prev, current *state.HostnameState,
 ) {
-	if slices.Contains(w.config.SkipRecordNotifications, hostname) {
-		return
-	}
-
 	for ns, cur := range current.RecordsByNameserver {
 		prevNS, ok := prev.RecordsByNameserver[ns]
 		if !ok || prevNS.Status != statusOK || cur.Status != statusOK {
@@ -839,18 +835,11 @@ func (w *Watcher) detectNSFailures(
 	}
 }
 
-// detectInconsistencies notifies each pair of nameservers that newly
-// disagree (see newlyDisagreeingPairs). Nothing is sent for a name in
-// SkipRecordNotifications.
 func (w *Watcher) detectInconsistencies(
 	ctx context.Context,
 	hostname string,
 	prev, current *state.HostnameState,
 ) {
-	if slices.Contains(w.config.SkipRecordNotifications, hostname) {
-		return
-	}
-
 	for _, pair := range newlyDisagreeingPairs(prev, current) {
 		ns1, ns2 := pair[0], pair[1]
 		state1 := current.RecordsByNameserver[ns1]