Compare commits
1 Commits
ae092dad8c
...
fix/mock-r
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
889855306f |
@@ -1,9 +1,26 @@
|
|||||||
name: check
|
name: Check
|
||||||
on: [push]
|
|
||||||
|
on:
|
||||||
|
push:
|
||||||
|
branches: [main]
|
||||||
|
pull_request:
|
||||||
|
branches: [main]
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
check:
|
check:
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
# actions/checkout v4.2.2, 2026-02-28
|
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
|
||||||
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
|
|
||||||
- run: docker build .
|
- uses: actions/setup-go@40f1582b2485089dde7abd97c1529aa768e1baff # v5
|
||||||
|
with:
|
||||||
|
go-version-file: go.mod
|
||||||
|
|
||||||
|
- name: Install golangci-lint
|
||||||
|
run: go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@5d1e709b7be35cb2025444e19de266b056b7b7ee # v2.10.1
|
||||||
|
|
||||||
|
- name: Install goimports
|
||||||
|
run: go install golang.org/x/tools/cmd/goimports@009367f5c17a8d4c45a961a3a509277190a9a6f0 # v0.42.0
|
||||||
|
|
||||||
|
- name: Run make check
|
||||||
|
run: make check
|
||||||
|
|||||||
15
Dockerfile
15
Dockerfile
@@ -1,13 +1,11 @@
|
|||||||
# Build stage
|
# Build stage
|
||||||
# golang 1.25-alpine, 2026-02-28
|
FROM golang:1.25-alpine AS builder
|
||||||
FROM golang@sha256:f6751d823c26342f9506c03797d2527668d095b0a15f1862cddb4d927a7a4ced AS builder
|
|
||||||
|
|
||||||
RUN apk add --no-cache git make gcc musl-dev binutils-gold
|
RUN apk add --no-cache git make gcc musl-dev
|
||||||
|
|
||||||
# golangci-lint v2.10.1
|
# Install golangci-lint v2
|
||||||
RUN go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@5d1e709b7be35cb2025444e19de266b056b7b7ee
|
RUN go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest
|
||||||
# goimports v0.42.0
|
RUN go install golang.org/x/tools/cmd/goimports@latest
|
||||||
RUN go install golang.org/x/tools/cmd/goimports@009367f5c17a8d4c45a961a3a509277190a9a6f0
|
|
||||||
|
|
||||||
WORKDIR /src
|
WORKDIR /src
|
||||||
COPY go.mod go.sum ./
|
COPY go.mod go.sum ./
|
||||||
@@ -22,8 +20,7 @@ RUN make check
|
|||||||
RUN make build
|
RUN make build
|
||||||
|
|
||||||
# Runtime stage
|
# Runtime stage
|
||||||
# alpine 3.21, 2026-02-28
|
FROM alpine:3.21
|
||||||
FROM alpine@sha256:c3f8e73fdb79deaebaa2037150150191b9dcbfba68b4a46d70103204c53f4709
|
|
||||||
|
|
||||||
RUN apk add --no-cache ca-certificates tzdata
|
RUN apk add --no-cache ca-certificates tzdata
|
||||||
|
|
||||||
|
|||||||
34
TESTING.md
34
TESTING.md
@@ -1,34 +0,0 @@
|
|||||||
# Testing Policy
|
|
||||||
|
|
||||||
## DNS Resolution Tests
|
|
||||||
|
|
||||||
All resolver tests **MUST** use live queries against real DNS servers.
|
|
||||||
No mocking of the DNS client layer is permitted.
|
|
||||||
|
|
||||||
### Rationale
|
|
||||||
|
|
||||||
The resolver performs iterative resolution from root nameservers through
|
|
||||||
the full delegation chain. Mocked responses cannot faithfully represent
|
|
||||||
the variety of real-world DNS behavior (truncation, referrals, glue
|
|
||||||
records, DNSSEC, varied response times, EDNS, etc.). Testing against
|
|
||||||
real servers ensures the resolver works correctly in production.
|
|
||||||
|
|
||||||
### Constraints
|
|
||||||
|
|
||||||
- Tests hit real DNS infrastructure and require network access
|
|
||||||
- Test duration depends on network conditions; timeout tuning keeps
|
|
||||||
the suite within the 30-second target
|
|
||||||
- Query timeout is calibrated to 3× maximum antipodal RTT (~300ms)
|
|
||||||
plus processing margin
|
|
||||||
- Root server fan-out is limited to reduce parallel query load
|
|
||||||
- Flaky failures from transient network issues are acceptable and
|
|
||||||
should be investigated as potential resolver bugs, not papered over
|
|
||||||
with mocks or skip flags
|
|
||||||
|
|
||||||
### What NOT to do
|
|
||||||
|
|
||||||
- **Do not mock `DNSClient`** for resolver tests (the mock constructor
|
|
||||||
exists for unit-testing other packages that consume the resolver)
|
|
||||||
- **Do not add `-short` flags** to skip slow tests
|
|
||||||
- **Do not increase `-timeout`** to hide hanging queries
|
|
||||||
- **Do not modify linter configuration** to suppress findings
|
|
||||||
@@ -4,6 +4,11 @@ import "errors"
|
|||||||
|
|
||||||
// Sentinel errors returned by the resolver.
|
// Sentinel errors returned by the resolver.
|
||||||
var (
|
var (
|
||||||
|
// ErrNotImplemented indicates a method is stubbed out.
|
||||||
|
ErrNotImplemented = errors.New(
|
||||||
|
"resolver not yet implemented",
|
||||||
|
)
|
||||||
|
|
||||||
// ErrNoNameservers is returned when no authoritative NS
|
// ErrNoNameservers is returned when no authoritative NS
|
||||||
// could be discovered for a domain.
|
// could be discovered for a domain.
|
||||||
ErrNoNameservers = errors.New(
|
ErrNoNameservers = errors.New(
|
||||||
|
|||||||
@@ -13,7 +13,7 @@ import (
|
|||||||
)
|
)
|
||||||
|
|
||||||
const (
|
const (
|
||||||
queryTimeoutDuration = 2 * time.Second
|
queryTimeoutDuration = 5 * time.Second
|
||||||
maxRetries = 2
|
maxRetries = 2
|
||||||
maxDelegation = 20
|
maxDelegation = 20
|
||||||
timeoutMultiplier = 2
|
timeoutMultiplier = 2
|
||||||
@@ -227,7 +227,7 @@ func (r *Resolver) followDelegation(
|
|||||||
|
|
||||||
authNS := extractNSSet(resp.Ns)
|
authNS := extractNSSet(resp.Ns)
|
||||||
if len(authNS) == 0 {
|
if len(authNS) == 0 {
|
||||||
return r.resolveNSIterative(ctx, domain)
|
return r.resolveNSRecursive(ctx, domain)
|
||||||
}
|
}
|
||||||
|
|
||||||
glue := extractGlue(resp.Extra)
|
glue := extractGlue(resp.Extra)
|
||||||
@@ -291,84 +291,60 @@ func (r *Resolver) resolveNSIPs(
|
|||||||
return ips
|
return ips
|
||||||
}
|
}
|
||||||
|
|
||||||
// resolveNSIterative queries for NS records using iterative
|
// resolveNSRecursive queries for NS records using recursive
|
||||||
// resolution as a fallback when followDelegation finds no
|
// resolution as a fallback for intercepted environments.
|
||||||
// authoritative answer in the delegation chain.
|
func (r *Resolver) resolveNSRecursive(
|
||||||
func (r *Resolver) resolveNSIterative(
|
|
||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
domain string,
|
domain string,
|
||||||
) ([]string, error) {
|
) ([]string, error) {
|
||||||
if checkCtx(ctx) != nil {
|
|
||||||
return nil, ErrContextCanceled
|
|
||||||
}
|
|
||||||
|
|
||||||
domain = dns.Fqdn(domain)
|
domain = dns.Fqdn(domain)
|
||||||
servers := rootServerList()
|
msg := new(dns.Msg)
|
||||||
|
msg.SetQuestion(domain, dns.TypeNS)
|
||||||
|
msg.RecursionDesired = true
|
||||||
|
|
||||||
for range maxDelegation {
|
for _, ip := range rootServerList()[:3] {
|
||||||
if checkCtx(ctx) != nil {
|
if checkCtx(ctx) != nil {
|
||||||
return nil, ErrContextCanceled
|
return nil, ErrContextCanceled
|
||||||
}
|
}
|
||||||
|
|
||||||
resp, err := r.queryServers(
|
addr := net.JoinHostPort(ip, "53")
|
||||||
ctx, servers, domain, dns.TypeNS,
|
|
||||||
)
|
resp, _, err := r.client.ExchangeContext(ctx, msg, addr)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, err
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
nsNames := extractNSSet(resp.Answer)
|
nsNames := extractNSSet(resp.Answer)
|
||||||
if len(nsNames) > 0 {
|
if len(nsNames) > 0 {
|
||||||
return nsNames, nil
|
return nsNames, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// Follow delegation.
|
|
||||||
authNS := extractNSSet(resp.Ns)
|
|
||||||
if len(authNS) == 0 {
|
|
||||||
break
|
|
||||||
}
|
|
||||||
|
|
||||||
glue := extractGlue(resp.Extra)
|
|
||||||
nextServers := glueIPs(authNS, glue)
|
|
||||||
|
|
||||||
if len(nextServers) == 0 {
|
|
||||||
break
|
|
||||||
}
|
|
||||||
|
|
||||||
servers = nextServers
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return nil, ErrNoNameservers
|
return nil, ErrNoNameservers
|
||||||
}
|
}
|
||||||
|
|
||||||
// resolveARecord resolves a hostname to IPv4 addresses using
|
// resolveARecord resolves a hostname to IPv4 addresses.
|
||||||
// iterative resolution through the delegation chain.
|
|
||||||
func (r *Resolver) resolveARecord(
|
func (r *Resolver) resolveARecord(
|
||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
hostname string,
|
hostname string,
|
||||||
) ([]string, error) {
|
) ([]string, error) {
|
||||||
if checkCtx(ctx) != nil {
|
|
||||||
return nil, ErrContextCanceled
|
|
||||||
}
|
|
||||||
|
|
||||||
hostname = dns.Fqdn(hostname)
|
hostname = dns.Fqdn(hostname)
|
||||||
servers := rootServerList()
|
msg := new(dns.Msg)
|
||||||
|
msg.SetQuestion(hostname, dns.TypeA)
|
||||||
|
msg.RecursionDesired = true
|
||||||
|
|
||||||
for range maxDelegation {
|
for _, ip := range rootServerList()[:3] {
|
||||||
if checkCtx(ctx) != nil {
|
if checkCtx(ctx) != nil {
|
||||||
return nil, ErrContextCanceled
|
return nil, ErrContextCanceled
|
||||||
}
|
}
|
||||||
|
|
||||||
resp, err := r.queryServers(
|
addr := net.JoinHostPort(ip, "53")
|
||||||
ctx, servers, hostname, dns.TypeA,
|
|
||||||
)
|
resp, _, err := r.client.ExchangeContext(ctx, msg, addr)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return nil, fmt.Errorf(
|
continue
|
||||||
"resolving %s: %w", hostname, err,
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check for A records in the answer section.
|
|
||||||
var ips []string
|
var ips []string
|
||||||
|
|
||||||
for _, rr := range resp.Answer {
|
for _, rr := range resp.Answer {
|
||||||
@@ -380,24 +356,6 @@ func (r *Resolver) resolveARecord(
|
|||||||
if len(ips) > 0 {
|
if len(ips) > 0 {
|
||||||
return ips, nil
|
return ips, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// Follow delegation if present.
|
|
||||||
authNS := extractNSSet(resp.Ns)
|
|
||||||
if len(authNS) == 0 {
|
|
||||||
break
|
|
||||||
}
|
|
||||||
|
|
||||||
glue := extractGlue(resp.Extra)
|
|
||||||
nextServers := glueIPs(authNS, glue)
|
|
||||||
|
|
||||||
if len(nextServers) == 0 {
|
|
||||||
// Resolve NS IPs iteratively — but guard
|
|
||||||
// against infinite recursion by using only
|
|
||||||
// already-resolved servers.
|
|
||||||
break
|
|
||||||
}
|
|
||||||
|
|
||||||
servers = nextServers
|
|
||||||
}
|
}
|
||||||
|
|
||||||
return nil, fmt.Errorf(
|
return nil, fmt.Errorf(
|
||||||
@@ -460,23 +418,6 @@ func (r *Resolver) QueryNameserver(
|
|||||||
return r.queryAllTypes(ctx, nsHostname, nsIPs[0], hostname)
|
return r.queryAllTypes(ctx, nsHostname, nsIPs[0], hostname)
|
||||||
}
|
}
|
||||||
|
|
||||||
// QueryNameserverIP queries a nameserver by its IP address directly,
|
|
||||||
// bypassing NS hostname resolution.
|
|
||||||
func (r *Resolver) QueryNameserverIP(
|
|
||||||
ctx context.Context,
|
|
||||||
nsHostname string,
|
|
||||||
nsIP string,
|
|
||||||
hostname string,
|
|
||||||
) (*NameserverResponse, error) {
|
|
||||||
if checkCtx(ctx) != nil {
|
|
||||||
return nil, ErrContextCanceled
|
|
||||||
}
|
|
||||||
|
|
||||||
hostname = dns.Fqdn(hostname)
|
|
||||||
|
|
||||||
return r.queryAllTypes(ctx, nsHostname, nsIP, hostname)
|
|
||||||
}
|
|
||||||
|
|
||||||
func (r *Resolver) queryAllTypes(
|
func (r *Resolver) queryAllTypes(
|
||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
nsHostname string,
|
nsHostname string,
|
||||||
@@ -504,7 +445,6 @@ func (r *Resolver) queryAllTypes(
|
|||||||
type queryState struct {
|
type queryState struct {
|
||||||
gotNXDomain bool
|
gotNXDomain bool
|
||||||
gotSERVFAIL bool
|
gotSERVFAIL bool
|
||||||
gotTimeout bool
|
|
||||||
hasRecords bool
|
hasRecords bool
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -542,10 +482,6 @@ func (r *Resolver) querySingleType(
|
|||||||
) {
|
) {
|
||||||
msg, err := r.queryDNS(ctx, nsIP, hostname, qtype)
|
msg, err := r.queryDNS(ctx, nsIP, hostname, qtype)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
if isTimeout(err) {
|
|
||||||
state.gotTimeout = true
|
|
||||||
}
|
|
||||||
|
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -583,26 +519,12 @@ func collectAnswerRecords(
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// isTimeout checks whether an error is a network timeout.
|
|
||||||
func isTimeout(err error) bool {
|
|
||||||
var netErr net.Error
|
|
||||||
if errors.As(err, &netErr) {
|
|
||||||
return netErr.Timeout()
|
|
||||||
}
|
|
||||||
|
|
||||||
return false
|
|
||||||
}
|
|
||||||
|
|
||||||
func classifyResponse(resp *NameserverResponse, state queryState) {
|
func classifyResponse(resp *NameserverResponse, state queryState) {
|
||||||
switch {
|
switch {
|
||||||
case state.gotNXDomain && !state.hasRecords:
|
case state.gotNXDomain && !state.hasRecords:
|
||||||
resp.Status = StatusNXDomain
|
resp.Status = StatusNXDomain
|
||||||
case state.gotTimeout && !state.hasRecords:
|
|
||||||
resp.Status = StatusTimeout
|
|
||||||
resp.Error = "all queries timed out"
|
|
||||||
case state.gotSERVFAIL && !state.hasRecords:
|
case state.gotSERVFAIL && !state.hasRecords:
|
||||||
resp.Status = StatusError
|
resp.Status = StatusError
|
||||||
resp.Error = "server returned SERVFAIL"
|
|
||||||
case !state.hasRecords && !state.gotNXDomain:
|
case !state.hasRecords && !state.gotNXDomain:
|
||||||
resp.Status = StatusNoData
|
resp.Status = StatusNoData
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -17,7 +17,6 @@ const (
|
|||||||
StatusError = "error"
|
StatusError = "error"
|
||||||
StatusNXDomain = "nxdomain"
|
StatusNXDomain = "nxdomain"
|
||||||
StatusNoData = "nodata"
|
StatusNoData = "nodata"
|
||||||
StatusTimeout = "timeout"
|
|
||||||
)
|
)
|
||||||
|
|
||||||
// MaxCNAMEDepth is the maximum CNAME chain depth to follow.
|
// MaxCNAMEDepth is the maximum CNAME chain depth to follow.
|
||||||
|
|||||||
@@ -2,6 +2,7 @@ package resolver_test
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
|
"fmt"
|
||||||
"log/slog"
|
"log/slog"
|
||||||
"net"
|
"net"
|
||||||
"os"
|
"os"
|
||||||
@@ -17,6 +18,497 @@ import (
|
|||||||
"sneak.berlin/go/dnswatcher/internal/resolver"
|
"sneak.berlin/go/dnswatcher/internal/resolver"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// ----------------------------------------------------------------
|
||||||
|
// Mock DNS client
|
||||||
|
// ----------------------------------------------------------------
|
||||||
|
|
||||||
|
// mockDNSClient implements resolver.DNSClient with canned responses.
|
||||||
|
type mockDNSClient struct {
|
||||||
|
handlers map[string]func(msg *dns.Msg) *dns.Msg
|
||||||
|
}
|
||||||
|
|
||||||
|
func newMockClient() *mockDNSClient {
|
||||||
|
return &mockDNSClient{
|
||||||
|
handlers: make(map[string]func(msg *dns.Msg) *dns.Msg),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (m *mockDNSClient) ExchangeContext(
|
||||||
|
ctx context.Context,
|
||||||
|
msg *dns.Msg,
|
||||||
|
addr string,
|
||||||
|
) (*dns.Msg, time.Duration, error) {
|
||||||
|
err := ctx.Err()
|
||||||
|
if err != nil {
|
||||||
|
return nil, 0, err
|
||||||
|
}
|
||||||
|
|
||||||
|
host, _, _ := net.SplitHostPort(addr)
|
||||||
|
if host == "" {
|
||||||
|
host = addr
|
||||||
|
}
|
||||||
|
|
||||||
|
qname := msg.Question[0].Name
|
||||||
|
qtype := dns.TypeToString[msg.Question[0].Qtype]
|
||||||
|
|
||||||
|
resp := m.findHandler(host, qname, qtype, msg)
|
||||||
|
|
||||||
|
return resp, time.Millisecond, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (m *mockDNSClient) findHandler(
|
||||||
|
host, qname, qtype string,
|
||||||
|
msg *dns.Msg,
|
||||||
|
) *dns.Msg {
|
||||||
|
key := fmt.Sprintf(
|
||||||
|
"%s|%s|%s", host, strings.ToLower(qname), qtype,
|
||||||
|
)
|
||||||
|
|
||||||
|
if h, ok := m.handlers[key]; ok {
|
||||||
|
return h(msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
wildKey := fmt.Sprintf(
|
||||||
|
"*|%s|%s", strings.ToLower(qname), qtype,
|
||||||
|
)
|
||||||
|
|
||||||
|
if h, ok := m.handlers[wildKey]; ok {
|
||||||
|
return h(msg)
|
||||||
|
}
|
||||||
|
|
||||||
|
resp := new(dns.Msg)
|
||||||
|
resp.SetReply(msg)
|
||||||
|
|
||||||
|
return resp
|
||||||
|
}
|
||||||
|
|
||||||
|
func (m *mockDNSClient) on(
|
||||||
|
server, qname, qtype string,
|
||||||
|
handler func(msg *dns.Msg) *dns.Msg,
|
||||||
|
) {
|
||||||
|
key := fmt.Sprintf(
|
||||||
|
"%s|%s|%s",
|
||||||
|
server, dns.Fqdn(strings.ToLower(qname)), qtype,
|
||||||
|
)
|
||||||
|
m.handlers[key] = handler
|
||||||
|
}
|
||||||
|
|
||||||
|
// ----------------------------------------------------------------
|
||||||
|
// Response builders
|
||||||
|
// ----------------------------------------------------------------
|
||||||
|
|
||||||
|
func referralResponse(
|
||||||
|
msg *dns.Msg,
|
||||||
|
nsNames []string,
|
||||||
|
glue map[string]string,
|
||||||
|
) *dns.Msg {
|
||||||
|
resp := new(dns.Msg)
|
||||||
|
resp.SetReply(msg)
|
||||||
|
|
||||||
|
for _, ns := range nsNames {
|
||||||
|
resp.Ns = append(resp.Ns, &dns.NS{
|
||||||
|
Hdr: dns.RR_Header{
|
||||||
|
Name: msg.Question[0].Name,
|
||||||
|
Rrtype: dns.TypeNS,
|
||||||
|
Class: dns.ClassINET,
|
||||||
|
Ttl: 3600,
|
||||||
|
},
|
||||||
|
Ns: dns.Fqdn(ns),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
for name, ip := range glue {
|
||||||
|
resp.Extra = append(resp.Extra, &dns.A{
|
||||||
|
Hdr: dns.RR_Header{
|
||||||
|
Name: dns.Fqdn(name),
|
||||||
|
Rrtype: dns.TypeA,
|
||||||
|
Class: dns.ClassINET,
|
||||||
|
Ttl: 3600,
|
||||||
|
},
|
||||||
|
A: net.ParseIP(ip),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
return resp
|
||||||
|
}
|
||||||
|
|
||||||
|
func nsAnswerResponse(
|
||||||
|
msg *dns.Msg, nsNames []string,
|
||||||
|
) *dns.Msg {
|
||||||
|
resp := new(dns.Msg)
|
||||||
|
resp.SetReply(msg)
|
||||||
|
|
||||||
|
for _, ns := range nsNames {
|
||||||
|
resp.Answer = append(resp.Answer, &dns.NS{
|
||||||
|
Hdr: dns.RR_Header{
|
||||||
|
Name: msg.Question[0].Name,
|
||||||
|
Rrtype: dns.TypeNS,
|
||||||
|
Class: dns.ClassINET,
|
||||||
|
Ttl: 3600,
|
||||||
|
},
|
||||||
|
Ns: dns.Fqdn(ns),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
return resp
|
||||||
|
}
|
||||||
|
|
||||||
|
func nxdomainResponse(msg *dns.Msg) *dns.Msg {
|
||||||
|
resp := new(dns.Msg)
|
||||||
|
resp.SetReply(msg)
|
||||||
|
resp.Rcode = dns.RcodeNameError
|
||||||
|
|
||||||
|
return resp
|
||||||
|
}
|
||||||
|
|
||||||
|
func aResponse(
|
||||||
|
msg *dns.Msg, name string, ip string,
|
||||||
|
) *dns.Msg {
|
||||||
|
resp := new(dns.Msg)
|
||||||
|
resp.SetReply(msg)
|
||||||
|
resp.Answer = append(resp.Answer, &dns.A{
|
||||||
|
Hdr: dns.RR_Header{
|
||||||
|
Name: dns.Fqdn(name), Rrtype: dns.TypeA,
|
||||||
|
Class: dns.ClassINET, Ttl: 300,
|
||||||
|
},
|
||||||
|
A: net.ParseIP(ip),
|
||||||
|
})
|
||||||
|
|
||||||
|
return resp
|
||||||
|
}
|
||||||
|
|
||||||
|
func aaaaResponse(
|
||||||
|
msg *dns.Msg, name string, ip string,
|
||||||
|
) *dns.Msg {
|
||||||
|
resp := new(dns.Msg)
|
||||||
|
resp.SetReply(msg)
|
||||||
|
resp.Answer = append(resp.Answer, &dns.AAAA{
|
||||||
|
Hdr: dns.RR_Header{
|
||||||
|
Name: dns.Fqdn(name), Rrtype: dns.TypeAAAA,
|
||||||
|
Class: dns.ClassINET, Ttl: 300,
|
||||||
|
},
|
||||||
|
AAAA: net.ParseIP(ip),
|
||||||
|
})
|
||||||
|
|
||||||
|
return resp
|
||||||
|
}
|
||||||
|
|
||||||
|
func emptyResponse(msg *dns.Msg) *dns.Msg {
|
||||||
|
resp := new(dns.Msg)
|
||||||
|
resp.SetReply(msg)
|
||||||
|
|
||||||
|
return resp
|
||||||
|
}
|
||||||
|
|
||||||
|
// ----------------------------------------------------------------
|
||||||
|
// Mock DNS hierarchy setup
|
||||||
|
// ----------------------------------------------------------------
|
||||||
|
|
||||||
|
// mockData holds all test DNS hierarchy configuration.
|
||||||
|
type mockData struct {
|
||||||
|
tldNS []string
|
||||||
|
tldGlue map[string]string
|
||||||
|
exNS []string
|
||||||
|
exGlue map[string]string
|
||||||
|
cfNS []string
|
||||||
|
cfGlue map[string]string
|
||||||
|
}
|
||||||
|
|
||||||
|
func newMockData() mockData {
|
||||||
|
return mockData{
|
||||||
|
tldNS: []string{"ns1.tld.com", "ns2.tld.com"},
|
||||||
|
tldGlue: map[string]string{
|
||||||
|
"ns1.tld.com": "10.0.0.1",
|
||||||
|
"ns2.tld.com": "10.0.0.2",
|
||||||
|
},
|
||||||
|
exNS: []string{
|
||||||
|
"ns1.example.com", "ns2.example.com",
|
||||||
|
"ns3.example.com",
|
||||||
|
},
|
||||||
|
exGlue: map[string]string{
|
||||||
|
"ns1.example.com": "10.1.0.1",
|
||||||
|
"ns2.example.com": "10.1.0.2",
|
||||||
|
"ns3.example.com": "10.1.0.3",
|
||||||
|
},
|
||||||
|
cfNS: []string{
|
||||||
|
"ns1.cloudflare.com", "ns2.cloudflare.com",
|
||||||
|
},
|
||||||
|
cfGlue: map[string]string{
|
||||||
|
"ns1.cloudflare.com": "10.2.0.1",
|
||||||
|
"ns2.cloudflare.com": "10.2.0.2",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func rootIPList() []string {
|
||||||
|
return []string{
|
||||||
|
"198.41.0.4", "170.247.170.2", "192.33.4.12",
|
||||||
|
"199.7.91.13", "192.203.230.10", "192.5.5.241",
|
||||||
|
"192.112.36.4", "198.97.190.53", "192.36.148.17",
|
||||||
|
"192.58.128.30", "193.0.14.129", "199.7.83.42",
|
||||||
|
"202.12.27.33",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func allQueryTypes() []string {
|
||||||
|
return []string{
|
||||||
|
"NS", "A", "AAAA", "CNAME", "MX", "TXT", "SRV", "CAA",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func setupRootDelegations(
|
||||||
|
m *mockDNSClient,
|
||||||
|
tNS []string,
|
||||||
|
tGlue map[string]string,
|
||||||
|
) {
|
||||||
|
domains := []string{
|
||||||
|
"example.com.", "www.example.com.",
|
||||||
|
"this-surely-does-not-exist-xyz.example.com.",
|
||||||
|
"cloudflare.com.",
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, rootIP := range rootIPList() {
|
||||||
|
for _, domain := range domains {
|
||||||
|
for _, qtype := range allQueryTypes() {
|
||||||
|
m.on(rootIP, domain, qtype,
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return referralResponse(
|
||||||
|
msg, tNS, tGlue,
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func setupRootARecords(m *mockDNSClient) {
|
||||||
|
nsIPs := map[string]string{
|
||||||
|
"ns1.example.com.": "10.1.0.1",
|
||||||
|
"ns2.example.com.": "10.1.0.2",
|
||||||
|
"ns3.example.com.": "10.1.0.3",
|
||||||
|
"ns1.cloudflare.com.": "10.2.0.1",
|
||||||
|
"ns2.cloudflare.com.": "10.2.0.2",
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, rootIP := range rootIPList() {
|
||||||
|
for nsName, nsIP := range nsIPs {
|
||||||
|
ip := nsIP
|
||||||
|
name := nsName
|
||||||
|
|
||||||
|
m.on(rootIP, name, "A",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return aResponse(msg, name, ip)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func setupTLDDelegations(
|
||||||
|
m *mockDNSClient,
|
||||||
|
exNS []string,
|
||||||
|
exGlue map[string]string,
|
||||||
|
cfNS []string,
|
||||||
|
cfGlue map[string]string,
|
||||||
|
) {
|
||||||
|
tldIPs := []string{"10.0.0.1", "10.0.0.2"}
|
||||||
|
|
||||||
|
exDomains := []string{
|
||||||
|
"example.com.", "www.example.com.",
|
||||||
|
"this-surely-does-not-exist-xyz.example.com.",
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tldIP := range tldIPs {
|
||||||
|
for _, domain := range exDomains {
|
||||||
|
for _, qtype := range allQueryTypes() {
|
||||||
|
m.on(tldIP, domain, qtype,
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return referralResponse(
|
||||||
|
msg, exNS, exGlue,
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, qtype := range allQueryTypes() {
|
||||||
|
m.on(tldIP, "cloudflare.com.", qtype,
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return referralResponse(
|
||||||
|
msg, cfNS, cfGlue,
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func setupExampleNSAndA(
|
||||||
|
m *mockDNSClient, exNS []string,
|
||||||
|
) {
|
||||||
|
exIPs := []string{"10.1.0.1", "10.1.0.2", "10.1.0.3"}
|
||||||
|
|
||||||
|
for _, authIP := range exIPs {
|
||||||
|
m.on(authIP, "example.com.", "NS",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return nsAnswerResponse(msg, exNS)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
m.on(authIP, "example.com.", "A",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return aResponse(
|
||||||
|
msg, "example.com.", "93.184.216.34",
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
m.on(authIP, "example.com.", "AAAA",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return aaaaResponse(
|
||||||
|
msg, "example.com.",
|
||||||
|
"2606:2800:220:1:248:1893:25c8:1946",
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func setupExampleMXAndTXT(m *mockDNSClient) {
|
||||||
|
exIPs := []string{"10.1.0.1", "10.1.0.2", "10.1.0.3"}
|
||||||
|
|
||||||
|
for _, authIP := range exIPs {
|
||||||
|
m.on(authIP, "example.com.", "MX",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
resp := new(dns.Msg)
|
||||||
|
resp.SetReply(msg)
|
||||||
|
resp.Answer = append(resp.Answer,
|
||||||
|
&dns.MX{
|
||||||
|
Hdr: dns.RR_Header{
|
||||||
|
Name: "example.com.",
|
||||||
|
Rrtype: dns.TypeMX,
|
||||||
|
Class: dns.ClassINET,
|
||||||
|
Ttl: 300,
|
||||||
|
},
|
||||||
|
Preference: 10,
|
||||||
|
Mx: "mail.example.com.",
|
||||||
|
},
|
||||||
|
&dns.MX{
|
||||||
|
Hdr: dns.RR_Header{
|
||||||
|
Name: "example.com.",
|
||||||
|
Rrtype: dns.TypeMX,
|
||||||
|
Class: dns.ClassINET,
|
||||||
|
Ttl: 300,
|
||||||
|
},
|
||||||
|
Preference: 20,
|
||||||
|
Mx: "mail2.example.com.",
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
return resp
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
m.on(authIP, "example.com.", "TXT",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
resp := new(dns.Msg)
|
||||||
|
resp.SetReply(msg)
|
||||||
|
resp.Answer = append(resp.Answer, &dns.TXT{
|
||||||
|
Hdr: dns.RR_Header{
|
||||||
|
Name: "example.com.",
|
||||||
|
Rrtype: dns.TypeTXT,
|
||||||
|
Class: dns.ClassINET,
|
||||||
|
Ttl: 300,
|
||||||
|
},
|
||||||
|
Txt: []string{
|
||||||
|
"v=spf1 include:_spf.example.com ~all",
|
||||||
|
},
|
||||||
|
})
|
||||||
|
|
||||||
|
return resp
|
||||||
|
},
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func setupExampleSubdomains(
|
||||||
|
m *mockDNSClient, exNS []string,
|
||||||
|
) {
|
||||||
|
exIPs := []string{"10.1.0.1", "10.1.0.2", "10.1.0.3"}
|
||||||
|
|
||||||
|
for _, authIP := range exIPs {
|
||||||
|
m.on(authIP, "www.example.com.", "NS",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return nsAnswerResponse(msg, exNS)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
m.on(authIP, "www.example.com.", "A",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return aResponse(
|
||||||
|
msg, "www.example.com.", "93.184.216.34",
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
nxName := "this-surely-does-not-exist-xyz.example.com."
|
||||||
|
for _, qtype := range allQueryTypes() {
|
||||||
|
m.on(authIP, nxName, qtype, nxdomainResponse)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func setupCloudflareAuthRecords(
|
||||||
|
m *mockDNSClient, cfNS []string,
|
||||||
|
) {
|
||||||
|
cfIPs := []string{"10.2.0.1", "10.2.0.2"}
|
||||||
|
|
||||||
|
for _, authIP := range cfIPs {
|
||||||
|
m.on(authIP, "cloudflare.com.", "NS",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return nsAnswerResponse(msg, cfNS)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
m.on(authIP, "cloudflare.com.", "A",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return aResponse(
|
||||||
|
msg, "cloudflare.com.", "104.16.132.229",
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
m.on(authIP, "cloudflare.com.", "AAAA",
|
||||||
|
func(msg *dns.Msg) *dns.Msg {
|
||||||
|
return aaaaResponse(
|
||||||
|
msg, "cloudflare.com.",
|
||||||
|
"2606:4700::6810:84e5",
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
|
||||||
|
m.on(authIP, "cloudflare.com.", "MX", emptyResponse)
|
||||||
|
m.on(authIP, "cloudflare.com.", "TXT", emptyResponse)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func setupMockDNS() *mockDNSClient {
|
||||||
|
m := newMockClient()
|
||||||
|
|
||||||
|
d := newMockData()
|
||||||
|
|
||||||
|
setupRootDelegations(m, d.tldNS, d.tldGlue)
|
||||||
|
setupRootARecords(m)
|
||||||
|
setupTLDDelegations(m, d.exNS, d.exGlue, d.cfNS, d.cfGlue)
|
||||||
|
setupExampleNSAndA(m, d.exNS)
|
||||||
|
setupExampleMXAndTXT(m)
|
||||||
|
setupExampleSubdomains(m, d.exNS)
|
||||||
|
setupCloudflareAuthRecords(m, d.cfNS)
|
||||||
|
|
||||||
|
return m
|
||||||
|
}
|
||||||
|
|
||||||
// ----------------------------------------------------------------
|
// ----------------------------------------------------------------
|
||||||
// Test helpers
|
// Test helpers
|
||||||
// ----------------------------------------------------------------
|
// ----------------------------------------------------------------
|
||||||
@@ -29,14 +521,14 @@ func newTestResolver(t *testing.T) *resolver.Resolver {
|
|||||||
&slog.HandlerOptions{Level: slog.LevelDebug},
|
&slog.HandlerOptions{Level: slog.LevelDebug},
|
||||||
))
|
))
|
||||||
|
|
||||||
return resolver.NewFromLogger(log)
|
return resolver.NewFromLoggerWithClient(log, setupMockDNS())
|
||||||
}
|
}
|
||||||
|
|
||||||
func testContext(t *testing.T) context.Context {
|
func testContext(t *testing.T) context.Context {
|
||||||
t.Helper()
|
t.Helper()
|
||||||
|
|
||||||
ctx, cancel := context.WithTimeout(
|
ctx, cancel := context.WithTimeout(
|
||||||
context.Background(), 60*time.Second,
|
context.Background(), 10*time.Second,
|
||||||
)
|
)
|
||||||
t.Cleanup(cancel)
|
t.Cleanup(cancel)
|
||||||
|
|
||||||
@@ -73,23 +565,23 @@ func TestFindAuthoritativeNameservers_ValidDomain(
|
|||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
nameservers, err := r.FindAuthoritativeNameservers(
|
nameservers, err := r.FindAuthoritativeNameservers(
|
||||||
ctx, "google.com",
|
ctx, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
require.NotEmpty(t, nameservers)
|
require.NotEmpty(t, nameservers)
|
||||||
|
|
||||||
hasGoogleNS := false
|
hasExampleNS := false
|
||||||
|
|
||||||
for _, ns := range nameservers {
|
for _, ns := range nameservers {
|
||||||
if strings.Contains(ns, "google") {
|
if strings.Contains(ns, "example") {
|
||||||
hasGoogleNS = true
|
hasExampleNS = true
|
||||||
|
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
assert.True(t, hasGoogleNS,
|
assert.True(t, hasExampleNS,
|
||||||
"expected google nameservers, got: %v", nameservers,
|
"expected example nameservers, got: %v", nameservers,
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -102,7 +594,7 @@ func TestFindAuthoritativeNameservers_Subdomain(
|
|||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
nameservers, err := r.FindAuthoritativeNameservers(
|
nameservers, err := r.FindAuthoritativeNameservers(
|
||||||
ctx, "www.google.com",
|
ctx, "www.example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
require.NotEmpty(t, nameservers)
|
require.NotEmpty(t, nameservers)
|
||||||
@@ -117,7 +609,7 @@ func TestFindAuthoritativeNameservers_ReturnsSorted(
|
|||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
nameservers, err := r.FindAuthoritativeNameservers(
|
nameservers, err := r.FindAuthoritativeNameservers(
|
||||||
ctx, "google.com",
|
ctx, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
@@ -137,12 +629,12 @@ func TestFindAuthoritativeNameservers_Deterministic(
|
|||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
first, err := r.FindAuthoritativeNameservers(
|
first, err := r.FindAuthoritativeNameservers(
|
||||||
ctx, "google.com",
|
ctx, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
second, err := r.FindAuthoritativeNameservers(
|
second, err := r.FindAuthoritativeNameservers(
|
||||||
ctx, "google.com",
|
ctx, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
@@ -158,12 +650,12 @@ func TestFindAuthoritativeNameservers_TrailingDot(
|
|||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
ns1, err := r.FindAuthoritativeNameservers(
|
ns1, err := r.FindAuthoritativeNameservers(
|
||||||
ctx, "google.com",
|
ctx, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
ns2, err := r.FindAuthoritativeNameservers(
|
ns2, err := r.FindAuthoritativeNameservers(
|
||||||
ctx, "google.com.",
|
ctx, "example.com.",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
@@ -200,10 +692,10 @@ func TestQueryNameserver_BasicA(t *testing.T) {
|
|||||||
|
|
||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
ns := findOneNSForDomain(t, r, ctx, "google.com")
|
ns := findOneNSForDomain(t, r, ctx, "example.com")
|
||||||
|
|
||||||
resp, err := r.QueryNameserver(
|
resp, err := r.QueryNameserver(
|
||||||
ctx, ns, "www.google.com",
|
ctx, ns, "www.example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
require.NotNil(t, resp)
|
require.NotNil(t, resp)
|
||||||
@@ -214,7 +706,7 @@ func TestQueryNameserver_BasicA(t *testing.T) {
|
|||||||
hasRecords := len(resp.Records["A"]) > 0 ||
|
hasRecords := len(resp.Records["A"]) > 0 ||
|
||||||
len(resp.Records["CNAME"]) > 0
|
len(resp.Records["CNAME"]) > 0
|
||||||
assert.True(t, hasRecords,
|
assert.True(t, hasRecords,
|
||||||
"expected A or CNAME records for www.google.com",
|
"expected A or CNAME records for www.example.com",
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -248,16 +740,16 @@ func TestQueryNameserver_MX(t *testing.T) {
|
|||||||
|
|
||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
ns := findOneNSForDomain(t, r, ctx, "google.com")
|
ns := findOneNSForDomain(t, r, ctx, "example.com")
|
||||||
|
|
||||||
resp, err := r.QueryNameserver(
|
resp, err := r.QueryNameserver(
|
||||||
ctx, ns, "google.com",
|
ctx, ns, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
mxRecords := resp.Records["MX"]
|
mxRecords := resp.Records["MX"]
|
||||||
require.NotEmpty(t, mxRecords,
|
require.NotEmpty(t, mxRecords,
|
||||||
"google.com should have MX records",
|
"example.com should have MX records",
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -266,16 +758,16 @@ func TestQueryNameserver_TXT(t *testing.T) {
|
|||||||
|
|
||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
ns := findOneNSForDomain(t, r, ctx, "google.com")
|
ns := findOneNSForDomain(t, r, ctx, "example.com")
|
||||||
|
|
||||||
resp, err := r.QueryNameserver(
|
resp, err := r.QueryNameserver(
|
||||||
ctx, ns, "google.com",
|
ctx, ns, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
txtRecords := resp.Records["TXT"]
|
txtRecords := resp.Records["TXT"]
|
||||||
require.NotEmpty(t, txtRecords,
|
require.NotEmpty(t, txtRecords,
|
||||||
"google.com should have TXT records",
|
"example.com should have TXT records",
|
||||||
)
|
)
|
||||||
|
|
||||||
hasSPF := false
|
hasSPF := false
|
||||||
@@ -289,7 +781,7 @@ func TestQueryNameserver_TXT(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
assert.True(t, hasSPF,
|
assert.True(t, hasSPF,
|
||||||
"google.com should have SPF TXT record",
|
"example.com should have SPF TXT record",
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -298,11 +790,11 @@ func TestQueryNameserver_NXDomain(t *testing.T) {
|
|||||||
|
|
||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
ns := findOneNSForDomain(t, r, ctx, "google.com")
|
ns := findOneNSForDomain(t, r, ctx, "example.com")
|
||||||
|
|
||||||
resp, err := r.QueryNameserver(
|
resp, err := r.QueryNameserver(
|
||||||
ctx, ns,
|
ctx, ns,
|
||||||
"this-surely-does-not-exist-xyz.google.com",
|
"this-surely-does-not-exist-xyz.example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
@@ -314,10 +806,10 @@ func TestQueryNameserver_RecordsSorted(t *testing.T) {
|
|||||||
|
|
||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
ns := findOneNSForDomain(t, r, ctx, "google.com")
|
ns := findOneNSForDomain(t, r, ctx, "example.com")
|
||||||
|
|
||||||
resp, err := r.QueryNameserver(
|
resp, err := r.QueryNameserver(
|
||||||
ctx, ns, "google.com",
|
ctx, ns, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
@@ -354,11 +846,11 @@ func TestQueryNameserver_EmptyRecordsOnNXDomain(
|
|||||||
|
|
||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
ns := findOneNSForDomain(t, r, ctx, "google.com")
|
ns := findOneNSForDomain(t, r, ctx, "example.com")
|
||||||
|
|
||||||
resp, err := r.QueryNameserver(
|
resp, err := r.QueryNameserver(
|
||||||
ctx, ns,
|
ctx, ns,
|
||||||
"this-surely-does-not-exist-xyz.google.com",
|
"this-surely-does-not-exist-xyz.example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
@@ -375,15 +867,15 @@ func TestQueryNameserver_TrailingDotHandling(t *testing.T) {
|
|||||||
|
|
||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
ns := findOneNSForDomain(t, r, ctx, "google.com")
|
ns := findOneNSForDomain(t, r, ctx, "example.com")
|
||||||
|
|
||||||
resp1, err := r.QueryNameserver(
|
resp1, err := r.QueryNameserver(
|
||||||
ctx, ns, "google.com",
|
ctx, ns, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
resp2, err := r.QueryNameserver(
|
resp2, err := r.QueryNameserver(
|
||||||
ctx, ns, "google.com.",
|
ctx, ns, "example.com.",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
@@ -401,7 +893,7 @@ func TestQueryAllNameservers_ReturnsAllNS(t *testing.T) {
|
|||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
results, err := r.QueryAllNameservers(
|
results, err := r.QueryAllNameservers(
|
||||||
ctx, "google.com",
|
ctx, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
require.NotEmpty(t, results)
|
require.NotEmpty(t, results)
|
||||||
@@ -420,7 +912,7 @@ func TestQueryAllNameservers_AllReturnOK(t *testing.T) {
|
|||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
results, err := r.QueryAllNameservers(
|
results, err := r.QueryAllNameservers(
|
||||||
ctx, "google.com",
|
ctx, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
@@ -442,7 +934,7 @@ func TestQueryAllNameservers_NXDomainFromAllNS(
|
|||||||
|
|
||||||
results, err := r.QueryAllNameservers(
|
results, err := r.QueryAllNameservers(
|
||||||
ctx,
|
ctx,
|
||||||
"this-surely-does-not-exist-xyz.google.com",
|
"this-surely-does-not-exist-xyz.example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
@@ -464,7 +956,7 @@ func TestLookupNS_ValidDomain(t *testing.T) {
|
|||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
nameservers, err := r.LookupNS(ctx, "google.com")
|
nameservers, err := r.LookupNS(ctx, "example.com")
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
require.NotEmpty(t, nameservers)
|
require.NotEmpty(t, nameservers)
|
||||||
|
|
||||||
@@ -481,7 +973,7 @@ func TestLookupNS_Sorted(t *testing.T) {
|
|||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
nameservers, err := r.LookupNS(ctx, "google.com")
|
nameservers, err := r.LookupNS(ctx, "example.com")
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
assert.True(t, sort.StringsAreSorted(nameservers))
|
assert.True(t, sort.StringsAreSorted(nameservers))
|
||||||
@@ -493,11 +985,11 @@ func TestLookupNS_MatchesFindAuthoritative(t *testing.T) {
|
|||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
fromLookup, err := r.LookupNS(ctx, "google.com")
|
fromLookup, err := r.LookupNS(ctx, "example.com")
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
fromFind, err := r.FindAuthoritativeNameservers(
|
fromFind, err := r.FindAuthoritativeNameservers(
|
||||||
ctx, "google.com",
|
ctx, "example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
@@ -514,7 +1006,7 @@ func TestResolveIPAddresses_ReturnsIPs(t *testing.T) {
|
|||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
ips, err := r.ResolveIPAddresses(ctx, "google.com")
|
ips, err := r.ResolveIPAddresses(ctx, "example.com")
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
require.NotEmpty(t, ips)
|
require.NotEmpty(t, ips)
|
||||||
|
|
||||||
@@ -532,7 +1024,7 @@ func TestResolveIPAddresses_Deduplicated(t *testing.T) {
|
|||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
ips, err := r.ResolveIPAddresses(ctx, "google.com")
|
ips, err := r.ResolveIPAddresses(ctx, "example.com")
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
seen := make(map[string]bool)
|
seen := make(map[string]bool)
|
||||||
@@ -549,7 +1041,7 @@ func TestResolveIPAddresses_Sorted(t *testing.T) {
|
|||||||
r := newTestResolver(t)
|
r := newTestResolver(t)
|
||||||
ctx := testContext(t)
|
ctx := testContext(t)
|
||||||
|
|
||||||
ips, err := r.ResolveIPAddresses(ctx, "google.com")
|
ips, err := r.ResolveIPAddresses(ctx, "example.com")
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
|
|
||||||
assert.True(t, sort.StringsAreSorted(ips))
|
assert.True(t, sort.StringsAreSorted(ips))
|
||||||
@@ -565,7 +1057,7 @@ func TestResolveIPAddresses_NXDomainReturnsEmpty(
|
|||||||
|
|
||||||
ips, err := r.ResolveIPAddresses(
|
ips, err := r.ResolveIPAddresses(
|
||||||
ctx,
|
ctx,
|
||||||
"this-surely-does-not-exist-xyz.google.com",
|
"this-surely-does-not-exist-xyz.example.com",
|
||||||
)
|
)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
assert.Empty(t, ips)
|
assert.Empty(t, ips)
|
||||||
@@ -595,7 +1087,9 @@ func TestFindAuthoritativeNameservers_ContextCanceled(
|
|||||||
ctx, cancel := context.WithCancel(context.Background())
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
cancel()
|
cancel()
|
||||||
|
|
||||||
_, err := r.FindAuthoritativeNameservers(ctx, "google.com")
|
_, err := r.FindAuthoritativeNameservers(
|
||||||
|
ctx, "example.com",
|
||||||
|
)
|
||||||
assert.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -607,7 +1101,7 @@ func TestQueryNameserver_ContextCanceled(t *testing.T) {
|
|||||||
cancel()
|
cancel()
|
||||||
|
|
||||||
_, err := r.QueryNameserver(
|
_, err := r.QueryNameserver(
|
||||||
ctx, "ns1.google.com.", "google.com",
|
ctx, "ns1.example.com.", "example.com",
|
||||||
)
|
)
|
||||||
assert.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
@@ -619,63 +1113,10 @@ func TestQueryAllNameservers_ContextCanceled(t *testing.T) {
|
|||||||
ctx, cancel := context.WithCancel(context.Background())
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
cancel()
|
cancel()
|
||||||
|
|
||||||
_, err := r.QueryAllNameservers(ctx, "google.com")
|
_, err := r.QueryAllNameservers(ctx, "example.com")
|
||||||
assert.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|
||||||
// ----------------------------------------------------------------
|
|
||||||
// Timeout tests
|
|
||||||
// ----------------------------------------------------------------
|
|
||||||
|
|
||||||
func TestQueryNameserverIP_Timeout(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
log := slog.New(slog.NewTextHandler(
|
|
||||||
os.Stderr,
|
|
||||||
&slog.HandlerOptions{Level: slog.LevelDebug},
|
|
||||||
))
|
|
||||||
|
|
||||||
r := resolver.NewFromLoggerWithClient(
|
|
||||||
log, &timeoutClient{},
|
|
||||||
)
|
|
||||||
|
|
||||||
ctx, cancel := context.WithTimeout(
|
|
||||||
context.Background(), 10*time.Second,
|
|
||||||
)
|
|
||||||
t.Cleanup(cancel)
|
|
||||||
|
|
||||||
// Query any IP — the client always returns a timeout error.
|
|
||||||
resp, err := r.QueryNameserverIP(
|
|
||||||
ctx, "unreachable.test.", "192.0.2.1",
|
|
||||||
"example.com",
|
|
||||||
)
|
|
||||||
require.NoError(t, err)
|
|
||||||
|
|
||||||
assert.Equal(t, resolver.StatusTimeout, resp.Status)
|
|
||||||
assert.NotEmpty(t, resp.Error)
|
|
||||||
}
|
|
||||||
|
|
||||||
// timeoutClient simulates DNS timeout errors for testing.
|
|
||||||
type timeoutClient struct{}
|
|
||||||
|
|
||||||
func (c *timeoutClient) ExchangeContext(
|
|
||||||
_ context.Context,
|
|
||||||
_ *dns.Msg,
|
|
||||||
_ string,
|
|
||||||
) (*dns.Msg, time.Duration, error) {
|
|
||||||
return nil, 0, &net.OpError{
|
|
||||||
Op: "read",
|
|
||||||
Net: "udp",
|
|
||||||
Err: &timeoutError{},
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
type timeoutError struct{}
|
|
||||||
|
|
||||||
func (e *timeoutError) Error() string { return "i/o timeout" }
|
|
||||||
func (e *timeoutError) Timeout() bool { return true }
|
|
||||||
func (e *timeoutError) Temporary() bool { return true }
|
|
||||||
|
|
||||||
func TestResolveIPAddresses_ContextCanceled(t *testing.T) {
|
func TestResolveIPAddresses_ContextCanceled(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
@@ -683,6 +1124,6 @@ func TestResolveIPAddresses_ContextCanceled(t *testing.T) {
|
|||||||
ctx, cancel := context.WithCancel(context.Background())
|
ctx, cancel := context.WithCancel(context.Background())
|
||||||
cancel()
|
cancel()
|
||||||
|
|
||||||
_, err := r.ResolveIPAddresses(ctx, "google.com")
|
_, err := r.ResolveIPAddresses(ctx, "example.com")
|
||||||
assert.Error(t, err)
|
assert.Error(t, err)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -6,7 +6,6 @@ import (
|
|||||||
"log/slog"
|
"log/slog"
|
||||||
"sort"
|
"sort"
|
||||||
"strings"
|
"strings"
|
||||||
"sync"
|
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"go.uber.org/fx"
|
"go.uber.org/fx"
|
||||||
@@ -50,8 +49,6 @@ type Watcher struct {
|
|||||||
notify Notifier
|
notify Notifier
|
||||||
cancel context.CancelFunc
|
cancel context.CancelFunc
|
||||||
firstRun bool
|
firstRun bool
|
||||||
expiryNotifiedMu sync.Mutex
|
|
||||||
expiryNotified map[string]time.Time
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// New creates a new Watcher instance wired into the fx lifecycle.
|
// New creates a new Watcher instance wired into the fx lifecycle.
|
||||||
@@ -68,7 +65,6 @@ func New(
|
|||||||
tlsCheck: params.TLSCheck,
|
tlsCheck: params.TLSCheck,
|
||||||
notify: params.Notify,
|
notify: params.Notify,
|
||||||
firstRun: true,
|
firstRun: true,
|
||||||
expiryNotified: make(map[string]time.Time),
|
|
||||||
}
|
}
|
||||||
|
|
||||||
lifecycle.Append(fx.Hook{
|
lifecycle.Append(fx.Hook{
|
||||||
@@ -112,7 +108,6 @@ func NewForTest(
|
|||||||
tlsCheck: tc,
|
tlsCheck: tc,
|
||||||
notify: n,
|
notify: n,
|
||||||
firstRun: true,
|
firstRun: true,
|
||||||
expiryNotified: make(map[string]time.Time),
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -211,28 +206,6 @@ func (w *Watcher) checkDomain(
|
|||||||
Nameservers: nameservers,
|
Nameservers: nameservers,
|
||||||
LastChecked: now,
|
LastChecked: now,
|
||||||
})
|
})
|
||||||
|
|
||||||
// Also look up A/AAAA records for the apex domain so that
|
|
||||||
// port and TLS checks (which read HostnameState) can find
|
|
||||||
// the domain's IP addresses.
|
|
||||||
records, err := w.resolver.LookupAllRecords(ctx, domain)
|
|
||||||
if err != nil {
|
|
||||||
w.log.Error(
|
|
||||||
"failed to lookup records for domain",
|
|
||||||
"domain", domain,
|
|
||||||
"error", err,
|
|
||||||
)
|
|
||||||
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
prevHS, hasPrevHS := w.state.GetHostnameState(domain)
|
|
||||||
if hasPrevHS && !w.firstRun {
|
|
||||||
w.detectHostnameChanges(ctx, domain, prevHS, records)
|
|
||||||
}
|
|
||||||
|
|
||||||
newState := buildHostnameState(records, now)
|
|
||||||
w.state.SetHostnameState(domain, newState)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func (w *Watcher) detectNSChanges(
|
func (w *Watcher) detectNSChanges(
|
||||||
@@ -718,22 +691,6 @@ func (w *Watcher) checkTLSExpiry(
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
// Deduplicate expiry warnings: don't re-notify for the same
|
|
||||||
// hostname within the TLS check interval.
|
|
||||||
dedupKey := fmt.Sprintf("expiry:%s:%s", hostname, ip)
|
|
||||||
|
|
||||||
w.expiryNotifiedMu.Lock()
|
|
||||||
|
|
||||||
lastNotified, seen := w.expiryNotified[dedupKey]
|
|
||||||
if seen && time.Since(lastNotified) < w.config.TLSInterval {
|
|
||||||
w.expiryNotifiedMu.Unlock()
|
|
||||||
|
|
||||||
return
|
|
||||||
}
|
|
||||||
|
|
||||||
w.expiryNotified[dedupKey] = time.Now()
|
|
||||||
w.expiryNotifiedMu.Unlock()
|
|
||||||
|
|
||||||
msg := fmt.Sprintf(
|
msg := fmt.Sprintf(
|
||||||
"Host: %s\nIP: %s\nCN: %s\n"+
|
"Host: %s\nIP: %s\nCN: %s\n"+
|
||||||
"Expires: %s (%.0f days)",
|
"Expires: %s (%.0f days)",
|
||||||
|
|||||||
@@ -273,10 +273,6 @@ func setupBaselineMocks(deps *testDeps) {
|
|||||||
"ns1.example.com.",
|
"ns1.example.com.",
|
||||||
"ns2.example.com.",
|
"ns2.example.com.",
|
||||||
}
|
}
|
||||||
deps.resolver.allRecords["example.com"] = map[string]map[string][]string{
|
|
||||||
"ns1.example.com.": {"A": {"93.184.216.34"}},
|
|
||||||
"ns2.example.com.": {"A": {"93.184.216.34"}},
|
|
||||||
}
|
|
||||||
deps.resolver.allRecords["www.example.com"] = map[string]map[string][]string{
|
deps.resolver.allRecords["www.example.com"] = map[string]map[string][]string{
|
||||||
"ns1.example.com.": {"A": {"93.184.216.34"}},
|
"ns1.example.com.": {"A": {"93.184.216.34"}},
|
||||||
"ns2.example.com.": {"A": {"93.184.216.34"}},
|
"ns2.example.com.": {"A": {"93.184.216.34"}},
|
||||||
@@ -294,14 +290,6 @@ func setupBaselineMocks(deps *testDeps) {
|
|||||||
"www.example.com",
|
"www.example.com",
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
deps.tlsChecker.certs["93.184.216.34:example.com"] = &tlscheck.CertificateInfo{
|
|
||||||
CommonName: "example.com",
|
|
||||||
Issuer: "DigiCert",
|
|
||||||
NotAfter: time.Now().Add(90 * 24 * time.Hour),
|
|
||||||
SubjectAlternativeNames: []string{
|
|
||||||
"example.com",
|
|
||||||
},
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
func assertNoNotifications(
|
func assertNoNotifications(
|
||||||
@@ -334,74 +322,14 @@ func assertStatePopulated(
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Hostnames includes both explicit hostnames and domains
|
if len(snap.Hostnames) != 1 {
|
||||||
// (domains now also get hostname state for port/TLS checks).
|
|
||||||
if len(snap.Hostnames) < 1 {
|
|
||||||
t.Errorf(
|
t.Errorf(
|
||||||
"expected at least 1 hostname in state, got %d",
|
"expected 1 hostname in state, got %d",
|
||||||
len(snap.Hostnames),
|
len(snap.Hostnames),
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestDomainPortAndTLSChecks(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
cfg := defaultTestConfig(t)
|
|
||||||
cfg.Domains = []string{"example.com"}
|
|
||||||
|
|
||||||
w, deps := newTestWatcher(t, cfg)
|
|
||||||
|
|
||||||
deps.resolver.nsRecords["example.com"] = []string{
|
|
||||||
"ns1.example.com.",
|
|
||||||
}
|
|
||||||
deps.resolver.allRecords["example.com"] = map[string]map[string][]string{
|
|
||||||
"ns1.example.com.": {"A": {"93.184.216.34"}},
|
|
||||||
}
|
|
||||||
deps.portChecker.results["93.184.216.34:80"] = true
|
|
||||||
deps.portChecker.results["93.184.216.34:443"] = true
|
|
||||||
deps.tlsChecker.certs["93.184.216.34:example.com"] = &tlscheck.CertificateInfo{
|
|
||||||
CommonName: "example.com",
|
|
||||||
Issuer: "DigiCert",
|
|
||||||
NotAfter: time.Now().Add(90 * 24 * time.Hour),
|
|
||||||
SubjectAlternativeNames: []string{
|
|
||||||
"example.com",
|
|
||||||
},
|
|
||||||
}
|
|
||||||
|
|
||||||
w.RunOnce(t.Context())
|
|
||||||
|
|
||||||
snap := deps.state.GetSnapshot()
|
|
||||||
|
|
||||||
// Domain should have port state populated
|
|
||||||
if len(snap.Ports) == 0 {
|
|
||||||
t.Error("expected port state for domain, got none")
|
|
||||||
}
|
|
||||||
|
|
||||||
// Domain should have certificate state populated
|
|
||||||
if len(snap.Certificates) == 0 {
|
|
||||||
t.Error("expected certificate state for domain, got none")
|
|
||||||
}
|
|
||||||
|
|
||||||
// Verify port checker was actually called
|
|
||||||
deps.portChecker.mu.Lock()
|
|
||||||
calls := deps.portChecker.calls
|
|
||||||
deps.portChecker.mu.Unlock()
|
|
||||||
|
|
||||||
if calls == 0 {
|
|
||||||
t.Error("expected port checker to be called for domain")
|
|
||||||
}
|
|
||||||
|
|
||||||
// Verify TLS checker was actually called
|
|
||||||
deps.tlsChecker.mu.Lock()
|
|
||||||
tlsCalls := deps.tlsChecker.calls
|
|
||||||
deps.tlsChecker.mu.Unlock()
|
|
||||||
|
|
||||||
if tlsCalls == 0 {
|
|
||||||
t.Error("expected TLS checker to be called for domain")
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestNSChangeDetection(t *testing.T) {
|
func TestNSChangeDetection(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
@@ -414,12 +342,6 @@ func TestNSChangeDetection(t *testing.T) {
|
|||||||
"ns1.example.com.",
|
"ns1.example.com.",
|
||||||
"ns2.example.com.",
|
"ns2.example.com.",
|
||||||
}
|
}
|
||||||
deps.resolver.allRecords["example.com"] = map[string]map[string][]string{
|
|
||||||
"ns1.example.com.": {"A": {"1.2.3.4"}},
|
|
||||||
"ns2.example.com.": {"A": {"1.2.3.4"}},
|
|
||||||
}
|
|
||||||
deps.portChecker.results["1.2.3.4:80"] = false
|
|
||||||
deps.portChecker.results["1.2.3.4:443"] = false
|
|
||||||
|
|
||||||
ctx := t.Context()
|
ctx := t.Context()
|
||||||
w.RunOnce(ctx)
|
w.RunOnce(ctx)
|
||||||
@@ -429,10 +351,6 @@ func TestNSChangeDetection(t *testing.T) {
|
|||||||
"ns1.example.com.",
|
"ns1.example.com.",
|
||||||
"ns3.example.com.",
|
"ns3.example.com.",
|
||||||
}
|
}
|
||||||
deps.resolver.allRecords["example.com"] = map[string]map[string][]string{
|
|
||||||
"ns1.example.com.": {"A": {"1.2.3.4"}},
|
|
||||||
"ns3.example.com.": {"A": {"1.2.3.4"}},
|
|
||||||
}
|
|
||||||
deps.resolver.mu.Unlock()
|
deps.resolver.mu.Unlock()
|
||||||
|
|
||||||
w.RunOnce(ctx)
|
w.RunOnce(ctx)
|
||||||
@@ -588,61 +506,6 @@ func TestTLSExpiryWarning(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestTLSExpiryWarningDedup(t *testing.T) {
|
|
||||||
t.Parallel()
|
|
||||||
|
|
||||||
cfg := defaultTestConfig(t)
|
|
||||||
cfg.Hostnames = []string{"www.example.com"}
|
|
||||||
cfg.TLSInterval = 24 * time.Hour
|
|
||||||
|
|
||||||
w, deps := newTestWatcher(t, cfg)
|
|
||||||
|
|
||||||
deps.resolver.allRecords["www.example.com"] = map[string]map[string][]string{
|
|
||||||
"ns1.example.com.": {"A": {"1.2.3.4"}},
|
|
||||||
}
|
|
||||||
deps.resolver.ipAddresses["www.example.com"] = []string{
|
|
||||||
"1.2.3.4",
|
|
||||||
}
|
|
||||||
deps.portChecker.results["1.2.3.4:80"] = true
|
|
||||||
deps.portChecker.results["1.2.3.4:443"] = true
|
|
||||||
deps.tlsChecker.certs["1.2.3.4:www.example.com"] = &tlscheck.CertificateInfo{
|
|
||||||
CommonName: "www.example.com",
|
|
||||||
Issuer: "DigiCert",
|
|
||||||
NotAfter: time.Now().Add(3 * 24 * time.Hour),
|
|
||||||
SubjectAlternativeNames: []string{
|
|
||||||
"www.example.com",
|
|
||||||
},
|
|
||||||
}
|
|
||||||
|
|
||||||
ctx := t.Context()
|
|
||||||
|
|
||||||
// First run = baseline, no notifications
|
|
||||||
w.RunOnce(ctx)
|
|
||||||
|
|
||||||
// Second run should fire one expiry warning
|
|
||||||
w.RunOnce(ctx)
|
|
||||||
|
|
||||||
// Third run should NOT fire another warning (dedup)
|
|
||||||
w.RunOnce(ctx)
|
|
||||||
|
|
||||||
notifications := deps.notifier.getNotifications()
|
|
||||||
|
|
||||||
expiryCount := 0
|
|
||||||
|
|
||||||
for _, n := range notifications {
|
|
||||||
if n.Title == "TLS Expiry Warning: www.example.com" {
|
|
||||||
expiryCount++
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if expiryCount != 1 {
|
|
||||||
t.Errorf(
|
|
||||||
"expected exactly 1 expiry warning (dedup), got %d",
|
|
||||||
expiryCount,
|
|
||||||
)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
func TestGracefulShutdown(t *testing.T) {
|
func TestGracefulShutdown(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
|
|
||||||
@@ -656,11 +519,6 @@ func TestGracefulShutdown(t *testing.T) {
|
|||||||
deps.resolver.nsRecords["example.com"] = []string{
|
deps.resolver.nsRecords["example.com"] = []string{
|
||||||
"ns1.example.com.",
|
"ns1.example.com.",
|
||||||
}
|
}
|
||||||
deps.resolver.allRecords["example.com"] = map[string]map[string][]string{
|
|
||||||
"ns1.example.com.": {"A": {"1.2.3.4"}},
|
|
||||||
}
|
|
||||||
deps.portChecker.results["1.2.3.4:80"] = false
|
|
||||||
deps.portChecker.results["1.2.3.4:443"] = false
|
|
||||||
|
|
||||||
ctx, cancel := context.WithCancel(t.Context())
|
ctx, cancel := context.WithCancel(t.Context())
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user