sneak/dnswatcher
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Resolver tests hit real DNS, causing slow/flaky/racy test suite #32

New Issue
Closed
opened 2026-02-22 13:19:26 +01:00 by clawbot · 0 comments
clawbot commented 2026-02-22 13:19:26 +01:00
Collaborator
Copy Link

Problem

The resolver tests in internal/resolver/resolver_test.go use NewFromLogger which creates real UDP/TCP DNS clients. All tests run in parallel hitting real nameservers, which causes:

  1. Slow: Test suite takes >30s, violating CI time constraints
  2. Racy: Data race detected under -race flag due to concurrent real DNS queries
  3. Flaky: Tests fail intermittently depending on network conditions and DNS server availability

Solution

Replace real DNS calls with a mock DNSClient using the existing NewFromLoggerWithClient(log, client DNSClient) constructor. All test behaviors (NS lookup, A/AAAA/MX/TXT records, NXDOMAIN, sorting, dedup, context cancellation, trailing dots, etc.) should be preserved but use deterministic canned responses instead of real network calls.

## Problem The resolver tests in `internal/resolver/resolver_test.go` use `NewFromLogger` which creates real UDP/TCP DNS clients. All tests run in parallel hitting real nameservers, which causes: 1. **Slow**: Test suite takes >30s, violating CI time constraints 2. **Racy**: Data race detected under `-race` flag due to concurrent real DNS queries 3. **Flaky**: Tests fail intermittently depending on network conditions and DNS server availability ## Solution Replace real DNS calls with a mock `DNSClient` using the existing `NewFromLoggerWithClient(log, client DNSClient)` constructor. All test behaviors (NS lookup, A/AAAA/MX/TXT records, NXDOMAIN, sorting, dedup, context cancellation, trailing dots, etc.) should be preserved but use deterministic canned responses instead of real network calls.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bot
Agent's turn to work
 merge-ready
All checks pass, reviewed, rebased, ready for merge
 needs-checks
make check does not pass cleanly
 needs-rebase
PR has merge conflicts or is behind main
 needs-review
Code review not yet done
 needs-rework
Code review found issues to fix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
clawbot sneak
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: sneak/dnswatcher#32
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?